[jira] [Comment Edited] (EXTCDI-300) ViewParameterMode.INCLUDE incudes all request parameters

["Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/EXTCDI-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480685#comment-13480685 ] 

Gerhard Petracek edited comment on EXTCDI-300 at 10/20/12 10:50 AM:
--------------------------------------------------------------------

it was intended to do it that way. that's the only approach which is also compatible with jsf 1.2.
+ with jsf 2.x you would have to provide the parameters as a part of the outcome. since only one view-config per page is allowed, you could only support one constellation in combination with a complex approach for providing the needed (dyn.) values.
+ in your case you are using a view-config with Page.ViewParameterMode.INCLUDE for a post-request and for the get-request a trick to just return the view-id instead of the class (which is supported as well). -> just remove the usage of Page.ViewParameterMode.INCLUDE in your example and everything works as expected. 
                
      was (Author: gpetracek):
    it was intended to do it that way. that's the only approach which is also compatible with jsf 1.2.
+ with jsf 2.x you would have to provide the parameters as a part of the outcome. since only one view-config per page is allowed, you could only support one constellation in combination with a complex approach for providing the needed (dyn.) values.
                  
> ViewParameterMode.INCLUDE incudes all request parameters
> --------------------------------------------------------
>
>                 Key: EXTCDI-300
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-300
>             Project: MyFaces CODI
>          Issue Type: Bug
>          Components: JEE-JSF20-Module
>    Affects Versions: 1.0.5
>            Reporter: Michael Kurz
>         Attachments: EXTCDI-300.zip
>
>
> I have a view config with navigation set to REDIRECT and viewParams set to INCLUDE like this:
> @Page(navigation = Page.NavigationMode.REDIRECT,
>     viewParams = Page.ViewParameterMode.INCLUDE)
> public class ShowProvider implements View {}
> I use this view config as the result of an action method to navigate from an edit page back to a details page with a redirect using the (single) view param id for identifying the current item.
> This works as expected, but additionally to the view param I get ALL request parameters in the url. As this is a redirect from a POST that is quite a list of parameters.
> The parameters are added in ViewConfigAwareNavigationHandler.convertEntryToOutcome() if ViewParameterMode.INCLUDE is used on the view config - but I don't see why this is done?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira