You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/12/21 01:26:54 UTC
[GitHub] zeppelin pull request #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkCluster...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1788
ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zRunTest
### What is this PR for?
Fix the flaky test of ZeppelinSparkClusterTest.zRunTest. The issue is that z.run is not a blocking call so we still need the check the paragraph status. (see code change for details).
Besides that, I also add more logging. This helps me a lot.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1826
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1826
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1788
----
commit 5c2279125758adbffd1068e1a9359d3d88a45905
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-12-15T07:29:07Z
ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zRunTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1788
@Leemoonsoo @jongyoul @bzz Please help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1788
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkCluster...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1788
LGTM and merge if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1788
ping @Leemoonsoo @jongyoul @bzz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1788
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---