You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Jarek Jarcec Cecho (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 17:53:39 UTC
[jira] [Created] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
HDFSWriterFactory is using operation == for string comparison
-------------------------------------------------------------
Key: FLUME-858
URL: https://issues.apache.org/jira/browse/FLUME-858
Project: Flume
Issue Type: Bug
Components: Sinks+Sources
Affects Versions: NG alpha 1, NG alpha 2
Reporter: Jarek Jarcec Cecho
Priority: Minor
HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "E. Sammer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer updated FLUME-858:
----------------------------
Fix Version/s: NG alpha 3
Scheduling for alpha 3.
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Prasad Mujumdar
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated FLUME-858:
-------------------------------------
Status: Patch Available (was: Open)
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162862#comment-13162862 ]
jiraposter@reviews.apache.org commented on FLUME-858:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3010/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
I've simply changed operator == to calling method equals().
This addresses bug FLUME-858.
https://issues.apache.org/jira/browse/FLUME-858
Diffs
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java 1205921
Diff: https://reviews.apache.org/r/3010/diff
Testing
-------
No tests for this class are available yet (actually it would be great idea to create them :-D), however I did test it on my testing cluster.
Thanks,
Jarek
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162891#comment-13162891 ]
jiraposter@reviews.apache.org commented on FLUME-858:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3010/#review3621
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2011-12-05 16:17:28, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3010/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 16:17:28)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've simply changed operator == to calling method equals().
bq.
bq.
bq. This addresses bug FLUME-858.
bq. https://issues.apache.org/jira/browse/FLUME-858
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java 1205921
bq.
bq. Diff: https://reviews.apache.org/r/3010/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No tests for this class are available yet (actually it would be great idea to create them :-D), however I did test it on my testing cluster.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162900#comment-13162900 ]
jiraposter@reviews.apache.org commented on FLUME-858:
-----------------------------------------------------
bq. On 2011-12-05 17:31:54, Prasad Mujumdar wrote:
bq. > lgtm
Thank you very much for the review, path is already submitted to JIRA, so feel free to commit it :-)
Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3010/#review3621
-----------------------------------------------------------
On 2011-12-05 16:17:28, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3010/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 16:17:28)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've simply changed operator == to calling method equals().
bq.
bq.
bq. This addresses bug FLUME-858.
bq. https://issues.apache.org/jira/browse/FLUME-858
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java 1205921
bq.
bq. Diff: https://reviews.apache.org/r/3010/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No tests for this class are available yet (actually it would be great idea to create them :-D), however I did test it on my testing cluster.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated FLUME-858:
-------------------------------------
Attachment: FLUME-858.patch
I've changed operator == for method equals and other file types started working as expected.
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164913#comment-13164913 ]
Hudson commented on FLUME-858:
------------------------------
Integrated in flume-728 #70 (See [https://builds.apache.org/job/flume-728/70/])
FLUME-858. Fix comparison in HDFSWriterFactory
(Jarek Jarcec Cecho via Prasad Mujumdar)
.
prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1211704
Files :
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "E. Sammer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer reassigned FLUME-858:
-------------------------------
Assignee: Prasad Mujumdar
Assigning to Prasad.
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Prasad Mujumdar
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "E. Sammer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer reassigned FLUME-858:
-------------------------------
Assignee: Jarek Jarcec Cecho (was: Prasad Mujumdar)
Jarek:
Can you post this patch at reviews.apache.org for us?
Thanks!
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-858:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk
Thanks Jarek !
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira