You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dennisimoo (via GitHub)" <gi...@apache.org> on 2026/09/12 02:17:38 UTC
[PR] fix(sql-lab): avoid duplicate generated result column names [superset]
dennisimoo opened a new pull request, #44189:
URL: https://github.com/apache/superset/pull/44189
### SUMMARY
Avoid collisions between generated duplicate-column suffixes and names already supplied by the database cursor.
For columns `a, a, a__1`, `dedup()` currently returns `a, a__1, a__1`. Constructing `SupersetResultSet` then raises `ValueError: field 'a__1' occurs more than once` while building the NumPy dtype.
Reserve the original names and skip occupied suffixes in the existing counter loop. The output becomes `a, a__2, a__1`, preserving the explicitly named column. Existing non-colliding naming, column order, case-sensitivity options, and custom suffixes are retained. This adds an O(n) set of reserved names and does not change result values.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Backend-only change. A result row `(1, 2, 3)` with cursor column names `a, a, a__1` previously raised the error above. It now produces `{"a": 1, "a__2": 2, "a__1": 3}`.
### TESTING INSTRUCTIONS
- Regression cases failed before the fix, including the actual `SupersetResultSet` constructor failure.
- `pytest -q tests/unit_tests/result_set_test.py`: 27 passed (Python 3.11).
- Tests cover occupied suffixes before and after duplicates, several reserved suffixes, case-sensitive and case-insensitive comparisons, and a custom uppercase suffix.
To reproduce, run the new `test_result_set_with_colliding_column_suffix` test or execute `SELECT 1 AS a, 2 AS a, 3 AS a__1` through SQL Lab on an engine permitting duplicate output labels.
### ADDITIONAL INFORMATION
- [ ] Has associated issue
- [ ] Required feature flags
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
AI disclosure: This patch, tests, and description were prepared and checked by OpenAI Codex at the account owner's explicit request. No independent human review is claimed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "dennisimoo (via GitHub)" <gi...@apache.org>.
dennisimoo commented on code in PR #44189:
URL: https://github.com/apache/superset/pull/44189#discussion_r4011935244
##########
tests/unit_tests/result_set_test.py:
##########
@@ -21,19 +21,53 @@
import numpy as np
import pandas as pd
+import pytest
from numpy.core.multiarray import array
from pytest_mock import MockerFixture
from superset.db_engine_specs.base import BaseEngineSpec
from superset.result_set import (
+ dedup,
stringify_extension_columns,
stringify_values,
SupersetResultSet,
)
-from superset.superset_typing import DbapiResult
+from superset.superset_typing import DbapiDescription, DbapiResult
from superset.utils import json as superset_json
+@pytest.mark.parametrize(
+ "names,case_sensitive,expected",
+ [
+ (["a", "a", "a__1"], True, ["a", "a__2", "a__1"]),
+ (["a__1", "a", "a"], True, ["a__1", "a", "a__2"]),
+ (["a", "a", "a__1", "a__2"], True, ["a", "a__3", "a__1", "a__2"]),
+ (["a", "A", "A__1"], False, ["a", "A__2", "A__1"]),
+ (["a", "A", "A__1"], True, ["a", "A", "A__1"]),
+ ],
+)
+def test_dedup_preserves_explicit_column_names(
+ names: list[str], case_sensitive: bool, expected: list[str]
+) -> None:
+ assert dedup(names, case_sensitive=case_sensitive) == expected
+
+
+def test_result_set_with_colliding_column_suffix() -> None:
+ description: DbapiDescription = [
+ (name, "INT", None, None, None, None, False) for name in ("a", "a", "a__1")
+ ]
+ result = SupersetResultSet([(1, 2, 3)], description, BaseEngineSpec)
+ assert result.to_pandas_df().to_dict("records") == [{"a": 1, "a__2": 2, "a__1": 3}]
+
+
+def test_dedup_case_insensitive_custom_suffix() -> None:
+ assert dedup(["a", "A", "ax1"], suffix="X", case_sensitive=False) == [
+ "a",
+ "AX2",
+ "ax1",
+ ]
Review Comment:
Added in 2f6ff4b. The test fails without reserved.add(); all 28 tests and pre-commit checks pass. Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44189:
URL: https://github.com/apache/superset/pull/44189#issuecomment-5674763046
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2f6ff4ba70d9a6e2006eb2e00456fbc1920ced53 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa8c97bb6c78d00080e3118 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44189--superset-docs-preview.netlify.app](https://deploy-preview-44189--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#FctBCoAgEEDRu8y6SAnUukHH0HEgQR3RgiK6e7Z7i_8fKJVTOWAFGMBVm3HvRvZ0TZXaGY8ROZ4pj9km-h1DC5xbzz2VyPfm-6CsNbho5xRq44UQRtAspYH3Aw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44189--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44189:
URL: https://github.com/apache/superset/pull/44189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on code in PR #44189:
URL: https://github.com/apache/superset/pull/44189#discussion_r4009435809
##########
tests/unit_tests/result_set_test.py:
##########
@@ -21,19 +21,53 @@
import numpy as np
import pandas as pd
+import pytest
from numpy.core.multiarray import array
from pytest_mock import MockerFixture
from superset.db_engine_specs.base import BaseEngineSpec
from superset.result_set import (
+ dedup,
stringify_extension_columns,
stringify_values,
SupersetResultSet,
)
-from superset.superset_typing import DbapiResult
+from superset.superset_typing import DbapiDescription, DbapiResult
from superset.utils import json as superset_json
+@pytest.mark.parametrize(
+ "names,case_sensitive,expected",
+ [
+ (["a", "a", "a__1"], True, ["a", "a__2", "a__1"]),
+ (["a__1", "a", "a"], True, ["a__1", "a", "a__2"]),
+ (["a", "a", "a__1", "a__2"], True, ["a", "a__3", "a__1", "a__2"]),
+ (["a", "A", "A__1"], False, ["a", "A__2", "A__1"]),
+ (["a", "A", "A__1"], True, ["a", "A", "A__1"]),
+ ],
+)
+def test_dedup_preserves_explicit_column_names(
+ names: list[str], case_sensitive: bool, expected: list[str]
+) -> None:
+ assert dedup(names, case_sensitive=case_sensitive) == expected
+
+
+def test_result_set_with_colliding_column_suffix() -> None:
+ description: DbapiDescription = [
+ (name, "INT", None, None, None, None, False) for name in ("a", "a", "a__1")
+ ]
+ result = SupersetResultSet([(1, 2, 3)], description, BaseEngineSpec)
+ assert result.to_pandas_df().to_dict("records") == [{"a": 1, "a__2": 2, "a__1": 3}]
+
+
+def test_dedup_case_insensitive_custom_suffix() -> None:
+ assert dedup(["a", "A", "ax1"], suffix="X", case_sensitive=False) == [
+ "a",
+ "AX2",
+ "ax1",
+ ]
Review Comment:
`reserved.add(...)` is the one conjunct no test pins — deleting it leaves all 27 green. It only bites when two different bases generate the same name, which the default `__` suffix cannot produce. A case that fails without it:
```suggestion
]
def test_dedup_reserves_generated_names() -> None:
result = dedup(["a"] * 14 + ["a1"] * 2, suffix="")
assert len(set(result)) == len(result)
assert result[-1] == "a15"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "dennisimoo (via GitHub)" <gi...@apache.org>.
dennisimoo commented on code in PR #44189:
URL: https://github.com/apache/superset/pull/44189#discussion_r4011935244
##########
tests/unit_tests/result_set_test.py:
##########
@@ -21,19 +21,53 @@
import numpy as np
import pandas as pd
+import pytest
from numpy.core.multiarray import array
from pytest_mock import MockerFixture
from superset.db_engine_specs.base import BaseEngineSpec
from superset.result_set import (
+ dedup,
stringify_extension_columns,
stringify_values,
SupersetResultSet,
)
-from superset.superset_typing import DbapiResult
+from superset.superset_typing import DbapiDescription, DbapiResult
from superset.utils import json as superset_json
+@pytest.mark.parametrize(
+ "names,case_sensitive,expected",
+ [
+ (["a", "a", "a__1"], True, ["a", "a__2", "a__1"]),
+ (["a__1", "a", "a"], True, ["a__1", "a", "a__2"]),
+ (["a", "a", "a__1", "a__2"], True, ["a", "a__3", "a__1", "a__2"]),
+ (["a", "A", "A__1"], False, ["a", "A__2", "A__1"]),
+ (["a", "A", "A__1"], True, ["a", "A", "A__1"]),
+ ],
+)
+def test_dedup_preserves_explicit_column_names(
+ names: list[str], case_sensitive: bool, expected: list[str]
+) -> None:
+ assert dedup(names, case_sensitive=case_sensitive) == expected
+
+
+def test_result_set_with_colliding_column_suffix() -> None:
+ description: DbapiDescription = [
+ (name, "INT", None, None, None, None, False) for name in ("a", "a", "a__1")
+ ]
+ result = SupersetResultSet([(1, 2, 3)], description, BaseEngineSpec)
+ assert result.to_pandas_df().to_dict("records") == [{"a": 1, "a__2": 2, "a__1": 3}]
+
+
+def test_dedup_case_insensitive_custom_suffix() -> None:
+ assert dedup(["a", "A", "ax1"], suffix="X", case_sensitive=False) == [
+ "a",
+ "AX2",
+ "ax1",
+ ]
Review Comment:
Added in 2f6ff4b, using your cross-base collision case. I verified that removing reserved.add() makes the new test fail (15 unique names for 16 entries); restoring it passes. The full result_set_test.py file passes all 28 tests, and pre-commit on the changed file passes. Thanks for catching the missing coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44189:
URL: https://github.com/apache/superset/pull/44189#issuecomment-5642808870
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44189:
URL: https://github.com/apache/superset/pull/44189#issuecomment-5676523763
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44189:
URL: https://github.com/apache/superset/pull/44189#issuecomment-5643291554
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44189?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.00000%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.45%. Comparing base ([`3d01094`](https://app.codecov.io/gh/apache/superset/commit/3d01094d231712e3470eb625be3f9925aeaeadb5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`65adf0d`](https://app.codecov.io/gh/apache/superset/commit/65adf0dbd980041bcd5967c569385b752aa6c845?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/44189?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/result\_set.py](https://app.codecov.io/gh/apache/superset/pull/44189?src=pr&el=tree&filepath=superset%2Fresult_set.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (3d01094) and HEAD (65adf0d). Click for more details.
>
> <details><summary>HEAD has 45 uploads less than BASE</summary>
>
>| Flag | BASE (3d01094) | HEAD (65adf0d) |
>|------|------|------|
>|hive|6|1|
>|python|37|2|
>|presto|6|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44189 +/- ##
===========================================
- Coverage 80.16% 57.45% -22.72%
===========================================
Files 2925 2925
Lines 172563 172568 +5
Branches 40058 40059 +1
===========================================
- Hits 138339 99144 -39195
- Misses 31627 72492 +40865
+ Partials 2597 932 -1665
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.34% <40.00%> (+<0.01%)` | :arrow_up: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.22% <40.00%> (+<0.01%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.27% <40.00%> (-45.28%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/44189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44189?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "dennisimoo (via GitHub)" <gi...@apache.org>.
dennisimoo commented on PR #44189:
URL: https://github.com/apache/superset/pull/44189#issuecomment-5690305781
Rebased onto master to include the migration-head fix in #44288. All 28 result-set tests and pre-commit checks pass; CI will rerun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sql-lab): avoid duplicate generated result column names [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44189:
URL: https://github.com/apache/superset/pull/44189#issuecomment-5691721133
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org