You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/13 10:57:59 UTC
[GitHub] [skywalking] tom-pytel opened a new pull request, #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
tom-pytel opened a new pull request, #9955:
URL: https://github.com/apache/skywalking/pull/9955
For: https://github.com/apache/skywalking-nodejs/pull/100
Also includes some previous component server mappings which I guess I forgot to push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9955:
URL: https://github.com/apache/skywalking/pull/9955#issuecomment-1312761907
One more, changes should be uodated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9955:
URL: https://github.com/apache/skywalking/pull/9955#discussion_r1020890525
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -425,6 +425,15 @@ tls:
Micronaut:
id: 131
languages: Java
+AWSDynamoDB:
+ id: 132
+ languages: Java,C#,Node.js,Python
+AWSSNS:
+ id: 133
+ languages: Java,C#,Node.js,Python
+AWSSQS:
+ id: 134
+ languages: Java,C#,Node.js,Python
Review Comment:
132-134 have been registered. Please register to new IDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9955:
URL: https://github.com/apache/skywalking/pull/9955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tom-pytel commented on pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #9955:
URL: https://github.com/apache/skywalking/pull/9955#issuecomment-1312757065
> We don't need extra logos for those services, right?
They would be logos from Amazon itself, I am guessing copyrighted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tom-pytel commented on pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #9955:
URL: https://github.com/apache/skywalking/pull/9955#issuecomment-1312763080
> One more, changes should be uodated.
Yes, will update in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] tom-pytel commented on a diff in pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on code in PR #9955:
URL: https://github.com/apache/skywalking/pull/9955#discussion_r1020929102
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -425,6 +425,15 @@ tls:
Micronaut:
id: 131
languages: Java
+AWSDynamoDB:
+ id: 132
+ languages: Java,C#,Node.js,Python
+AWSSNS:
+ id: 133
+ languages: Java,C#,Node.js,Python
+AWSSQS:
+ id: 134
+ languages: Java,C#,Node.js,Python
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9955: Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9955:
URL: https://github.com/apache/skywalking/pull/9955#issuecomment-1312850777
Merged first, in case of conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org