You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jim Spring <no...@github.com> on 2017/07/27 20:06:13 UTC
[jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
At some point the substitution of the "SUBSCRIPTION_ID" for the AzureComputeProviderMetadata endpoint stopped working. This PR fixes that substitution issue to work properly.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/406
-- Commit Summary --
* Subscription ID wasn't being substituted
-- File Changes --
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeProviderMetadata.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/406.patch
https://github.com/jclouds/jclouds-labs/pull/406.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406
Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
Posted by Ignasi Barrera <no...@github.com>.
Closed #406.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406#event-1187024419
Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
Posted by Ignasi Barrera <no...@github.com>.
I think [this](https://github.com/jclouds/jclouds-labs/commit/17f7c4528472c87799df28512b7a97571f11f625) is the offending commit.
Having the property makes it easier to create the context. Following the same pattern, it would be good to also preset the `oauth.endpoint` property by default in the provider metadata default properties with a placeholder for the `tenantId` to be substituted the same way. WDYT? This way users will only have to set the two properties and the credentials (and they'll still be able to configure the entire endpoints if they want to).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-318579277
Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
Posted by Jim Spring <no...@github.com>.
@nacx Default oauth.endpoint added. Tested with compute-basics.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-318734863
Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
Posted by Jim Spring <no...@github.com>.
@nacx -- at some point the endpoint URL for Azure ARM calls broke. This PR fixes that. I'm not sure when/how the exact breakage (change to JClouds maybe?) occurred. Tested using jclouds-examples/compute-basics.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-318471776
Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
Posted by Jim Spring <no...@github.com>.
It makes sense.
I'll plumb it into the pr today.
-j
On Jul 28, 2017 12:12 AM, "Ignasi Barrera" <no...@github.com> wrote:
> I think this
> <https://github.com/jclouds/jclouds-labs/commit/17f7c4528472c87799df28512b7a97571f11f625>
> is the offending commit.
>
> Having the property makes it easier to create the context. Following the
> same pattern, it would be good to also preset the oauth.endpoint property
> by default in the provider metadata default properties with a placeholder
> for the tenantId to be substituted the same way. WDYT? This way users
> will only have to set the two properties and the credentials (and they'll
> still be able to configure the entire endpoints if they want to).
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-318579277>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAHljhdu28xiL9zO7Gvdrs3O6gImefV2ks5sSYnXgaJpZM4OlxeV>
> .
>
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-318681666
Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted
(#406)
Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [caf91f88](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/caf91f88). Thanks, @jmspring!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-319279212