You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/05 15:38:20 UTC
[GitHub] [flink] rmetzger opened a new pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
rmetzger opened a new pull request #13950:
URL: https://github.com/apache/flink/pull/13950
## What is the purpose of the change
The prometheus e2e test might get killed by the oom killer. This adds more infrastructure for generally logging received signals in the test, and collecting the kernel messages at the end of the e2e tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13950:
URL: https://github.com/apache/flink/pull/13950#issuecomment-722537629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "916e5b7a425dbd5b95046e39283a7da7313b5b5a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9113",
"triggerID" : "916e5b7a425dbd5b95046e39283a7da7313b5b5a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 916e5b7a425dbd5b95046e39283a7da7313b5b5a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9113)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13950:
URL: https://github.com/apache/flink/pull/13950#discussion_r518170871
##########
File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/TestSignalHandler.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import sun.misc.Signal;
+
+/**
+ * This signal handler / signal logger is based on Apache Hadoop's org.apache.hadoop.util.SignalLogger.
+ *
+ * <p>This is a reduced version of {@link org.apache.flink.runtime.util.SignalHandler}.
Review comment:
Yes, I was annoyed by this as well!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13950:
URL: https://github.com/apache/flink/pull/13950#issuecomment-722457098
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 916e5b7a425dbd5b95046e39283a7da7313b5b5a (Thu Nov 05 15:40:11 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13950:
URL: https://github.com/apache/flink/pull/13950#issuecomment-722474909
Thanks for your review. Will merge once CI has passed (tomorrow 😂 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13950:
URL: https://github.com/apache/flink/pull/13950#issuecomment-722537629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "916e5b7a425dbd5b95046e39283a7da7313b5b5a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "916e5b7a425dbd5b95046e39283a7da7313b5b5a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 916e5b7a425dbd5b95046e39283a7da7313b5b5a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13950:
URL: https://github.com/apache/flink/pull/13950#discussion_r518169286
##########
File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/TestSignalHandler.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import sun.misc.Signal;
+
+/**
+ * This signal handler / signal logger is based on Apache Hadoop's org.apache.hadoop.util.SignalLogger.
+ *
+ * <p>This is a reduced version of {@link org.apache.flink.runtime.util.SignalHandler}.
Review comment:
I'm wondering whether this reduction makes sense. Couldn't we just move the existing SignalHandler to flink-runtime to flinkcore, and register it in the test logger with....well no we can't because flink-test-utils-junit doesn't depend on flink-core, and everything else uses flink-test-utils-junit as a test dependency. So there is quite literally no place to put it.
Well that's annoying 💢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13950:
URL: https://github.com/apache/flink/pull/13950#discussion_r518163664
##########
File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/TestSignalHandler.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import sun.misc.Signal;
Review comment:
~~does this work on java 11?~~
Guess it does since we use the same thing already in flink-runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13950:
URL: https://github.com/apache/flink/pull/13950#issuecomment-722537629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "916e5b7a425dbd5b95046e39283a7da7313b5b5a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9113",
"triggerID" : "916e5b7a425dbd5b95046e39283a7da7313b5b5a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 916e5b7a425dbd5b95046e39283a7da7313b5b5a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9113)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13950:
URL: https://github.com/apache/flink/pull/13950#issuecomment-722471350
The class is in flink-runtime. We could move it to flink-core, but so far the junit testing utils have no Flink dependencies. I didn't want to mess with the dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13950:
URL: https://github.com/apache/flink/pull/13950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13950: [FLINK-19699][e2e] Improve error reporting for failing Prometheus test.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13950:
URL: https://github.com/apache/flink/pull/13950#discussion_r518163664
##########
File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/TestSignalHandler.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import sun.misc.Signal;
Review comment:
does this work on java 11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org