[aries-journaled-events] branch master updated (050cdc9 -> 530611c)

[cs...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cschneider pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/aries-journaled-events.git.


 discard 050cdc9  Remove TopicPosition as we do not support partitions
     new 530611c  Remove TopicPosition as we do not support partitions

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (050cdc9)
            \
             N -- N -- N   refs/heads/master (530611c)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../main/java/org/apache/aries/events/api/TopicPosition.java  | 11 -----------
 1 file changed, 11 deletions(-)
 delete mode 100644 org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/TopicPosition.java

[aries-journaled-events] 01/01: Remove TopicPosition as we do not support partitions

[cs...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cschneider pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/aries-journaled-events.git

commit 530611c5e8fa6df9820353576381b6324055be62
Author: Christian Schneider <cs...@adobe.com>
AuthorDate: Mon Dec 31 09:45:15 2018 +0100

    Remove TopicPosition as we do not support partitions
---
 .../src/main/java/org/apache/aries/events/api/Messaging.java  |  2 +-
 .../src/main/java/org/apache/aries/events/api/Position.java   |  6 ++++--
 .../main/java/org/apache/aries/events/api/TopicPosition.java  | 11 -----------
 3 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java
index 7432799..e2f9308 100644
--- a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java
+++ b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java
@@ -22,7 +22,7 @@ public interface Messaging {
      * @param callback will be called for each message received
      * @return Returned subscription must be closed by the caller to unsubscribe
      */
-    Subscription subscribe(String topic, TopicPosition position, Seek seek, Consumer<Message> callback);
+    Subscription subscribe(String topic, Position position, Seek seek, Consumer<Message> callback);
 
     /**
      * Create a message with payload and metadata
diff --git a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java
index 4e1c8ee..7a85039 100644
--- a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java
+++ b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java
@@ -1,8 +1,10 @@
 package org.apache.aries.events.api;
 
 /**
- * Implementation dependent position in a the topic.
- * E.g. For a kafka implementation this would be a list of (partition, offset)
+ * Position in a the topic.
+ * E.g. For a kafka implementation this would be a list of (partition, offset) as we do not support partitions 
+ * this could simply be like an offset.
+ * TODO How do we provide ordering without being too specific?
  */
 public interface Position {
     
diff --git a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/TopicPosition.java b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/TopicPosition.java
deleted file mode 100644
index 8416163..0000000
--- a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/TopicPosition.java
+++ /dev/null
@@ -1,11 +0,0 @@
-package org.apache.aries.events.api;
-
-import java.util.Set;
-
-/**
- * Implementation dependent position in a the topic.
- * E.g. For a kafka implementation this would be a list of (partition, offset)
- */
-public interface TopicPosition {
-    Set<Position> getPositions(); 
-}