You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/01/20 11:12:02 UTC
[GitHub] incubator-gearpump pull request #137: [GERAPUMP-22] Merge akka-streams branc...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/137
[GERAPUMP-22] Merge akka-streams branch into master
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump akka-streams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 4fe5458f45e1f1a9da84704d7c4d7eaff3b625bb
Author: Kam Kasravi <ka...@yahoo.com>
Date: 2016-10-11T02:32:04Z
Fixes #22 support akka-streams Gearpump Materializer
Author: Kam Kasravi <ka...@yahoo.com>
Closes #94 from kkasravi/GEARPUMP-22.
commit bc39403525b4065360acf82386fac21a588b59e6
Author: manuzhang <ow...@gmail.com>
Date: 2016-10-11T03:57:48Z
Merge branch 'master' into akka-streams
Author: manuzhang <ow...@gmail.com>
Author: darionyaphet <da...@gmail.com>
Closes #95 from manuzhang/akka-streams.
commit f1bec67098b80f9bffe719f885f8d089344a5579
Author: manuzhang <ow...@gmail.com>
Date: 2016-10-12T06:30:49Z
update akkastream against latests Graph DSL
Author: manuzhang <ow...@gmail.com>
Closes #97 from manuzhang/akka-streams-new.
commit efed8e7ec4b31ee4517a3c0639758fb33eb1510f
Author: manuzhang <ow...@gmail.com>
Date: 2017-01-20T05:37:58Z
Merge branch 'master' into akka-streams
# Conflicts:
# core/src/main/scala/org/apache/gearpump/cluster/UserConfig.scala
# examples/streaming/wordcount/src/main/scala/org/apache/gearpump/streaming/examples/wordcount/dsl/WindowedWordCount.scala
# experiments/redis/src/main/scala/org/apache/gearpump/redis/RedisMessage.scala
# experiments/redis/src/main/scala/org/apache/gearpump/redis/RedisSink.scala
# project/Build.scala
# project/BuildShaded.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/Stream.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/javaapi/JavaStream.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/partitioner/GroupByPartitioner.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/plan/OP.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/plan/functions/SingleInputFunction.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/CountTriggerTask.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/EventTimeTriggerTask.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/ProcessingTimeTriggerTask.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/TransformTask.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala
# streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala
# streaming/src/test/scala/org/apache/gearpump/streaming/dsl/plan/OpSpec.scala
# streaming/src/test/scala/org/apache/gearpump/streaming/dsl/plan/PlannerSpec.scala
# streaming/src/test/scala/org/apache/gearpump/streaming/dsl/plan/functions/SingleInputFunctionSpec.scala
# streaming/src/test/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamAppSpec.scala
# streaming/src/test/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamSpec.scala
commit 3e61236faef44bf93d7943e8eea76c8cdfca5ac2
Author: manuzhang <ow...@gmail.com>
Date: 2017-01-20T05:38:31Z
Fix compile errors
commit bd2d5bb44cb762f7c93737bed9860e1eb33ccf81
Author: manuzhang <ow...@gmail.com>
Date: 2017-01-20T07:26:08Z
Add scalastyle-config.xml
commit 5539150e187bb9271a2a7337857cfdedf0c3b827
Author: manuzhang <ow...@gmail.com>
Date: 2017-01-20T08:27:38Z
Fix scalastyle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #137: [GERAPUMP-22] Merge akka-streams branch into ...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/137
R: @huafengw Most changes are confined to akka-streams module while the major exception is upgrading akka version. I've made some inline comments to note it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #137: [GERAPUMP-22] Merge akka-streams branch into ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/137
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/137?src=pr) is 70.67% (diff: 85.71%)
> Merging [#137](https://codecov.io/gh/apache/incubator-gearpump/pull/137?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **0.22%**
```diff
@@ master #137 diff @@
==========================================
Files 191 191
Lines 6019 6018 -1
Methods 5500 5502 +2
Messages 0 0
Branches 517 514 -3
==========================================
+ Hits 4240 4253 +13
+ Misses 1779 1765 -14
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [5f90b70...b3d3374](https://codecov.io/gh/apache/incubator-gearpump/compare/5f90b70f98a5aec68be5e6cbd46805916281d3f2...b3d33741136615f3c8fc2b85fc3fd2431ffa2ff2?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #137: [GERAPUMP-22] Merge akka-streams branc...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/137#discussion_r97054274
--- Diff: project/Dependencies.scala ---
@@ -23,7 +23,8 @@ object Dependencies {
val crossScalaVersionNumbers = Seq("2.11.8")
val scalaVersionNumber = crossScalaVersionNumbers.last
- val akkaVersion = "2.4.3"
+ val akkaVersion = "2.4.16"
--- End diff --
Note that Akka version is updated to **2.4.16**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #137: [GERAPUMP-22] Merge akka-streams branc...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/137#discussion_r97054147
--- Diff: project/BuildExperiments.scala ---
@@ -25,7 +25,7 @@ import sbt.Keys._
object BuildExperiments extends sbt.Build {
lazy val experiments: Seq[ProjectReference] = Seq(
- // akkastream,
+ akkastream,
--- End diff --
now build is activated for `akkastream` project
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #137: [GERAPUMP-22] Merge akka-streams branc...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/137#discussion_r97054334
--- Diff: project/Dependencies.scala ---
@@ -23,7 +23,8 @@ object Dependencies {
val crossScalaVersionNumbers = Seq("2.11.8")
val scalaVersionNumber = crossScalaVersionNumbers.last
- val akkaVersion = "2.4.3"
+ val akkaVersion = "2.4.16"
+ val akkaHttpVersion = "10.0.1"
--- End diff --
Note that akka-http version is updated to **10.0.1**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #137: [GERAPUMP-22] Merge akka-streams branc...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/137#discussion_r97054779
--- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/StreamApplication.scala ---
@@ -123,7 +123,7 @@ object LifeTime {
*/
class StreamApplication(
override val name: String, val inputUserConfig: UserConfig,
- dag: Graph[ProcessorDescription, PartitionerDescription])
+ val dag: Graph[ProcessorDescription, PartitionerDescription])
--- End diff --
We need to access `dag` in `RemoteMaterializerImpl` for akka-streams.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #137: [GERAPUMP-22] Merge akka-streams branc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #137: [GERAPUMP-22] Merge akka-streams branch into ...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/137
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---