[GitHub] [hudi] vinothchandar commented on a change in pull request #3373: [HUDI-2255] Refactor Datasource options

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #3373:
URL: https://github.com/apache/hudi/pull/3373#discussion_r680043304



##########
File path: docker/demo/sparksql-incremental.commands
##########
@@ -27,8 +27,8 @@ import org.apache.hadoop.fs.FileSystem;
 val fs = FileSystem.get(spark.sparkContext.hadoopConfiguration)
 val beginInstantTime = HoodieDataSourceHelpers.listCommitsSince(fs, "/user/hive/warehouse/stock_ticks_cow", "00000").get(0)
 val hoodieIncQueryDF =  spark.read.format("org.apache.hudi").
-                      option(DataSourceReadOptions.QUERY_TYPE_OPT_KEY.key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL).
-                      option(DataSourceReadOptions.BEGIN_INSTANTTIME_OPT_KEY.key(), beginInstantTime).
+                      option(DataSourceReadOptions.QUERY_TYPE_OPT.key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL).

Review comment:
       @zhedoubushishi how about we drop the `_OPT` as well. Just `DataSourceReadOptions.QUERY_TYPE` ? Sounds lot shorter?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org