You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/02 09:19:59 UTC

[GitHub] [echarts] pe-3 opened a new pull request, #17457: feat(funnel): funnel exit can be rect #14863

pe-3 opened a new pull request, #17457:
URL: https://github.com/apache/echarts/pull/17457

   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   The shape of the funnel exit can be rect.
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   #14863
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   #### We need to maintain the pyramid shape of the funnel and add a way to flatten funnel exit to make it closer to the funnel
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   ![beforeFunnel](https://user-images.githubusercontent.com/103579791/182336140-3416ba67-abaf-4f5a-af1a-3e1a6a84d092.png)
   
   
   
   ### After: How does it behave after the fixing?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   #### Add a new property to set is as rect then the funnel exit is flattened.
   `series:[{
       ...,
       exitShape:'rect'
   }]`
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   ![funnel-exit-rect](https://user-images.githubusercontent.com/103579791/182337063-2377c734-f1dc-44a0-b1bd-93e6c9b99b9e.png)
   ![image](https://user-images.githubusercontent.com/103579791/182337700-50f64fe8-2671-4505-aad4-af36e40404c8.png)
   ![image](https://user-images.githubusercontent.com/103579791/182337751-010f028f-4684-45f6-9d46-5f7c0f465580.png)
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [ ] This PR doesn't relate to document changes
   - [x] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   Please refer to test/funnel.html
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pe-3 closed pull request #17457: feat(funnel): funnel exit can be rect #14863

Posted by GitBox <gi...@apache.org>.
pe-3 closed pull request #17457: feat(funnel): funnel exit can be rect #14863
URL: https://github.com/apache/echarts/pull/17457


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17457: feat(funnel): funnel exit can be rect #14863

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17457:
URL: https://github.com/apache/echarts/pull/17457#issuecomment-1202234823

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org