You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/06/27 15:00:31 UTC
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test fpr reading ACID tables
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13751
Change subject: IMPALA-8648: Add a simple stress test fpr reading ACID tables
......................................................................
IMPALA-8648: Add a simple stress test fpr reading ACID tables
Add a test that runs several INSERT INTO/OVERWRITE to a single table
in Hive and reads in from a parallel process using Impala.
Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
---
A tests/stress/test_acid_stress.py
1 file changed, 117 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13751/1
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4685/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 13:29:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13751
to look at the new patch set (#6).
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
IMPALA-8648: Add a simple stress test for reading ACID tables
Add a test that runs several INSERT INTO/OVERWRITE to a single table
in Hive and reads in from a parallel process using Impala.
Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
---
A tests/stress/test_acid_stress.py
1 file changed, 133 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13751/6
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 6:
Added a version of the test that writes a table with a single partition.
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 12:49:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 3: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 13:40:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test fpr reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test fpr reading ACID tables
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3768/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:40:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49:
nit: no space needed
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49: '
nit: extra '
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@67
PS3, Line 67: read
write?
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@68
PS3, Line 68: from Hive.
Should we add another role and test for an Impala writer?
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@86
PS3, Line 86: if len(result.data) == 0:
: continue
nit: __verify_result() could just return when result.data is empty
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@94
PS3, Line 94:
nit: extra indentation
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@114
PS3, Line 114: CTRL+C can't interrupt the test
You can use pool.map_async(...).get(long timeout) which will handle keyboard interrupts properly.
See https://stackoverflow.com/a/1408476
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@116
PS3, Line 116: for i in pool.imap(do_role, ["impala", "hive"]):
: pass
why not just simply pool.imap()? Or better, pool.map_async(...).get(...)?
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 15:17:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 2: Code-Review-2
I ran it a bit more and hit the following issue:
Query aborted:Disk I/O error on csringhofer-desktop:22001: Failed to open HDFS file hdfs://localhost:20500/test-warehouse/test_read_hive_inserts_9016893c.db/test_read_hive_inserts/_tmp.base_0000001/000000_0.manifest
Error(2): No such file or directory
This should be fixed if the .tmp file skipping logic goes in:
https://gerrit.cloudera.org/#/c/13665/
Until then this test is flaky.
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 16:12:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 12:53:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
IMPALA-8648: Add a simple stress test for reading ACID tables
Add a test that runs several INSERT INTO/OVERWRITE to a single table
in Hive and reads in from a parallel process using Impala.
Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Reviewed-on: http://gerrit.cloudera.org:8080/13751
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A tests/stress/test_acid_stress.py
1 file changed, 133 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13751
to look at the new patch set (#2).
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
IMPALA-8648: Add a simple stress test for reading ACID tables
Add a test that runs several INSERT INTO/OVERWRITE to a single table
in Hive and reads in from a parallel process using Impala.
Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
---
A tests/stress/test_acid_stress.py
1 file changed, 117 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13751/2
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4684/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 12:34:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13751
to look at the new patch set (#5).
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
IMPALA-8648: Add a simple stress test for reading ACID tables
Add a test that runs several INSERT INTO/OVERWRITE to a single table
in Hive and reads in from a parallel process using Impala.
Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
---
A tests/stress/test_acid_stress.py
1 file changed, 119 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13751/5
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49: V
> nit: no space needed
Done
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@67
PS3, Line 67: writ
> write?
Done
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@68
PS3, Line 68: rom Hive."
> Should we add another role and test for an Impala writer?
We should, but I consider that a different test. For Impala writers to most interesting is the case when there are multiple impalad's doing inserts in parallel.
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@86
PS3, Line 86: result = self.client.execute("select * from %s" % tbl_name)
: if len(res
> nit: __verify_result() could just return when result.data is empty
I made this a bit stricter - we shouldn't see 0 rows after the first insert, as insert overwrite statement always reset to 1 row.
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@94
PS3, Line 94: ytes
> nit: extra indentation
Done
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 11:57:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 17:15:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5032/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 12:53:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49: '
> nit: extra '
Done
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@114
PS3, Line 114: CTRL+C can't interrupt the test
> You can use pool.map_async(...).get(long timeout) which will handle keyboar
Thanks, it works well!
http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@116
PS3, Line 116: for i in pool.imap(do_role, ["impala", "hive"]):
: pass
> why not just simply pool.imap()? Or better, pool.map_async(...).get(...)?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 11:58:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 12:53:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................
Patch Set 5: Code-Review+2
Lgtm, do you want to add partitioned table tests as well?
--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 12:46:16 +0000
Gerrit-HasComments: No