You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/04 04:50:11 UTC

[GitHub] [echarts] dmzc opened a new pull request, #17155: fix:improve PictorialBarSeriesOption

dmzc opened a new pull request, #17155:
URL: https://github.com/apache/echarts/pull/17155

   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] 100pah merged pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
100pah merged PR #17155:
URL: https://github.com/apache/echarts/pull/17155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] dmzc commented on pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
dmzc commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1147001828

   > Please update PR description to let us know what this PR does and why it's necessary.
   
   The PR description is completed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] dmzc closed pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
dmzc closed pull request #17155: fix:improve PictorialBarSeriesOption
URL: https://github.com/apache/echarts/pull/17155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia commented on pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1148153935

   I check the code and the following series don't have `SeriesEncodeOptionMixin`. @100pah Can you confirm if there are any missing by mistake?
   
   - Treemap
   - Tree
   - Sunburst
   - Lines
   - Graph
   - Sankey
   - ThemeRiver
   - Pictorial (the only one that has `encode` in the doc)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1148300423

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] dmzc commented on pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
dmzc commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1147001018

   > Please update PR description to let us know what this PR does and why it's necessar


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1146533470

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] 100pah commented on pull request #17155: fix:improve PictorialBarSeriesOption

Posted by GitBox <gi...@apache.org>.
100pah commented on PR #17155:
URL: https://github.com/apache/echarts/pull/17155#issuecomment-1148309517

   @Ovilia 
   
   > I check the code and the following series don't have SeriesEncodeOptionMixin. @100pah Can you confirm if there are any missing by mistake?
   
   > Treemap
   > Tree
   > Sunburst
   > Lines
   > Graph
   > Sankey
   > ThemeRiver
   > Pictorial (the only one that has encode in the doc)
   
   
   This series theoretically can use `encode`, but seams rarely used? We can probably add `encode` 
   Tree based data source (`Treemap`, `Tree`, `Sunburst`)  and graph based data source (`Graph`, `Sankey `) theoretically can use `encode`, but we might not ready to use it (e.g.,  no test case yet).
   
   `Lines` and `ThemeRiver ` have special data source, which we are not sure whether it is suitable to use `encode` yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org