You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/11/15 21:46:35 UTC

Review Request: Added registration timeout for executors

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs
-----

  src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
  src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
  src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
  src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
  src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
  src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
  src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.

> On Nov. 16, 2012, 7:09 p.m., Ben Mahler wrote:
> > src/slave/process_based_isolation_module.cpp, line 291
> > <https://reviews.apache.org/r/8077/diff/2/?file=190545#file190545line291>
> >
> >     Do you see a way to avoid introducing this boolean?

Hmmm, not sure how. The thing is an executor process terminated signal might still need a proper clean up (for eg: process group in process based isolation module or cgroup in cgroup based isolation module). Also, note that killExecutor() can be called by the slave. Fwiw, the boolean 'killed' here is used similarly in cgroups isolation module.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13523
-----------------------------------------------------------


On Nov. 15, 2012, 11:54 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 11:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Ben Mahler <be...@gmail.com>.

> On Nov. 16, 2012, 7:09 p.m., Ben Mahler wrote:
> > src/slave/process_based_isolation_module.cpp, line 291
> > <https://reviews.apache.org/r/8077/diff/2/?file=190545#file190545line291>
> >
> >     Do you see a way to avoid introducing this boolean?
> 
> Vinod Kone wrote:
>     Hmmm, not sure how. The thing is an executor process terminated signal might still need a proper clean up (for eg: process group in process based isolation module or cgroup in cgroup based isolation module). Also, note that killExecutor() can be called by the slave. Fwiw, the boolean 'killed' here is used similarly in cgroups isolation module.

Ah, yes, I had a bit of deja-vu when looking at this ;)

To me it seems like killExecutor() should be smart enough to be called several times, so that we can avoid having to introduce more state (i.e. the killed boolean).
I could be convinced otherwise though, since I don't know this code very well.
I guess one advantage of ensuring it's only called once is that we can LOG any redundant/invalid kill attempts?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13523
-----------------------------------------------------------


On Nov. 15, 2012, 11:54 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 11:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13523
-----------------------------------------------------------



src/slave/process_based_isolation_module.cpp
<https://reviews.apache.org/r/8077/#comment29015>

    Do you see a way to avoid introducing this boolean?


- Ben Mahler


On Nov. 15, 2012, 11:54 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 11:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.

> On Nov. 19, 2012, 11:37 p.m., Ben Mahler wrote:
> > src/slave/process_based_isolation_module.hpp, line 91
> > <https://reviews.apache.org/r/8077/diff/3/?file=221889#file221889line91>
> >
> >     s/'killExecutor'/killExecutor() ?

done


> On Nov. 19, 2012, 11:37 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 1168
> > <https://reviews.apache.org/r/8077/diff/3/?file=221893#file221893line1168>
> >
> >     Where are the schedule and detroyExecutor calls now? Will they be called as a consequence of killExecutor?

We only do it once now, inside executorTerminated(). And yes killExecutor results in executorTerminated.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13596
-----------------------------------------------------------


On Nov. 19, 2012, 9:23 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 9:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13596
-----------------------------------------------------------


Almost a ship it from me ;)


src/slave/process_based_isolation_module.hpp
<https://reviews.apache.org/r/8077/#comment29171>

    s/'killExecutor'/killExecutor() ?



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment29172>

    Where are the schedule and detroyExecutor calls now? Will they be called as a consequence of killExecutor?


- Ben Mahler


On Nov. 19, 2012, 9:23 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 9:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review14270
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment30406>

    As discussed offline, you still want to keep the gc'ing right?


- Benjamin Hindman


On Nov. 20, 2012, 3:37 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 3:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/cgroups_isolation_module.hpp 9f80fc5a969b959b34eaea4cac40700662d7f8b2 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review18109
-----------------------------------------------------------

Ship it!



src/slave/constants.cpp
<https://reviews.apache.org/r/8077/#comment38227>

    plumb it through flags.



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment38228>

    kill comment



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment38229>

    kill comment



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment38230>

    s/WARNING/INFO
    
    rephrase



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment38231>

    flags.


- Vinod Kone


On March 16, 2013, 1:49 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 1:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor, executor process hung after fork).
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp c1d6f54fb0c93d255f95ee85e1305022db1ce3cc 
>   src/master/master.cpp 87bbfac692c3f37f4ef1112b1a44e2afa01296d8 
>   src/slave/cgroups_isolator.hpp 049d50e306d936708d2bde72b1f16f8accaf9a13 
>   src/slave/cgroups_isolator.cpp c06baecac5a89886673a36d3dad934e06a577875 
>   src/slave/constants.hpp 02c45398cbc2686de22750c38f69761e0fccb24c 
>   src/slave/constants.cpp 8ef3642d1624db71f40a07be86373f44afa93f21 
>   src/slave/process_isolator.cpp e719a0711157f37cf87b92127fd4f50287b1cf21 
>   src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118 
>   src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca 
>   src/tests/master_tests.cpp 9d13ebe2f1d3cbc1d39fd8bdd5060a15e2767eb0 
>   third_party/libprocess/include/process/delay.hpp cb2fa9ab372e62befec01a95b3ca401567a1a626 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated March 20, 2013, 1:17 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benh's comments. no need for further review, but need a shipit.


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor, executor process hung after fork).


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp c1d6f54fb0c93d255f95ee85e1305022db1ce3cc 
  src/master/master.cpp 87bbfac692c3f37f4ef1112b1a44e2afa01296d8 
  src/slave/cgroups_isolator.hpp 049d50e306d936708d2bde72b1f16f8accaf9a13 
  src/slave/cgroups_isolator.cpp c06baecac5a89886673a36d3dad934e06a577875 
  src/slave/constants.hpp 02c45398cbc2686de22750c38f69761e0fccb24c 
  src/slave/constants.cpp 8ef3642d1624db71f40a07be86373f44afa93f21 
  src/slave/flags.hpp 546edb0c34ca59e2d84c4ba8a35a66d1411422bd 
  src/slave/process_isolator.cpp e719a0711157f37cf87b92127fd4f50287b1cf21 
  src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118 
  src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca 
  src/tests/master_tests.cpp 9d13ebe2f1d3cbc1d39fd8bdd5060a15e2767eb0 
  third_party/libprocess/include/process/delay.hpp cb2fa9ab372e62befec01a95b3ca401567a1a626 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated March 16, 2013, 1:49 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebased off trunk. ready for review!

also s/reason/message/ in cgroups isolator per discussion with benh.


Description (updated)
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor, executor process hung after fork).


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp c1d6f54fb0c93d255f95ee85e1305022db1ce3cc 
  src/master/master.cpp 87bbfac692c3f37f4ef1112b1a44e2afa01296d8 
  src/slave/cgroups_isolator.hpp 049d50e306d936708d2bde72b1f16f8accaf9a13 
  src/slave/cgroups_isolator.cpp c06baecac5a89886673a36d3dad934e06a577875 
  src/slave/constants.hpp 02c45398cbc2686de22750c38f69761e0fccb24c 
  src/slave/constants.cpp 8ef3642d1624db71f40a07be86373f44afa93f21 
  src/slave/process_isolator.cpp e719a0711157f37cf87b92127fd4f50287b1cf21 
  src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118 
  src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca 
  src/tests/master_tests.cpp 9d13ebe2f1d3cbc1d39fd8bdd5060a15e2767eb0 
  third_party/libprocess/include/process/delay.hpp cb2fa9ab372e62befec01a95b3ca401567a1a626 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors.

Posted by Benjamin Mahler <bm...@twitter.com>.
My 'ship it' stands, unless there's anything else you think needs more
reviewing.

On Mon, Mar 4, 2013 at 1:51 PM, Vinod Kone <vi...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Changes
> -------
>
> Rebased off of "Properly cleanup cgroups" https://reviews.apache.org/r/9408/.
>
>
> Summary (updated)
> -----------------
>
> Added registration timeout for executors.
>
>
> Description
> -------
>
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
>
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
>
>
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
>
>
> Diffs (updated)
> -----
>
>   src/master/hierarchical_allocator_process.hpp 33e059c10bb87db88b1fb9a100b7504bc89ac896
>   src/master/master.cpp 814a6e1af2c7caf77452748dfc9e6935d8386d8f
>   src/slave/cgroups_isolation_module.hpp a04fc46b15d2741886f5847cadbdc9bed351c588
>   src/slave/constants.hpp dc5b9877e2608f6806f13b6ef4d133b6fddaece4
>   src/slave/constants.cpp ecb96fd42afdb74aca394411c6ff60276f509cfd
>   src/slave/process_based_isolation_module.hpp 6a4e6aef9ab4b13cce9341f6f35c6b24e6f8fde7
>   src/slave/process_based_isolation_module.cpp ff98d105af675dfc66070feaa43b42c1aa438fd8
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2
>   src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47
>   src/slave/slave.cpp c13d268c5e0e107902f64e30304a18128927a571
>   src/tests/master_tests.cpp 104610cef3fdaaea75271657c42c4fd2b6b61618
>   third_party/libprocess/include/process/delay.hpp cb2fa9ab372e62befec01a95b3ca401567a1a626
>
> Diff: https://reviews.apache.org/r/8077/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>

Re: Review Request: Added registration timeout for executors.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated March 4, 2013, 9:51 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

Rebased off of "Properly cleanup cgroups" https://reviews.apache.org/r/9408/.


Summary (updated)
-----------------

Added registration timeout for executors.


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 33e059c10bb87db88b1fb9a100b7504bc89ac896 
  src/master/master.cpp 814a6e1af2c7caf77452748dfc9e6935d8386d8f 
  src/slave/cgroups_isolation_module.hpp a04fc46b15d2741886f5847cadbdc9bed351c588 
  src/slave/constants.hpp dc5b9877e2608f6806f13b6ef4d133b6fddaece4 
  src/slave/constants.cpp ecb96fd42afdb74aca394411c6ff60276f509cfd 
  src/slave/process_based_isolation_module.hpp 6a4e6aef9ab4b13cce9341f6f35c6b24e6f8fde7 
  src/slave/process_based_isolation_module.cpp ff98d105af675dfc66070feaa43b42c1aa438fd8 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47 
  src/slave/slave.cpp c13d268c5e0e107902f64e30304a18128927a571 
  src/tests/master_tests.cpp 104610cef3fdaaea75271657c42c4fd2b6b61618 
  third_party/libprocess/include/process/delay.hpp cb2fa9ab372e62befec01a95b3ca401567a1a626 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated Jan. 16, 2013, 2:52 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

addressed benh's comment.

also rebased off "creating unique test working directories" patch.


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 33e059c10bb87db88b1fb9a100b7504bc89ac896 
  src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c 
  src/slave/cgroups_isolation_module.hpp 669efa14ba2603764aa68ae19a44e79dbfdec192 
  src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
  src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
  src/slave/process_based_isolation_module.hpp f1817192582e3646f8dcf17934ba7998829e8fd6 
  src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 
  src/slave/slave.cpp 9755b46f97173d6fcc9ab1fd63e0e4814b3bc018 
  src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
  third_party/libprocess/include/process/delay.hpp cb2fa9ab372e62befec01a95b3ca401567a1a626 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13634
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Nov. 20, 2012, 3:37 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 3:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/cgroups_isolation_module.hpp 9f80fc5a969b959b34eaea4cac40700662d7f8b2 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated Nov. 20, 2012, 3:37 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

blah.


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
  src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
  src/slave/cgroups_isolation_module.hpp 9f80fc5a969b959b34eaea4cac40700662d7f8b2 
  src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
  src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
  src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
  src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
  src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated Nov. 19, 2012, 9:23 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

better log messages


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
  src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
  src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
  src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
  src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
  src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
  src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13574
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment29136>

    Any reason not to log the invalid cases?
    
    Framework* framework = getFramework(frameworkId);
    if (framework == NULL) {
      // LOG something?
      return;
    }
    
    Executor* executor = framework->getExecutor(executorId);
    if (executor == NULL) {
      // LOG something?
      return;
    } else if (executor->uuid != uuid) {
      // LOG something?
      return;
    }
    
    if (!executor->pid) {
      // your code
    }


- Ben Mahler


On Nov. 15, 2012, 11:54 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 11:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated Nov. 15, 2012, 11:54 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

BenM's comments


Description
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
  src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
  src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
  src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
  src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
  src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
  src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/
-----------------------------------------------------------

(Updated Nov. 15, 2012, 11:53 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

BenM's comments


Description (updated)
-------

This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).

This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.


This addresses bug MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-310


Diffs
-----

  src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
  src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
  src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
  src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
  src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
  src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
  src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
  src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
  src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 

Diff: https://reviews.apache.org/r/8077/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Added registration timeout for executors

Posted by Vinod Kone <vi...@gmail.com>.

> On Nov. 15, 2012, 11:39 p.m., Ben Mahler wrote:
> > src/slave/constants.cpp, line 25
> > <https://reviews.apache.org/r/8077/diff/1/?file=190364#file190364line25>
> >
> >     s/Seconds(60.0)/Minutes(1.0) ?

done


> On Nov. 15, 2012, 11:39 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 1177
> > <https://reviews.apache.org/r/8077/diff/1/?file=190369#file190369line1177>
> >
> >     so this will indeed unblock the blocked isolation module correct?

correct. updated the description to make it clear.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13499
-----------------------------------------------------------


On Nov. 15, 2012, 11:54 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 11:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request: Added registration timeout for executors

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review13499
-----------------------------------------------------------



src/slave/constants.cpp
<https://reviews.apache.org/r/8077/#comment28962>

    s/Seconds(60.0)/Minutes(1.0) ?



src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment28967>

    so this will indeed unblock the blocked isolation module correct?


- Ben Mahler


On Nov. 15, 2012, 8:46 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 8:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
> 
> This fix is not enough for cgroups isolation module because it currently blocks while launching an executor.
> 
> 
> This addresses bug MESOS-310.
>     https://issues.apache.org/jira/browse/MESOS-310
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c 
>   src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 
>   src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf 
>   src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
> 
> Diff: https://reviews.apache.org/r/8077/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>