You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/09 03:00:37 UTC
Review Request 61517: Refactored OpenSSL library checks in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
Bugs: MESOS-7870
https://issues.apache.org/jira/browse/MESOS-7870
Repository: mesos
Description
-------
Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
matter if the `--enable-ssl` flag is on. This enables us to have a
non-SSL-enabled libprocess build with gRPC support. Also fixed an error
that a bad linker might link a configure test with libssl unnecessarily,
which would cause a runtime failure if libssl is not in the runtime
library search path.
Diffs
-----
3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464
Diff: https://reviews.apache.org/r/61517/diff/1/
Testing
-------
Ran `make check` on the following two configurations:
1. ../configure
2. ../configure --enable-ssl --enable-libevent
Thanks,
Chun-Hung Hsiao
Re: Review Request 61517: Refactored OpenSSL library checks in
libprocess.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/#review182519
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/configure.ac
Lines 1108-1109 (patched)
<https://reviews.apache.org/r/61517/#comment258428>
Let's focus this comment, see https://reviews.apache.org/r/61433/#comment258427.
- Benjamin Bannier
On Aug. 9, 2017, 5 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61517/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2017, 5 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
>
>
> Bugs: MESOS-7870
> https://issues.apache.org/jira/browse/MESOS-7870
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
> matter if the `--enable-ssl` flag is on. This enables us to have a
> non-SSL-enabled libprocess build with gRPC support. Also fixed an error
> that a bad linker might link a configure test with libssl unnecessarily,
> which would cause a runtime failure if libssl is not in the runtime
> library search path.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464
>
>
> Diff: https://reviews.apache.org/r/61517/diff/1/
>
>
> Testing
> -------
>
> Ran `make check` on the following two configurations:
> 1. ../configure
> 2. ../configure --enable-ssl --enable-libevent
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61517: Refactored OpenSSL library checks in
libprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/#review182639
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 9, 2017, 11:48 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61517/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2017, 11:48 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
>
>
> Bugs: MESOS-7870
> https://issues.apache.org/jira/browse/MESOS-7870
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
> matter if the `--enable-ssl` flag is on. This enables us to have a
> non-SSL-enabled libprocess build with gRPC support. Also fixed an error
> that a bad linker might link a configure test with libssl unnecessarily,
> which would cause a runtime failure if libssl is not in the runtime
> library search path.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464
>
>
> Diff: https://reviews.apache.org/r/61517/diff/4/
>
>
> Testing
> -------
>
> Ran `make check` on the following two configurations:
> 1. ../configure
> 2. ../configure --enable-ssl --enable-libevent
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61517: Refactored OpenSSL library checks in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/
-----------------------------------------------------------
(Updated Aug. 9, 2017, 11:48 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
Changes
-------
Addressed @tillt's comments.
Bugs: MESOS-7870
https://issues.apache.org/jira/browse/MESOS-7870
Repository: mesos
Description
-------
Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
matter if the `--enable-ssl` flag is on. This enables us to have a
non-SSL-enabled libprocess build with gRPC support. Also fixed an error
that a bad linker might link a configure test with libssl unnecessarily,
which would cause a runtime failure if libssl is not in the runtime
library search path.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464
Diff: https://reviews.apache.org/r/61517/diff/3/
Changes: https://reviews.apache.org/r/61517/diff/2-3/
Testing
-------
Ran `make check` on the following two configurations:
1. ../configure
2. ../configure --enable-ssl --enable-libevent
Thanks,
Chun-Hung Hsiao
Re: Review Request 61517: Refactored OpenSSL library checks in
libprocess.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/#review182542
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/configure.ac
Lines 957-959 (patched)
<https://reviews.apache.org/r/61517/#comment258444>
See my (non issue) comment in the previous one.
- Till Toenshoff
On Aug. 9, 2017, 10:47 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61517/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
>
>
> Bugs: MESOS-7870
> https://issues.apache.org/jira/browse/MESOS-7870
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
> matter if the `--enable-ssl` flag is on. This enables us to have a
> non-SSL-enabled libprocess build with gRPC support. Also fixed an error
> that a bad linker might link a configure test with libssl unnecessarily,
> which would cause a runtime failure if libssl is not in the runtime
> library search path.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464
>
>
> Diff: https://reviews.apache.org/r/61517/diff/2/
>
>
> Testing
> -------
>
> Ran `make check` on the following two configurations:
> 1. ../configure
> 2. ../configure --enable-ssl --enable-libevent
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61517: Refactored OpenSSL library checks in
libprocess.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/
-----------------------------------------------------------
(Updated Aug. 9, 2017, 10:47 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
Changes
-------
Addressed @bbannier's comments.
Bugs: MESOS-7870
https://issues.apache.org/jira/browse/MESOS-7870
Repository: mesos
Description
-------
Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
matter if the `--enable-ssl` flag is on. This enables us to have a
non-SSL-enabled libprocess build with gRPC support. Also fixed an error
that a bad linker might link a configure test with libssl unnecessarily,
which would cause a runtime failure if libssl is not in the runtime
library search path.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464
Diff: https://reviews.apache.org/r/61517/diff/2/
Changes: https://reviews.apache.org/r/61517/diff/1-2/
Testing
-------
Ran `make check` on the following two configurations:
1. ../configure
2. ../configure --enable-ssl --enable-libevent
Thanks,
Chun-Hung Hsiao