You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org> on 2008/08/07 11:03:44 UTC
[jira] Created: (OFBIZ-1910) Add support of fromDate & thruDate in
CustRequestRole entity
Add support of fromDate & thruDate in CustRequestRole entity
------------------------------------------------------------
Key: OFBIZ-1910
URL: https://issues.apache.org/jira/browse/OFBIZ-1910
Project: OFBiz
Issue Type: Improvement
Components: order
Reporter: Ashish Vijaywargiya
Priority: Trivial
Attachments: Improve_CustRequestRole.patch
Hello,
I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
So it will be easy to keep the old record with the help of fromDate & thruDate.
Please let me know your thoughts on it.
--
Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1910) Add support of fromDate & thruDate in
CustRequestRole entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-1910.
--------------------------------------
Resolution: Fixed
Code checked in into rev # 686731.
Thanks to me in Working on this issue :-).
Special thanks to Jacopo,Ratnesh and Bilgin.
--
Ashish
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Assignee: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch, Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1910) Add support of fromDate & thruDate
in CustRequestRole entity
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620577#action_12620577 ]
Bilgin Ibryam commented on OFBIZ-1910:
--------------------------------------
Hi Ashish,
I also wanted to add from - thru date fields to a few role entities, but the procedure for modifying a primary key field is very time consuming task.
If I got it right from http://docs.ofbiz.org/display/OFBTECH/General+Entity+Overview , you have to create a new table(with the new primary key) and also provide a service to move the data.
+ 1 for having fromDate & thruDate fields in CustRequestRole entity.
I think there are also other entities that need these very important fields: ProductStoreGroupRole, FacilityGroupRole, FacilityRole, AgreementRole, MarketingCampaignRole, SegmentGroupRole.
Regards,
Bilgin Ibryam
PS: here is the discussion: http://www.nabble.com/*Role-entities-question-to18503776.html#a18607087
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Assignee: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1910) Add support of fromDate & thruDate
in CustRequestRole entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620596#action_12620596 ]
Ashish Vijaywargiya commented on OFBIZ-1910:
--------------------------------------------
Bilgin,
Today I just forgot that concept, although at the time when you have created that thread I have gone through the details present in that section.
I agree that adding new field as the primary key is not the problem but it will take a long to create additional service as well.
I will think more about the implementation of that service and will get back to have further discussion on this thread.
Thanks Bilgin for catching that concept.
--
Ashish
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Assignee: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1910) Add support of fromDate & thruDate in
CustRequestRole entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya updated OFBIZ-1910:
---------------------------------------
Attachment: Improve_CustRequestRole.patch
Patch for the same.
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1910) Add support of fromDate & thruDate in
CustRequestRole entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-1910:
------------------------------------------
Assignee: Ashish Vijaywargiya
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Assignee: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1910) Add support of fromDate & thruDate
in CustRequestRole entity
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621787#action_12621787 ]
Bilgin Ibryam commented on OFBIZ-1910:
--------------------------------------
Ashish,
Thanks for your work. The patch looks fine to me.
I'm not sure only about one point: when there is an entity modification proposal in the patch, should we also ask about it in the dev list, or waiting one week after jira issue is created is enough? Any suggestions?
Bilgin
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Assignee: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch, Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1910) Add support of fromDate & thruDate in
CustRequestRole entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya updated OFBIZ-1910:
---------------------------------------
Attachment: Improve_CustRequestRole.patch
Hello Bilgin,
As per as discussion in b/w us I have updated the patch and did extensive testing of this changes.
In this patch I have also created new migration service.
Can you please review the work done for CustRequestRole entity ?
Please let me know your thoughts.
If everything goes well after your review then I would like to commit this patch.
Thanks in advance.
--
Ashish Vijaywargiya
> Add support of fromDate & thruDate in CustRequestRole entity
> ------------------------------------------------------------
>
> Key: OFBIZ-1910
> URL: https://issues.apache.org/jira/browse/OFBIZ-1910
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Ashish Vijaywargiya
> Assignee: Ashish Vijaywargiya
> Priority: Trivial
> Attachments: Improve_CustRequestRole.patch, Improve_CustRequestRole.patch
>
>
> Hello,
> I have added fromDate & thruDate field to maintain the old records from CustRequestRole entity.
> Suppose a request is assigned to a party in the role of "Request Taker" and after few day it can be assigned to another party in the role of "Request Taker".
> So it will be easy to keep the old record with the help of fromDate & thruDate.
> Please let me know your thoughts on it.
> --
> Ashish
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.