[GitHub] [iceberg] kbendick commented on a diff in pull request #5972: [WIP] Snowflake catalog for iceberg

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5972:
URL: https://github.com/apache/iceberg/pull/5972#discussion_r996383639


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -78,7 +78,7 @@ public OutputFile newOutputFile(String path) {
 
   @Override
   public void deleteFile(String path) {
-    Path toDelete = new Path(path);
+    Path toDelete = new Path(path.replaceAll("s3", "s3a"));

Review Comment:
   In some situations, these are considered the same -- specifically in S3FileIO on read.
   
   In other parts of the code, equivalency of schemes is something that can be configured.
   
   Some people might  want more s3 prefixes to be considered, such as `s3n`. So I'm more of a fan of the second approach.
   
   But I've been OOO for a bit, so might not be fully up to date. I would be interested to see what @flyrain thinks about this change to HadoopFileIO, as I believe he introduced the configuration for allowing different prefixes to be considered equivalent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org