You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by liuxunorg <gi...@git.apache.org> on 2018/10/03 01:24:49 UTC
[GitHub] zeppelin pull request #3201: [ZEPPELIN-3805] Don't distribution shade jar to...
GitHub user liuxunorg opened a pull request:
https://github.com/apache/zeppelin/pull/3201
[ZEPPELIN-3805] Don't distribution shade jar to lib/interpreter for zeppelin-interpreter
The zeppelin-interpreter-api module shades the conflicting package, Need to remove the package that issued these shades in zeppelin-distribution.
[Bug Fix]
* [x] Exclude shade JAR packages to lib/interpreter
* [x] Add zeppelin-interpreter-api JAR package to lib/interpreter
* https://issues.apache.org/jira/browse/ZEPPELIN-3805
[CI pass](https://travis-ci.org/liuxunorg/zeppelin/builds/436144528)
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuxunorg/zeppelin ZEPPELIN-3805
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3201
----
commit 5f073baaccacc913c1b925f14d67aa82d2528774
Author: liuxunorg <33...@...>
Date: 2018-10-02T13:35:15Z
[ZEPPELIN-3805] Don't distribution shade jar to lib/interpreter for zeppelin-interpreter
The zeppelin-interpreter-api module shades the conflicting package, Need to remove the package that issued these conflicts in zeppelin-distribution.
[Bug Fix]
* [x] Exclude shade JAR packages
* [x] Add zeppelin-interpreter-api JAR package
* https://issues.apache.org/jira/browse/ZEPPELIN-3805
CI pass
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----
---
[GitHub] zeppelin issue #3201: [ZEPPELIN-3805] Don't distribution shade jar to lib/in...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3201
It is not necessary to publish zeppelin-interpreter-api.jar to lib/interpreter. zeppelin interpreter api jar is already included to all interpreter jars under lib folder.
---
[GitHub] zeppelin pull request #3201: [ZEPPELIN-3805] Don't distribution shade jar to...
Posted by liuxunorg <gi...@git.apache.org>.
Github user liuxunorg closed the pull request at:
https://github.com/apache/zeppelin/pull/3201
---
[GitHub] zeppelin issue #3201: [ZEPPELIN-3805] Don't distribution shade jar to lib/in...
Posted by liuxunorg <gi...@git.apache.org>.
Github user liuxunorg commented on the issue:
https://github.com/apache/zeppelin/pull/3201
Tanks @zjffdu , Indeed zeppelin-interpreter-api.jar is already included in every interpreter JAR package.
---
[GitHub] zeppelin issue #3201: [ZEPPELIN-3805] Don't distribution shade jar to lib/in...
Posted by liuxunorg <gi...@git.apache.org>.
Github user liuxunorg commented on the issue:
https://github.com/apache/zeppelin/pull/3201
@zjffdu , Because the interpreter process requires the zeppelin-interpreter-api.jar file,
So in the `zeppelin-distribution/src/assemble/distribution.xml` only include
```
<fileSet>
<outputDirectory>/lib/interpreter</outputDirectory>
<directory>../zeppelin-interpreter-api/target</directory>
<include>zeppelin-interpreter-api-*.jar</include>
</includes>
</fileSet>
```
include, delete the excludes part.
```
<excludes>
<exclude>asm-5.0.4.jar</exclude>
<exclude>atomix-cluster-3.0.0-rc4.jar</exclude>
......
</excludes>
```
Also delete the `https://github.com/apache/zeppelin/blob/master/bin/interpreter.sh#L88` line, publish `zeppelin-interpreter-api.jar` to the lib/interpreter/ directory, and pass Travis CI .
However, the LIB file directory in zeppelin-xxx.tar.gz released by zeppelin-distribution is `https://issues.apache.org/jira/secure/attachment/12942346/zeppelin-lib-tree.txt`.
Both shaded jars (zeppelin-interpreter-api) also include unshaded jars (zeppelin-interpreter).
Is `zeppelin-interpreter-api.jar` not published to the `lib/interpreter` directory?
---