You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/16 10:41:06 UTC
[GitHub] [flink] link3280 opened a new pull request #14670: [FLINK-20918][FileSystem] Avoid excessive flush of Hadoop output stream
link3280 opened a new pull request #14670:
URL: https://github.com/apache/flink/pull/14670
## What is the purpose of the change
HadoopRecoverableFsDataOutputStream#sync calls both `hflush` and `hsync`, whereas `hsync` is an enhanced version of `hflush`. We should remove the `hflush` call to avoid the excessive flush.
## Brief change log
Remove `hflush` in HadoopRecoverableFsDataOutputStream#sync.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14670: [FLINK-20918][FileSystem] Avoid excessive flush of Hadoop output stream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14670:
URL: https://github.com/apache/flink/pull/14670#issuecomment-761544566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12137",
"triggerID" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d2ecb25c3544e84f89a35498efa1c92186ef6ae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12137)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14670: [FLINK-20918][FileSystem] Avoid excessive flush of Hadoop output stream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14670:
URL: https://github.com/apache/flink/pull/14670#issuecomment-761544566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12137",
"triggerID" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d2ecb25c3544e84f89a35498efa1c92186ef6ae Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12137)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14670: [FLINK-20918][FileSystem] Avoid excessive flush of Hadoop output stream
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14670:
URL: https://github.com/apache/flink/pull/14670#issuecomment-761544566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d2ecb25c3544e84f89a35498efa1c92186ef6ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14670: [FLINK-20918][FileSystem] Avoid excessive flush of Hadoop output stream
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14670:
URL: https://github.com/apache/flink/pull/14670#issuecomment-761542409
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4d2ecb25c3544e84f89a35498efa1c92186ef6ae (Sat Jan 16 10:44:01 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20918).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14670: [FLINK-20918][FileSystem] Avoid excessive flush of Hadoop output stream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14670:
URL: https://github.com/apache/flink/pull/14670#issuecomment-761544566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12137",
"triggerID" : "4d2ecb25c3544e84f89a35498efa1c92186ef6ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d2ecb25c3544e84f89a35498efa1c92186ef6ae Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12137)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org