You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "chatman (via GitHub)" <gi...@apache.org> on 2023/04/30 22:57:52 UTC
[GitHub] [solr] chatman opened a new pull request, #1603: SOLR-16776: Disable remote streaming via system property
chatman opened a new pull request, #1603:
URL: https://github.com/apache/solr/pull/1603
Details in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1603: SOLR-16776: Disable remote streaming via system property
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman commented on PR #1603:
URL: https://github.com/apache/solr/pull/1603#issuecomment-1529164272
I don't have time to pursue this issue any further. Thanks for the feedback, @janhoy .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman closed pull request #1603: SOLR-16776: Disable remote streaming via system property
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman closed pull request #1603: SOLR-16776: Disable remote streaming via system property
URL: https://github.com/apache/solr/pull/1603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1603: SOLR-16776: Disable remote streaming via system property
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1603:
URL: https://github.com/apache/solr/pull/1603#discussion_r1181313208
##########
solr/core/src/test/org/apache/solr/request/TestRemoteStreaming.java:
##########
@@ -48,14 +48,17 @@ public class TestRemoteStreaming extends SolrJettyTestBase {
@BeforeClass
public static void beforeTest() throws Exception {
+ System.setProperty("solr.enableRemoteStreaming", "true");
Review Comment:
Should add a new test case here to verify streaming fails when sysprop is false.
##########
solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java:
##########
@@ -86,7 +86,11 @@ public class SolrRequestParsers {
private final HashMap<String, SolrRequestParser> parsers = new HashMap<>();
private final boolean enableRemoteStreams;
+ public final boolean enableRemoteStreamsAtNodeLevel =
+ Boolean.parseBoolean(System.getProperty("solr.enableRemoteStreaming", "false"));
private final boolean enableStreamBody;
+ public final boolean enableStreamBodyAtNodeLevel =
+ Boolean.parseBoolean(System.getProperty("solr.enableStreamBody", "true"));
Review Comment:
Do we need two different sysprops here? This `solr.enableStreamBody` is not documented in refGuide. Can't the same `solr.enableRemoteStreaming` be used for all remote streaming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1603: SOLR-16776: Disable remote streaming via system property
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1603:
URL: https://github.com/apache/solr/pull/1603#issuecomment-1531083240
Superceded by #1615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org