You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "korlov42 (via GitHub)" <gi...@apache.org> on 2024/11/13 10:50:38 UTC
[PR] IGNITE-23665 Sql. Introduce query execution program [ignite-3]
korlov42 opened a new pull request, #4714:
URL: https://github.com/apache/ignite-3/pull/4714
https://issues.apache.org/jira/browse/IGNITE-23665
----------
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23665 Sql. Introduce query execution program [ignite-3]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on code in PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714#discussion_r1840104134
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/ExecutionPhase.java:
##########
@@ -65,9 +47,4 @@ public enum ExecutionPhase {
Result evaluate(Query query) {
return handler.handle(query);
}
-
- /** Returns {@code true} if transition is allowed from current phase to given one, return {@code false} otherwise. */
- boolean transitionAllowed(ExecutionPhase newPhase) {
Review Comment:
as i understand correct transitions is :
1. from previous to only next phase
2. from any, besides TERMINATED into any previous
3. from any into TERMINATED in case of errors
briefly ordinal of current phase in comparison with next can be incremented only be 1 or TERMINATED or decrement by any. Why do you think that such a check is redundant ? Or i miss smth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23665 Sql. Introduce query execution program [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714#discussion_r1840119802
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/ExecutionPhase.java:
##########
@@ -65,9 +47,4 @@ public enum ExecutionPhase {
Result evaluate(Query query) {
return handler.handle(query);
}
-
- /** Returns {@code true} if transition is allowed from current phase to given one, return {@code false} otherwise. */
- boolean transitionAllowed(ExecutionPhase newPhase) {
Review Comment:
possible transitions now defined by program (which is initialized with collection of `Transition`'s object). The check is moved to Program as well (see `org.apache.ignite.internal.sql.engine.exec.fsm.Program#advanceQuery`). So, it's not up to ExecutionPhase whether transition is allowed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23665 Sql. Introduce query execution program [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714#discussion_r1840119802
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/ExecutionPhase.java:
##########
@@ -65,9 +47,4 @@ public enum ExecutionPhase {
Result evaluate(Query query) {
return handler.handle(query);
}
-
- /** Returns {@code true} if transition is allowed from current phase to given one, return {@code false} otherwise. */
- boolean transitionAllowed(ExecutionPhase newPhase) {
Review Comment:
possible transitions now defined by program (which is initialized with collection of `Transition`'s object). The check is moved to Program as well (see `org.apache.ignite.internal.sql.engine.exec.fsm.Program#advanceQuery`). So, it's not up to ExecutionPhase to decide whether transition is allowed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23665 Sql. Introduce query execution program [ignite-3]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on code in PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714#discussion_r1840116000
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/ExecutionPhase.java:
##########
@@ -65,9 +47,4 @@ public enum ExecutionPhase {
Result evaluate(Query query) {
return handler.handle(query);
}
-
- /** Returns {@code true} if transition is allowed from current phase to given one, return {@code false} otherwise. */
- boolean transitionAllowed(ExecutionPhase newPhase) {
Review Comment:
ok, got it, seems this check is redundant for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23665 Sql. Introduce query execution program [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 merged PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org