[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #989: [KYUUBI #988] Add Kyuubi session event

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #989:
URL: https://github.com/apache/incubator-kyuubi/pull/989#discussion_r697447696



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/events/KyuubiSessionEvent.scala
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.events
+
+import org.apache.kyuubi.Utils
+import org.apache.kyuubi.server.KyuubiServer
+import org.apache.kyuubi.session.KyuubiSessionImpl
+
+/**
+ * @param sessionId server session id
+ * @param sessionName if user not specify it, we use empty string instead
+ * @param user session user
+ * @param clientIp client ip address
+ * @param serverId A unique Kyuubi server id, e.g. kyuubi server ip address and port,
+ *                 it is useful if has multi-instance Kyuubi Server
+ * @param startTime session create time
+ * @param endTime session end time
+ * @param totalOperations how many queries and meta calls
+ */
+case class KyuubiSessionEvent(
+    sessionId: String,
+    sessionName: String,
+    user: String,
+    clientIp: String,
+    serverId: String,

Review comment:
       the name is tricky and ambiguous.
   how about serverIP？ We do not need to hack KyuubiServer then




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org