You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "RocMarshal (via GitHub)" <gi...@apache.org> on 2023/04/01 04:28:35 UTC

[GitHub] [incubator-streampark] RocMarshal opened a new pull request, #2543: [Hotfix] Fix the redundant deleteIngress calling when 'doTriggerSavepoint' for k8s.

RocMarshal opened a new pull request, #2543:
URL: https://github.com/apache/incubator-streampark/pull/2543

   
   
   <!--
   Thank you for contributing to StreamPark! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   ## Contribution Checklist
   
     - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
   
     - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
   
   -->
   
   ## What changes were proposed in this pull request
   
   Fix the redundant deleteIngress calling when 'doTriggerSavepoint' for k8s.
   
   ## Brief change log
   
   Fix the redundant deleteIngress calling when 'doTriggerSavepoint' for k8s.
   
   ## Verifying this change
   
   
   This change added tests and can be verified as follows:
   
   - *Manually verified the change by testing locally.* 
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (yes / **no**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] RocMarshal commented on pull request #2543: [Hotfix] Fix the redundant deleteIngress calling when 'doTriggerSavepoint' for k8s.

Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #2543:
URL: https://github.com/apache/incubator-streampark/pull/2543#issuecomment-1492827571

   Hi, @wolfboys  @MonsterChenzhuo .
   Could you help to review it if you are in free time?
   Thanks a lot~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys merged pull request #2543: [Hotfix] Fix the redundant deleteIngress calling when 'doTriggerSavepoint' for k8s.

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2543:
URL: https://github.com/apache/incubator-streampark/pull/2543


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org