You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tcl.apache.org by mx...@apache.org on 2022/11/06 11:21:52 UTC
[tcl-rivet] 03/03: trailing whitespaces removed thorough C code, new version 3.2.3
This is an automated email from the ASF dual-hosted git repository.
mxmanghi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git
commit ca5b2581b1958b5e7abd92998a6200143cb6c24e
Author: Massimo Manghi <mx...@apache.org>
AuthorDate: Sun Nov 6 12:17:57 2022 +0100
trailing whitespaces removed thorough C code, new version 3.2.3
---
ChangeLog | 4002 +++++++++++++++---------------
VERSION | 2 +-
doc/rivet.xml | 2 +-
src/TclWeb.h | 2 +-
src/librivet/rivetCrypt.c | 2 +-
src/librivet/rivetList.c | 20 +-
src/librivet/rivetPkgInit.c | 18 +-
src/librivet/rivetWWW.c | 2 +-
src/mod_rivet_ng/TclWebapache.c | 64 +-
src/mod_rivet_ng/apache_config.c | 74 +-
src/mod_rivet_ng/mod_rivet.c | 78 +-
src/mod_rivet_ng/mod_rivet.h | 14 +-
src/mod_rivet_ng/mod_rivet_cache.c | 26 +-
src/mod_rivet_ng/mod_rivet_cache.h | 2 +-
src/mod_rivet_ng/mod_rivet_common.c | 118 +-
src/mod_rivet_ng/mod_rivet_common.h | 2 +-
src/mod_rivet_ng/mod_rivet_generator.c | 44 +-
src/mod_rivet_ng/rivetChannel.c | 2 +-
src/mod_rivet_ng/rivetCore.c | 116 +-
src/mod_rivet_ng/rivetInspect.c | 58 +-
src/mod_rivet_ng/rivet_lazy_mpm.c | 102 +-
src/mod_rivet_ng/rivet_prefork_mpm.c | 24 +-
src/mod_rivet_ng/rivet_worker_mpm.c | 124 +-
src/mod_rivet_ng/worker_prefork_common.c | 60 +-
src/mod_rivet_ng/worker_prefork_common.h | 2 +-
src/parser/parserPkgInit.c | 8 +-
src/parser/rivetParser.c | 6 +-
src/parser/rivetParser.h | 2 +-
src/request/apache_multipart_buffer.c | 6 +-
src/request/apache_multipart_buffer.h | 4 +-
src/request/apache_request.c | 16 +-
src/request/apache_request.h | 4 +-
src/rivet.h | 12 +-
33 files changed, 2511 insertions(+), 2507 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index bdf0e10..fce7278 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2022-11-05 Massimo Manghi <mx...@apache.org>
+ * VERSION: new version 3.2.3
+ * src/*.[hc]: Thoroughly removed trailing spaces
+
2022-06-21 Massimo Manghi <mx...@apache.org>
* Changelog: logging release of Rivet 3.2.2.
@@ -72,7 +76,7 @@
2021-10-20 Massimo Manghi <mx...@apache.org>
* src/mod_rivet_ng/Tclwebapache.c: new environment variable handling.
- Command ::rivet::env doesn't necessarily trigger the whole enviroment load
+ Command ::rivet::env doesn't necessarily trigger the whole environment load
into request_rec, it tries to resolve a variable incrementally. Need
to recommend the usage of ::rivet::env instead of ::rivet::load_env
* tests/env.rvt: adding new tests to environment variable resolution
@@ -203,288 +207,288 @@
redundant flags. Changing function names scheme
2019-05-24 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivetCore.c: Add Tcl_DecrRefCnt after
- RivetCache_StoreScript as this function itself calls
- Tcl_IncrRefCnt to preserve the Tcl_Obj with the script code
-
+ * src/mod_rivet_ng/rivetCore.c: Add Tcl_DecrRefCnt after
+ RivetCache_StoreScript as this function itself calls
+ Tcl_IncrRefCnt to preserve the Tcl_Obj with the script code
+
2019-04-13 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: Correct wrong header in ::rivet::http_accept code example
+ * doc/xml/commands.xml: Correct wrong header in ::rivet::http_accept code example
2019-04-12 Massimo Manghi <mx...@apache.org>
- * INSTALL: wrong references corrected
+ * INSTALL: wrong references corrected
2019-02-19 Massimo Manghi <mx...@apache.org>
- * .appveyor.yml: merging from master in order to have new tags generate
- artifacts
+ * .appveyor.yml: merging from master in order to have new tags generate
+ artifacts
2019-02-16 Georgios Petasis <pe...@apache.org>
- * .appveyor.yml: Added support for creating a zip with the installed rivet
- files (both module and library), and create an artifact. If a tag is added
- (in all branches), the zip will be added to the release.
+ * .appveyor.yml: Added support for creating a zip with the installed rivet
+ files (both module and library), and create an artifact. If a tag is added
+ (in all branches), the zip will be added to the release.
2019-01-21 Massimo Manghi <mx...@apache.org>
- * src/rivet.h: Add error message buffer size definition (was still hardcoded
- here and there)
- * src/mod_rivet_ng/rivetCore.c,rivet_worker_mpm.c: hardcoded buffer size
- into their correct macro definitions
+ * src/rivet.h: Add error message buffer size definition (was still hardcoded
+ here and there)
+ * src/mod_rivet_ng/rivetCore.c,rivet_worker_mpm.c: hardcoded buffer size
+ into their correct macro definitions
2019-01-14 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivetCore.c: add experimental ::rivet::thread_id
+ * src/mod_rivet_ng/rivetCore.c: add experimental ::rivet::thread_id
command
2019-01-05 Massimo Manghi <mx...@apache.org>
- * doc/: merging from 3.1 fixes to various broken docbook elements
- and new entities to external resources' URLs
+ * doc/: merging from 3.1 fixes to various broken docbook elements
+ and new entities to external resources' URLs
2018-12-24 Georgios Petasis <pe...@apache.org>
- * README.md: Added badges also for the GitHub fork at:
- https://github.com/petasis/tcl-rivet.
+ * README.md: Added badges also for the GitHub fork at:
+ https://github.com/petasis/tcl-rivet.
- * .appveyor.yml: Enhancements to not rely on hard-coded paths.
+ * .appveyor.yml: Enhancements to not rely on hard-coded paths.
2018-12-23 Massimo Manghi <mx...@apache.org>
- * cmake/CMakeLists.txt: starting with rivet 3 we need Tcl > 8.6.1
+ * cmake/CMakeLists.txt: starting with rivet 3 we need Tcl > 8.6.1
2018-12-20 Georgios Petasis <pe...@apache.org>
- * cmake/CMakeLists.txt: Set policy behaviour of CMP0074, only if policy is
- defined (i.e. cmake version >= 3.12).
+ * cmake/CMakeLists.txt: Set policy behaviour of CMP0074, only if policy is
+ defined (i.e. cmake version >= 3.12).
2018-12-19 Georgios Petasis <pe...@apache.org>
- * cmake/CMakeLists.txt: Added support for regenerating pkgIndex.tcl in the
- installation directory of rivetlib, after files have been installed.
- This executes "tclsh".
+ * cmake/CMakeLists.txt: Added support for regenerating pkgIndex.tcl in the
+ installation directory of rivetlib, after files have been installed.
+ This executes "tclsh".
2018-12-17 Georgios Petasis <pe...@apache.org>
- * Readme.md: Added a separate badge for winbuild branch.
+ * Readme.md: Added a separate badge for winbuild branch.
2018-12-17 Massimo Manghi <mx...@apache.org>
- * src/request/apache_request.c,src/request/apache_multipart_buffer.[c|h]:
- explicit cast to int wherever needed by calls to Tcl_* functions and
- changed int to size_t wherever required
- * src/mod_rivet_ng/rivet_types.h,rivetCore.c: field 'size' in structure
- typed as size_t
- * src/mod_rivet_ng/TclWebapache.c: argument to Tcl_ReadChars explicitly
- cast to int
+ * src/request/apache_request.c,src/request/apache_multipart_buffer.[c|h]:
+ explicit cast to int wherever needed by calls to Tcl_* functions and
+ changed int to size_t wherever required
+ * src/mod_rivet_ng/rivet_types.h,rivetCore.c: field 'size' in structure
+ typed as size_t
+ * src/mod_rivet_ng/TclWebapache.c: argument to Tcl_ReadChars explicitly
+ cast to int
2018-12-16 Georgios Petasis <pe...@apache.org>
- * Readme.md: Added a Markdown README file, which shows the build status
- from Appveyor, for Windows.
+ * Readme.md: Added a Markdown README file, which shows the build status
+ from Appveyor, for Windows.
- * .appveyor.yml: Started a build configuration for Appveyor:
- https://ci.appveyor.com/project/petasis/tcl-rivet
+ * .appveyor.yml: Started a build configuration for Appveyor:
+ https://ci.appveyor.com/project/petasis/tcl-rivet
- * cmake/CMakeLists.txt: Set policy CMP0074 to new behaviour. Rivet version
- is read from file VERSION.
+ * cmake/CMakeLists.txt: Set policy CMP0074 to new behaviour. Rivet version
+ is read from file VERSION.
- * cmake/README.cmake: Some changes in directories used.
+ * cmake/README.cmake: Some changes in directories used.
- * src/mod_rivet_ng/mod_rivet.h: Removed statement "APLOG_USE_MODULE(rivet);"
- from the module header file.
+ * src/mod_rivet_ng/mod_rivet.h: Removed statement "APLOG_USE_MODULE(rivet);"
+ from the module header file.
2018-12-07 Massimo Manghi <mx...@apache.org>
- * rivet/pkgIndex.tcl: completed with actual list of packages
+ * rivet/pkgIndex.tcl: completed with actual list of packages
2018-12-04 Massimo Manghi <mx...@apache.org>
- * configure.ac: now infer the version number from VERSION.
- * doc/rivet.xml,doc/xml/examples.xml: modified example "color table"
+ * configure.ac: now infer the version number from VERSION.
+ * doc/rivet.xml,doc/xml/examples.xml: modified example "color table"
2018-12-03 Massimo Manghi <mx...@apache.org>
- * cmake/CMakeList.c: we infer the version number from the file
- VERSION assumed to reside in the project root directory
- * src/parser/rivetParser.c:
- * src/mod_rivet_ng/mod_rivet_common.c: type cast of pointer
- arithmetics into int
+ * cmake/CMakeList.c: we infer the version number from the file
+ VERSION assumed to reside in the project root directory
+ * src/parser/rivetParser.c:
+ * src/mod_rivet_ng/mod_rivet_common.c: type cast of pointer
+ arithmetics into int
2018-11-23 Massimo Manghi <mx...@apache.org>
- * VERSION,configure,ac: version number bumped to 3.2.0 as we created
- 3.1 out of branch 3.0 in order to highlight possible regressions that
- may surface as a consequence of fixing bug #62926
+ * VERSION,configure,ac: version number bumped to 3.2.0 as we created
+ 3.1 out of branch 3.0 in order to highlight possible regressions that
+ may surface as a consequence of fixing bug #62926
2018-11-20 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivetCore.c: patching from 3.0 to fix bug #62926
- * tests/post.rvt,fqrivet_var.tcl: add tests to prevent post and get
- variables crosstalk (bug #92926)
- * doc/rivet.xml.in: displaying full version associated to the manual
+ * src/mod_rivet_ng/rivetCore.c: patching from 3.0 to fix bug #62926
+ * tests/post.rvt,fqrivet_var.tcl: add tests to prevent post and get
+ variables crosstalk (bug #92926)
+ * doc/rivet.xml.in: displaying full version associated to the manual
2018-11-11 Massimo Manghi <mx...@apache.org>
- * configure.ac: correct macro description
- * src/mod_rivet_ng/rivetChannel.c: new copyright notice
- * doc/xml/commands.xml: correct sentence in ::rivet::exit manual page
+ * configure.ac: correct macro description
+ * src/mod_rivet_ng/rivetChannel.c: new copyright notice
+ * doc/xml/commands.xml: correct sentence in ::rivet::exit manual page
2018-11-02 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/mod_rivet.[c|h]: add macro RIVET_MPM_BRIDGE to
- compose rivet bridge names
+ * src/mod_rivet_ng/mod_rivet.[c|h]: add macro RIVET_MPM_BRIDGE to
+ compose rivet bridge names
2018-10-17 Massimo Manghi <mx...@apache.org>
- * tests/commands.tcl: changing test on self closing element
- * [doc/rivet.xml.in|doc/rivet.xml]: removed delimiters of
- symbols expanded by svn
- * doc/xml/commands.xml: fixed entities in ::rivet::xml manual page
+ * tests/commands.tcl: changing test on self closing element
+ * [doc/rivet.xml.in|doc/rivet.xml]: removed delimiters of
+ symbols expanded by svn
+ * doc/xml/commands.xml: fixed entities in ::rivet::xml manual page
2018-08-16 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/xml.tcl: changing form to support single self
- closing XML elements such as <tag attr1="val1" attr2="val2".... />
- when if the text string is empty
- * tests/commands.tcl: changing ::rivet::xml test accordingly
- * doc/xml/commands.xml: documenting new ::rivet::xml feature
+ * rivet/rivet-tcl/xml.tcl: changing form to support single self
+ closing XML elements such as <tag attr1="val1" attr2="val2".... />
+ when if the text string is empty
+ * tests/commands.tcl: changing ::rivet::xml test accordingly
+ * doc/xml/commands.xml: documenting new ::rivet::xml feature
2018-08-07 Massimo Manghi <mx...@apache.org>
- * VERSION,configure.ac: first commit after svn to git migration.
- The trunk branch is now the master branch of the git repository.
- setting the master branch version as 3.1.0.
- * .gitignore: untracking Makefile.in and putting in .gitignore
- autools generated files
- * doc/rivet.xml.in: removing references to now unsupported
- svn keywords substitutions
+ * VERSION,configure.ac: first commit after svn to git migration.
+ The trunk branch is now the master branch of the git repository.
+ setting the master branch version as 3.1.0.
+ * .gitignore: untracking Makefile.in and putting in .gitignore
+ autools generated files
+ * doc/rivet.xml.in: removing references to now unsupported
+ svn keywords substitutions
2018-06-25 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: the error handler of error scripts requires
- ::Rivet::script to keep the actual 'script' being run
- (reintegrated into trunk from branches/3.0)
+ * rivet/init.tcl.in: the error handler of error scripts requires
+ ::Rivet::script to keep the actual 'script' being run
+ (reintegrated into trunk from branches/3.0)
2018-06-18 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/*.tcl: fully qualifying calls to ::rivet::lempty
+ * rivet/packages/dio/*.tcl: fully qualifying calls to ::rivet::lempty
2018-06-14 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl: fixed bug in error scripts' error handling (the
- case of handling an error that occurs in the default error script may
- need the introduction of a new test
+ * rivet/init.tcl: fixed bug in error scripts' error handling (the
+ case of handling an error that occurs in the default error script may
+ need the introduction of a new test
2018-04-09 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/mod_rivet.h: changing argument list of function
- *mpm_thread_interp in the bridge interface. It must work
- as an accessor to the interpreter database when both getting
- and storing an interpreter pointer
+ * src/mod_rivet_ng/mod_rivet.h: changing argument list of function
+ *mpm_thread_interp in the bridge interface. It must work
+ as an accessor to the interpreter database when both getting
+ and storing an interpreter pointer
2018-02-28 Massimo Manghi <mx...@apache.org>
- * Makefile.am: default_request_handler.tcl and init.tcl can be
- installed without the exec bit set
+ * Makefile.am: default_request_handler.tcl and init.tcl can be
+ installed without the exec bit set
2018-02-17 Massimo Manghi <mx...@apache.org>
- * NOTICE: update copyright statement
- * src/mod_rivet_ng/worker_prefork_common.c: Rivet_CleanupProcessor
- to call RivetCache_Cleanup
- * doc/rivet.xml: new version in docs
+ * NOTICE: update copyright statement
+ * src/mod_rivet_ng/worker_prefork_common.c: Rivet_CleanupProcessor
+ to call RivetCache_Cleanup
+ * doc/rivet.xml: new version in docs
2018-02-08 Massimo Manghi <mx...@apache.org>
- * VERSION,configure.ac: bumping version to 3.0.2
+ * VERSION,configure.ac: bumping version to 3.0.2
2018-02-08 Ronnie Brunner <ro...@apache.org>
- * doc/apachetest.tcl: make independent from TclX adding
- our own 'kill' procedure. Changing signal to stop the
- http webserver as KILL
- * doc/runtests.tcl: removing depend on the prefork module
+ * doc/apachetest.tcl: make independent from TclX adding
+ our own 'kill' procedure. Changing signal to stop the
+ http webserver as KILL
+ * doc/runtests.tcl: removing depend on the prefork module
2018-02-03 Massimo Manghi <mx...@apache.org>
- * src/librivet/rivetPkgInit.c: changing way we determine the
- namespace pointer in order to avoid the necessity of gaining
- access to the module globals and therefore avoid including
- mod_rivet.h. The macro APLOG_USE_MODULE introduced in
- mod_rivet.h makes the library load fail outside
- mod_rivet and Apache
- * rivet/pkgIndex.tcl: recreated from scratch
+ * src/librivet/rivetPkgInit.c: changing way we determine the
+ namespace pointer in order to avoid the necessity of gaining
+ access to the module globals and therefore avoid including
+ mod_rivet.h. The macro APLOG_USE_MODULE introduced in
+ mod_rivet.h makes the library load fail outside
+ mod_rivet and Apache
+ * rivet/pkgIndex.tcl: recreated from scratch
2018-01-23 Massimo Manghi <mx...@apache.org>
- * VERSION,configure.ac: bumping version number to 3.0.1
- * doc/rivet.xml.in,doc/xml/request.xml: wrong links and information
- about MPM support fixed
- * src/mod_rivet_ng/mod_rivet.h: add APLOG_USE_MODULE
- macro
- * src/mod_rivet/ng/rivet_worker_mpm.c: number
- of threads waited on exit by the supervisor was wrong
- and it's now the acutal number of threads available,
- variable uninitalized in loop fixed
+ * VERSION,configure.ac: bumping version number to 3.0.1
+ * doc/rivet.xml.in,doc/xml/request.xml: wrong links and information
+ about MPM support fixed
+ * src/mod_rivet_ng/mod_rivet.h: add APLOG_USE_MODULE
+ macro
+ * src/mod_rivet/ng/rivet_worker_mpm.c: number
+ of threads waited on exit by the supervisor was wrong
+ and it's now the acutal number of threads available,
+ variable uninitalized in loop fixed
2018-01-23 Massimo Manghi <mx...@apache.org>
- * doc/xml/lazybridge.xml: more improvements and
- inclusion of new comments to the code
- * doc/xml/commands.xml: rather cosmetic improvment
- to the page of ::rivet::try
- * src/mod_rivet_ng/rivet_lazy_mpm.c: more comments
+ * doc/xml/lazybridge.xml: more improvements and
+ inclusion of new comments to the code
+ * doc/xml/commands.xml: rather cosmetic improvment
+ to the page of ::rivet::try
+ * src/mod_rivet_ng/rivet_lazy_mpm.c: more comments
2018-01-19 Massimo Manghi <mx...@apache.org>
- * doc/xml/installation.xml: various broken links fixed
- * doc/xml/internals.xml: expanding some explanations and changing
- links to the Apache server from version 2.2 to 2.4
- * doc/xml/lazybridge.xml: expanding code explanations
- * src/mod_rivet_ng/rivet_lazy_mpm.c: commenting code in
- various functions
+ * doc/xml/installation.xml: various broken links fixed
+ * doc/xml/internals.xml: expanding some explanations and changing
+ links to the Apache server from version 2.2 to 2.4
+ * doc/xml/lazybridge.xml: expanding code explanations
+ * src/mod_rivet_ng/rivet_lazy_mpm.c: commenting code in
+ various functions
2018-01-17 Massimo Manghi <mx...@apache.org>
- * : Released as 3.0.0
+ * : Released as 3.0.0
2018-01-09 Massimo Manghi <mx...@apache.org>
- * tests/virtualhost.test,tests/channel.test: changed
- virtual hosts declarations. Now accepting '*' as host
- name prevents test from failing with certain set ups (a
- DNS related problem)
- * doc/xml/intro.xml: add ackowledgements to George
- * win/: old Windows scripts removed
- * src/mod_rivet: old mod_rivet code removed
+ * tests/virtualhost.test,tests/channel.test: changed
+ virtual hosts declarations. Now accepting '*' as host
+ name prevents test from failing with certain set ups (a
+ DNS related problem)
+ * doc/xml/intro.xml: add ackowledgements to George
+ * win/: old Windows scripts removed
+ * src/mod_rivet: old mod_rivet code removed
2018-01-01 Massimo Manghi <mx...@apache.org>
- * doc/xml/: more error checking and several improvements to
- the manual
+ * doc/xml/: more error checking and several improvements to
+ the manual
2017-12-29 Massimo Manghi <mx...@apache.org>
- * doc/rivet.xml.in: more entities to extend documentation
- * doc/xml/intro.xml: introduction revised and extended
- * doc/xml-2: files used to generate the manual removed or
- moved into doc/xml
- * doc/rivet.css: changed color palette
+ * doc/rivet.xml.in: more entities to extend documentation
+ * doc/xml/intro.xml: introduction revised and extended
+ * doc/xml-2: files used to generate the manual removed or
+ moved into doc/xml
+ * doc/rivet.css: changed color palette
2017-12-22 Massimo Manghi <mx...@apache.org>
- * doc/: more changes to manual pages
+ * doc/: more changes to manual pages
2017-11-29 Massimo Manghi <mx...@apache.org>
- * NOTICE, README: expanded and obsolete information amended
+ * NOTICE, README: expanded and obsolete information amended
2017-10-31 Massimo Manghi <mx...@apache.org>
- * merging branch cmake back into trunk
- * tests/broken.test: the error message form has changed with
- the Tcl based new request handling procedure
+ * merging branch cmake back into trunk
+ * tests/broken.test: the error message form has changed with
+ the Tcl based new request handling procedure
2017-10-28 Massimo Manghi <mx...@apache.org>
- * docs/xml/cmake.xml: draft manual page for cmake build system
+ * docs/xml/cmake.xml: draft manual page for cmake build system
2017-10-22 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: Following Jeff Lawson's suggestion we check
- if init.tcl is loaded from within mod_rivet. If we're not running
- from it we don't divert the [exit] command
- * src/librivet/rivetPkgInit.c: removing code kept in the file
- that had been commented because not needed.
+ * rivet/init.tcl.in: Following Jeff Lawson's suggestion we check
+ if init.tcl is loaded from within mod_rivet. If we're not running
+ from it we don't divert the [exit] command
+ * src/librivet/rivetPkgInit.c: removing code kept in the file
+ that had been commented because not needed.
2017-10-18 Massimo Manghi <mx...@apache.org>
- * doc/: add new cmake.xml file, further manual developments
+ * doc/: add new cmake.xml file, further manual developments
2017-10-12 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/mod_rivet.c: add preprocessor test on
- variable declaration for the WIN32 build
- * src/librivet/rivetWWW.c: fixed subtle buffer overflow
- mistakenly assuming snprintf printed a byte less than
- * doc/xml/processing.xml,command.xml: further elaboration of the
- Rivet 3.0 manual. Update ::rivet::redirect manual entry
- * tcl/rivet-tcl/redirect.tcl: now handling generic boolean arguments
- or any integer > 0 (as for the HTTP status codes)
+ * src/mod_rivet_ng/mod_rivet.c: add preprocessor test on
+ variable declaration for the WIN32 build
+ * src/librivet/rivetWWW.c: fixed subtle buffer overflow
+ mistakenly assuming snprintf printed a byte less than
+ * doc/xml/processing.xml,command.xml: further elaboration of the
+ Rivet 3.0 manual. Update ::rivet::redirect manual entry
+ * tcl/rivet-tcl/redirect.tcl: now handling generic boolean arguments
+ or any integer > 0 (as for the HTTP status codes)
2017-09-17 Massimo Manghi <mx...@apache.org>
- * doc/xml/examples.xml: moved into final directory
+ * doc/xml/examples.xml: moved into final directory
2017-09-15 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio.tcl: new version 1.1 of class Database
- new method mkdir for class Result
- * docs/Makefile.am: removed automatic manual creation upon installation
+ * rivet/packages/dio/dio.tcl: new version 1.1 of class Database
+ new method mkdir for class Result
+ * docs/Makefile.am: removed automatic manual creation upon installation
2017-09-03 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Mysql.c: unqualified string command conflicted
- with Database class same method
+ * rivet/packages/dio/dio_Mysql.c: unqualified string command conflicted
+ with Database class same method
2017-08-18 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio.tcl: method build_where_clause treated
- single value key differently, but this failed to remove braces
- for the representation of a single element list containing space
- characters. The method has been changed the have an uniform
- way to handle this
+ * rivet/packages/dio/dio.tcl: method build_where_clause treated
+ single value key differently, but this failed to remove braces
+ for the representation of a single element list containing space
+ characters. The method has been changed the have an uniform
+ way to handle this
2017-08-12 Massimo Manghi <mx...@apache.org>
* src/mod_rivet_ng/mod_rivet.c: moving to
@@ -494,9 +498,9 @@
systems
2017-08-10 Georgios Petasis <pe...@apache.org>
- * cmake/CMakeLists.txt: Modified also variable CMAKE_PREFIX_PATH, as
- TCL_ROOT and TclStub_ROOT are specific to CMake 3.9.0, and will be
- removed. See https://gitlab.kitware.com/cmake/cmake/issues/17158.
+ * cmake/CMakeLists.txt: Modified also variable CMAKE_PREFIX_PATH, as
+ TCL_ROOT and TclStub_ROOT are specific to CMake 3.9.0, and will be
+ removed. See https://gitlab.kitware.com/cmake/cmake/issues/17158.
2017-08-11 Massimo Manghi <mx...@apache.org>
* src/mod_rivet_ng/mod_rivet.c: add check on
@@ -506,28 +510,28 @@
server documentation)
2017-08-10 Georgios Petasis <pe...@apache.org>
- * src\mod_rivet_ng\apache_config.c:
- * src\mod_rivet_ng\mod_rivet.c:
- * src\mod_rivet_ng\mod_rivet_common.c:
- * src\mod_rivet_ng\mod_rivet_generator.c:
- * src\mod_rivet_ng\rivet_lazy_mpm.c:
- * src\mod_rivet_ng\worker_prefork_common.c: Locally declared symbol
- rivet_module as extern (DLLIMPORT).
+ * src\mod_rivet_ng\apache_config.c:
+ * src\mod_rivet_ng\mod_rivet.c:
+ * src\mod_rivet_ng\mod_rivet_common.c:
+ * src\mod_rivet_ng\mod_rivet_generator.c:
+ * src\mod_rivet_ng\rivet_lazy_mpm.c:
+ * src\mod_rivet_ng\worker_prefork_common.c: Locally declared symbol
+ rivet_module as extern (DLLIMPORT).
- * branches\cmake\src\mod_rivet_ng\mod_rivet.h: Symbol rivet_module
- removed from header file.
+ * branches\cmake\src\mod_rivet_ng\mod_rivet.h: Symbol rivet_module
+ removed from header file.
- * branches\cmake\src\mod_rivet_ng\mod_rivet_common.c: Used ckalloc() instead
- of apr_pcalloc() for variable globals, in Rivet_PerInterpInit().
+ * branches\cmake\src\mod_rivet_ng\mod_rivet_common.c: Used ckalloc() instead
+ of apr_pcalloc() for variable globals, in Rivet_PerInterpInit().
- * cmake\README.cmake:
- * cmake\CMakeLists.txt: Added support for picking a Tcl installed at a
- non-standard location. Updated README.cmake with an example. Also disabled
- the switch to export all symbols from mod_rivet.so
- (WINDOWS_EXPORT_ALL_SYMBOLS).
+ * cmake\README.cmake:
+ * cmake\CMakeLists.txt: Added support for picking a Tcl installed at a
+ non-standard location. Updated README.cmake with an example. Also disabled
+ the switch to export all symbols from mod_rivet.so
+ (WINDOWS_EXPORT_ALL_SYMBOLS).
- * src\mod_rivet_ng\mod_rivet_common.c:
- * src\mod_rivet_ng\rivetCore.c: Fixes in DLLEXPORT.
+ * src\mod_rivet_ng\mod_rivet_common.c:
+ * src\mod_rivet_ng\rivetCore.c: Fixes in DLLEXPORT.
2017-08-07 Massimo Manghi <mx...@apache.org>
* src/mod_rivet_ng/mod_rivet.c: Rivet_ServerInit is now implementing
@@ -535,2601 +539,2601 @@
modules
2017-08-05 Georgios Petasis <pe...@apache.org>
- * cmake\CMakeLists.txt: rivetparser/rivetlib shared libraries now have the
- prefix "lib" under all platforms.
-
- * cmake\cmake_extra_modules\rivet_config.h.cmake: RIVET_RIVET_CORE or
- RIVET_CORE? Added also support for RIVET_CORE, but disabled, as it causes
- compilation errors (in C preprosessor, two strings are compared, which is
- not supported).
-
- * rivet\pkgIndex.tcl: Dropped ".so" in favour of "info sharedlibextension".
-
- * src\librivet\rivetCrypt.c:
- * src\librivet\rivetList.c:
- * src\librivet\rivetPkgInit.c:
- * src\librivet\rivetWWW.c: Definition of EXTERN and exported symbols through
- DLLEXPORT.
-
- * src\mod_rivet_ng\mod_rivet.c:
- * src\mod_rivet_ng\mod_rivet_cache.c:
- * src\mod_rivet_ng\mod_rivet_common.c:
- * src\mod_rivet_ng\mod_rivet_generator.c:
- * src\mod_rivet_ng\rivetCore.c:
- * src\mod_rivet_ng\rivetCore.h:
- * src\parser\parserPkgInit.c: Definition of EXTERN and exported symbols
- through DLLEXPORT.
+ * cmake\CMakeLists.txt: rivetparser/rivetlib shared libraries now have the
+ prefix "lib" under all platforms.
+
+ * cmake\cmake_extra_modules\rivet_config.h.cmake: RIVET_RIVET_CORE or
+ RIVET_CORE? Added also support for RIVET_CORE, but disabled, as it causes
+ compilation errors (in C preprosessor, two strings are compared, which is
+ not supported).
+
+ * rivet\pkgIndex.tcl: Dropped ".so" in favour of "info sharedlibextension".
+
+ * src\librivet\rivetCrypt.c:
+ * src\librivet\rivetList.c:
+ * src\librivet\rivetPkgInit.c:
+ * src\librivet\rivetWWW.c: Definition of EXTERN and exported symbols through
+ DLLEXPORT.
+
+ * src\mod_rivet_ng\mod_rivet.c:
+ * src\mod_rivet_ng\mod_rivet_cache.c:
+ * src\mod_rivet_ng\mod_rivet_common.c:
+ * src\mod_rivet_ng\mod_rivet_generator.c:
+ * src\mod_rivet_ng\rivetCore.c:
+ * src\mod_rivet_ng\rivetCore.h:
+ * src\parser\parserPkgInit.c: Definition of EXTERN and exported symbols
+ through DLLEXPORT.
2017-08-05 Georgios Petasis <pe...@apache.org>
- * src\mod_rivet_ng\rivet_lazy_mpm.c:
- * src\mod_rivet_ng\rivet_prefork_mpm.c:
- * src\mod_rivet_ng\rivet_worker_mpm.c: Added DLLEXPORT for the symbol
- defined with RIVET_MPM_BRIDGE macro.
-
- * cmake\CMakeLists.txt: Exported all symbols for mod_rivet.so under Windows,
- to copy the behaviour in UNIX systems (where all symbols are exported from
- shared libraries).
-
- * cmake\cmake_extra_modules\checks.cmake:
- * cmake\cmake_extra_modules\config.h.cmake:
- * cmake\cmake_extra_modules\rivet_config.h.cmake: Under VC11, round()
- has not been implemented. Added checks in CMake build, for detecting
- round()'s absence.
-
- * src\mod_rivet_ng\rivetCore.c:
- * src\mod_rivet_ng\rivet_lazy_mpm.c:
- * src\mod_rivet_ng\rivet_prefork_mpm.c:
- * src\mod_rivet_ng\rivet_worker_mpm.c:
- * src\mod_rivet_ng\worker_prefork_common.c:
- * src\parser\parserPkgInit.c: Changes for avoiding link error under Windows
- (mostly) related to importing exported symbols from mod_rivet.so.
+ * src\mod_rivet_ng\rivet_lazy_mpm.c:
+ * src\mod_rivet_ng\rivet_prefork_mpm.c:
+ * src\mod_rivet_ng\rivet_worker_mpm.c: Added DLLEXPORT for the symbol
+ defined with RIVET_MPM_BRIDGE macro.
+
+ * cmake\CMakeLists.txt: Exported all symbols for mod_rivet.so under Windows,
+ to copy the behaviour in UNIX systems (where all symbols are exported from
+ shared libraries).
+
+ * cmake\cmake_extra_modules\checks.cmake:
+ * cmake\cmake_extra_modules\config.h.cmake:
+ * cmake\cmake_extra_modules\rivet_config.h.cmake: Under VC11, round()
+ has not been implemented. Added checks in CMake build, for detecting
+ round()'s absence.
+
+ * src\mod_rivet_ng\rivetCore.c:
+ * src\mod_rivet_ng\rivet_lazy_mpm.c:
+ * src\mod_rivet_ng\rivet_prefork_mpm.c:
+ * src\mod_rivet_ng\rivet_worker_mpm.c:
+ * src\mod_rivet_ng\worker_prefork_common.c:
+ * src\parser\parserPkgInit.c: Changes for avoiding link error under Windows
+ (mostly) related to importing exported symbols from mod_rivet.so.
2017-08-05 Georgios Petasis <pe...@apache.org>
- * src/mod_rivet_ng/mod_rivet_common.c: Reordered header files, so
- <unistd.h> (and its check) to come after "mod_rivet.h" that includes
- "rivet_config.h".
+ * src/mod_rivet_ng/mod_rivet_common.c: Reordered header files, so
+ <unistd.h> (and its check) to come after "mod_rivet.h" that includes
+ "rivet_config.h".
2017-08-04 Georgios Petasis <pe...@apache.org>
- * cmake\CMakeLists.txt:
- * cmake\cmake_extra_modules\FindAPR.cmake:
- * src\mod_rivet_ng\TclWebapache.c:
- * src\mod_rivet_ng\mod_rivet.c:
- * src\mod_rivet_ng\mod_rivet.h:
- * src\mod_rivet_ng\mod_rivet_cache.c:
- * src\mod_rivet_ng\mod_rivet_common.c:
- * src\mod_rivet_ng\mod_rivet_generator.c:
- * src\mod_rivet_ng\rivetCore.c:
- * src\parser\rivetParser.c: Changes for fixing compilation errors under
- Windows.
+ * cmake\CMakeLists.txt:
+ * cmake\cmake_extra_modules\FindAPR.cmake:
+ * src\mod_rivet_ng\TclWebapache.c:
+ * src\mod_rivet_ng\mod_rivet.c:
+ * src\mod_rivet_ng\mod_rivet.h:
+ * src\mod_rivet_ng\mod_rivet_cache.c:
+ * src\mod_rivet_ng\mod_rivet_common.c:
+ * src\mod_rivet_ng\mod_rivet_generator.c:
+ * src\mod_rivet_ng\rivetCore.c:
+ * src\parser\rivetParser.c: Changes for fixing compilation errors under
+ Windows.
2017-08-04 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivetCore.c: changes demanded by windows compiler
- * rivet/pkgIndex.tcl: recreated with a up to date list of packages
+ * src/mod_rivet_ng/rivetCore.c: changes demanded by windows compiler
+ * rivet/pkgIndex.tcl: recreated with a up to date list of packages
2017-08-04 Georgios Petasis <pe...@apache.org>
- * cmake\CMakeLists.txt: Various changes for better support build under
- Windows.
-
- * cmake\README.cmake: Added a section for building under Windows.
-
- * cmake\cmake_extra_modules\FindAPACHE.cmake: Enhanced customisability.
- The user can guide detection with variables APACHE_INCLUDE_DIR_HINTS,
- APACHE_MODULE_DIR_HINTS, APACHE_LIB_DIR_HINTS, APACHE_ROOT.
-
- * cmake\cmake_extra_modules\FindAPR.cmake: Enhanced customisability.
- The user can guide detection with variables APR_INCLUDE_DIR_HINTS,
- APACHE_INCLUDE_DIR_HINTS, APACHE_ROOT, APR_LIBRARY_HINTS,
- APRUTIL_INCLUDE_DIR_HINTS, APRUTIL_LIBRARY_HINTS.
+ * cmake\CMakeLists.txt: Various changes for better support build under
+ Windows.
+
+ * cmake\README.cmake: Added a section for building under Windows.
+
+ * cmake\cmake_extra_modules\FindAPACHE.cmake: Enhanced customisability.
+ The user can guide detection with variables APACHE_INCLUDE_DIR_HINTS,
+ APACHE_MODULE_DIR_HINTS, APACHE_LIB_DIR_HINTS, APACHE_ROOT.
+
+ * cmake\cmake_extra_modules\FindAPR.cmake: Enhanced customisability.
+ The user can guide detection with variables APR_INCLUDE_DIR_HINTS,
+ APACHE_INCLUDE_DIR_HINTS, APACHE_ROOT, APR_LIBRARY_HINTS,
+ APRUTIL_INCLUDE_DIR_HINTS, APRUTIL_LIBRARY_HINTS.
2017-08-03 Georgios Petasis <pe...@apache.org>
- * CMake build system: Removed "lib" prefix from some libraris.
+ * CMake build system: Removed "lib" prefix from some libraris.
2017-08-03 Georgios Petasis <pe...@apache.org>
- * CMake build system: Added support for installing Rivet. Added more
- checks for various definitions in config.h/rivet_config.h.
+ * CMake build system: Added support for installing Rivet. Added more
+ checks for various definitions in config.h/rivet_config.h.
2017-08-03 Georgios Petasis <pe...@apache.org>
- * CMake build system: Added missing source files, enabled as default
- the build of shared libraries, added needed link libraries. Also
- extended build system for all Rivet libraries (librivetlib.so,
- librivetparser.so, librivet_worker_mpm.so, librivet_prefork_mpm.so,
- librivet_lazy_mpm.so), and checked their linked libraries and missing
- symbols with their versions when build with autoconf.
+ * CMake build system: Added missing source files, enabled as default
+ the build of shared libraries, added needed link libraries. Also
+ extended build system for all Rivet libraries (librivetlib.so,
+ librivetparser.so, librivet_worker_mpm.so, librivet_prefork_mpm.so,
+ librivet_lazy_mpm.so), and checked their linked libraries and missing
+ symbols with their versions when build with autoconf.
2017-08-02 Massimo Manghi <mx...@apache.org>
* Changed references in cmake/CMakeList.txt to build with
code in src/mod_rivet_ng.
2017-08-02 Georgios Petasis <pe...@apache.org>
- * Created a new branch (cmake) for the CMake build system.
+ * Created a new branch (cmake) for the CMake build system.
2017-07-24 Massimo Manghi <mx...@apache.org>
* xml/rivet.xml.in: reflects rivet.xml having been moved to doc/xml
* rivet/default_request_handler.tcl: code of the default
request handler read by mod_rivet
- * Makefile.am: now installing also rivet/default_request_handler.tcl
- * src/mod_rivet_ng/mod_rivet.c: add function for creation of
- the module_globals strucuture. This structure is not assumed anymore
- to be inherited through a fork operation and it's now in case
- re-created at child process initialization
- * src/mod_rivet_ng/rivet_lazy_mpm.c: removing
- reference to unused global variable
- * src/mod_rivet_ng/mod_rivet_common.c: Rivet_RunningScripts
- handling default request procedure specified in the configuration
-
+ * Makefile.am: now installing also rivet/default_request_handler.tcl
+ * src/mod_rivet_ng/mod_rivet.c: add function for creation of
+ the module_globals strucuture. This structure is not assumed anymore
+ to be inherited through a fork operation and it's now in case
+ re-created at child process initialization
+ * src/mod_rivet_ng/rivet_lazy_mpm.c: removing
+ reference to unused global variable
+ * src/mod_rivet_ng/mod_rivet_common.c: Rivet_RunningScripts
+ handling default request procedure specified in the configuration
+
2017-07-20 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: now using Tcl
- [string is boolean ...]
-
+ * rivet/packages/formbroker/formbroker.tcl: now using Tcl
+ [string is boolean ...]
+
2017-07-19 Massimo Manghi <mx...@apache.org>
- * doc/xml/internals.xml: moving the internals chapter
- to its final directory
- * doc/xml/processing.xml: more proof reading corrections
+ * doc/xml/internals.xml: moving the internals chapter
+ to its final directory
+ * doc/xml/processing.xml: more proof reading corrections
2017-07-13 Massimo Manghi <mx...@apache.org>
- * doc/xml/: further developments of the 3.0 manual
- * src/mod_rivet_ng/mod_rivet.c: better coding of
- bridge module search and determination
- * rivet/default_request_handler.tcl: proposed file
- to store the actual request handling code
+ * doc/xml/: further developments of the 3.0 manual
+ * src/mod_rivet_ng/mod_rivet.c: better coding of
+ bridge module search and determination
+ * rivet/default_request_handler.tcl: proposed file
+ to store the actual request handling code
2017-06-22 Massimo Manghi <mx...@apache.org>
- * doc/rivet.xml.in: introducing rivet.xml.in for
- automatic and consistent definition of versioning entities
- * doc/xml/commands.xml: moved into final directory
- * doc/xml/processing.xml: add new file to separate request
- processing from MPM bridge interface documentation
+ * doc/rivet.xml.in: introducing rivet.xml.in for
+ automatic and consistent definition of versioning entities
+ * doc/xml/commands.xml: moved into final directory
+ * doc/xml/processing.xml: add new file to separate request
+ processing from MPM bridge interface documentation
2017-06-19 Massimo Manghi <mx...@apache.org>
- * doc/xml/directives.xml: first rewriting into a new page.
- Still more directives to be documented
- * doc/convert_examples.tcl.in: changed message
- * doc/rivet.css: add directives for styling the
- directives page
+ * doc/xml/directives.xml: first rewriting into a new page.
+ Still more directives to be documented
+ * doc/convert_examples.tcl.in: changed message
+ * doc/rivet.css: add directives for styling the
+ directives page
2017-06-09 Massimo Manghi <mx...@apache.org>
- * doc/xml/: manual rewriting started
+ * doc/xml/: manual rewriting started
2017-06-07 Massimo Manghi <mx...@apache.org>
- * doc/xml-2/: XML manual moved to xml-2 to make
- rewriting easier
+ * doc/xml-2/: XML manual moved to xml-2 to make
+ rewriting easier
2017-05-15 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivet_prefork_mpm.c: server root
- interpreter needs to re-seed the random number generator
+ * src/mod_rivet_ng/rivet_prefork_mpm.c: server root
+ interpreter needs to re-seed the random number generator
2017-05-11 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: apply Damon's patch concerning
- some tests and error handling. Removed call to the
- undocumented procedure ::Rivet::cleanup_request
- * configure.ac: better wording of some configure
- messages
+ * rivet/init.tcl.in: apply Damon's patch concerning
+ some tests and error handling. Removed call to the
+ undocumented procedure ::Rivet::cleanup_request
+ * configure.ac: better wording of some configure
+ messages
2017-04-07 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivetCore.c: Fixed bug
- in argument list passed to RivetCache_MakeKey
+ * src/mod_rivet_ng/rivetCore.c: Fixed bug
+ in argument list passed to RivetCache_MakeKey
2017-04-06 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivet_lazy_mpm.c: server_rec
- argument in error logging changed to global
- root server. Passing the virtual host server rec
- makes the call to ap_log_error quiet and
- if something goes wrong in the thread's Tcl interp
- initialization we don't read anything!
+ * src/mod_rivet_ng/rivet_lazy_mpm.c: server_rec
+ argument in error logging changed to global
+ root server. Passing the virtual host server rec
+ makes the call to ap_log_error quiet and
+ if something goes wrong in the thread's Tcl interp
+ initialization we don't read anything!
2017-04-05 Massimo Manghi <mx...@apache.org>
- * doc/xml/formbroker.xml: better wording of a few
- concepts. Add documentation for the boolean data type
- * doc/xml/internals.xml: fixed incomplete sentence
+ * doc/xml/formbroker.xml: better wording of a few
+ concepts. Add documentation for the boolean data type
+ * doc/xml/internals.xml: fixed incomplete sentence
2017-02-10 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: now
- handling natively also boolean in the form y|n or
- 0|1
+ * rivet/packages/formbroker/formbroker.tcl: now
+ handling natively also boolean in the form y|n or
+ 0|1
2017-02-01 Massimo Manghi <mx...@apache.org>
- * configure.ac: defining and substituting
- RIVETLIB_VERSION
- * rivet/init.tcl.in: the ::rivet namespace is
- created already in src/mod_rivet_ng/mod_rivet_common.c
- Package rivetlib is loaded here now
- * src/mod_rivet_ng/mod_rivet_common.c: in
- function Rivet_PerInterpInit more code is
- devolved to the Tcl initialization
+ * configure.ac: defining and substituting
+ RIVETLIB_VERSION
+ * rivet/init.tcl.in: the ::rivet namespace is
+ created already in src/mod_rivet_ng/mod_rivet_common.c
+ Package rivetlib is loaded here now
+ * src/mod_rivet_ng/mod_rivet_common.c: in
+ function Rivet_PerInterpInit more code is
+ devolved to the Tcl initialization
2017-01-18 Massimo Manghi <mx...@apache.org>
- * doc/Makefile.am: integration of the automake
- infrastructure and rules
- * src/Makefile.am: removed prefixing of
- library names with DESTDIR
+ * doc/Makefile.am: integration of the automake
+ infrastructure and rules
+ * src/Makefile.am: removed prefixing of
+ library names with DESTDIR
2017-01-17 Massimo Manghi <mx...@apache.org>
- * Makefile.am: removing the mpm shared library
- directory only if exists (it's removed by
- the libtool generated rules by the src/Makefile.am)
- * src/Makefile.am: installation directories
- have been prepended by DESTDIR
+ * Makefile.am: removing the mpm shared library
+ directory only if exists (it's removed by
+ the libtool generated rules by the src/Makefile.am)
+ * src/Makefile.am: installation directories
+ have been prepended by DESTDIR
2017-01-16 Massimo Manghi <mx...@apache.org>
- * Makefile.am: removing the _configs.sed file generated
- by configure in distclean target rule fulfills now
- entirely the 'distcheck' target
-
+ * Makefile.am: removing the _configs.sed file generated
+ by configure in distclean target rule fulfills now
+ entirely the 'distcheck' target
+
2017-01-04 Massimo Manghi <mx...@apache.org>
- * Makefile.am,src/Makefile.am: now handling the 'dist'
- and 'distcheck' targets of the automake generated
- Makefile
- * configure.ac: add RIVET_CORE definition
- * src/mod_rivet_ng/rivetCore.c: now calls
- the alternate form of RivetParse
- * src/parser/parserPkgInit.c: altenate form of
- function Rivet_Parser elimianates the need of
- enclosing the code in the namespace ::request
+ * Makefile.am,src/Makefile.am: now handling the 'dist'
+ and 'distcheck' targets of the automake generated
+ Makefile
+ * configure.ac: add RIVET_CORE definition
+ * src/mod_rivet_ng/rivetCore.c: now calls
+ the alternate form of RivetParse
+ * src/parser/parserPkgInit.c: altenate form of
+ function Rivet_Parser elimianates the need of
+ enclosing the code in the namespace ::request
2016-12-19 Massimo Manghi <mx...@apache.org>
- * rivet/mod_rivet_ng/mod_rivet_cache.c: better wording of cache
- functions names.
+ * rivet/mod_rivet_ng/mod_rivet_cache.c: better wording of cache
+ functions names.
2016-12-12 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: [url_script] now evaluated
- explicitly in the ::request name space. We
- don't need the Rivet parser to place a script
- in this namespace
- * rivet/mod_rivet_ng/rivetCore.c: now Rivet_GetRivetFile
- is called with the flag 'toplevel' set to zero. The
- code handling this flag could be removed if we
- abandoned the traditional mod_rivet core
+ * rivet/init.tcl.in: [url_script] now evaluated
+ explicitly in the ::request name space. We
+ don't need the Rivet parser to place a script
+ in this namespace
+ * rivet/mod_rivet_ng/rivetCore.c: now Rivet_GetRivetFile
+ is called with the flag 'toplevel' set to zero. The
+ code handling this flag could be removed if we
+ abandoned the traditional mod_rivet core
2016-12-07 Massimo Manghi <mx...@apache.org>
- * src/librivet/rivetWWW.c: enlarging buffer
- allocated in ::rivet::escape_sgml_chars
- * configure.ac: removed test on the apache
- version (we don't support apache-1 anymore)
-
+ * src/librivet/rivetWWW.c: enlarging buffer
+ allocated in ::rivet::escape_sgml_chars
+ * configure.ac: removed test on the apache
+ version (we don't support apache-1 anymore)
+
2016-12-06 Massimo Manghi <mx...@apache.org>
- * configure.ac: mod_rivet_ng now default for
- builing mod_rivet
- * src/mod_rivet_ng/rivetCore.c: safer condition
- testing should avoid assumptions about how
- the compiler builds pointer comparisons
- * src/mod_rivet_ng/worker_prefork_common.c:
- before running the child init script the
- running configuration pointer is the thread
- private data has to be set
- * tests/broken.test: new error message structure
- * tests/checkfails.tcl, failtest.tcl: changed
- value returned by one of the tests
+ * configure.ac: mod_rivet_ng now default for
+ builing mod_rivet
+ * src/mod_rivet_ng/rivetCore.c: safer condition
+ testing should avoid assumptions about how
+ the compiler builds pointer comparisons
+ * src/mod_rivet_ng/worker_prefork_common.c:
+ before running the child init script the
+ running configuration pointer is the thread
+ private data has to be set
+ * tests/broken.test: new error message structure
+ * tests/checkfails.tcl, failtest.tcl: changed
+ value returned by one of the tests
2016-12-05 Massimo Manghi <mx...@apache.org>
- * rivet/packages/session/session-class.tcl: new
- method synch saves in the session cache data
- coming from form
- * src/mod_rivet_ng/mod_rivet_common.c: more
- careful design assign to a single function
- the task of determining the current configuration
- when an interpreter is initialized
+ * rivet/packages/session/session-class.tcl: new
+ method synch saves in the session cache data
+ coming from form
+ * src/mod_rivet_ng/mod_rivet_common.c: more
+ careful design assign to a single function
+ the task of determining the current configuration
+ when an interpreter is initialized
2016-11-30 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivet_lazy_mpm.c:
- * src/mod_rivet_ng/worker_prefork_mpm.c: setting
- the running_conf pointer in the thread private
- data enables ::rivet::inspect to return
- meaningful data even outside of request processing (in
- the forms that make sense)
- * src/mod_rivet_ng/rivetCore.c: more accurate
- determination of the rivet_server_rec makes
- possible to determine the pointer also
- outside a request processing
+ * src/mod_rivet_ng/rivet_lazy_mpm.c:
+ * src/mod_rivet_ng/worker_prefork_mpm.c: setting
+ the running_conf pointer in the thread private
+ data enables ::rivet::inspect to return
+ meaningful data even outside of request processing (in
+ the forms that make sense)
+ * src/mod_rivet_ng/rivetCore.c: more accurate
+ determination of the rivet_server_rec makes
+ possible to determine the pointer also
+ outside a request processing
2016-11-28 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/: new configuration directives
- RequestHandler (request handling procedure), ImportRivetNS
- and ExportRivetNS (override parameters for
- build options). RequestHandler enables rivet
- to run an application specific request handler.
- * src/mod_rivet_ng/rivetInspect.c: now runs also
- during the server initialization stage. The whole
- rivet core is setup during that phase but only
- a few commands are actually operational (most
- of them make sense only during an HTTP request processing)
+ * src/mod_rivet_ng/: new configuration directives
+ RequestHandler (request handling procedure), ImportRivetNS
+ and ExportRivetNS (override parameters for
+ build options). RequestHandler enables rivet
+ to run an application specific request handler.
+ * src/mod_rivet_ng/rivetInspect.c: now runs also
+ during the server initialization stage. The whole
+ rivet core is setup during that phase but only
+ a few commands are actually operational (most
+ of them make sense only during an HTTP request processing)
2016-11-23 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form.tcl,form2.tcl: fix full
- qualification of the ::rivet::lempty command
- * src/mod_rivet_ng/mod_rivet_common.c: changed or removed
- old comments that don't apply to the current code
- * configure.ac: now quoting strings when passed
- to macro AC_MSG_CHECKING
+ * rivet/packages/form/form.tcl,form2.tcl: fix full
+ qualification of the ::rivet::lempty command
+ * src/mod_rivet_ng/mod_rivet_common.c: changed or removed
+ old comments that don't apply to the current code
+ * configure.ac: now quoting strings when passed
+ to macro AC_MSG_CHECKING
2016-11-22 Damon J. Courtney <da...@gmail.com>
- * rivet/init.tcl.it: Rewrite init.tcl.in from the top down
+ * rivet/init.tcl.it: Rewrite init.tcl.in from the top down
2016-11-22 Massimo Manghi <mx...@apache.org>
- * rivet/packages/session/session-class.tcl:
- * rivet/packages/form/form.tcl,form2.tcl: now
- fully qualifying mod_rivet commands, fixed
- 'file' method that emits an 'email' HTML input element
- * doc/xml/formbroker.xml: correct coding example
+ * rivet/packages/session/session-class.tcl:
+ * rivet/packages/form/form.tcl,form2.tcl: now
+ fully qualifying mod_rivet commands, fixed
+ 'file' method that emits an 'email' HTML input element
+ * doc/xml/formbroker.xml: correct coding example
2016-11-19 Massimo Manghi <mx...@apache.org>
- * src/mod-rivet/rivetInspect.c: now returning
- an empty string if a value is undefined
- * configure.ac: now defaults to non automatic
- import of ::rivet namespace into global namespace
+ * src/mod-rivet/rivetInspect.c: now returning
+ an empty string if a value is undefined
+ * configure.ac: now defaults to non automatic
+ import of ::rivet namespace into global namespace
2016-11-17 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Postgresql.tcl: applied
- consistent single quote character handling by
- calling PgTcl function pg_quote (closes bug #60378)
- * rivet/packages/formbroker/formbroker.tcl: fixed
- bug in method response. Package version number
- bumped up to 1.0
- * doc/xml/formbroker.xml: first draft of the
- manual page of package formbroker with example
- of implementation of a validator
- * doc/xml/commands.xml: fixed type in page
- of ::rivet::xml
+ * rivet/packages/dio/dio_Postgresql.tcl: applied
+ consistent single quote character handling by
+ calling PgTcl function pg_quote (closes bug #60378)
+ * rivet/packages/formbroker/formbroker.tcl: fixed
+ bug in method response. Package version number
+ bumped up to 1.0
+ * doc/xml/formbroker.xml: first draft of the
+ manual page of package formbroker with example
+ of implementation of a validator
+ * doc/xml/commands.xml: fixed type in page
+ of ::rivet::xml
2016-11-15 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: trimming error buffer
- to make test message matching easier
- * rivet/rivet-tcl/catch.tcl|try.tcl: better
- script evaluation is catch/try construct, complete
- error codes in case ::rivet::abort_page is to be
- handled
- * src/mod_rivet_ng/rivetCore.c: direct
- result object handling in [::rivet::inspect script]
- * try.rvt: changed test expression matching
+ * rivet/init.tcl.in: trimming error buffer
+ to make test message matching easier
+ * rivet/rivet-tcl/catch.tcl|try.tcl: better
+ script evaluation is catch/try construct, complete
+ error codes in case ::rivet::abort_page is to be
+ handled
+ * src/mod_rivet_ng/rivetCore.c: direct
+ result object handling in [::rivet::inspect script]
+ * try.rvt: changed test expression matching
2016-11-12 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: removed debugging messages,
- request handling made much simpler after
- ::rivet::inspect changed its behavior when
- a script is undefined
- * src/mod_rivet_ng/rivetInspect.c: changed
- to an empty string the value returned when
- a configuration script is undefined
- * src/mod_rivet_ng/mod_rivet_common.c: we don't
- need to handle at C level the error handler
- and the request cleanup Tcl scritps: they are
- called from Tcl
- * src/mod_rivet_ng/mod_rivet_generator.c: removed
- code unused by this version of the module
+ * rivet/init.tcl.in: removed debugging messages,
+ request handling made much simpler after
+ ::rivet::inspect changed its behavior when
+ a script is undefined
+ * src/mod_rivet_ng/rivetInspect.c: changed
+ to an empty string the value returned when
+ a configuration script is undefined
+ * src/mod_rivet_ng/mod_rivet_common.c: we don't
+ need to handle at C level the error handler
+ and the request cleanup Tcl scritps: they are
+ called from Tcl
+ * src/mod_rivet_ng/mod_rivet_generator.c: removed
+ code unused by this version of the module
2016-11-11 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.it: further development of the
- url processing procedures allows script level
- overriding of both request handling and error handling
- * src/mod_rivet_ng/rivetCore.c: ::rivet::inspect C code
- argument handling improved
+ * rivet/init.tcl.it: further development of the
+ url processing procedures allows script level
+ overriding of both request handling and error handling
+ * src/mod_rivet_ng/rivetCore.c: ::rivet::inspect C code
+ argument handling improved
2016-11-09 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet_common.c: the request_rec
- field to be checked in order to determine whether we
- are serving the request is 'header' non 'content_type'.
- This bug didn't surface because it's set to the same
- string when a request is handed down to the module
- chain, but it's been around ever since.
+ * src/mod_rivet/mod_rivet_common.c: the request_rec
+ field to be checked in order to determine whether we
+ are serving the request is 'header' non 'content_type'.
+ This bug didn't surface because it's set to the same
+ string when a request is handed down to the module
+ chain, but it's been around ever since.
2016-11-08 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/apache_config.c: fixed conf
- merge that didn't assign the correct cache size
- * rivet/init.tcl: fixed exception scripts checks
- * src/mod_rivet_ng/rivetCore.c: command 'parse -string'
- composes the script and calls directly Tcl_EvalObjEx
- * src/mod_rivet/apache_config.c: fixed same bug
- found in Rivet_MergeConf developing mod_rivet_ng
+ * src/mod_rivet_ng/apache_config.c: fixed conf
+ merge that didn't assign the correct cache size
+ * rivet/init.tcl: fixed exception scripts checks
+ * src/mod_rivet_ng/rivetCore.c: command 'parse -string'
+ composes the script and calls directly Tcl_EvalObjEx
+ * src/mod_rivet/apache_config.c: fixed same bug
+ found in Rivet_MergeConf developing mod_rivet_ng
2016-11-07 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet_ng/rivetCore.c: changed also code
- of command ::rivet::parse, now handling the
- cache and calling directly Tcl
- * src/mod_rivet_ng/mod_rivet_generator.c: now
- calling Tcl_EvalObjEx instead of Rivet_ParseExec
- * src/mod_rivet_ng/mod_rivet_common.c: now initializing
- the thread interpreter private cache with
- the new calls to the cache handler
- * rivet/init.tcl.in: tested also call to AbortScript
+ * src/mod_rivet_ng/rivetCore.c: changed also code
+ of command ::rivet::parse, now handling the
+ cache and calling directly Tcl
+ * src/mod_rivet_ng/mod_rivet_generator.c: now
+ calling Tcl_EvalObjEx instead of Rivet_ParseExec
+ * src/mod_rivet_ng/mod_rivet_common.c: now initializing
+ the thread interpreter private cache with
+ the new calls to the cache handler
+ * rivet/init.tcl.in: tested also call to AbortScript
2016-11-03 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet_cache.[c|h]: new file
- for the cache code created to have uniform file structure
- in order to build the module
- * src/mod_rivet_ng/mod_rivet_cache.c: completed code for cache management
- * src/mod_rivet_ng/rivetCore.c: new command ::rivet::url_script
- returns the full URL referenced script to be parsed
- subsequently
- * src/mod_rivet/mod_rivet_generator.c: we are now
- calling the cache routines, but it won't be needed any longer
- as the cache control and interaction are devolved to
- the parse routines
+ * src/mod_rivet/mod_rivet_cache.[c|h]: new file
+ for the cache code created to have uniform file structure
+ in order to build the module
+ * src/mod_rivet_ng/mod_rivet_cache.c: completed code for cache management
+ * src/mod_rivet_ng/rivetCore.c: new command ::rivet::url_script
+ returns the full URL referenced script to be parsed
+ subsequently
+ * src/mod_rivet/mod_rivet_generator.c: we are now
+ calling the cache routines, but it won't be needed any longer
+ as the cache control and interaction are devolved to
+ the parse routines
2016-10-28 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/[lazy|worker|prefork]_mpm_bridge.c: new
- Rivet_ExecutionThreadInit unifies thread initialization
- common to each bridge
- * src/mod_rivet/apache_config.c: the Rivet_MergeConfig
- method did not merge the cache size value
- * src/mod_rivet/mod_rivet_common.c: New function
- Rivet_ExecutionThreadInit
+ * src/mod_rivet/[lazy|worker|prefork]_mpm_bridge.c: new
+ Rivet_ExecutionThreadInit unifies thread initialization
+ common to each bridge
+ * src/mod_rivet/apache_config.c: the Rivet_MergeConfig
+ method did not merge the cache size value
+ * src/mod_rivet/mod_rivet_common.c: New function
+ Rivet_ExecutionThreadInit
2016-10-24 Massimo Manghi <mx...@apache.org>
- * rivet/mod_rivet_ng: new directory to develop new
- module having a Tcl based content generation script
- * rivet/packages/formbroker/formbroker.tcl: new method
- 'reset' restores a form internal status
- * rivet/rivet-tcl/try.tcl: tab expansion to fix
- indentation
- * doc/xml/formbroker.xml: add XML manual page for the
- form broker package
+ * rivet/mod_rivet_ng: new directory to develop new
+ module having a Tcl based content generation script
+ * rivet/packages/formbroker/formbroker.tcl: new method
+ 'reset' restores a form internal status
+ * rivet/rivet-tcl/try.tcl: tab expansion to fix
+ indentation
+ * doc/xml/formbroker.xml: add XML manual page for the
+ form broker package
2016-10-20 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: new method
- 'response' returns an array with the last processed response
- or an array with the defaults value
+ * rivet/packages/formbroker/formbroker.tcl: new method
+ 'response' returns an array with the last processed response
+ or an array with the defaults value
2016-10-18 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: add response copy
- and default value management
-
+ * rivet/packages/formbroker/formbroker.tcl: add response copy
+ and default value management
+
2016-10-17 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: add global
- quoting switch, add method for single form variable method (untested)
+ * rivet/packages/formbroker/formbroker.tcl: add global
+ quoting switch, add method for single form variable method (untested)
2016-10-15 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: add quote
- mechanism
+ * rivet/packages/formbroker/formbroker.tcl: add quote
+ mechanism
2016-10-12 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: removed need
- for a form_name argument. Now forms receive automatic names.
- The list of fields whose validation failed is now
- a flat list of field_name - validation_error pairs suitable
- to be put in dictionary or array
+ * rivet/packages/formbroker/formbroker.tcl: removed need
+ for a form_name argument. Now forms receive automatic names.
+ The list of fields whose validation failed is now
+ a flat list of field_name - validation_error pairs suitable
+ to be put in dictionary or array
2016-10-11 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: first stable
- version of the FormBroker package. The package checks and
- validates form data stored in response array as produced
- by ::rivet::response
- * contrib/validate_mac.tcl: example of validator checking
- and mangling a network mac address. This function is meant
- to work with the FormBroker
+ * rivet/packages/formbroker/formbroker.tcl: first stable
+ version of the FormBroker package. The package checks and
+ validates form data stored in response array as produced
+ by ::rivet::response
+ * contrib/validate_mac.tcl: example of validator checking
+ and mangling a network mac address. This function is meant
+ to work with the FormBroker
2016-10-09 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet_generator.c: improved comments in view of
- branching for new version of content generation script
- * rivet/packages/formbroker/formbroker.tcl: inital reworking for
- a transaction type form broker and validator
+ * src/mod_rivet/mod_rivet_generator.c: improved comments in view of
+ branching for new version of content generation script
+ * rivet/packages/formbroker/formbroker.tcl: inital reworking for
+ a transaction type form broker and validator
2016-09-24 Massimo Manghi <mx...@apache.org>
- * rivet/packages/formbroker/formbroker.tcl: add proposed form broker
- * rivet/packages/dio/dio.tcl: now returning also results in a dictionary
- * rivet/packages/dio/dio_Mysql.tcl: supporting also NULL as keyword for
- NULL values of a column
- * doc/xml/commands.xml: further elaboration of ::rivet::exit command
- by adding alink to MaxRequestsPerChild parameter in Apache docs
+ * rivet/packages/formbroker/formbroker.tcl: add proposed form broker
+ * rivet/packages/dio/dio.tcl: now returning also results in a dictionary
+ * rivet/packages/dio/dio_Mysql.tcl: supporting also NULL as keyword for
+ NULL values of a column
+ * doc/xml/commands.xml: further elaboration of ::rivet::exit command
+ by adding alink to MaxRequestsPerChild parameter in Apache docs
2016-09-19 Massimo Manghi <mx...@apache.org>
- * rivet/rivet.tcl.in,rivet.tcl: fixed errors in comments
+ * rivet/rivet.tcl.in,rivet.tcl: fixed errors in comments
2016-09-08 Massimo Manghi <mx...@apache.org>
- * tests/runtests.tcl: support for Apache 1.3 dropped. Add modules needed by
- Apache 2.4
- * tests/apachetests/apachetests.tcl: Dropped support for Apache 1.3
- * tests/shorthand.test: shorthand notation test versioning added
- * tests/virtualhost.test: removed NameVirtualHost directive no longer supported
- * tests/bailout.test: add tests for ::rivet::catch and ::rivet::try
- * tests/catch.rvt,try.rvt: script testing handling various conditions
- * rivet/rivet-tcl/url_query.tcl: add new command ::rivet::url_query
-
+ * tests/runtests.tcl: support for Apache 1.3 dropped. Add modules needed by
+ Apache 2.4
+ * tests/apachetests/apachetests.tcl: Dropped support for Apache 1.3
+ * tests/shorthand.test: shorthand notation test versioning added
+ * tests/virtualhost.test: removed NameVirtualHost directive no longer supported
+ * tests/bailout.test: add tests for ::rivet::catch and ::rivet::try
+ * tests/catch.rvt,try.rvt: script testing handling various conditions
+ * rivet/rivet-tcl/url_query.tcl: add new command ::rivet::url_query
+
2016-09-07 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/catch.tcl: fixed argument management in ::catch call
+ * rivet/rivet-tcl/catch.tcl: fixed argument management in ::catch call
2016-09-06 Massimo Manghi <mx...@apache.org>
- * doc/xml/lazybridge.xml: further lazybridge documentation
- development
+ * doc/xml/lazybridge.xml: further lazybridge documentation
+ development
2016-07-11 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form2.tcl,rivet/pkgIndex.tcl: bump up package
- form version to 2.1
+ * rivet/packages/form/form2.tcl,rivet/pkgIndex.tcl: bump up package
+ form version to 2.1
2016-07-04 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: ::rivet::catch man page example corrected
- * rivet/packages/form/form2.tcl: fixed output in code for the
- <select>...</select> form element method
- * src/mod_rivet/mod_rivet_generator.c: removed code commented away
- * src/mod_rivet/rivetCore.c: FQ var command name
+ * doc/xml/commands.xml: ::rivet::catch man page example corrected
+ * rivet/packages/form/form2.tcl: fixed output in code for the
+ <select>...</select> form element method
+ * src/mod_rivet/mod_rivet_generator.c: removed code commented away
+ * src/mod_rivet/rivetCore.c: FQ var command name
2016-06-16 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: rephrasing the ::rivet::catch manual page
+ * doc/xml/commands.xml: rephrasing the ::rivet::catch manual page
2016-03-18 Massimo Manghi <mx...@apache.org>
- * tclconfig/: reverting to previous release
+ * tclconfig/: reverting to previous release
2016-03-17 Massimo Manghi <mx...@apache.org>
- * tclconfig/tcl.m4,install-sh,ltmain.sh,libtool.m4: updating autotools
- and libtool macros to the latest versions available
+ * tclconfig/tcl.m4,install-sh,ltmain.sh,libtool.m4: updating autotools
+ and libtool macros to the latest versions available
2016-02-16 Massimo Manghi <mx...@apache.org>
- * src/doc/xml/lazybridge.xml: further elaboration of the lazy bridge
+ * src/doc/xml/lazybridge.xml: further elaboration of the lazy bridge
2016-02-05 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: removed code implmenting the old
- model of inter thread communication. This should fix the problem of
- redundant mutex/cond variable creation/destruction needed by the former
- model to avoid memory leaks
+ * src/mod_rivet/rivet_worker_mpm.c: removed code implmenting the old
+ model of inter thread communication. This should fix the problem of
+ redundant mutex/cond variable creation/destruction needed by the former
+ model to avoid memory leaks
2016-02-01 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: upon process shutdown thread status
- has to be set to 'init' to force thread exit
+ * src/mod_rivet/rivet_worker_mpm.c: upon process shutdown thread status
+ has to be set to 'init' to force thread exit
2016-01-25 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivetInspect.c: adding handling of the MpmBridge directive
- to the ::rivet::inspect command
- * doc/xml/lazybridge.xml: more development to lazy bridge manual page
- * rivet/packages/calendar/: preparing new version of package calendar
+ * src/mod_rivet/rivetInspect.c: adding handling of the MpmBridge directive
+ to the ::rivet::inspect command
+ * doc/xml/lazybridge.xml: more development to lazy bridge manual page
+ * rivet/packages/calendar/: preparing new version of package calendar
2016-01-19 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_lazy_mpm.c: removed unused field structures, boolean
- for process shutdown moved to process wide module status
- * doc/lazybridge.xml: started documentation of the lazy bridge
+ * src/mod_rivet/rivet_lazy_mpm.c: removed unused field structures, boolean
+ for process shutdown moved to process wide module status
+ * doc/lazybridge.xml: started documentation of the lazy bridge
2016-01-17 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: removed variable needed only when built with
- the old thread communication model
+ * src/mod_rivet/rivet_worker_mpm.c: removed variable needed only when built with
+ the old thread communication model
2016-01-14 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: new communication method between bridge
- controlled Tcl threads and handler threads. This method was inspired by
- the experiment done with the lazy bridge and proved to have simpler code
- and avoids the need to rely on the handler thread memory pool that gets
- destroyed too often
- * src/mod_rivet/mod_rivet.h: removed definition specific to the worker bridge
+ * src/mod_rivet/rivet_worker_mpm.c: new communication method between bridge
+ controlled Tcl threads and handler threads. This method was inspired by
+ the experiment done with the lazy bridge and proved to have simpler code
+ and avoids the need to rely on the handler thread memory pool that gets
+ destroyed too often
+ * src/mod_rivet/mod_rivet.h: removed definition specific to the worker bridge
2016-01-07 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/: fixed aimed at consistently determining the virtual host
- associated to a thread
+ * src/mod_rivet/: fixed aimed at consistently determining the virtual host
+ associated to a thread
2016-01-05 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet_generator.[h|c]: files holding the output generation
- procedures on which all the bridges rely (previously stored in mod_rivet.c)
- * src/mod_rivet/rivet_lazy_mpm.c: purged of redundant locking code and unused variables
- * src/mod_rivet/worker_prefork_mpm.c: new file with thread private data extension to
- bridge status
- * doc/xml/internals.xml: update to amend out of date explanations
+ * src/mod_rivet/mod_rivet_generator.[h|c]: files holding the output generation
+ procedures on which all the bridges rely (previously stored in mod_rivet.c)
+ * src/mod_rivet/rivet_lazy_mpm.c: purged of redundant locking code and unused variables
+ * src/mod_rivet/worker_prefork_mpm.c: new file with thread private data extension to
+ bridge status
+ * doc/xml/internals.xml: update to amend out of date explanations
2015-12-28 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_lazy_mpm.c: fixed missing interpreter scripts initialization
- * doc/xml/internals.xml: documenting bridge interpreter accessor function
+ * src/mod_rivet/rivet_lazy_mpm.c: fixed missing interpreter scripts initialization
+ * doc/xml/internals.xml: documenting bridge interpreter accessor function
2015-12-26 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/worker_prefork_common.c: functions common to both the prefork
- and worker bridges, but not general enough bur rather specific to the worker
- model adopted by them
- * src/mod_rivet/rivet_lazy_mpm.c: further development, now capable of serving
- rivet requests, but needs to be completed.
- * src/mod_rivet/mod_rivet_common.c: more stuff moved from mod_rivet to this file
- * src/mod_rivet/mod_rivet.h: new data organization with bridge specific thread
- private data
- * src/mod_rivet/Tclwebapache.c: API changed from Tclwebreq pointers to
- thread private data that is supposed to store most of the thread environment
+ * src/mod_rivet/worker_prefork_common.c: functions common to both the prefork
+ and worker bridges, but not general enough bur rather specific to the worker
+ model adopted by them
+ * src/mod_rivet/rivet_lazy_mpm.c: further development, now capable of serving
+ rivet requests, but needs to be completed.
+ * src/mod_rivet/mod_rivet_common.c: more stuff moved from mod_rivet to this file
+ * src/mod_rivet/mod_rivet.h: new data organization with bridge specific thread
+ private data
+ * src/mod_rivet/Tclwebapache.c: API changed from Tclwebreq pointers to
+ thread private data that is supposed to store most of the thread environment
2015-12-22 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_lazy_mpm.c: taking a snapshot of the current development
- as this code proved to be quite robust when stressed using 'ab'
+ * src/mod_rivet/rivet_lazy_mpm.c: taking a snapshot of the current development
+ as this code proved to be quite robust when stressed using 'ab'
2015-12-20 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_lazy_mpm.c: first prototype of a threaded bridge with
- reduced start up time and thread number optimization
+ * src/mod_rivet/rivet_lazy_mpm.c: first prototype of a threaded bridge with
+ reduced start up time and thread number optimization
2015-12-15 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_lazy_mpm.c: new lazy MPM bridge with a smoother workload
- balancing (should work better for low to middle workloads)
- * src/mod_rivet/rivet_worker_mpm.c: improved code comments
- * src/mod_rivet/mod_rivet.c: handling of mpm_bridge configuration parameter.
- New bridge module search method
- * src/mod_rivet/rivet_config.c: new MpmBridge configuration directive
+ * src/mod_rivet/rivet_lazy_mpm.c: new lazy MPM bridge with a smoother workload
+ balancing (should work better for low to middle workloads)
+ * src/mod_rivet/rivet_worker_mpm.c: improved code comments
+ * src/mod_rivet/mod_rivet.c: handling of mpm_bridge configuration parameter.
+ New bridge module search method
+ * src/mod_rivet/rivet_config.c: new MpmBridge configuration directive
2015-12-13 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: changed in order to have a better handling
- of ::rivet::exit (the call to exit( ) is now carried out from within the
- supervising thread
- * src/mod_rivet/rivet_prefork_mpm.c: Adding exit command handler
- * src/mod_rivet/mod_rivet.c: new central Rivet_Finalize method that calls
- any bridge module finalization. The function deletes the thread key to
- access private data
+ * src/mod_rivet/rivet_worker_mpm.c: changed in order to have a better handling
+ of ::rivet::exit (the call to exit( ) is now carried out from within the
+ supervising thread
+ * src/mod_rivet/rivet_prefork_mpm.c: Adding exit command handler
+ * src/mod_rivet/mod_rivet.c: new central Rivet_Finalize method that calls
+ any bridge module finalization. The function deletes the thread key to
+ access private data
2015-12-08 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml,asciiglyphs.tcl: adding documentation for ::rivet::try
- and AsciiGlyphs
+ * doc/xml/commands.xml,asciiglyphs.tcl: adding documentation for ::rivet::try
+ and AsciiGlyphs
2015-12-06 Massimo Manghi <mx...@apache.org>
- * rivet/packages/asciiglyphs.tcl: Package HexGlyphs renamed as AsciiGlyphs
+ * rivet/packages/asciiglyphs.tcl: Package HexGlyphs renamed as AsciiGlyphs
2015-12-05 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/try.tcl: new command ::rivet::try wraps core
- same command to trap ::rivet::abort_code and ::rivet::exit interruptions
- * src/mod_rivet/rivetCore.c: removed semicolons in macro CHECK_REQUEST_REC
- calls
- * rivet/rivet-tcl/catch.tcl: using [uplevel] to control Tcl core [catch]
- command (as it's been customary with Tcl ever since)
+ * rivet/rivet-tcl/try.tcl: new command ::rivet::try wraps core
+ same command to trap ::rivet::abort_code and ::rivet::exit interruptions
+ * src/mod_rivet/rivetCore.c: removed semicolons in macro CHECK_REQUEST_REC
+ calls
+ * rivet/rivet-tcl/catch.tcl: using [uplevel] to control Tcl core [catch]
+ command (as it's been customary with Tcl ever since)
2015-12-03 Massimo Manghi <mx...@apache.org>
- * doc/xml/internals.xml: explaining the MPM bridge jump table
- * doc/rivet.css: changing colors adopting 2.3 style temporarily
- * doc/images: new images with new colors
- * doc/xml/intro.xml,install.xml: removing reference no longer
- valid for version 3.0
- * packages/hexglyphs/hexglyphs.tcl: new glyphs for more punctuation
- characters
+ * doc/xml/internals.xml: explaining the MPM bridge jump table
+ * doc/rivet.css: changing colors adopting 2.3 style temporarily
+ * doc/images: new images with new colors
+ * doc/xml/intro.xml,install.xml: removing reference no longer
+ valid for version 3.0
+ * packages/hexglyphs/hexglyphs.tcl: new glyphs for more punctuation
+ characters
2015-11-27 Massimo Manghi <mx...@apache.org>
- * VERSION,configure.ac: Major version number increased to 3.0.0
+ * VERSION,configure.ac: Major version number increased to 3.0.0
2015-11-25 Massimo Manghi <mx...@apache.org>
- * src/rivet.h: defined RIVET_CMD_EXPORT as wrapper to Tcl_Export
- * tests/bailout.test: redirect.test renamed as bailout.test. It's meant
- to gather all the tests concerning exceptions like abort_page and ::rivet::exit
- * src/librivet/rivet[Crypt|WWW|List].c: command export mechanism changed
- as we are now explicitly exporting commands
- * rivet/rivet-tcl/catch.tcl: new (non-exported) command ::rivet::catch
- * rivet/init.tcl[.in]: command export mechanics changed
- * src/mod_rivet/rivetCore.c: command export made explicit through RIVET_CMD_EXPORT.
- Abort page command now handling also [::rivet::abort_page -exiting] test
+ * src/rivet.h: defined RIVET_CMD_EXPORT as wrapper to Tcl_Export
+ * tests/bailout.test: redirect.test renamed as bailout.test. It's meant
+ to gather all the tests concerning exceptions like abort_page and ::rivet::exit
+ * src/librivet/rivet[Crypt|WWW|List].c: command export mechanism changed
+ as we are now explicitly exporting commands
+ * rivet/rivet-tcl/catch.tcl: new (non-exported) command ::rivet::catch
+ * rivet/init.tcl[.in]: command export mechanics changed
+ * src/mod_rivet/rivetCore.c: command export made explicit through RIVET_CMD_EXPORT.
+ Abort page command now handling also [::rivet::abort_page -exiting] test
2015-10-27 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl.in: actually was this file that had to be changed
+ * rivet/init.tcl.in: actually was this file that had to be changed
2015-10-22 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl: now renaming the [exit] core command into ::Rivet::tclcore_exit
- and replacing with a Tcl scripts that calls ::rivet::thread_exit
- * rivet/packages/hexglyphs/hexglyphs.tcl: package generating ASCII
- glyphs of hexadecimal characters and punctuation character : and -
+ * rivet/init.tcl: now renaming the [exit] core command into ::Rivet::tclcore_exit
+ and replacing with a Tcl scripts that calls ::rivet::thread_exit
+ * rivet/packages/hexglyphs/hexglyphs.tcl: package generating ASCII
+ glyphs of hexadecimal characters and punctuation character : and -
2015-10-18 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: returning HTTP_INTERNAL_SERVER_ERROR
- to requests coming in during a process shutdown. This is required
- by the exit command handling
- * src/mod_rivet/mod_rivet.c: changed some log message calls
- in order to have ap_log_rerror when an error occurs during
- a request processing
+ * src/mod_rivet/rivet_worker_mpm.c: returning HTTP_INTERNAL_SERVER_ERROR
+ to requests coming in during a process shutdown. This is required
+ by the exit command handling
+ * src/mod_rivet/mod_rivet.c: changed some log message calls
+ in order to have ap_log_rerror when an error occurs during
+ a request processing
2015-10-17 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c,rivet_prefork_mpm.c,mod_rivet.c:
- bridge jump table macro definition
+ * src/mod_rivet/rivet_worker_mpm.c,rivet_prefork_mpm.c,mod_rivet.c:
+ bridge jump table macro definition
2015-10-14 Massimo Manghi <mx...@apache.org>
- * rivet/packages/hexgliphs/hexgliphs.tcl: new package HexGliphs
- to print hexadecimal character gliphs as ascii art
+ * rivet/packages/hexgliphs/hexgliphs.tcl: new package HexGliphs
+ to print hexadecimal character gliphs as ascii art
2015-10-04 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.c: moving Rivet_ProcessorCleanup in
- mod_rivet_common.c
- * src/mod_rivet/mod_rivet.h: add exit status code to
- thread private data
- * src/mod_rivet/mod_rivet_common.c: Rivet_ProcessorCleanup now
- in this file
- * src/mod_rivet/rivet_worker_mpm.c: thread exit handling
- now calling the finalize handling function. Functions naming
- scheme reformed. Since the exit_thread command forces
- the whole child process to exit the check on the thread
- counter in the supervisor thread was changed as the thread
- executing thread_exit brings about can't exit before
- the supervisor itself terminates
- * src/mod_rivet/rivet_prefork_mpm.c: function naming scheme
- changed.
+ * src/mod_rivet/mod_rivet.c: moving Rivet_ProcessorCleanup in
+ mod_rivet_common.c
+ * src/mod_rivet/mod_rivet.h: add exit status code to
+ thread private data
+ * src/mod_rivet/mod_rivet_common.c: Rivet_ProcessorCleanup now
+ in this file
+ * src/mod_rivet/rivet_worker_mpm.c: thread exit handling
+ now calling the finalize handling function. Functions naming
+ scheme reformed. Since the exit_thread command forces
+ the whole child process to exit the check on the thread
+ counter in the supervisor thread was changed as the thread
+ executing thread_exit brings about can't exit before
+ the supervisor itself terminates
+ * src/mod_rivet/rivet_prefork_mpm.c: function naming scheme
+ changed.
2015-09-04 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_prefork_mpm.c: fix message severity
- in finalize method
- * src/mod_rivet/rivet_worker_mpm.c: passing actual error
- code to log message if thread join fails
+ * src/mod_rivet/rivet_prefork_mpm.c: fix message severity
+ in finalize method
+ * src/mod_rivet/rivet_worker_mpm.c: passing actual error
+ code to log message if thread join fails
2015-08-30 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.c: bringing the request type check
- back to Rivet_Handler shook quite a bit the build process as
- it required to create a new file rivet_types.h to store
- various definitions
- * src/mod_rivet/TclWebapache.c: changed definition of
- TclWeb_InitRequest. The thread private data must have
- stored the whole request processing status
- * src/mod_rivet/rivet_prefork_mpm.c: Request type check moved
- to mod_rivet.c (Rivet_Handler)
- * src/mod_rivet/rivet_worker_mpm.c: Request type stored
- now in the request private data
- * src/parser/parsePkgInit.c: was still including config.h
- instead rivet_config.h. Add mandatory Apache standard
- copyright statement
- * src/mod_rivet/mod_rivet_common.c: Rivet_CheckType
- definition changed to return a rivet_req_ctype value
- * src/mod_rivet/rivet_types.h: add new file with
- definition used by various files that don't need mod_rivet.h
- * src/mod_rivet/apache_request.h: removed definition that
- went into rivet_types.h
- * src/Makefile.am: libparser needed to have also LDFLAGS
- to build correctly
- * src/rivet.h: ASF copyright statement, including also
- rivet_types.h
-
+ * src/mod_rivet/mod_rivet.c: bringing the request type check
+ back to Rivet_Handler shook quite a bit the build process as
+ it required to create a new file rivet_types.h to store
+ various definitions
+ * src/mod_rivet/TclWebapache.c: changed definition of
+ TclWeb_InitRequest. The thread private data must have
+ stored the whole request processing status
+ * src/mod_rivet/rivet_prefork_mpm.c: Request type check moved
+ to mod_rivet.c (Rivet_Handler)
+ * src/mod_rivet/rivet_worker_mpm.c: Request type stored
+ now in the request private data
+ * src/parser/parsePkgInit.c: was still including config.h
+ instead rivet_config.h. Add mandatory Apache standard
+ copyright statement
+ * src/mod_rivet/mod_rivet_common.c: Rivet_CheckType
+ definition changed to return a rivet_req_ctype value
+ * src/mod_rivet/rivet_types.h: add new file with
+ definition used by various files that don't need mod_rivet.h
+ * src/mod_rivet/apache_request.h: removed definition that
+ went into rivet_types.h
+ * src/Makefile.am: libparser needed to have also LDFLAGS
+ to build correctly
+ * src/rivet.h: ASF copyright statement, including also
+ rivet_types.h
+
2015-08-18 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.[c|h]: now calling MPM through
- a bridge_jump_table structure with all the functions exported
- by a bridge implementation. Created default exit handler
- so that only if a special exit handler is needed it has
- to be defined
- * src/mod_rivet/rivet_worker_mpm.c: exporting through
- the bridge_jump_table the names of bridge functions
- * src/mod_rivet/rivet_prefork_mpm.c: export of the
- bridge function through the jump table. Removed the
- empty server init function (it's field in the jump
- table set to NULL). Removed exit handler (we rely on
- the default exit handler)
- * src/mod_rivet/rivetCore.c: using the jump table
- to call the exit handler
+ * src/mod_rivet/mod_rivet.[c|h]: now calling MPM through
+ a bridge_jump_table structure with all the functions exported
+ by a bridge implementation. Created default exit handler
+ so that only if a special exit handler is needed it has
+ to be defined
+ * src/mod_rivet/rivet_worker_mpm.c: exporting through
+ the bridge_jump_table the names of bridge functions
+ * src/mod_rivet/rivet_prefork_mpm.c: export of the
+ bridge function through the jump table. Removed the
+ empty server init function (it's field in the jump
+ table set to NULL). Removed exit handler (we rely on
+ the default exit handler)
+ * src/mod_rivet/rivetCore.c: using the jump table
+ to call the exit handler
2015-07-15 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: when thread private data
- are released the correponding pointer is set to NULL in APR
- threadkey database. It turned out a thread pool is very often
- deleted and data allcoated from it invalidated
- * src/mod_rivet/mod_rivet.c: handler private data key is
- now local to rivet_worker_mpm.c
+ * src/mod_rivet/rivet_worker_mpm.c: when thread private data
+ are released the correponding pointer is set to NULL in APR
+ threadkey database. It turned out a thread pool is very often
+ deleted and data allcoated from it invalidated
+ * src/mod_rivet/mod_rivet.c: handler private data key is
+ now local to rivet_worker_mpm.c
2015-07-07 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: hopefully a method to
- determine the thread id portable across Apache versions
+ * src/mod_rivet/rivet_worker_mpm.c: hopefully a method to
+ determine the thread id portable across Apache versions
2015-06-30 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: thread id determination
- method changed to support Apache 2.2
+ * src/mod_rivet/rivet_worker_mpm.c: thread id determination
+ method changed to support Apache 2.2
2015-06-28 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.c: fixed errors in comments
- * src/mod_rivet/rivet_worker_mpm.c: Binding release of mutex and
- condition variable to MPM thread pool cleanup, hopefully fixing
- this potential memory leak
+ * src/mod_rivet/mod_rivet.c: fixed errors in comments
+ * src/mod_rivet/rivet_worker_mpm.c: Binding release of mutex and
+ condition variable to MPM thread pool cleanup, hopefully fixing
+ this potential memory leak
2015-06-21 Massimo Manghi <mx...@apache.org>
- * configure.ac: add creation of config variable RIVET_CONFIGURE_CMD
- * src/mod_rivet/mod_rivet_common.c: add RIVET_CONFIGURE_CMD handling
- in 'server' array
+ * configure.ac: add creation of config variable RIVET_CONFIGURE_CMD
+ * src/mod_rivet/mod_rivet_common.c: add RIVET_CONFIGURE_CMD handling
+ in 'server' array
2015-06-06 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: found a solution for determining
- the current thread pool. Mutex and cond variable are allocated from it
- but never destroyed. Still have to understand if letting the pool go
- is enough for a clean deletion of them
- * src/mod_rivet/rivetInspect.c: a pesky 'static' declaration of
- a local variable was still existing and under intense request firing
- threads stumbled on it.
+ * src/mod_rivet/rivet_worker_mpm.c: found a solution for determining
+ the current thread pool. Mutex and cond variable are allocated from it
+ but never destroyed. Still have to understand if letting the pool go
+ is enough for a clean deletion of them
+ * src/mod_rivet/rivetInspect.c: a pesky 'static' declaration of
+ a local variable was still existing and under intense request firing
+ threads stumbled on it.
2015-06-03 Massimo Manghi <mx...@apache.org>
- * doc/rivet.css: changing selector for namespace table as DocBook
- seems not to honor the id attribute anymore
- * doc/xml/request.css: changing the id "namespaces" as class
+ * doc/rivet.css: changing selector for namespace table as DocBook
+ seems not to honor the id attribute anymore
+ * doc/xml/request.css: changing the id "namespaces" as class
2015-05-25 Massimo Manghi <mx...@apache.org>
- * src/Makefile.am: disabled build of aprthread experimental bridge
- * src/mod_rivet/mod_rivet.h: introduced opaque datatype mpm_bridge_status
- and removed bridge specific variables from mod_rivet_globals.
- * src/mod_rivet/mod_rivet.c: removed handling of bridge specific status
- * src/mod_rivet/rivet_worker_mpm.c: devolving to this file all the handling
- of its internal status
- * src/mod_rivet/rivet_prefork_mpm.c: changes imposed by modification
- of the APIs and also new responsabilities devolved to Rivet_CreatePrivateData.
+ * src/Makefile.am: disabled build of aprthread experimental bridge
+ * src/mod_rivet/mod_rivet.h: introduced opaque datatype mpm_bridge_status
+ and removed bridge specific variables from mod_rivet_globals.
+ * src/mod_rivet/mod_rivet.c: removed handling of bridge specific status
+ * src/mod_rivet/rivet_worker_mpm.c: devolving to this file all the handling
+ of its internal status
+ * src/mod_rivet/rivet_prefork_mpm.c: changes imposed by modification
+ of the APIs and also new responsabilities devolved to Rivet_CreatePrivateData.
2015-05-21 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_prefork_mpm.c: child processes created by fork calls
- inherit an interpreter that needs to import the ::rivet namespace when
- configured that way
+ * src/mod_rivet/rivet_prefork_mpm.c: child processes created by fork calls
+ inherit an interpreter that needs to import the ::rivet namespace when
+ configured that way
2015-05-19 Massimo Manghi <mx...@apache.org>
- * src/rivet.h: macro THREAD_PRIVATE_DATA now simply casts ClientData
- pointer to a rivet_thread_private pointer
- * src/mod_rivet/mod_rivet.h: type vhost_interp renamed as rivet_thread_interp
- * src/mod_rivet/mod_rivet.c: Server root interpreter not initialized
- with mod_rivet core as it's pointless to have the rivet commands
- for a ServerInitScript. Rivet core deferred to child process initialization
- for the same interpreter when the OS supports the fork system call, thus
- to rivet_prefork_mpm.c. Changed argument list of Rivet_PerInterpInit in
- that the function handles a whole rivet_thread_interp object.
- New function Rivet_RunServerInit controls and runs ServerInitScript.
- Thread private key creation devolved to child process initialization
- * src/mod_rivet/rivet_prefork_mpm.c: Rivet_MPM_ServerInit emptied
- Rivet core commands initialized in Rivet_MPM_ChildInit
- * src/mod_rivet/rivetCore.c: removed dependence from rivet_interp_globals,
- status devolved to rivet_thread_private as it's thread specific not
- interpreter specific. Pointer to the rivet_thread_private cast as
- client data when core commands are create calling Tcl_CreateCommand (see
- macros THREAD_PRIVATE_DATA and RIVET_OBJ_COMMAND)
+ * src/rivet.h: macro THREAD_PRIVATE_DATA now simply casts ClientData
+ pointer to a rivet_thread_private pointer
+ * src/mod_rivet/mod_rivet.h: type vhost_interp renamed as rivet_thread_interp
+ * src/mod_rivet/mod_rivet.c: Server root interpreter not initialized
+ with mod_rivet core as it's pointless to have the rivet commands
+ for a ServerInitScript. Rivet core deferred to child process initialization
+ for the same interpreter when the OS supports the fork system call, thus
+ to rivet_prefork_mpm.c. Changed argument list of Rivet_PerInterpInit in
+ that the function handles a whole rivet_thread_interp object.
+ New function Rivet_RunServerInit controls and runs ServerInitScript.
+ Thread private key creation devolved to child process initialization
+ * src/mod_rivet/rivet_prefork_mpm.c: Rivet_MPM_ServerInit emptied
+ Rivet core commands initialized in Rivet_MPM_ChildInit
+ * src/mod_rivet/rivetCore.c: removed dependence from rivet_interp_globals,
+ status devolved to rivet_thread_private as it's thread specific not
+ interpreter specific. Pointer to the rivet_thread_private cast as
+ client data when core commands are create calling Tcl_CreateCommand (see
+ macros THREAD_PRIVATE_DATA and RIVET_OBJ_COMMAND)
2015-05-18 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet_common.c: fixed call to apr_palloc which
- allocated dirty ram, changed as apr_pcalloc
+ * src/mod_rivet/mod_rivet_common.c: fixed call to apr_palloc which
+ allocated dirty ram, changed as apr_pcalloc
2015-05-15 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.h: further reorganization removes duplication
- of status variables between rivet_thread_worker and rivet_interp_globals
- * src/mod_rivet/rivetCore.c: completed transition from interpreter globals
- to thread private data which now stores per request status
- * src/mod_rivet/mod_rivet.c: removed globals variable initialization
- * src/mod_rivet/TclWebapache.c: charset determination stored now done in
- TclWeb_InitRequest
+ * src/mod_rivet/mod_rivet.h: further reorganization removes duplication
+ of status variables between rivet_thread_worker and rivet_interp_globals
+ * src/mod_rivet/rivetCore.c: completed transition from interpreter globals
+ to thread private data which now stores per request status
+ * src/mod_rivet/mod_rivet.c: removed globals variable initialization
+ * src/mod_rivet/TclWebapache.c: charset determination stored now done in
+ TclWeb_InitRequest
2015-05-14 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.h: removing redundant variable from handler_private
- structure
- * src/mod_rivet/rivet_worker_mpm.c: removing unnecessary call to
- TclWeb_InitRequest which is called in Rivet_SendContent.
+ * src/mod_rivet/mod_rivet.h: removing redundant variable from handler_private
+ structure
+ * src/mod_rivet/rivet_worker_mpm.c: removing unnecessary call to
+ TclWeb_InitRequest which is called in Rivet_SendContent.
2015-05-12 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.[c|h]: moving some request processing status
- objects (request_rec, TclWebapache etc) from the interpreter
- globals (mod_rivet_globals) to the thread private data (rivet_thread_private)
- * src/mod_rivet/rivet_[prefork|worker]_mpm.c: Rivet channel creation
- is now removed from Rivet_CreatePrivateData, Private data
- must be allocated indipendtly from the RivetChannel
- * src/mod_rivet/rivetCore.c: setting up status variables storage
- transition from mod_rivet_globals to rivet_thread_private
- * src/rivet.h: Rivet command macro changed to accept a new
- argument to be passed to a command implementation as ClientData.
- Currently the value passed must be the pointer to the thread private
- data
- * src/mod_rivet/mod_rivet_common.c: New function Rivet_ReleaseChannel
- and initialization of status variables moved to thread private data
- * src/mod_rivet/rivetCore.c:
- changes needed after we moved to rivet_thread_private fields
- driven by C code implementing ::rivet::abort_page.
- Adding bridge name to server array variables.
- * src/librivet/rivetCrypt.c:
- * src/librivet/rivetWWW.c:
- * src/librivet/rivetList.c:
- * src/parser/parserPkgInit.c: Changing command creation macro
- to follow new 3 arguments form
+ * src/mod_rivet/mod_rivet.[c|h]: moving some request processing status
+ objects (request_rec, TclWebapache etc) from the interpreter
+ globals (mod_rivet_globals) to the thread private data (rivet_thread_private)
+ * src/mod_rivet/rivet_[prefork|worker]_mpm.c: Rivet channel creation
+ is now removed from Rivet_CreatePrivateData, Private data
+ must be allocated indipendtly from the RivetChannel
+ * src/mod_rivet/rivetCore.c: setting up status variables storage
+ transition from mod_rivet_globals to rivet_thread_private
+ * src/rivet.h: Rivet command macro changed to accept a new
+ argument to be passed to a command implementation as ClientData.
+ Currently the value passed must be the pointer to the thread private
+ data
+ * src/mod_rivet/mod_rivet_common.c: New function Rivet_ReleaseChannel
+ and initialization of status variables moved to thread private data
+ * src/mod_rivet/rivetCore.c:
+ changes needed after we moved to rivet_thread_private fields
+ driven by C code implementing ::rivet::abort_page.
+ Adding bridge name to server array variables.
+ * src/librivet/rivetCrypt.c:
+ * src/librivet/rivetWWW.c:
+ * src/librivet/rivetList.c:
+ * src/parser/parserPkgInit.c: Changing command creation macro
+ to follow new 3 arguments form
2015-05-05 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.c: porting error and
- abort_page handling implemented in branches/2.2 (fixes bug #57501).
- * src/mod_rivet/mod_rivet.h: abort_page related fields
- moved to rivet_thread_private from interpreter globals
-
+ * src/mod_rivet/mod_rivet.c: porting error and
+ abort_page handling implemented in branches/2.2 (fixes bug #57501).
+ * src/mod_rivet/mod_rivet.h: abort_page related fields
+ moved to rivet_thread_private from interpreter globals
+
2015-04-16 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/rivet_worker_mpm.c: now we assume thread private data
- exist already
- * rivet/init.tcl.in,rivet/init.tcl: new method Rivet::exit now
- replaces Tcl ::exit and calls ::rivet::exit_thread which has
- an implementation in the MPM bridges
- * docs/xml/install.xml: removed documentation for obsolete
- configure switch --with-apache-version
+ * src/mod_rivet/rivet_worker_mpm.c: now we assume thread private data
+ exist already
+ * rivet/init.tcl.in,rivet/init.tcl: new method Rivet::exit now
+ replaces Tcl ::exit and calls ::rivet::exit_thread which has
+ an implementation in the MPM bridges
+ * docs/xml/install.xml: removed documentation for obsolete
+ configure switch --with-apache-version
2015-03-28 Massimo Manghi <mx...@apache.org>
- * src/mod_rivet/mod_rivet.[c|h]: moved Tcl panic procedure data from
- mod_rivet_globals to rivet_thread_private
- * src/mod_rivet/mod_rivet_common.[c|h]: new procedure Rivet_SetupTclPanicProc
- and Rivet_PanicProc fixed to handle thread private data to get valid
- and thread safe information about the module status. New procedure
- Rivet_CreatePrivateData should provide a common method for all bridges
- to create thread private data
- * src/mod_rivet/rivet_[prefork|worker]_mpm.c: exploiting
- Rivet_CreatePrivateData and Rivet_SetupTclPanicProc makes code
- more localized, removes redundancy and improves readability
+ * src/mod_rivet/mod_rivet.[c|h]: moved Tcl panic procedure data from
+ mod_rivet_globals to rivet_thread_private
+ * src/mod_rivet/mod_rivet_common.[c|h]: new procedure Rivet_SetupTclPanicProc
+ and Rivet_PanicProc fixed to handle thread private data to get valid
+ and thread safe information about the module status. New procedure
+ Rivet_CreatePrivateData should provide a common method for all bridges
+ to create thread private data
+ * src/mod_rivet/rivet_[prefork|worker]_mpm.c: exploiting
+ Rivet_CreatePrivateData and Rivet_SetupTclPanicProc makes code
+ more localized, removes redundancy and improves readability
2015-03-18 Massimo Manghi <mx...@apache.org>
- * INSTALL: update installation and configuration examples
+ * INSTALL: update installation and configuration examples
2015-03-11 Massimo Manghi <mx...@apache.org>
- * doc/xml/internals.xml: Improved paragraph on how to extend mod_rivet
- * src/apache-2/mod_rivet.c: Improper handling of 'HTTP_NOT_FOUND' and
- HTTP_INTERNAL_SERVER_ERROR caused mod_rivet to access a non existing
- memory location (Bug #57686)
+ * doc/xml/internals.xml: Improved paragraph on how to extend mod_rivet
+ * src/apache-2/mod_rivet.c: Improper handling of 'HTTP_NOT_FOUND' and
+ HTTP_INTERNAL_SERVER_ERROR caused mod_rivet to access a non existing
+ memory location (Bug #57686)
2015-02-20 Massimo Manghi <mx...@apache.org>
- * INSTALL: updating examples and version
- * src/mod_rivet/mod_rivet.c: Restoring usual Rivet/VERSION signature
+ * INSTALL: updating examples and version
+ * src/mod_rivet/mod_rivet.c: Restoring usual Rivet/VERSION signature
2015-02-07 Massimo Manghi <mx...@apache.org>
- * src/apache-2/: removed, now maintained only in branches/2.2
- * src/mod_rivet: new directory with code for MPM aware mod_rivet
- * src/experimental: removed
+ * src/apache-2/: removed, now maintained only in branches/2.2
+ * src/mod_rivet: new directory with code for MPM aware mod_rivet
+ * src/experimental: removed
2015-02-03 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivet_worker_mpm.c: assigning to base server interpreter
- the channel referenced in private->channel (was dangling and caused segfaults)
+ * src/experimental/rivet_worker_mpm.c: assigning to base server interpreter
+ the channel referenced in private->channel (was dangling and caused segfaults)
2015-02-02 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivet_worker_mpm.c: removing commented code and adding
- new function Rivet_MPM_Shutdown aimed at forcing ancillary thread to exit
- * src/experimental/rivetCore.c: in Rivet_Parse returned value of
- Rivet_ParseExecFile is propagated up to the caller. Probably unnecessary
- now, but just in case we want to have special handling of TCL_CONTINUE or
- TCL_BREAK
- * src/experimental/mod_rivet.c: moving call to after_every_script out
- of Rivet_ParseExecFile and into Rivet_SendContent. Any call to
- ::rivet::abort_page is now trapped by abort_script
- * src/experimental/TclWebapache.c: if charset is set in the configuration
- then it's set in the headers just before HTTP headers are sent (moved
- from mod_rivet.c
+ * src/experimental/rivet_worker_mpm.c: removing commented code and adding
+ new function Rivet_MPM_Shutdown aimed at forcing ancillary thread to exit
+ * src/experimental/rivetCore.c: in Rivet_Parse returned value of
+ Rivet_ParseExecFile is propagated up to the caller. Probably unnecessary
+ now, but just in case we want to have special handling of TCL_CONTINUE or
+ TCL_BREAK
+ * src/experimental/mod_rivet.c: moving call to after_every_script out
+ of Rivet_ParseExecFile and into Rivet_SendContent. Any call to
+ ::rivet::abort_page is now trapped by abort_script
+ * src/experimental/TclWebapache.c: if charset is set in the configuration
+ then it's set in the headers just before HTTP headers are sent (moved
+ from mod_rivet.c
2015-01-19 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: Channel ref count fixed
+ * src/experimental/mod_rivet.c: Channel ref count fixed
2015-01-13 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c,mod_rivet_common.c: improved some comments
- * rivet_worker_bridge.c: fixed channel wrong handling
+ * src/experimental/mod_rivet.c,mod_rivet_common.c: improved some comments
+ * rivet_worker_bridge.c: fixed channel wrong handling
2015-01-12 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c,mod_rivet_common.c,rivet_[prefork|worker]_bridge.c: fixed
- various bugs with separate channel handling
- * tests/channel.test,channel.tcl: adding test for SeparateChannels
+ * src/experimental/mod_rivet.c,mod_rivet_common.c,rivet_[prefork|worker]_bridge.c: fixed
+ various bugs with separate channel handling
+ * tests/channel.test,channel.tcl: adding test for SeparateChannels
2015-01-11 Massimo Manghi <mx...@apache.org>
- * tests/redirect.test,redirect.rvt: adding test for command ::rivet::redirect
+ * tests/redirect.test,redirect.rvt: adding test for command ::rivet::redirect
2015-01-08 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivetInspect.c: add SeparateChannels directive introspection
- * doc/xml/command.xml,directives.xml: add explanation of new command
- ::rivet::redirect and new directive SeparateChannel
+ * src/experimental/rivetInspect.c: add SeparateChannels directive introspection
+ * doc/xml/command.xml,directives.xml: add explanation of new command
+ ::rivet::redirect and new directive SeparateChannel
2015-01-06 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: handling separate_channels flag for virtual host
- private Rivet Channels
- * src/experimental/mod_rivet_common.c: new function Rivet_CreateRivetChannel
- * src/experimental/apache_config.c: Conf directive SeparateChannels
- * src/experimental/rivet_worker_mpm.c,rivet_prefork_mpm.c: Channel creation code
- moved to mod_rivet_common.c
- * configure.ac: apache utils configuration split from APR configuration
- * Makefile.am: new symbols APU_INCLUDES and APU_LDFLAGS
+ * src/experimental/mod_rivet.c: handling separate_channels flag for virtual host
+ private Rivet Channels
+ * src/experimental/mod_rivet_common.c: new function Rivet_CreateRivetChannel
+ * src/experimental/apache_config.c: Conf directive SeparateChannels
+ * src/experimental/rivet_worker_mpm.c,rivet_prefork_mpm.c: Channel creation code
+ moved to mod_rivet_common.c
+ * configure.ac: apache utils configuration split from APR configuration
+ * Makefile.am: new symbols APU_INCLUDES and APU_LDFLAGS
2014-12-21 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/redirect.tcl: passing a meaningful dictionary as error descriptor
- * src/experimental/rivetCore.c: supporting also method 'get'
- * src/experimental/Tclwebapache.c: new function TclWeb_OutputHeader[Get|Set] to
- explicitly suggesting they are accessing the output headers
+ * rivet/rivet-tcl/redirect.tcl: passing a meaningful dictionary as error descriptor
+ * src/experimental/rivetCore.c: supporting also method 'get'
+ * src/experimental/Tclwebapache.c: new function TclWeb_OutputHeader[Get|Set] to
+ explicitly suggesting they are accessing the output headers
2014-12-17 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivetCore.c: new 'headers sent' introspection command to
- understand whether headers have been sent already
- * rivet/rivet-tcl/redirect.tcl: command didn't fail with a meaningful message
- if headers had been sent already because of ::rivet::no_body that blocks output
- to the socket. The procedure now returns an error if ::rivet::headers sent
- returns 1
+ * src/experimental/rivetCore.c: new 'headers sent' introspection command to
+ understand whether headers have been sent already
+ * rivet/rivet-tcl/redirect.tcl: command didn't fail with a meaningful message
+ if headers had been sent already because of ::rivet::no_body that blocks output
+ to the socket. The procedure now returns an error if ::rivet::headers sent
+ returns 1
2014-12-16 Massimo Manghi <mx...@apache.org>
- * configure.ac: bumping version number to 2.3.0
- * rivet/init.tcl: recreated by automake
- * rivet/rivet-tcl/redirect.tcl: add new command ::rivet::redirect
- * src/experimental/mod_rivet.c: Tcl_Flush call moved from Rivet_ExecuteAndCheck to
- the very end of Rivet_SendContent, also TclWeb_PrintHeader is now unique just before
- the I/O buffer is flushed
+ * configure.ac: bumping version number to 2.3.0
+ * rivet/init.tcl: recreated by automake
+ * rivet/rivet-tcl/redirect.tcl: add new command ::rivet::redirect
+ * src/experimental/mod_rivet.c: Tcl_Flush call moved from Rivet_ExecuteAndCheck to
+ the very end of Rivet_SendContent, also TclWeb_PrintHeader is now unique just before
+ the I/O buffer is flushed
2014-12-06 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c,src/apache-2/mod_rivet.c: Rivet init package bound to
- be $(RIVET_MAJOR_VERSION).$(RIVET_MINOR_VERSION) and defined in autotool variable
- INIT_VERSION (to be transformed into RIVET_INIT_VERSION for C code includes)
- * rivet/rivet-tcl/read_file.c: argument lists admit a variable number of extra arguments
- to be evaluated as argument of 'fconfigure' call
- * configure.ac: Macro symbol TCL_PACKAGE_VERSION renamed as INIT_VERSION
+ * src/experimental/mod_rivet.c,src/apache-2/mod_rivet.c: Rivet init package bound to
+ be $(RIVET_MAJOR_VERSION).$(RIVET_MINOR_VERSION) and defined in autotool variable
+ INIT_VERSION (to be transformed into RIVET_INIT_VERSION for C code includes)
+ * rivet/rivet-tcl/read_file.c: argument lists admit a variable number of extra arguments
+ to be evaluated as argument of 'fconfigure' call
+ * configure.ac: Macro symbol TCL_PACKAGE_VERSION renamed as INIT_VERSION
2014-11-28 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: Rivet channel is set as stdout and as such is released
- when its refCount drops below 2. Therefore we cannot unregister it for each interpreter
- unless we remove it as stdout when terminating the thread just before unregistering
- the channel and deleting the intepreters
+ * src/experimental/mod_rivet.c: Rivet channel is set as stdout and as such is released
+ when its refCount drops below 2. Therefore we cannot unregister it for each interpreter
+ unless we remove it as stdout when terminating the thread just before unregistering
+ the channel and deleting the intepreters
2014-11-05 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: fixed wrong call to Tcl_GetString passing a void argument
- that actually wasn't a Tcl_Obj pointer
+ * src/experimental/mod_rivet.c: fixed wrong call to Tcl_GetString passing a void argument
+ that actually wasn't a Tcl_Obj pointer
2014-10-28 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form2.tcl: how comes the method 'file' emits the same output of method
- email and nobody noticed it?
+ * rivet/packages/form/form2.tcl: how comes the method 'file' emits the same output of method
+ email and nobody noticed it?
2014-10-06 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: handling exception generated by ::rivet::exit_thread
- * src/experimental/rivetCore.c: adding experimental ::rivet::inspect exit form for
- detection of ::rivet::exit_thread call
+ * src/experimental/mod_rivet.c: handling exception generated by ::rivet::exit_thread
+ * src/experimental/rivetCore.c: adding experimental ::rivet::inspect exit form for
+ detection of ::rivet::exit_thread call
2014-09-29 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: adding mpm_exit_handler function pointer handling. Completed
- draft solution for RivetUserConf directives. Scripts cannot be cached though and the whole
- mechanism has to be redesigned
- * src/experimental/rivetCore.c: Add new command ::rivet::exit_thread
- * src/experimental/rivet_prefork_mpm.c,rivet_worker_mpm.c: add function for mpm_exit_handler
- hook definition
+ * src/experimental/mod_rivet.c: adding mpm_exit_handler function pointer handling. Completed
+ draft solution for RivetUserConf directives. Scripts cannot be cached though and the whole
+ mechanism has to be redesigned
+ * src/experimental/rivetCore.c: Add new command ::rivet::exit_thread
+ * src/experimental/rivet_prefork_mpm.c,rivet_worker_mpm.c: add function for mpm_exit_handler
+ hook definition
2014-09-26 Massimo Manghi <mx...@apache.org>
- * tests/apachetest/apachetest.tcl: phasing out TclX calls as the web server seems not to respond
- to QUIT signals sent by Tclx's kill. Likewise in apachetcl the httpd binary is used to control
- execution
+ * tests/apachetest/apachetest.tcl: phasing out TclX calls as the web server seems not to respond
+ to QUIT signals sent by Tclx's kill. Likewise in apachetcl the httpd binary is used to control
+ execution
2014-09-26 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: Add user scripts handling. Fixed bug in per dir and per user
- scripts when virtual interpreters are off.
- * src/experimental/mod_rivet.h: add macros for user configuration flags handling
- * src/experimental/apache_config.h: add user configuration handling
- * tests/inspect.test: trimming tests in order to make them independent for the final CR.
- Carriage returns should now be appended when needed
- * tests/virtualhost.test: adding returned string space class character trimming
- * tests/rivet.test: changing localhost into 127.0.0.1 as it breaks in certain cases
-
+ * src/experimental/mod_rivet.c: Add user scripts handling. Fixed bug in per dir and per user
+ scripts when virtual interpreters are off.
+ * src/experimental/mod_rivet.h: add macros for user configuration flags handling
+ * src/experimental/apache_config.h: add user configuration handling
+ * tests/inspect.test: trimming tests in order to make them independent for the final CR.
+ Carriage returns should now be appended when needed
+ * tests/virtualhost.test: adding returned string space class character trimming
+ * tests/rivet.test: changing localhost into 127.0.0.1 as it breaks in certain cases
+
2014-09-08 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: handling per dir configurations that have no Rivet directives
- in them, thus leaving the 'path' field NULL.
- * src/experimental/TclWebapache.c: reenabling CACHE_SIZE and CACHE_FREE in the environment
- array
+ * src/experimental/mod_rivet.c: handling per dir configurations that have no Rivet directives
+ in them, thus leaving the 'path' field NULL.
+ * src/experimental/TclWebapache.c: reenabling CACHE_SIZE and CACHE_FREE in the environment
+ array
2014-09-07 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.h: add field path to rivet_server_conf. This field carries
- a copy of the 'path' field in cmd_parms. This field is NULL for global and <VirtualHost>
- sections whereas for <Directory> sections points to the argument (the pattern matching
- a certain directory)
- * src/experimental/mod_rivet.c: handling of rdc->path to store configuration scripts
- * src/experimental/rivet_prefork_mpm.c: defining request_init and request_cleanup in the
- thread private data
- * src/experimental/apache_config.h: handling of the path field in rivet_server_conf
+ * src/experimental/mod_rivet.h: add field path to rivet_server_conf. This field carries
+ a copy of the 'path' field in cmd_parms. This field is NULL for global and <VirtualHost>
+ sections whereas for <Directory> sections points to the argument (the pattern matching
+ a certain directory)
+ * src/experimental/mod_rivet.c: handling of rdc->path to store configuration scripts
+ * src/experimental/rivet_prefork_mpm.c: defining request_init and request_cleanup in the
+ thread private data
+ * src/experimental/apache_config.h: handling of the path field in rivet_server_conf
2014-09-05 Massimo Manghi <mx...@apache.org>
- * src/experimental/apache_config.h: removed handling of lines unneeded by this version of mod_rivet
- * src/experimental/rivet_worker_mpm.c:
- * src/experimental/rivet_aprthread_mpm.c:
- * src/experimental/rivet_prefork_mpm.c: moving reference to configurations
- scripts into their new location on rivet_thread_private
- * src/experimental/mod_rivet.h: running_scripts object defined to store running configurations
- script wrapped in Tcl_Obj instances and allow construction of database of Tcl scripts bound
- to per-directory configuration. Adding variables for storing running configuration in rivet_thread_private.
- Configuration records now store references to pristine char* buffers for scripts
- * src/experimental/mod_rivet.c: changed referenced to configured scripts to their new location,
- removed redundant calls to Rivet_GetConf. Configuration is now built and stored in thread private data
- * src/experimental/rivetInspect.c: code in Rivet_ReadConfParameter adapted to reflect changes
- in configuration record definitions
+ * src/experimental/apache_config.h: removed handling of lines unneeded by this version of mod_rivet
+ * src/experimental/rivet_worker_mpm.c:
+ * src/experimental/rivet_aprthread_mpm.c:
+ * src/experimental/rivet_prefork_mpm.c: moving reference to configurations
+ scripts into their new location on rivet_thread_private
+ * src/experimental/mod_rivet.h: running_scripts object defined to store running configurations
+ script wrapped in Tcl_Obj instances and allow construction of database of Tcl scripts bound
+ to per-directory configuration. Adding variables for storing running configuration in rivet_thread_private.
+ Configuration records now store references to pristine char* buffers for scripts
+ * src/experimental/mod_rivet.c: changed referenced to configured scripts to their new location,
+ removed redundant calls to Rivet_GetConf. Configuration is now built and stored in thread private data
+ * src/experimental/rivetInspect.c: code in Rivet_ReadConfParameter adapted to reflect changes
+ in configuration record definitions
2014-08-31 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivet_prefork_mpm.c: removing commented code
- * src/experimental/mod_rivet.c: removing unnecessary Tcl mutex declaration
- * src/experimental/mod_rivet.h: adding new aggregate structure for conf scripts
+ * src/experimental/rivet_prefork_mpm.c: removing commented code
+ * src/experimental/mod_rivet.c: removing unnecessary Tcl mutex declaration
+ * src/experimental/mod_rivet.h: adding new aggregate structure for conf scripts
2014-08-29 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: added control on Tcl object stored in the variable auto_path and duplicate
- it in case it's shared. Removed callback to Rivet_ProcessorCleanup: this call back is called by APR
- in a thread different from the one that allocated a specific private data record. Thus Tcl thread specific
- data cannot be released consistently when calling Tcl_DeleteInterp.
- * src/experimental/rivet_worker_mpm.c: request_init and request_cleanup made thread private. Supervisor
- wait time definition moved here.
+ * src/experimental/mod_rivet.c: added control on Tcl object stored in the variable auto_path and duplicate
+ it in case it's shared. Removed callback to Rivet_ProcessorCleanup: this call back is called by APR
+ in a thread different from the one that allocated a specific private data record. Thus Tcl thread specific
+ data cannot be released consistently when calling Tcl_DeleteInterp.
+ * src/experimental/rivet_worker_mpm.c: request_init and request_cleanup made thread private. Supervisor
+ wait time definition moved here.
2014-08-27 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.h: request_init and request_cleanup moved from static into rivet_thread_private
- * src/experimental/rivet_aprthread_mpm.c,rivet_worker_mpm.c: request_init and request_cleanup are initialized
- during thread private data set up
+ * src/experimental/mod_rivet.h: request_init and request_cleanup moved from static into rivet_thread_private
+ * src/experimental/rivet_aprthread_mpm.c,rivet_worker_mpm.c: request_init and request_cleanup are initialized
+ during thread private data set up
2014-08-19 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: mutex serializing request processing now controlled by
- RIVET_SERIALIZE_HTTP_REQUEST.
- * src/experimental/mod_rivet.h: mutex req_mutex conditional to definition of RIVET_SERIALIZE_HTTP_REQUESTS.
- Also defined macro HTTP_REQUESTS_PROC macro to protect execution of code by module_globals->req_mutex
- * src/experimental/rivet_aprthread_mpm.c: new simplified bridge rivet_aprthread_mpm.c which creates
- Tcl interpreters within thread private data.
- * configure.ac: introducing HTTP_REQUESTS_MUTEX for handling of request serialization
+ * src/experimental/mod_rivet.c: mutex serializing request processing now controlled by
+ RIVET_SERIALIZE_HTTP_REQUEST.
+ * src/experimental/mod_rivet.h: mutex req_mutex conditional to definition of RIVET_SERIALIZE_HTTP_REQUESTS.
+ Also defined macro HTTP_REQUESTS_PROC macro to protect execution of code by module_globals->req_mutex
+ * src/experimental/rivet_aprthread_mpm.c: new simplified bridge rivet_aprthread_mpm.c which creates
+ Tcl interpreters within thread private data.
+ * configure.ac: introducing HTTP_REQUESTS_MUTEX for handling of request serialization
2014-08-18 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: fixed old symbols now renamed as 'module_globals'
+ * src/apache-2/mod_rivet.c: fixed old symbols now renamed as 'module_globals'
2014-08-16 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: reinstated big mutex aroud Rivet_SendContent (where originally
- Tcl_Mutex lock/unlock were called. The module is usable but way too slow wrt prefork because
- of the locking
- * configure.ac,src/apache-2/Makefile.am: fixed mismatch between symbols
+ * src/experimental/mod_rivet.c: reinstated big mutex aroud Rivet_SendContent (where originally
+ Tcl_Mutex lock/unlock were called. The module is usable but way too slow wrt prefork because
+ of the locking
+ * configure.ac,src/apache-2/Makefile.am: fixed mismatch between symbols
2014-08-15 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: Tcl protecting mutex localized in order to restrict as much as possible
- the protected code and reduce the size of the bottleneck. Still, this is not OK and the current implementation
- is going to be kept to provide functionality of mod_rivet with the worker MPM. We have to explore
- the possibility of calling directly Tcl threading functions.
+ * src/experimental/mod_rivet.c: Tcl protecting mutex localized in order to restrict as much as possible
+ the protected code and reduce the size of the bottleneck. Still, this is not OK and the current implementation
+ is going to be kept to provide functionality of mod_rivet with the worker MPM. We have to explore
+ the possibility of calling directly Tcl threading functions.
2014-08-14 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: implemented automatic bridge load mechanism.
- * src/experimental/rivet_worker_mpm.c: starting maximal number of threads (as per mpm_worker configuration)
- * configure.ac: automated parameters when build experimental module.
+ * src/experimental/mod_rivet.c: implemented automatic bridge load mechanism.
+ * src/experimental/rivet_worker_mpm.c: starting maximal number of threads (as per mpm_worker configuration)
+ * configure.ac: automated parameters when build experimental module.
2014-08-12 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivet_[prefork|worker]_mpm.c: bridges integrated. Removed substantial code
- from rivet_prefork_mpm.c and merged with the current approach handling hosts interpreters using
- vhost_interp objects and storing everything in a child process/thread private data
- * src/experimental/apache_config.[c|h]: eventually these files had to be copied here from common
- and modified to reflect the new model for handling server records
- * src/experimental/mod_rivet_common.c: same for this file
- * src/experimental/mod_rivet.c: further generalization of the code to provide consistent
- support for the bridges. Adding a new hook for mpm_master_interp, a function implemented by
- a bridge responsible for returning the child process/thread master interpreter.
+ * src/experimental/rivet_[prefork|worker]_mpm.c: bridges integrated. Removed substantial code
+ from rivet_prefork_mpm.c and merged with the current approach handling hosts interpreters using
+ vhost_interp objects and storing everything in a child process/thread private data
+ * src/experimental/apache_config.[c|h]: eventually these files had to be copied here from common
+ and modified to reflect the new model for handling server records
+ * src/experimental/mod_rivet_common.c: same for this file
+ * src/experimental/mod_rivet.c: further generalization of the code to provide consistent
+ support for the bridges. Adding a new hook for mpm_master_interp, a function implemented by
+ a bridge responsible for returning the child process/thread master interpreter.
2014-08-11 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivet_worker_mpm.c: redesigning virtual hosts resource management for threads
- * src/experimental/mod_rivet[c|h]: implementing thread private interpreters management
- * src/experimental/rivetCore.c,rivetInspect.c: I had to move here these files as some API has changed
- and perhaps it's better if we stick into the interp globals a reference to the thread private data
+ * src/experimental/rivet_worker_mpm.c: redesigning virtual hosts resource management for threads
+ * src/experimental/mod_rivet[c|h]: implementing thread private interpreters management
+ * src/experimental/rivetCore.c,rivetInspect.c: I had to move here these files as some API has changed
+ and perhaps it's better if we stick into the interp globals a reference to the thread private data
2014-08-10 Massimo Manghi <mx...@apache.org>
- * src/experimental/rivet_prefork_mpm.c: handling also server initialization
- * src/experimental/rivet_worker_mpm.c: doing server initialization from the threaded MPM perspective
- * src/experimental/mod_rivet.c: server initialization loads symbols from the bridge module and
- then defers the initialization task to the specific bridge.
+ * src/experimental/rivet_prefork_mpm.c: handling also server initialization
+ * src/experimental/rivet_worker_mpm.c: doing server initialization from the threaded MPM perspective
+ * src/experimental/mod_rivet.c: server initialization loads symbols from the bridge module and
+ then defers the initialization task to the specific bridge.
2014-08-09 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: Various functions moved to src/common/mod_rivet_common.c
- * configure.ac: --with-rivet-core switch simplified
- * Makefile.am: preparing for installation of MPM bridges which have not to be scanned for Tcl packages
- * NOTICE: now Apache policy compliant
- * src/apache-2/Makefile.am: reenabled and reworked to make paths relative
- * src/apache-2/mod_rivet.h: reworked to reflect the new code organization. Also some definitions
- moved here from mod_rivet.c
- * src/common/mod_rivet_common.c: this is now the place where mod_rivet implementation independent
- function must go
- * src/experimental/Makefile.am: adding build for rivet_prefork_mpm.so
- * src/experimental/mod_rivet.[c|h]: placing here only the hopefully necessary code. The module
- resolves the bridge module symbols and actually calls those function to initialize, respond to
- requests and exit child processes
- * src/experimental/rivet_prefork_mpm.c: first sccessful implementation of the prefork bridge
- * src/experimental/rivet_worker_mpm.c: stuffing code into this module. It doesn't build now
- * src/common/mod_rivet_common.h: definitions for functions stored here.
+ * src/apache-2/mod_rivet.c: Various functions moved to src/common/mod_rivet_common.c
+ * configure.ac: --with-rivet-core switch simplified
+ * Makefile.am: preparing for installation of MPM bridges which have not to be scanned for Tcl packages
+ * NOTICE: now Apache policy compliant
+ * src/apache-2/Makefile.am: reenabled and reworked to make paths relative
+ * src/apache-2/mod_rivet.h: reworked to reflect the new code organization. Also some definitions
+ moved here from mod_rivet.c
+ * src/common/mod_rivet_common.c: this is now the place where mod_rivet implementation independent
+ function must go
+ * src/experimental/Makefile.am: adding build for rivet_prefork_mpm.so
+ * src/experimental/mod_rivet.[c|h]: placing here only the hopefully necessary code. The module
+ resolves the bridge module symbols and actually calls those function to initialize, respond to
+ requests and exit child processes
+ * src/experimental/rivet_prefork_mpm.c: first sccessful implementation of the prefork bridge
+ * src/experimental/rivet_worker_mpm.c: stuffing code into this module. It doesn't build now
+ * src/common/mod_rivet_common.h: definitions for functions stored here.
2014-08-05 Massimo Manghi <mx...@apache.org>
- * src/apache-2/Makefile.am: build of mod_rivet moved again into the directory containing the code
- * configure.ac: new symbol RIVET_SOURCE_BASE pointing to <rivet-root>/src/, various fixes,
- generation of Makefile.in in both src/apache-2 and src/experimental
- * src/Makefile.am: still keeping here the magic symbols triggering build of librivetparser and librivet
- build of mod_rivet moved in src/apache-2 and experimental
- * src/experimental/mod_rivet.c: dynamic object load implemented for rivet_mpm_worker. Code handling
- Tcl threads moved to this new shared lib
- * src/experimental/rivet_worker_mpm.c: this file keeps the whole mechanics of handling APR threads
- running Tcl interpreters
- * src/experimental/mod_rivet.h: new fields added to module globals for function pointers to
- rivet_worker_mpm.so
- * tclconfig/: new version of scripts
+ * src/apache-2/Makefile.am: build of mod_rivet moved again into the directory containing the code
+ * configure.ac: new symbol RIVET_SOURCE_BASE pointing to <rivet-root>/src/, various fixes,
+ generation of Makefile.in in both src/apache-2 and src/experimental
+ * src/Makefile.am: still keeping here the magic symbols triggering build of librivetparser and librivet
+ build of mod_rivet moved in src/apache-2 and experimental
+ * src/experimental/mod_rivet.c: dynamic object load implemented for rivet_mpm_worker. Code handling
+ Tcl threads moved to this new shared lib
+ * src/experimental/rivet_worker_mpm.c: this file keeps the whole mechanics of handling APR threads
+ running Tcl interpreters
+ * src/experimental/mod_rivet.h: new fields added to module globals for function pointers to
+ rivet_worker_mpm.so
+ * tclconfig/: new version of scripts
2014-08-04 Massimo Manghi <mx...@apache.org>
- * src/common: renaming src/config to a more specific name
+ * src/common: renaming src/config to a more specific name
2014-07-31: Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.[c|h],rivetChannel.c: better implementation where Tcl interpreters are
- running within their own threads communicating to a supervisor. Also implemented APR callback functions
- to cleanup memory and interpreters data
- * src/config/parse_exec.c: adding this file which is to hold most of model independent code:
- Rivet_ParseExecFile, Rivet_chdir_file, Rivet_CheckType, Rivet_ParseExecString
- * src/apache-2/mod_rivet.c: Removed code to be common to the experimental module
- * src/Makefile.am: now compiling also new files needed to build the module.
- * src/rivet.h: adding preprocessor checks to avoid recursive includes
+ * src/experimental/mod_rivet.[c|h],rivetChannel.c: better implementation where Tcl interpreters are
+ running within their own threads communicating to a supervisor. Also implemented APR callback functions
+ to cleanup memory and interpreters data
+ * src/config/parse_exec.c: adding this file which is to hold most of model independent code:
+ Rivet_ParseExecFile, Rivet_chdir_file, Rivet_CheckType, Rivet_ParseExecString
+ * src/apache-2/mod_rivet.c: Removed code to be common to the experimental module
+ * src/Makefile.am: now compiling also new files needed to build the module.
+ * src/rivet.h: adding preprocessor checks to avoid recursive includes
2014-07-14 Massimo Manghi <mx...@apache.org>
- * src/experimental/mod_rivet.c: working toy module capable of running Tcl scripts with a worker MPM
- * src/experimental/rivetChannel.c: now depending on the thread private data
+ * src/experimental/mod_rivet.c: working toy module capable of running Tcl scripts with a worker MPM
+ * src/experimental/rivetChannel.c: now depending on the thread private data
2014-07-17 Massimo Manghi <mx...@apache.org>
- * src/channel/rivetChannel.[c|h]: add preprocessor symbol to prevent multiple includes
+ * src/channel/rivetChannel.[c|h]: add preprocessor symbol to prevent multiple includes
2014-07-16 Massimo Manghi <mx...@apache.org>
- * src/experimental: add experimental code for threaded module
+ * src/experimental: add experimental code for threaded module
2014-07-10 Massimo Manghi <mx...@apache.org>
- * src/apache-2/apache_config.[h|c]: moved to src/config
- * src/apache-2/TclWebapache.c: this file moved temporarily into src/config to separate it from
- the specific module implementation
- * src/experimental: making room to a new implementation of mod_rivet
- * src/channel/rivetChannel.c: the request_rec pointer is passed through another pointer
- as this channel is now the only channel handled by mod_rivet and it's shared across virutal hosts
- * src/apache-2/mod_rivet.c: now creating only one Rivet channel instance and storing a pointer
- to the current request_rec in the structure mod_rivet_globals, as the running the prefork MPM
- we can only handle a request at a time.
- * src/apache-2/*.tcl: removing obsolete tcl files
+ * src/apache-2/apache_config.[h|c]: moved to src/config
+ * src/apache-2/TclWebapache.c: this file moved temporarily into src/config to separate it from
+ the specific module implementation
+ * src/experimental: making room to a new implementation of mod_rivet
+ * src/channel/rivetChannel.c: the request_rec pointer is passed through another pointer
+ as this channel is now the only channel handled by mod_rivet and it's shared across virutal hosts
+ * src/apache-2/mod_rivet.c: now creating only one Rivet channel instance and storing a pointer
+ to the current request_rec in the structure mod_rivet_globals, as the running the prefork MPM
+ we can only handle a request at a time.
+ * src/apache-2/*.tcl: removing obsolete tcl files
2014-07-09 Massimo Manghi <mx...@apache.org>
- * m4/ax_split_version.m4: adding macro for version number manipulation
+ * m4/ax_split_version.m4: adding macro for version number manipulation
2014-06-22 Massimo Manghi <mx...@apache.org>
- * configure.ac: new macros MOD_RIVET_CORE and RIVET_CHANNEL. Macro APACHE_VERSION preserved but not
- called anymore
- * rivet/init.tcl.in: Add template for rivet/init.tcl
- * src/Makefile.am: building mod_rivet with code entirely selected by autoconf defined symbols
- * src/apache-2/mod_rivet.c: comments added. Rivet package version depends now on preprocessor
- symbol RIVET_TCL_PACKAGE_VERSION
+ * configure.ac: new macros MOD_RIVET_CORE and RIVET_CHANNEL. Macro APACHE_VERSION preserved but not
+ called anymore
+ * rivet/init.tcl.in: Add template for rivet/init.tcl
+ * src/Makefile.am: building mod_rivet with code entirely selected by autoconf defined symbols
+ * src/apache-2/mod_rivet.c: comments added. Rivet package version depends now on preprocessor
+ symbol RIVET_TCL_PACKAGE_VERSION
2014-06-10 Massimo Manghi <mx...@apache.org>
- * tests/rivet.test: removed lang.test as it was testing just a tautology
+ * tests/rivet.test: removed lang.test as it was testing just a tautology
2014-06-04 Massimo Manghi <mx...@apache.org>
- * doc/images/color-table.png, doc/xml/examples.xml,doc/examples/color-table-tcl: Changing old table.rvt
- example in a more enticing colorful table generation
+ * doc/images/color-table.png, doc/xml/examples.xml,doc/examples/color-table-tcl: Changing old table.rvt
+ example in a more enticing colorful table generation
2014-06-03 Massimo Manghi <mx...@apache.org>
- * doc/xml/intro.xml: Acknowledgements reworded into a list
- * doc/images/: logo has now a transparent background, navigation icons colors turned into a greenish tint
- * rivet.xsl,rivet.css: new style based on a green gamut to make pages visually different from Rivet 2.1
+ * doc/xml/intro.xml: Acknowledgements reworded into a list
+ * doc/images/: logo has now a transparent background, navigation icons colors turned into a greenish tint
+ * rivet.xsl,rivet.css: new style based on a green gamut to make pages visually different from Rivet 2.1
2014-06-02 Massimo Manghi <mx...@apache.org>
- * VERSION,configure.ac: tagging this code as 2.2.0
- * src/rivet.h,src/rivetcmds/rivetCore.c: macro CHECK_REQUEST_REC moved from rivetCore.c to rivet.h
- * doc/xml/internals.xml: New section documenting how to extend mod_rivet with new commands written in C
+ * VERSION,configure.ac: tagging this code as 2.2.0
+ * src/rivet.h,src/rivetcmds/rivetCore.c: macro CHECK_REQUEST_REC moved from rivetCore.c to rivet.h
+ * doc/xml/internals.xml: New section documenting how to extend mod_rivet with new commands written in C
2014-05-22 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/aida.sql: redifining responsability of class Aida (not to be officially released)
+ * rivet/packages/dio/aida.sql: redifining responsability of class Aida (not to be officially released)
2014-04-17 Massimo Manghi <mx...@apache.org>
- * src/: reintegrating modularization branch. Now every subsystem mod_rivet is made of (module,
- channel, parser, commands, request multipart handling) can be developed separately
- * src/rivetcmds/rivetCore.c: reintroduced handling of the -string argument that disappeared
- from Rivet_ParseCmd probably because of the merge with modular.
- * src/apache-2/mod-rivet.c: Corrected comments to Rivet_ParseExecString
+ * src/: reintegrating modularization branch. Now every subsystem mod_rivet is made of (module,
+ channel, parser, commands, request multipart handling) can be developed separately
+ * src/rivetcmds/rivetCore.c: reintroduced handling of the -string argument that disappeared
+ from Rivet_ParseCmd probably because of the merge with modular.
+ * src/apache-2/mod-rivet.c: Corrected comments to Rivet_ParseExecString
2014-04-16 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/aida.tcl,dio_Tdbc.tcl,sql.tcl: more methods implemented in aida.tcl
- * doc/xml/commands.xml: new form '::rivet::inspect server' documented
- * src/rivetcmds/rivetInspect.c: adding is_virtual flag to dictionary returned by '::rivet::inspect server'
- * branches/modular: merging latest changes in trunk
- * trunk/src/rivetcmds/rivetInpect.c: adding is_virtual flag to dictionary returned by '::rivet::inspect server'
+ * rivet/packages/dio/aida.tcl,dio_Tdbc.tcl,sql.tcl: more methods implemented in aida.tcl
+ * doc/xml/commands.xml: new form '::rivet::inspect server' documented
+ * src/rivetcmds/rivetInspect.c: adding is_virtual flag to dictionary returned by '::rivet::inspect server'
+ * branches/modular: merging latest changes in trunk
+ * trunk/src/rivetcmds/rivetInpect.c: adding is_virtual flag to dictionary returned by '::rivet::inspect server'
2014-04-11 Massimo Manghi <mx...@apache.org>
- * src/rivetcmds/rivetCore.c: misplaced check on request_rec in Rivet_InspectCmd
- * tests/failtest.tcl,failtest.test,checkfail.tcl: adding tests for ::rivet::inspect
+ * src/rivetcmds/rivetCore.c: misplaced check on request_rec in Rivet_InspectCmd
+ * tests/failtest.tcl,failtest.test,checkfail.tcl: adding tests for ::rivet::inspect
2014-04-07 Massimo Manghi <mx...@apache.org>
- * tests/failtest.[test|tcl],failcheck.tcl: implementing test for consistent error
- handling by commands that are supposed to refuse execution outside of a request processing
- * tests/inspect.tcl: implementing test of command '::rivet::inspect script'
- * src/rivetcmds/rivetCore.c: typo in command ::rivet::apache_table
+ * tests/failtest.[test|tcl],failcheck.tcl: implementing test for consistent error
+ handling by commands that are supposed to refuse execution outside of a request processing
+ * tests/inspect.tcl: implementing test of command '::rivet::inspect script'
+ * src/rivetcmds/rivetCore.c: typo in command ::rivet::apache_table
2014-04-04 Massimo Manghi <mx...@apache.org>
- * tests/failtest.tcl,failtest.test,checkfail.tcl: adding script for commands that must fail
- outside of a request processing (to be completed)
- * src/rivetcmds/rivetCore.c: comment rephrased
+ * tests/failtest.tcl,failtest.test,checkfail.tcl: adding script for commands that must fail
+ outside of a request processing (to be completed)
+ * src/rivetcmds/rivetCore.c: comment rephrased
2014-03-30 Massimo Manghi <mx...@apache.org>
- * src/rivetcmds/rivetInspect.c: Add function Rivet_CurrentServerRec returning a dictionary of
- some field values stored in the server_rec object
- * src/rivetcmds/rivetCore.c: Add support for 'server' argument returning the dictionary built
- by Rivet_CurrentServerRec
- * src/TclWeb.h: adding declaration of function constructor of a TclWebRequest object
- * src/apache-2/TclWebapache.c: Add functions TclWeb_NewRequestObject and TclWeb_InitRequest to
- reinitialize a TclWebRequest object on each request
- * src/apache-2/apache_request.[c|h]: API change for ApacheRequest_new taking now an apr_pool_t
- object instance for creating an ApacheRequest oject pointer. Task to reset this object
- to initial values is now delegated to ApacheRequest_init.
- * src/apache-2/mod_rivet.[c|h]: new field in globals stores the current server_rec object pointer.
- This pointer is used in RivetInspect.c to access to field of the object for introspection
-
+ * src/rivetcmds/rivetInspect.c: Add function Rivet_CurrentServerRec returning a dictionary of
+ some field values stored in the server_rec object
+ * src/rivetcmds/rivetCore.c: Add support for 'server' argument returning the dictionary built
+ by Rivet_CurrentServerRec
+ * src/TclWeb.h: adding declaration of function constructor of a TclWebRequest object
+ * src/apache-2/TclWebapache.c: Add functions TclWeb_NewRequestObject and TclWeb_InitRequest to
+ reinitialize a TclWebRequest object on each request
+ * src/apache-2/apache_request.[c|h]: API change for ApacheRequest_new taking now an apr_pool_t
+ object instance for creating an ApacheRequest oject pointer. Task to reset this object
+ to initial values is now delegated to ApacheRequest_init.
+ * src/apache-2/mod_rivet.[c|h]: new field in globals stores the current server_rec object pointer.
+ This pointer is used in RivetInspect.c to access to field of the object for introspection
+
2014-03-26 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: wrong example for lassign_array corrected
- * src/apache-2/mod_rivet.c: Adding comment explaining the meaning of setting/resetting globals->r as
- a way to detect if a script is running in the context of a request processing
- * src/rivetcmds/rivetCore.c,rivetInspect.c: Tcl object handling improved. Code simplified and
- ap_assert call added in Rivet_CurrentConfDict if there is no handling of a configuration parameter
- by Rivet_ReadConfParameter (which should never happen)
- * configure.ac, VERSION: version number bumped to 2.1.5
+ * doc/xml/commands.xml: wrong example for lassign_array corrected
+ * src/apache-2/mod_rivet.c: Adding comment explaining the meaning of setting/resetting globals->r as
+ a way to detect if a script is running in the context of a request processing
+ * src/rivetcmds/rivetCore.c,rivetInspect.c: Tcl object handling improved. Code simplified and
+ ap_assert call added in Rivet_CurrentConfDict if there is no handling of a configuration parameter
+ by Rivet_ReadConfParameter (which should never happen)
+ * configure.ac, VERSION: version number bumped to 2.1.5
2014-03-16 Massimo Manghi <mx...@apache.org>
- * doc/images/Rivetlogo_small.png: removed because already in doc/ and duplicate to home.png
+ * doc/images/Rivetlogo_small.png: removed because already in doc/ and duplicate to home.png
2014-02-28 Massimo Manghi <mx...@apache.org>
- * doc/xml/upgrading.xml: Adding Karl's note about upgrading from NeoWebScript
+ * doc/xml/upgrading.xml: Adding Karl's note about upgrading from NeoWebScript
2014-02-24 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: completed reworking of manual page for command ::rivet::inspect.
- * .: Preparing RC1 archive for version 2.1.4
+ * doc/xml/commands.xml: completed reworking of manual page for command ::rivet::inspect.
+ * .: Preparing RC1 archive for version 2.1.4
2014-02-22 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: further elaboration of the section about command ::rivet::inspect
+ * doc/xml/commands.xml: further elaboration of the section about command ::rivet::inspect
2014-02-21 Massimo Manghi <mx...@apache.org>
- * tests/inspect.[test|tcl]: adding tests for introspection command
+ * tests/inspect.[test|tcl]: adding tests for introspection command
2014-02-19 Massimo Manghi <mx...@apache.org>
- * src/rivetcmds/rivetCore.c: spurious ref count decrement caused random crashes
- * src/rivetcmds/rivetInspect.c: fixed behaviour when inspect is passed with an undefined argument value
- * configure.ac: reindented some function to improve readability and editor independence
+ * src/rivetcmds/rivetCore.c: spurious ref count decrement caused random crashes
+ * src/rivetcmds/rivetInspect.c: fixed behaviour when inspect is passed with an undefined argument value
+ * configure.ac: reindented some function to improve readability and editor independence
2014-02-19 Massimo Manghi <mx...@apache.org>
- * src/rivetcmds/rivetInspect.c,src/librivet/rivetList.c: removing lines of code commented and unused
- * doc/xml/commands.xml: documenting command lremove
- * tests/rivetlib.test: adding more tests for lremove
+ * src/rivetcmds/rivetInspect.c,src/librivet/rivetList.c: removing lines of code commented and unused
+ * doc/xml/commands.xml: documenting command lremove
+ * tests/rivetlib.test: adding more tests for lremove
2014-02-11 Massimo Manghi <mx...@apache.org>
- * tests/rivetlib.test: adding tests for rivetlib
- * rivet/packages/dio/aida.tcl,sql.tcl: new files for development of DIO compatible interface to tdbc
- * rivet/rivet-tcl/lassign_array.tcl: removed since already provided in rivetlib
- * docs/xml/commands.xml: documenting features of lassign_array.tcl rivetlib version
+ * tests/rivetlib.test: adding tests for rivetlib
+ * rivet/packages/dio/aida.tcl,sql.tcl: new files for development of DIO compatible interface to tdbc
+ * rivet/rivet-tcl/lassign_array.tcl: removed since already provided in rivetlib
+ * docs/xml/commands.xml: documenting features of lassign_array.tcl rivetlib version
2014-02-06 Massimo Manghi <mx...@apache.org>
- * ChangeLog: timestamps of latest entries of this file carried the wrong year (2013)
- * rivet/packages/dio/dio_Mysql.tcl: fixed comment lines placed within the switch construct
- that have become incompatibile with Tcl8.6.
- * configure.ac: add AC_C_INLINE macro
+ * ChangeLog: timestamps of latest entries of this file carried the wrong year (2013)
+ * rivet/packages/dio/dio_Mysql.tcl: fixed comment lines placed within the switch construct
+ that have become incompatibile with Tcl8.6.
+ * configure.ac: add AC_C_INLINE macro
2014-02-04 Massimo Manghi <mx...@apache.org>
- * src/rivetcmd/rivetCore.c: testing globals->r against NULL and in case return a null string
- * src/apache-2/mod_rivet.c: using only globals->r to flag a request processing under way
+ * src/rivetcmd/rivetCore.c: testing globals->r against NULL and in case return a null string
+ * src/apache-2/mod_rivet.c: using only globals->r to flag a request processing under way
2014-02-03 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: globals->req had to be set to NULL in Rivet_PerInterpInit!
+ * src/apache-2/mod_rivet.c: globals->req had to be set to NULL in Rivet_PerInterpInit!
2014-02-02 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.[c|h]: further optimizing code avoiding to
- allocate a TclWebRequest structure on every request. This structure
- is allocate when the interpreter is initialized and a pointer
- stored in rivet globals
- * src/rivetcmd/rivetInspect.c: impoved consistence if Tcl objects handling
+ * src/apache-2/mod_rivet.[c|h]: further optimizing code avoiding to
+ allocate a TclWebRequest structure on every request. This structure
+ is allocate when the interpreter is initialized and a pointer
+ stored in rivet globals
+ * src/rivetcmd/rivetInspect.c: impoved consistence if Tcl objects handling
2014-01-30 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: this ChangeLog entry is meant to amend the
- 2014-01-27 entry that missed to point out as small still important change
- in mod_rivet.c. Rivet_SendContent is not calling Tcl anymore to coax
- command 'info script' to return the current Rivet script full path. This
- will soon be solved by adding a new functionality to command '::rivet::inspect'
-
+ * src/apache-2/mod_rivet.c: this ChangeLog entry is meant to amend the
+ 2014-01-27 entry that missed to point out as small still important change
+ in mod_rivet.c. Rivet_SendContent is not calling Tcl anymore to coax
+ command 'info script' to return the current Rivet script full path. This
+ will soon be solved by adding a new functionality to command '::rivet::inspect'
+
2014-01-27 Massimo Manghi <mx...@apache.org>
- * src/apache-2/apache_config.[c|h]: new file with Apache module configuration
- procedures moved here from mod_rivet.c. This code is likely to be Apache 2.x
- but totally independent from the running MPM. Therefore it was moved here
- to improved size and manageability of mod_rivet.c
- * src/apache-2/mod_rivet.c: The module central code, from which configuration
- handling procedures were removed
+ * src/apache-2/apache_config.[c|h]: new file with Apache module configuration
+ procedures moved here from mod_rivet.c. This code is likely to be Apache 2.x
+ but totally independent from the running MPM. Therefore it was moved here
+ to improved size and manageability of mod_rivet.c
+ * src/apache-2/mod_rivet.c: The module central code, from which configuration
+ handling procedures were removed
2014-01-08 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/aida.tcl: adding aida.tcl experimental file
- for a DIO compatible interface to TDBC.
- * rivet/packages/dio/sql.tcl: now able to produce same basic SQL queries
- ::DIO::Database class is doing now
+ * rivet/packages/dio/aida.tcl: adding aida.tcl experimental file
+ for a DIO compatible interface to TDBC.
+ * rivet/packages/dio/sql.tcl: now able to produce same basic SQL queries
+ ::DIO::Database class is doing now
2013-12-19 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Postgresql.tcl: reindented and tabs converted to spaces
- * rivet/packages/dio/sql.tcl: class DIO::Sql now returning basic SELECT SQL statements
+ * rivet/packages/dio/dio_Postgresql.tcl: reindented and tabs converted to spaces
+ * rivet/packages/dio/sql.tcl: class DIO::Sql now returning basic SELECT SQL statements
2013-12-18 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/sql.tcl: further developments. Class Sql is now able
- to build an abstract representation of a SELECT query
- * rivet/packages/dio/dio.tcl: typo in a comment
+ * rivet/packages/dio/sql.tcl: further developments. Class Sql is now able
+ to build an abstract representation of a SELECT query
+ * rivet/packages/dio/dio.tcl: typo in a comment
2013-12-16 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/sql.tcl: trying to redesign rivet in order to comply with
- Tdbc and aiming at making DIO a pure interface to Tdbc dropping the
- dependency with DBMS specific drivers
+ * rivet/packages/dio/sql.tcl: trying to redesign rivet in order to comply with
+ Tdbc and aiming at making DIO a pure interface to Tdbc dropping the
+ dependency with DBMS specific drivers
2013-12-13 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Tdbc.tcl: first version of Tdbc driver for DIO. This
- class is able to execute basic queries and needs further development
+ * rivet/packages/dio/dio_Tdbc.tcl: first version of Tdbc driver for DIO. This
+ class is able to execute basic queries and needs further development
2013-12-08 Massimo Manghi <mx...@apache.org>
- * configure.ac: version number bumped up to 2.1.4
+ * configure.ac: version number bumped up to 2.1.4
2013-12-06 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Postgres.tcl: minor changes (code indentation revised)
- * rivet/packages/dio/dio_Tdbc.tcl: experimental support for the tdbc
- abstraction library
- * doc/xml/install.xml: the manual still suggested to call make install-packages,
- whereas 'make install' does everything now as it was before 2.1.2
+ * rivet/packages/dio/dio_Postgres.tcl: minor changes (code indentation revised)
+ * rivet/packages/dio/dio_Tdbc.tcl: experimental support for the tdbc
+ abstraction library
+ * doc/xml/install.xml: the manual still suggested to call make install-packages,
+ whereas 'make install' does everything now as it was before 2.1.2
2013-12-04 Massimo Manghi <mx...@apache.org>
- * src/apache-2/apache_request.c: log message in ApacheRequest___parse()
- commented out (Bug #55845)
+ * src/apache-2/apache_request.c: log message in ApacheRequest___parse()
+ commented out (Bug #55845)
2013-12-03 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: Rivet template preprocessor symbols renamed in
- the more expressive RIVET_TEMPLATE and RIVET_TCLFILE
- * rivet/rivet-tcl/lassing_array.tcl: new command lassing_array taken
- from DIO's result set class (inspired by Tclx)
- * doc/xml/commands.xml: lassign_array documented in the manual
- * rivet/packages/dio/dio.tcl: reformatted during analysis for supporting
- tdbc based driver
+ * src/apache-2/mod_rivet.c: Rivet template preprocessor symbols renamed in
+ the more expressive RIVET_TEMPLATE and RIVET_TCLFILE
+ * rivet/rivet-tcl/lassing_array.tcl: new command lassing_array taken
+ from DIO's result set class (inspired by Tclx)
+ * doc/xml/commands.xml: lassign_array documented in the manual
+ * rivet/packages/dio/dio.tcl: reformatted during analysis for supporting
+ tdbc based driver
2013-11-04 Massimo Manghi <mx...@apache.org>
- * src/Makefile.am: this Makefile.am is now in charge for building mod_rivet
- librivet.so and librivetparser.so. This fixes and problem with the 'distclean'
- target and keeps us from further customization of automake (subdir-objects
- property)
- * src/runtests.tcl: changed path to mod_rivet.so and librivetparser.so
+ * src/Makefile.am: this Makefile.am is now in charge for building mod_rivet
+ librivet.so and librivetparser.so. This fixes and problem with the 'distclean'
+ target and keeps us from further customization of automake (subdir-objects
+ property)
+ * src/runtests.tcl: changed path to mod_rivet.so and librivetparser.so
2013-10-15 Massimo Manghi <mx...@apache.org>
- * src/rivetcmds/rivetCore.c: 'headers redirect' used to return TCL_RETURN
- to force the caller to terminate and interrupt the processing. It didn't
- actually worked exactly that way and starting with Tcl 8.6.1 it also failed
- returning a Tcl invalid error code (Bug #55583). Turning it into TCL_OK
- seems to cure the problem
+ * src/rivetcmds/rivetCore.c: 'headers redirect' used to return TCL_RETURN
+ to force the caller to terminate and interrupt the processing. It didn't
+ actually worked exactly that way and starting with Tcl 8.6.1 it also failed
+ returning a Tcl invalid error code (Bug #55583). Turning it into TCL_OK
+ seems to cure the problem
2013-09-26 Massimo Manghi <mx...@apache.org>
- * doc/xml/session.xml: fixed code example indentation
- * rivet/packages/calendar.xml: fixed class and tag for calendar banner
+ * doc/xml/session.xml: fixed code example indentation
+ * rivet/packages/calendar.xml: fixed class and tag for calendar banner
2013-09-23 Massimo Manghi <mx...@apache.org>
- * rivet/packages/calendar/calendar.tcl: fixed zero length argument list
- calling method emit
+ * rivet/packages/calendar/calendar.tcl: fixed zero length argument list
+ calling method emit
2013-09-22 Massimo Manghi <mx...@apache.org>
- * modular: committing changes from last merge
+ * modular: committing changes from last merge
2013-09-21 Massimo Manghi <mx...@apache.org>
- * contrib/tcl.vim: list of subcommands completed
+ * contrib/tcl.vim: list of subcommands completed
2013-09-20 Massimo Manghi <mx...@apache.org>
- * contrib/tcl.vim: Vim's syntax highlighting extension including also
- rivet's command set (experimental)
+ * contrib/tcl.vim: Vim's syntax highlighting extension including also
+ rivet's command set (experimental)
2013-09-18 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl: removed paranoid debugging log messages
+ * rivet/init.tcl: removed paranoid debugging log messages
2013-09-17 Massimo Manghi <mx...@apache.org>
- * src/[parser|apache-2|librivet]/Makefile.am: AM_CPPFLAGS are not
- a transparent replacement for INCLUDES at least when a Makefile.am is
- in a subdirectory. Placing include directory switches in the target
- specific <target>_CPPFLAGS variable
-
+ * src/[parser|apache-2|librivet]/Makefile.am: AM_CPPFLAGS are not
+ a transparent replacement for INCLUDES at least when a Makefile.am is
+ in a subdirectory. Placing include directory switches in the target
+ specific <target>_CPPFLAGS variable
+
2013-09-15 Massimo Manghi <mx...@apache.org>
- * tclconfig/missing: new version of 'missing' taken from automake 1.14
- * src/[parser|apache-2|librivet]/Makefile.am: depracated INCLUDES variables
- replaces with their recommended counterparts AM_CPPFLAGS
- * configure.ac: new message about the notifier failing to start in child
- processes after the child processes fork
+ * tclconfig/missing: new version of 'missing' taken from automake 1.14
+ * src/[parser|apache-2|librivet]/Makefile.am: depracated INCLUDES variables
+ replaces with their recommended counterparts AM_CPPFLAGS
+ * configure.ac: new message about the notifier failing to start in child
+ processes after the child processes fork
2013-09-14 Massimo Manghi <mx...@apache.org>
- * rivet/packages/calendar/calendar.tcl: too restrictive test on Tcl versione fixed
- * rivet/rivet-tcl/parray_table.tcl: also the parray putting out an HTML table
- is now escaping SGML characters
- * INSTALL: new installation instruction amending the rejected installation
- approach done in 2.1.2 and restoring old target 'install' to get everything
- moved to their final directory
- * doc/xml/install.xml: same for INSTALL
- * doc/xml/commands.xml: new 'parse -string' form documented
+ * rivet/packages/calendar/calendar.tcl: too restrictive test on Tcl versione fixed
+ * rivet/rivet-tcl/parray_table.tcl: also the parray putting out an HTML table
+ is now escaping SGML characters
+ * INSTALL: new installation instruction amending the rejected installation
+ approach done in 2.1.2 and restoring old target 'install' to get everything
+ moved to their final directory
+ * doc/xml/install.xml: same for INSTALL
+ * doc/xml/commands.xml: new 'parse -string' form documented
2013-09-13 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Mysql.tcl: attempting to correct detection of
- SELECT query by checking if a SELECT keyword exists at the beginning of
- query either following a '(' or only space characters (their trimmed away
- in any case)
+ * rivet/packages/dio/dio_Mysql.tcl: attempting to correct detection of
+ SELECT query by checking if a SELECT keyword exists at the beginning of
+ query either following a '(' or only space characters (their trimmed away
+ in any case)
2013-08-30 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/parray.tcl: escaping SGML characters that might appear
- in the output to avoid cross scripting
+ * rivet/rivet-tcl/parray.tcl: escaping SGML characters that might appear
+ in the output to avoid cross scripting
2013-08-29 Massimo Manghi <mx...@apache.org>
- * branches/modular: merging latest changes from trunk
+ * branches/modular: merging latest changes from trunk
2013-08-26 Massimo Manghi <mx...@apache.org>
- * configure.ac: expanded warning message about broken implementations
- of Tcl when using forks and the event loop
- * Makefile.am: target 'install' now depends on targets install-binaries and
- install-packages, thus install the whole Rivet code as it did before 2.1.2.
- Packagers wanting to separated binary and Tcl code can draw on those 2
- targets
- * INSTALL,doc/xml/install.xml: changed documentation to reflect the restored
- organization of install targets
+ * configure.ac: expanded warning message about broken implementations
+ of Tcl when using forks and the event loop
+ * Makefile.am: target 'install' now depends on targets install-binaries and
+ install-packages, thus install the whole Rivet code as it did before 2.1.2.
+ Packagers wanting to separated binary and Tcl code can draw on those 2
+ targets
+ * INSTALL,doc/xml/install.xml: changed documentation to reflect the restored
+ organization of install targets
2013-08-12 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form2.tcl,form.tcl: form packages called Rivet's command
- '::rivet::env' in its unqualified form. Fixed adding the ::rivet namespace
- specification.
- * src/apache-2/rivetCore.c: errata corrige for entry added on 2013-07-19:
- command 'parse -string' superseded test command parsestr, thus removed from
- rivetCore.c
+ * rivet/packages/form/form2.tcl,form.tcl: form packages called Rivet's command
+ '::rivet::env' in its unqualified form. Fixed adding the ::rivet namespace
+ specification.
+ * src/apache-2/rivetCore.c: errata corrige for entry added on 2013-07-19:
+ command 'parse -string' superseded test command parsestr, thus removed from
+ rivetCore.c
2013-08-07 Massimo Manghi <mx...@apache.org>
- * ./: merging changes done in trunk
+ * ./: merging changes done in trunk
2013-08-07 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: adding MPM descripting fields to the 'server' array
- * configure.ac: warning message about Tcl version not supporting fork correctly
- moved to the end of configure.ac, so that it's more readable by the user
+ * src/apache-2/mod_rivet.c: adding MPM descripting fields to the 'server' array
+ * configure.ac: warning message about Tcl version not supporting fork correctly
+ moved to the end of configure.ac, so that it's more readable by the user
2013-08-06 Massimo Manghi <mx...@apache.org>
- * rivetcmds/rivetCore.c,rivetInspect.c: moved core commands into this new directory.
- Their code is (nearly) independent from Apache version and in future it might be shared
- between different versions/branches of the module
- * src/apache-2/Makefile.am: changed reference to rivetCore.c and rivetConf.c to
- their new position and new names
- * src/apache-2/mod_rivet.c: conditional compilation to Tcl_InitIdentifier might
- help preserving event loop on Unices where no pthreads_atfork call exists (Bug #55153)
- * configure.ac: Tcl version checked to detect when the notifier might
- not be working (Tcl < 8.5.15 and Tcl < 8.6.1). In case a warning message is printed
+ * rivetcmds/rivetCore.c,rivetInspect.c: moved core commands into this new directory.
+ Their code is (nearly) independent from Apache version and in future it might be shared
+ between different versions/branches of the module
+ * src/apache-2/Makefile.am: changed reference to rivetCore.c and rivetConf.c to
+ their new position and new names
+ * src/apache-2/mod_rivet.c: conditional compilation to Tcl_InitIdentifier might
+ help preserving event loop on Unices where no pthreads_atfork call exists (Bug #55153)
+ * configure.ac: Tcl version checked to detect when the notifier might
+ not be working (Tcl < 8.5.15 and Tcl < 8.6.1). In case a warning message is printed
2013-07-19 Massimo Manghi <mx...@apache.org>
- * tests/parse.test,parsestring.rvt: adding test for 'parse -string' variant
- to Rivet command 'parse'
+ * tests/parse.test,parsestring.rvt: adding test for 'parse -string' variant
+ to Rivet command 'parse'
2013-07-17 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.[h|c],rivetCore.c: reverting new command 'parsestr' and
- turning string parsing command into the support for the new -string modifier of the
- ordinary parse command
+ * src/apache-2/mod_rivet.[h|c],rivetCore.c: reverting new command 'parsestr' and
+ turning string parsing command into the support for the new -string modifier of the
+ ordinary parse command
2013-07-06 Massimo Manghi <mx...@apache.org>
- * src/parser/parserPkgInit.c: commands are created through the RIVET_OBJ_CMD macro
- * rivet/packages/tclrivet/tclrivet.tcl: loading the rivetparser library caused
- weird side effects and the interpreter failed when this package was required
- by a script. It's still to be understood why librivetparser was loaded using
- command 'load' in tclrivet.tcl
- * src/apache-2/mod_rivet.c: reverting an attempt to include rivetparser
- as package required by default.
+ * src/parser/parserPkgInit.c: commands are created through the RIVET_OBJ_CMD macro
+ * rivet/packages/tclrivet/tclrivet.tcl: loading the rivetparser library caused
+ weird side effects and the interpreter failed when this package was required
+ by a script. It's still to be understood why librivetparser was loaded using
+ command 'load' in tclrivet.tcl
+ * src/apache-2/mod_rivet.c: reverting an attempt to include rivetparser
+ as package required by default.
2013-07-05 Massimo Manghi <mx...@apache.org>
- * configure.ac: changed the default path for installation dir
- * doc/xml/commands.xml: add manual page for command ::rivet::xml
+ * configure.ac: changed the default path for installation dir
+ * doc/xml/commands.xml: add manual page for command ::rivet::xml
2013-06-28 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c,rivetCore.c: command 'parsestr' to parse templates stored
- in Tcl objects coded
- * doc/Makefile.am: 'clean' target made a little terser
+ * src/apache-2/mod_rivet.c,rivetCore.c: command 'parsestr' to parse templates stored
+ in Tcl objects coded
+ * doc/Makefile.am: 'clean' target made a little terser
2013-06-26 Massimo Manghi <mx...@apache.org>
- * Makefile.am: forcing install/unistall targets to recreate pkgIndex.tcl
- in order to have a coherent directory of packages actually available
+ * Makefile.am: forcing install/unistall targets to recreate pkgIndex.tcl
+ in order to have a coherent directory of packages actually available
2013-06-24 Massimo Manghi <mx...@apache.org>
- * INSTALL: It must be made explicit installation is a two stage operation now
+ * INSTALL: It must be made explicit installation is a two stage operation now
2013-06-24 Massimo Manghi <mx...@apache.org>
- * rivet/packages/session/session-class.tcl: two new methods 'load' (loads a
- whole package data for a given package and session) and 'clear' (it deletes either
- a whole package or a single data like for a session)
+ * rivet/packages/session/session-class.tcl: two new methods 'load' (loads a
+ whole package data for a given package and session) and 'clear' (it deletes either
+ a whole package or a single data like for a session)
2013-06-22 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: cleanup of unused code in mod_rivet.c. Adding comments
- to undocumented functions
- * src/parser/rivetParse.c: New TODO comment added
+ * src/apache-2/mod_rivet.c: cleanup of unused code in mod_rivet.c. Adding comments
+ to undocumented functions
+ * src/parser/rivetParse.c: New TODO comment added
2013-06-12 Massimo Manghi <mx...@apache.org>
- * Makefile.am: splitting install targets into 'make install' (mod_rivet.so,
- librivet.so,librivetparser.so + Tcl commands in rivet/rivet-tcl) and
- 'make install-packages' (whole content of rivet/packages), thus decoupling
- binary and non binary installs. Notice: 'make install' creates a fully
- functional install of Rivet in case packages such as 'form', 'session',
- 'DIO' aren't needed.
- * rivet/rivet-tcl/xml.tcl: Adding svn:keywords Id to svn properties
- * doc/xml/install.xml: updating manual to document the new installation command
- sequence
-
+ * Makefile.am: splitting install targets into 'make install' (mod_rivet.so,
+ librivet.so,librivetparser.so + Tcl commands in rivet/rivet-tcl) and
+ 'make install-packages' (whole content of rivet/packages), thus decoupling
+ binary and non binary installs. Notice: 'make install' creates a fully
+ functional install of Rivet in case packages such as 'form', 'session',
+ 'DIO' aren't needed.
+ * rivet/rivet-tcl/xml.tcl: Adding svn:keywords Id to svn properties
+ * doc/xml/install.xml: updating manual to document the new installation command
+ sequence
+
2013-06-04 Massimo Manghi <mx...@apache.org>
- * tclconfig/* : merging into this branch the latest commits done from trunk
+ * tclconfig/* : merging into this branch the latest commits done from trunk
2013-06-03 Massimo Manghi <mx...@apache.org>
- * tclconfig/[ltmain.sh,compile,depcomp]: more libtool scripts updated
+ * tclconfig/[ltmain.sh,compile,depcomp]: more libtool scripts updated
2013-06-03 Massimo Manghi <mx...@apache.org>
- * src/parser/Makefile.am: adding include paths to INCLUDE
- * src/Makefile.am: Rivet library build moved to this script
- * src/librivet/Makefile.am: Rivet library build removed from this file
-
+ * src/parser/Makefile.am: adding include paths to INCLUDE
+ * src/Makefile.am: Rivet library build moved to this script
+ * src/librivet/Makefile.am: Rivet library build removed from this file
+
2013-06-02 Massimo Manghi <mx...@apache.org>
- * src/Makefile.am: including librivet.so build in this file
- * src/librivet/Makefile.am: kept for reference but without effective code now
- * tclconfig/[install-sh,config.sub,config.guess]: new versions for script used by
- the autoconf/automake/libtool toolchain
+ * src/Makefile.am: including librivet.so build in this file
+ * src/librivet/Makefile.am: kept for reference but without effective code now
+ * tclconfig/[install-sh,config.sub,config.guess]: new versions for script used by
+ the autoconf/automake/libtool toolchain
2013-05-24 Massimo Manghi <mx...@apache.org>
- * src/: branching trunk to branches/modular to reorganize mod_rivet in a
- way that should enable the development of single components (apache request,
- Rivet channel, parser) with minimal branching
+ * src/: branching trunk to branches/modular to reorganize mod_rivet in a
+ way that should enable the development of single components (apache request,
+ Rivet channel, parser) with minimal branching
2013-05-21 Massimo Manghi <mx...@apache.org>
- * src/apache-2/apache_request.c: ApacheRequest___parse further simplified and
- made less restrictive about the combination of method and mimetype of the request
- * src/apache-2/mod_rivet.c: add debug message in exit handler
+ * src/apache-2/apache_request.c: ApacheRequest___parse further simplified and
+ made less restrictive about the combination of method and mimetype of the request
+ * src/apache-2/mod_rivet.c: add debug message in exit handler
2013-05-06 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: call to 'panic' changed to fulfill the hardening
- flags that (quite oddly) fail when building against Tcl8.6 on some platforms
- or Linux distros
+ * src/apache-2/rivetCore.c: call to 'panic' changed to fulfill the hardening
+ flags that (quite oddly) fail when building against Tcl8.6 on some platforms
+ or Linux distros
2013-04-30 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: improved entry for ::rivet::var with an explanation
- and example provided by Harald
- * configure.ac,VERSION: version number bumped to 2.1.2
+ * doc/xml/commands.xml: improved entry for ::rivet::var with an explanation
+ and example provided by Harald
+ * configure.ac,VERSION: version number bumped to 2.1.2
2013-02-12 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: To avoid clash on freeing resources Tcl_Finalize
- is removed from child process cleanup (Bug #54162)
+ * src/apache-2/mod_rivet.c: To avoid clash on freeing resources Tcl_Finalize
+ is removed from child process cleanup (Bug #54162)
2013-02-11 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio.tcl: fixing nasty bug introduced with Rivet 2.1. When
- method 'store' is updating the call to method update needs a flat list as
- last argument, not just a sigle valued list argument
- * doc/xml/commands.xml: Improved explanation for command abort_page
- * src/apache-2/rivetConf.c: corrected typo in header
- * src/apache-2/apache_request.c: new handling of apache requests largely
- relaxes checks on the 'Content-Type' header (Bug #53661)
+ * rivet/packages/dio/dio.tcl: fixing nasty bug introduced with Rivet 2.1. When
+ method 'store' is updating the call to method update needs a flat list as
+ last argument, not just a sigle valued list argument
+ * doc/xml/commands.xml: Improved explanation for command abort_page
+ * src/apache-2/rivetConf.c: corrected typo in header
+ * src/apache-2/apache_request.c: new handling of apache requests largely
+ relaxes checks on the 'Content-Type' header (Bug #53661)
2013-02-02 Massimo Manghi <mx...@apache.org>
- * src/apache-2/apache_request.c,src/apache-2/mod_rivet.c: extending request
- handling also for PUT and DELETE. Applied patch provided by Jeff Lawson in
- bug report #53892
+ * src/apache-2/apache_request.c,src/apache-2/mod_rivet.c: extending request
+ handling also for PUT and DELETE. Applied patch provided by Jeff Lawson in
+ bug report #53892
2013-02-01 Massimo Manghi <mx...@apache.org>
- * src/apache-2/Makefile.am, src/Makefile.am: removed -v flag from rm command
- in install-data-hook: target to avoid incompatibility with same command's
- implementation in Solaris (Bug: #54181)
+ * src/apache-2/Makefile.am, src/Makefile.am: removed -v flag from rm command
+ in install-data-hook: target to avoid incompatibility with same command's
+ implementation in Solaris (Bug: #54181)
2013-01-28 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.[c|h],rivetCore.c: removed hardcoded error code
- generated by abort_page and defined in the preprocessor symbol ABORTCODE.
-
+ * src/apache-2/mod_rivet.[c|h],rivetCore.c: removed hardcoded error code
+ generated by abort_page and defined in the preprocessor symbol ABORTCODE.
+
2013-01-25 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/xml.tcl,rivet/rivet-tcl/tclIndex: New command for XML fragments
- composition
+ * rivet/rivet-tcl/xml.tcl,rivet/rivet-tcl/tclIndex: New command for XML fragments
+ composition
2013-01-20 Massimo Manghi <mx...@apache.org>
- * Makefile.am: added removal of libool created .la files for librivetparser and
- librivet
+ * Makefile.am: added removal of libool created .la files for librivetparser and
+ librivet
2012-12-30 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/xml.tcl: revised command for simple XML string mark up
+ * rivet/rivet-tcl/xml.tcl: revised command for simple XML string mark up
2012-12-18 Massimo Manghi <mx...@apache.org>
- * src/librivet/rivetPkgInit.c: package version taken from preprocessor symbol
- RIVET_VERSION so that it's guaranteed mod_rivet.c will get the right library
- version.
- * src/apache-2/mod_rivet.c: removed trailing spaces from various lines (offends
- some patch management tools such as quilt)
+ * src/librivet/rivetPkgInit.c: package version taken from preprocessor symbol
+ RIVET_VERSION so that it's guaranteed mod_rivet.c will get the right library
+ version.
+ * src/apache-2/mod_rivet.c: removed trailing spaces from various lines (offends
+ some patch management tools such as quilt)
2012-12-17 Massimo Manghi <mx...@apache.org>
- * doc/xml/install.xml: fixed link to download page on the website
- * rivet/packages/dio/dio.tcl: method store uses internally methods 'insert' or
- 'update' (depending on the existence of a row having the same keyfield). The
- latest version of DIO shipped a 'store' method that returns the very same value
- returned either by 'insert' or 'update'. Previous versions of DIO returned
- invariably 1, which was undocumented and not very well thought out (handled
- errors in 'store' return a -code error, not necessarily 0). Previous behavior
- is reinstated (bug #54313)
+ * doc/xml/install.xml: fixed link to download page on the website
+ * rivet/packages/dio/dio.tcl: method store uses internally methods 'insert' or
+ 'update' (depending on the existence of a row having the same keyfield). The
+ latest version of DIO shipped a 'store' method that returns the very same value
+ returned either by 'insert' or 'update'. Previous versions of DIO returned
+ invariably 1, which was undocumented and not very well thought out (handled
+ errors in 'store' return a -code error, not necessarily 0). Previous behavior
+ is reinstated (bug #54313)
2012-12-16 Massimo Manghi <mx...@apache.org>
- * rivet/packages/session/session-class.tcl: method 'store' had an hardcoded
- 'parray' the ran when an error occurred. It also printed a message using
- 'puts' instead of 'debug'
+ * rivet/packages/session/session-class.tcl: method 'store' had an hardcoded
+ 'parray' the ran when an error occurred. It also printed a message using
+ 'puts' instead of 'debug'
2012-12-15 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: command 'headers' returns a meaningful error in case
- a subcommand is invalid
+ * src/apache-2/rivetCore.c: command 'headers' returns a meaningful error in case
+ a subcommand is invalid
2012-12-12 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: Tcl_PkgRequire for packages Rivet and rivetlib
- are exchanged so that commands in librivet.so can be imported when
- they are on the export list and a programmer issues a 'package require
- ::rivet' (fixes bug #54290)
- * rivet/init.tcl: this script is now providing package 'Rivet' instead of
- 'RivetTcl'. init.tcl initializes the Tcl core of Rivet and a package rivet
- has to exists for compatibility with version 2.0 where it was provided
- rather pointelessly by librivet.so.
+ * src/apache-2/mod_rivet.c: Tcl_PkgRequire for packages Rivet and rivetlib
+ are exchanged so that commands in librivet.so can be imported when
+ they are on the export list and a programmer issues a 'package require
+ ::rivet' (fixes bug #54290)
+ * rivet/init.tcl: this script is now providing package 'Rivet' instead of
+ 'RivetTcl'. init.tcl initializes the Tcl core of Rivet and a package rivet
+ has to exists for compatibility with version 2.0 where it was provided
+ rather pointelessly by librivet.so.
2012-12-03 Massimo Manghi <mx...@apache.org>
- * doc/Makefile.am: Manual pages output encoding set to UTF-8
+ * doc/Makefile.am: Manual pages output encoding set to UTF-8
2012-11-13 Massimo Manghi <mx...@apache.org>
- * doc/xml/form.xml: subcommand 'checkboxes' documented
+ * doc/xml/form.xml: subcommand 'checkboxes' documented
2012-11-09 Harald Oehlmann <oe...@apache.org>
- * rivet/packages/form/form2.tcl: Checkboxes with no value and an arbitrary
- default value are initialy checked.
- *** POTENTIAL INCOMPATIBILITY ***
- The default value is not taken as checkbox value any more.
- This was IMHO a security hole.
- (reported on rivet-dev by Jeff Lawson)
+ * rivet/packages/form/form2.tcl: Checkboxes with no value and an arbitrary
+ default value are initialy checked.
+ *** POTENTIAL INCOMPATIBILITY ***
+ The default value is not taken as checkbox value any more.
+ This was IMHO a security hole.
+ (reported on rivet-dev by Jeff Lawson)
2012-11-05 Harald Oehlmann <oe...@apache.org>
- * rivet/packages/form/form2.tcl: Bug fixed: method textarea did not honor default values.
- (reported on rivet-dev by Jeff Lawson)
+ * rivet/packages/form/form2.tcl: Bug fixed: method textarea did not honor default values.
+ (reported on rivet-dev by Jeff Lawson)
2012-10-29 Massimo Manghi <mx...@apache.org>
- * rivet/packages/session/[session-create-mysql.sql|session-create-sqlite.sql]: index
- riv_sess_cache_ix had a incomplete unique key definition that missed the 'package_' column (fixes bug #54063)
+ * rivet/packages/session/[session-create-mysql.sql|session-create-sqlite.sql]: index
+ riv_sess_cache_ix had a incomplete unique key definition that missed the 'package_' column (fixes bug #54063)
2012-10-28 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: Manual entry for makeurl extented to clarify how the
- protocol is determined.
-
+ * doc/xml/commands.xml: Manual entry for makeurl extented to clarify how the
+ protocol is determined.
+
2012-10-16 Massimo Manghi <mx...@apache.org>
- * doc/xml/directives.xml,doc/xml/commands.xml,doc/xml/install.xml,doc/xml/examples.xml,
- doc/xml/request.xml,doc/convert_examples.tcl.in,doc/examples-sgml/hello1.rvt: Trying to
- improve the manual revising and extending it
+ * doc/xml/directives.xml,doc/xml/commands.xml,doc/xml/install.xml,doc/xml/examples.xml,
+ doc/xml/request.xml,doc/convert_examples.tcl.in,doc/examples-sgml/hello1.rvt: Trying to
+ improve the manual revising and extending it
2012-10-01 Massimo Manghi <mx...@apache.org>
- * doc/xml/request.xml,doc/xml/install.xml: attempting to improve the documentation
- * doc/images/: Adding missing icons
+ * doc/xml/request.xml,doc/xml/install.xml: attempting to improve the documentation
+ * doc/images/: Adding missing icons
2012-09-30 Massimo Manghi <mx...@apache.org>
- * tests/parsepackage.test: changed path to librivetparser.so
+ * tests/parsepackage.test: changed path to librivetparser.so
2012-09-29 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/xml.tcl: Adding command for simple quick XML fragments generation
+ * rivet/rivet-tcl/xml.tcl: Adding command for simple quick XML fragments generation
2012-09-22 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio.tcl: various methods used as
- accessors to some property variables of the class Database were not returning their values
- as expeected. This also surfaced a bug in method 'string' where a result object wasn't
- used correctly. Method 'count' failed when no keyfield was set. Since it should be possible
- to call this method also when there is no keyfield defined private method table_check is
- returning specific error codes making possible to catch this error and ignore
- it in 'count' (fixed bugs #53733 and #53732)
- * rivet/packages/dio/dio_Sqlite.tcl: Class Sqlite did not set the variable 'interface' to
- value 'Sqlite' as expected.
+ * rivet/packages/dio/dio.tcl: various methods used as
+ accessors to some property variables of the class Database were not returning their values
+ as expeected. This also surfaced a bug in method 'string' where a result object wasn't
+ used correctly. Method 'count' failed when no keyfield was set. Since it should be possible
+ to call this method also when there is no keyfield defined private method table_check is
+ returning specific error codes making possible to catch this error and ignore
+ it in 'count' (fixed bugs #53733 and #53732)
+ * rivet/packages/dio/dio_Sqlite.tcl: Class Sqlite did not set the variable 'interface' to
+ value 'Sqlite' as expected.
2012-09-21 Massimo Manghi <mx...@apache.org>
- * doc/README: improved instruction for code examples inclusion into XML manual
- * doc/rivet-full.xml: removed
+ * doc/README: improved instruction for code examples inclusion into XML manual
+ * doc/rivet-full.xml: removed
2012-09-18 Massimo Manghi <mx...@apache.org>
- * rivet/pkgIndex.tcl: index file regenerated
+ * rivet/pkgIndex.tcl: index file regenerated
2012-09-17 Massimo Manghi <mx...@apache.org>
- * src/librivet/rivet[Crypt|WWW|List|pkgInit].c,src/parser/rivetParser.[c|h],
- src/parser/parserPkgInit.c: files for librivet and the Rivet parser moved into
- src/librivet and src/parser.
- * src/Makefile.am,src/librivet/Makefile.am, src/parser/Makefile.am: new automake conf files
- reflect libraries reorganization.
- * src/apache-2/Makefile.am: mod_rivet builds from the newly located parser code. Is it
- sensible to let the module depend on a real package (provided by libparser.c)?
- * configure.ac: add variable substitution for newly created Makefile.am
+ * src/librivet/rivet[Crypt|WWW|List|pkgInit].c,src/parser/rivetParser.[c|h],
+ src/parser/parserPkgInit.c: files for librivet and the Rivet parser moved into
+ src/librivet and src/parser.
+ * src/Makefile.am,src/librivet/Makefile.am, src/parser/Makefile.am: new automake conf files
+ reflect libraries reorganization.
+ * src/apache-2/Makefile.am: mod_rivet builds from the newly located parser code. Is it
+ sensible to let the module depend on a real package (provided by libparser.c)?
+ * configure.ac: add variable substitution for newly created Makefile.am
2012-09-16 Massimo Manghi <mx...@apache.org>
- * tests/runtests.tcl,tests/apachetest.tcl: User and Group directives removed from conffile
- template to make test suite independent from the output of command 'id' from which
- the values for this parameters were inferred (Bug #53396)
- * tests/shorthand.rvt: oddly enough the template output the same line twice.
+ * tests/runtests.tcl,tests/apachetest.tcl: User and Group directives removed from conffile
+ template to make test suite independent from the output of command 'id' from which
+ the values for this parameters were inferred (Bug #53396)
+ * tests/shorthand.rvt: oddly enough the template output the same line twice.
2012-09-03 Harald Oehlmann <oe...@apache.org>
- * Thank you accepting me as committer
+ * Thank you accepting me as committer
2012-08-19 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: the module returns now a HTTP_INTERNAL_SERVER_ERROR when a request
- namespace cannot be created
+ * src/apache-2/mod_rivet.c: the module returns now a HTTP_INTERNAL_SERVER_ERROR when a request
+ namespace cannot be created
2012-08-16 Massimo Manghi <mx...@apache.org>
- * src/rivetPkgInit.c: improved namespace structure pointer handling (contributed by
- Georgios Petasis)
+ * src/rivetPkgInit.c: improved namespace structure pointer handling (contributed by
+ Georgios Petasis)
2012-08-15 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Oracle.tcl: fixed method makeDBFieldValue in class Oracle (Bug #53703)
+ * rivet/packages/dio/dio_Oracle.tcl: fixed method makeDBFieldValue in class Oracle (Bug #53703)
2012-08-15 Massimo Manghi <mx...@apache.org>
- * doc/xml/dio.xml: Fixed wrong declariation of 'insert' subcommand in page manual (Bug #53670)
- * rivet/packages/dio/dio_Postgresql.tcl: method makeDBFieldValue implemented and tested with
- package Sessiona (Bug #53703).
- * rivet/packages/session/session-create.sql: file renamed as session-create-postgresql.sql.
- Schema tested with package Session.
- * Changelog: entry of Aug 12 corrected: the method of Database (dio.tcl) in question was 'store'
- not 'fetch'
- * rivet/packages/session/session-class.tcl: removed 'conf' variable that could clash with
- application code (and in at least one case it did) (Fixes bug #53544)
+ * doc/xml/dio.xml: Fixed wrong declariation of 'insert' subcommand in page manual (Bug #53670)
+ * rivet/packages/dio/dio_Postgresql.tcl: method makeDBFieldValue implemented and tested with
+ package Sessiona (Bug #53703).
+ * rivet/packages/session/session-create.sql: file renamed as session-create-postgresql.sql.
+ Schema tested with package Session.
+ * Changelog: entry of Aug 12 corrected: the method of Database (dio.tcl) in question was 'store'
+ not 'fetch'
+ * rivet/packages/session/session-class.tcl: removed 'conf' variable that could clash with
+ application code (and in at least one case it did) (Fixes bug #53544)
2012-08-13 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Sqlite.sql,rivet/packages/dio/dio_Mysql.tcl: These connector classes
- didn't compute correctly the number of seconds as unix timestamp to be returned for comparison
- with the same information returned by [clock seconds] (Bug #53703)
- * rivet/packages/session/session-class.tcl: special datetime field were registered associated
- to the rivet_session and rivet_session_cache names, whereas the class has member variables for
- storing these definitions (Bug #53543)
+ * rivet/packages/dio/dio_Sqlite.sql,rivet/packages/dio/dio_Mysql.tcl: These connector classes
+ didn't compute correctly the number of seconds as unix timestamp to be returned for comparison
+ with the same information returned by [clock seconds] (Bug #53703)
+ * rivet/packages/session/session-class.tcl: special datetime field were registered associated
+ to the rivet_session and rivet_session_cache names, whereas the class has member variables for
+ storing these definitions (Bug #53543)
2012-08-12 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio.tcl: Database's class 'store' method was rewritten on a more simple
- assumption that methods 'insert' and 'update' know how to actually .... insert and update rows
- * rivet/packages/dio/dio_Sqlite.tcl: The class was found to fail in various circumstances
- determining the number of rows affected by a query and determining the set of fields in a
- table involved by a query. Since a 'select' query is treated in a rather distinctive way
- from other SQL queries, a new public variable 'select' was added to the properties of the
- class in order to handle consistently the 2 cases within SqliteResult. The number of rows
- affected rows is obtained from the 'changes' subcommand of Sqlite3 connector.
- * rivet/packages/dio_Mysql.tcl: wrong special field handling fixed
+ * rivet/packages/dio/dio.tcl: Database's class 'store' method was rewritten on a more simple
+ assumption that methods 'insert' and 'update' know how to actually .... insert and update rows
+ * rivet/packages/dio/dio_Sqlite.tcl: The class was found to fail in various circumstances
+ determining the number of rows affected by a query and determining the set of fields in a
+ table involved by a query. Since a 'select' query is treated in a rather distinctive way
+ from other SQL queries, a new public variable 'select' was added to the properties of the
+ class in order to handle consistently the 2 cases within SqliteResult. The number of rows
+ affected rows is obtained from the 'changes' subcommand of Sqlite3 connector.
+ * rivet/packages/dio_Mysql.tcl: wrong special field handling fixed
2012-08-11 Massimo Manghi <mx...@apache.org>
- * rivet/packages/session/session-create-sqlite.sql: new file with schema of session package tables
- for Sqlite.
+ * rivet/packages/session/session-create-sqlite.sql: new file with schema of session package tables
+ for Sqlite.
2012-08-07 Massimo Manghi <mx...@apache.org>
- * doc/rivet.css: text in monospace characted made a little smaller
- * rivet/packages/form/form.tcl: Workaround to avoid wrong parsing of form data when parameter
- values have spaces in them
- * src/apache-2/mod_rivet.c: 'server' array uses RIVET_VERSION instead of the lengthy RIVET_PACKAGE_VERSION
+ * doc/rivet.css: text in monospace characted made a little smaller
+ * rivet/packages/form/form.tcl: Workaround to avoid wrong parsing of form data when parameter
+ values have spaces in them
+ * src/apache-2/mod_rivet.c: 'server' array uses RIVET_VERSION instead of the lengthy RIVET_PACKAGE_VERSION
2012-07-31 Massimo Manghi <mx...@apache.org>
- * rivet/packages/dio/dio_Sqlite.tcl: Add search case for package sqlite3. Add method makeDBFieldValue
- to handle time and date special fields support. Add method 'quote' which overrides the same method
- in Database, as correct way to escape quotes (') characters for Sqlite is doubling them ('')
+ * rivet/packages/dio/dio_Sqlite.tcl: Add search case for package sqlite3. Add method makeDBFieldValue
+ to handle time and date special fields support. Add method 'quote' which overrides the same method
+ in Database, as correct way to escape quotes (') characters for Sqlite is doubling them ('')
2012-07-04 Massimo Manghi <mx...@apache.org>
- * doc/examples/download.tcl: The example has been having ever since an error in calling 'source'
- instead of 'parse'. The multitude of the userbase never realized.
+ * doc/examples/download.tcl: The example has been having ever since an error in calling 'source'
+ instead of 'parse'. The multitude of the userbase never realized.
2012-07-03 Massimo Manghi <mx...@apache.org>
- * CHANGES: file emptied from obsolete notes
- * src/apache-2/mod_rivet.c: Add UploadDirectory to the list of handled options for RivetUserConf
+ * CHANGES: file emptied from obsolete notes
+ * src/apache-2/mod_rivet.c: Add UploadDirectory to the list of handled options for RivetUserConf
2012-06-27 Massimo Manghi <mx...@apache.org>
- * configure.ac: Version number set as 1.2.0b1
- * rivet/packages/form/form.tcl: form package 1.0 taken from branches/2.0
- * doc/xml/commands.xml: improved page manual about incr0 being declared deprecated
+ * configure.ac: Version number set as 1.2.0b1
+ * rivet/packages/form/form.tcl: form package 1.0 taken from branches/2.0
+ * doc/xml/commands.xml: improved page manual about incr0 being declared deprecated
2012-06-20 Massimo Manghi <mx...@apache.org>
- * contrib/form.tcl: Requiring package TclOO making explicit it's needed to run this version of form.tcl
+ * contrib/form.tcl: Requiring package TclOO making explicit it's needed to run this version of form.tcl
2012-06-01 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form2.tcl: New form2.tcl providing form 2.0 package (proposed name for
- the file)
+ * rivet/packages/form/form2.tcl: New form2.tcl providing form 2.0 package (proposed name for
+ the file)
2012-05-18 Massimo Manghi <mx...@apache.org>
- * doc/xml/intro.xml: add acknowledgments for contributions made by Cyril, Jeff and Harald
- * doc/xml/commands.xml: add page manual for ::rivet::inspect
- * src/apache-2/mod_rivet.c: add handling for Debug, DebugIp and DebugSeparator in
- user conf table.
- * rivet/rivet-tcl/debug.tcl: Array ::RivetUserConf (which is used to convey control
- parameters for the command) is now created on demand using command ::rivet::inspect
- * doc/rivet.css: adjustments needed to make characters size consistent and nice looking
+ * doc/xml/intro.xml: add acknowledgments for contributions made by Cyril, Jeff and Harald
+ * doc/xml/commands.xml: add page manual for ::rivet::inspect
+ * src/apache-2/mod_rivet.c: add handling for Debug, DebugIp and DebugSeparator in
+ user conf table.
+ * rivet/rivet-tcl/debug.tcl: Array ::RivetUserConf (which is used to convey control
+ parameters for the command) is now created on demand using command ::rivet::inspect
+ * doc/rivet.css: adjustments needed to make characters size consistent and nice looking
2012-05-17 Massimo Manghi <mx...@apache.org>
- * doc/xml/examples.xml: "Hello World" example reworked
- * rivet/packages/dio/dio.tcl: fixed SQL syntax that would break compatibility with Oracle (fixes
- reopened bug #53222)
+ * doc/xml/examples.xml: "Hello World" example reworked
+ * rivet/packages/dio/dio.tcl: fixed SQL syntax that would break compatibility with Oracle (fixes
+ reopened bug #53222)
2012-05-15 Massimo Manghi <mx...@apache.org>
- * doc/hello1.rvt: add new "Hello World!" example to explain the new shorthand syntax <?= ... ?>
+ * doc/hello1.rvt: add new "Hello World!" example to explain the new shorthand syntax <?= ... ?>
2012-05-14 Massimo Manghi <mx...@apache.org>
- * doc/rivet.xsl,doc/rivet.css,doc/images/[prev.png,next.png,up.png]: new stylesheet and icons for
- the page manual
+ * doc/rivet.xsl,doc/rivet.css,doc/images/[prev.png,next.png,up.png]: new stylesheet and icons for
+ the page manual
2012-05-13 Massimo Manghi <mx...@apache.org>
- * rivet/packages/tclrivet/tclrivetparser.tcl: Tcl parser implements new shorthand echo syntax (closes
- bug #53217)
- * doc/xml/entities.xml: New manual page for package RivetEntities
- * rivet/packages/tclrivet/parse.tcl: auto_path handling improved (closes bug #52898)
- * rivet/packages/form/form.tcl: indentation converted to spaces to improve editing across different
- editors. Fixed problem with variable clash in constructor. Also removed unneeded [expr ...] in conditions
- that prevented byte compiling (Closes bug #52650)
- * doc/xml/commands.xml: improved manual entry for 'var list' (Fixes bug #52911)
+ * rivet/packages/tclrivet/tclrivetparser.tcl: Tcl parser implements new shorthand echo syntax (closes
+ bug #53217)
+ * doc/xml/entities.xml: New manual page for package RivetEntities
+ * rivet/packages/tclrivet/parse.tcl: auto_path handling improved (closes bug #52898)
+ * rivet/packages/form/form.tcl: indentation converted to spaces to improve editing across different
+ editors. Fixed problem with variable clash in constructor. Also removed unneeded [expr ...] in conditions
+ that prevented byte compiling (Closes bug #52650)
+ * doc/xml/commands.xml: improved manual entry for 'var list' (Fixes bug #52911)
2012-05-12 Massimo Manghi <mx...@apache.org>
- * src/rivetParser.c: add shorthand expression <?= ... ?> for <? puts -nonewline "..." ?> (contributed
- by Jeff Lawson, addresses #53217, tclrivetparser still to be fixed)
- * tests/shorthand.[test|rvt]: add test of shorthand notation for string output
- * rivet/rivet-tcl/cookie.tcl: add support for HttpOnly flag (contributed by Cyril Shtumf,
- fixes bug #53224)
- * rivet/packages/session/session-class.tcl: support for HttpOnly flag improves security and reduces
- the risk of cross-site scripting attacks (contributed by Cyril Shtumf, fixes #52224)
- * rivet/packages/dio/dio.tcl: wrong SQL syntax generated in delete method when multiple fields are
- used in the selection clause (contributed by Cyril Shtumf, fixes bug #53222)
- * rivet/packages/dio/dio_Mysql.tcl: Mysql connection must be checked when connection reference is reused
- because it could have dropped (contributed by Cyril Shtumf, fixes #53221)
+ * src/rivetParser.c: add shorthand expression <?= ... ?> for <? puts -nonewline "..." ?> (contributed
+ by Jeff Lawson, addresses #53217, tclrivetparser still to be fixed)
+ * tests/shorthand.[test|rvt]: add test of shorthand notation for string output
+ * rivet/rivet-tcl/cookie.tcl: add support for HttpOnly flag (contributed by Cyril Shtumf,
+ fixes bug #53224)
+ * rivet/packages/session/session-class.tcl: support for HttpOnly flag improves security and reduces
+ the risk of cross-site scripting attacks (contributed by Cyril Shtumf, fixes #52224)
+ * rivet/packages/dio/dio.tcl: wrong SQL syntax generated in delete method when multiple fields are
+ used in the selection clause (contributed by Cyril Shtumf, fixes bug #53222)
+ * rivet/packages/dio/dio_Mysql.tcl: Mysql connection must be checked when connection reference is reused
+ because it could have dropped (contributed by Cyril Shtumf, fixes #53221)
2012-05-09 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/http_accept.tcl: new command ::rivet::http_accept
- * doc/xml/commands.xml: new manual entry for ::rivet::http_accept
- * doc/rivet.xml: Add new file entities.xml describing package 'RivetEntities' (only a
- stub, to be elaborated)
- * doc/xml/entities.xml: New manual page for package 'RivetEntities'
+ * rivet/rivet-tcl/http_accept.tcl: new command ::rivet::http_accept
+ * doc/xml/commands.xml: new manual entry for ::rivet::http_accept
+ * doc/rivet.xml: Add new file entities.xml describing package 'RivetEntities' (only a
+ stub, to be elaborated)
+ * doc/xml/entities.xml: New manual page for package 'RivetEntities'
2012-05-08 Massimo Manghi <mx...@apache.org>
- * src/rivetPkgInit.c: reinstated safe interpreters initialization
- * doc/xml/install.xml: corrections and further elaboration of explanation for
- the --disable-import-rivet-commands
+ * src/rivetPkgInit.c: reinstated safe interpreters initialization
+ * doc/xml/install.xml: corrections and further elaboration of explanation for
+ the --disable-import-rivet-commands
2012-05-07 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: new command ::rivet::inspect implementing function
- Rivet_InspectCmd
- * src/apache-2/rivetConf.c: Ancillary functions for instrospection procedure Rivet_InspectCmd
- * src/apache-2/Makefile.am: Added handling of rivetConf.c
- * src/apache-2/mod_rivet.c: Handling of configuration directives restricted to meaningful
- options when RivetDirConf or RivetUserConf directives are set. An error message is printed
- when child process initialization directives are set by RivetDirConf and RivetUserConf.
- Rivet_PropagatePerDirConfArrays and Rivet_PropagateServerConfArray functions disabled as the
- ::rivet::inspect command can work out a better alternative creating the RivetServerConf,
- RivetDirConf and RivetUserConf on demand.
- * src/apache-2/mod_rivet.h: Added declaration for functions in rivetConf.c
- * rivet/rivet-tcl/lassign.tcl: removed, since Tcl 8.5 lassign implements and extends the
- same functionalities
+ * src/apache-2/rivetCore.c: new command ::rivet::inspect implementing function
+ Rivet_InspectCmd
+ * src/apache-2/rivetConf.c: Ancillary functions for instrospection procedure Rivet_InspectCmd
+ * src/apache-2/Makefile.am: Added handling of rivetConf.c
+ * src/apache-2/mod_rivet.c: Handling of configuration directives restricted to meaningful
+ options when RivetDirConf or RivetUserConf directives are set. An error message is printed
+ when child process initialization directives are set by RivetDirConf and RivetUserConf.
+ Rivet_PropagatePerDirConfArrays and Rivet_PropagateServerConfArray functions disabled as the
+ ::rivet::inspect command can work out a better alternative creating the RivetServerConf,
+ RivetDirConf and RivetUserConf on demand.
+ * src/apache-2/mod_rivet.h: Added declaration for functions in rivetConf.c
+ * rivet/rivet-tcl/lassign.tcl: removed, since Tcl 8.5 lassign implements and extends the
+ same functionalities
2012-04-30 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form.tcl: Patch provided by Jeff Lawson to manage -label switches.
- The package now requires package uuid from Tcllib.
- * : Entry of 2012-04-07 amended as the path to mod_rivet.[c|h] was clearly wrong
+ * rivet/packages/form/form.tcl: Patch provided by Jeff Lawson to manage -label switches.
+ The package now requires package uuid from Tcllib.
+ * : Entry of 2012-04-07 amended as the path to mod_rivet.[c|h] was clearly wrong
2012-04-07 Massimo Manghi <mx...@apache.org>
- * rivet/apache-2/mod_rivet.[c|h]: One more change to an ap_log_error call suggested
- by the compilation hardening flags
+ * rivet/apache-2/mod_rivet.[c|h]: One more change to an ap_log_error call suggested
+ by the compilation hardening flags
2012-03-26 Massimo Manghi <mx...@apache.org>
- * rivet/packages/entities.tcl: new package RivetEntities, replacement for tcllib
- ::html::entities but with no extra dependecies (as a matter of fact it
- works without Rivet too)
+ * rivet/packages/entities.tcl: new package RivetEntities, replacement for tcllib
+ ::html::entities but with no extra dependecies (as a matter of fact it
+ works without Rivet too)
2012-03-13 Karl Lehenbauer <ka...@apache.org>
- * configure.ac: Default separate virtual interps to "no".
- (--enable-virtual-interps-separation option implies disabled if not set.)
- * rivet/packages/form/form.tcl: In the forms package, stop bleeding the
- raw value of radio buttons and checkboxes into the generated HTML.
- * src/apache-2/mod_rivet.c: Rework ap_log_error calls to include the
- mod_rivet module name. Emit debug-level messages for successful
- execution of GlobalInitScript and ServerInitScript.
- * README.freebsd: Update to reflect the modern world.
- * README.configure: Document how to regenerate the configure script, etc.
- * tclconfig/depcomp, tclconfig/missing, tclconfig/config.guess,
- tclconfig/config.sub, tclconfig/ltmain.sh: Update from newer libtools, etc.
+ * configure.ac: Default separate virtual interps to "no".
+ (--enable-virtual-interps-separation option implies disabled if not set.)
+ * rivet/packages/form/form.tcl: In the forms package, stop bleeding the
+ raw value of radio buttons and checkboxes into the generated HTML.
+ * src/apache-2/mod_rivet.c: Rework ap_log_error calls to include the
+ mod_rivet module name. Emit debug-level messages for successful
+ execution of GlobalInitScript and ServerInitScript.
+ * README.freebsd: Update to reflect the modern world.
+ * README.configure: Document how to regenerate the configure script, etc.
+ * tclconfig/depcomp, tclconfig/missing, tclconfig/config.guess,
+ tclconfig/config.sub, tclconfig/ltmain.sh: Update from newer libtools, etc.
2012-03-08 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/,/rivet/packages/simpledb: various changes suggested by code profiler
- (thanks to Harald Oehlmann)
- * rivet/packages/tclrivetparse.tcl: wrong handling of swich cases made method 'parse'
- unusable
- * src/rivet.h: obsolete comment amended
+ * rivet/rivet-tcl/,/rivet/packages/simpledb: various changes suggested by code profiler
+ (thanks to Harald Oehlmann)
+ * rivet/packages/tclrivetparse.tcl: wrong handling of swich cases made method 'parse'
+ unusable
+ * src/rivet.h: obsolete comment amended
2012-01-16 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/tclIndex.tcl: regenerated with auto_mkindex.
+ * rivet/rivet-tcl/tclIndex.tcl: regenerated with auto_mkindex.
2012-01-15 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/parray_table.tcl: this file was erroneously introduced as
- tablearray.tcl. Renamed.
- * rivet/rivet-tcl/putsnnl.tcl: experimental putsnnl command rewritten to
- improve features and make it more flexible by adding option for padding
- with entities.
+ * rivet/rivet-tcl/parray_table.tcl: this file was erroneously introduced as
+ tablearray.tcl. Renamed.
+ * rivet/rivet-tcl/putsnnl.tcl: experimental putsnnl command rewritten to
+ improve features and make it more flexible by adding option for padding
+ with entities.
2012-01-10 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/parray_table.tcl: New command parray_table to print the
- content of an array into an HTML table
- * rivet/rivet-tcl/putsnnl.tcl: More consistent form for 'putsnnl'. If the
- second argument is given and it's an integer then the string is at most <nchars>
- characters long. If <nchars> > [string lenghth <output_string>] then the output
- is still <nchars> wide. If <spaces> is a positive integer the string is printed
- right-aligned, if negative the string is left-aligned
+ * rivet/rivet-tcl/parray_table.tcl: New command parray_table to print the
+ content of an array into an HTML table
+ * rivet/rivet-tcl/putsnnl.tcl: More consistent form for 'putsnnl'. If the
+ second argument is given and it's an integer then the string is at most <nchars>
+ characters long. If <nchars> > [string lenghth <output_string>] then the output
+ is still <nchars> wide. If <spaces> is a positive integer the string is printed
+ right-aligned, if negative the string is left-aligned
2011-12-26 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/putsnnl.tcl: Add new command 'putsnnl', a wrapper for
- 'puts -nonewline' with the extra optional feature of prepending the output
- with a definite number of spaces (it helps pretty printing of HTML)
+ * rivet/rivet-tcl/putsnnl.tcl: Add new command 'putsnnl', a wrapper for
+ 'puts -nonewline' with the extra optional feature of prepending the output
+ with a definite number of spaces (it helps pretty printing of HTML)
2011-12-09 Massimo Manghi <mx...@apache.org>
- * src/rivetPkgInit.c,src/parserPkgInit.c: libs now are fully based on stubs and
- the tcl version parameter passed with Tcl_InitStubs is the same Tcl version their
- linked against. Probably too strict, but a cautious point as we are moving towards
- Tcl8.6 and Tcl9, which will probably require recompilation of the whole Tcl software
+ * src/rivetPkgInit.c,src/parserPkgInit.c: libs now are fully based on stubs and
+ the tcl version parameter passed with Tcl_InitStubs is the same Tcl version their
+ linked against. Probably too strict, but a cautious point as we are moving towards
+ Tcl8.6 and Tcl9, which will probably require recompilation of the whole Tcl software
2011-12-08 Massimo Manghi <mx...@apache.org>
- * trunk/: Final commit merging changes to scoping commands in the ::rivet namespace
+ * trunk/: Final commit merging changes to scoping commands in the ::rivet namespace
2011-12-07 Massimo Manghi <mx...@apache.org>
- * doc/examples, doc/convert_examples.tcl.in: Add ::rivet namespace to examples and
- examples code converter
- * doc/examples/*.rvt: removed unneeded sgml chars escaping
- * doc/xml/install.xml: removed duplicated entry of a 'configure' switch
+ * doc/examples, doc/convert_examples.tcl.in: Add ::rivet namespace to examples and
+ examples code converter
+ * doc/examples/*.rvt: removed unneeded sgml chars escaping
+ * doc/xml/install.xml: removed duplicated entry of a 'configure' switch
2011-12-06 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/tablearray.tcl: new procedure 'tablearray' prints an array content
- in an HTML <table> construct. Test procedure, we maybe want to have something more
- general for printing also dictionaries.
+ * rivet/rivet-tcl/tablearray.tcl: new procedure 'tablearray' prints an array content
+ in an HTML <table> construct. Test procedure, we maybe want to have something more
+ general for printing also dictionaries.
2011-12-06 Massimo Manghi <mx...@apache.org>
- * configure_ac: add new test on Tcl version using AX_VERSION_COMPARE.
+ * configure_ac: add new test on Tcl version using AX_VERSION_COMPARE.
2011-12-06 Massimo Manghi <mx...@apache.org>
- * doc/xml/request.xml,doc/xml/install.xml: documenting new configure switches
+ * doc/xml/request.xml,doc/xml/install.xml: documenting new configure switches
2011-12-05 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: child init sets also the array module_conf to signal the
- compilation flags --enable-rivet-commands-export and --enable-import-namespace-commands
- for the benefit of init.tcl
- * configure.ac: new macro created to handle --enable-rivet-commands-export and
- --enable-import-namespace-commands
- * rivet/init.tcl: module_conf signals when commands have to be exported from ::rivet
- and when they have to be implicitly imported into the global namespace for compatibility
- with previous versions of Rivet.
+ * src/apache-2/mod_rivet.c: child init sets also the array module_conf to signal the
+ compilation flags --enable-rivet-commands-export and --enable-import-namespace-commands
+ for the benefit of init.tcl
+ * configure.ac: new macro created to handle --enable-rivet-commands-export and
+ --enable-import-namespace-commands
+ * rivet/init.tcl: module_conf signals when commands have to be exported from ::rivet
+ and when they have to be implicitly imported into the global namespace for compatibility
+ with previous versions of Rivet.
2011-11-21 Massimo Manghi <mx...@apache.org>
- * doc/xml/directives.xml,doc/xml/commands.xml: removed note about 'rivetlib' package
- no more needed. Notes about ServerInitScript not having effect when virtual hosts
- have their own private slave interpreters.
+ * doc/xml/directives.xml,doc/xml/commands.xml: removed note about 'rivetlib' package
+ no more needed. Notes about ServerInitScript not having effect when virtual hosts
+ have their own private slave interpreters.
2011-11-20 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml,doc/xml/install.xml: documentation for building Rivet updated.
- * configure.ac: corrected help message for --disable-rivet-commands-export
+ * doc/xml/commands.xml,doc/xml/install.xml: documentation for building Rivet updated.
+ * configure.ac: corrected help message for --disable-rivet-commands-export
2011-11-20 Massimo Manghi <mx...@apache.org>
- * src/rivet.h: Macro definition for Rivet command objects has rolled back to
- its previous form and doesn't call Tcl_Export anymore. In case commands are
- exported by calling Tcl_Export in rivetCore.c and rivetPkgInit.c
- * tests/*: test suite reviewed for new tests
+ * src/rivet.h: Macro definition for Rivet command objects has rolled back to
+ its previous form and doesn't call Tcl_Export anymore. In case commands are
+ exported by calling Tcl_Export in rivetCore.c and rivetPkgInit.c
+ * tests/*: test suite reviewed for new tests
2011-11-16 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: code rationalization. namespace reference will not be
- passed to the RIVET_OBJ_COMMAND macro and commands are exported by calling Tcl_Export
- on the whole command set in ::rivet. The whole process is controlled by the macro
- symbol RIVET_NAMESPACE_EXPORT
- * src/rivet.h: only one RIVET_OBJ_COMMAND object exists now. Call to Rivet_WWWInit,
- Rivet_CryptInit and Rivet_ListInit haved changed. Rivet namespace pointer in not
- passed around anymore and it's handled only in rivetPkgInit.c
- * src/rivetPkgInit.c:
+ * src/apache-2/rivetCore.c: code rationalization. namespace reference will not be
+ passed to the RIVET_OBJ_COMMAND macro and commands are exported by calling Tcl_Export
+ on the whole command set in ::rivet. The whole process is controlled by the macro
+ symbol RIVET_NAMESPACE_EXPORT
+ * src/rivet.h: only one RIVET_OBJ_COMMAND object exists now. Call to Rivet_WWWInit,
+ Rivet_CryptInit and Rivet_ListInit haved changed. Rivet namespace pointer in not
+ passed around anymore and it's handled only in rivetPkgInit.c
+ * src/rivetPkgInit.c:
2011-11-14 Massimo Manghi <mx...@apache.org>
- * configure.ac: new switch --enable-rivet-commands-export to enable/disable
- commands in ::rivet namespace
+ * configure.ac: new switch --enable-rivet-commands-export to enable/disable
+ commands in ::rivet namespace
2011-11-12 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: reindented to improve readability.
- * doc/xml/commands.xml: typo corrected
- * tclconfig/ltmain.sh: new script from recently released libtools
- * configure.ac: new macro AC_CONFIG_MACRO_DIR to include macros in m4
+ * src/apache-2/rivetCore.c: reindented to improve readability.
+ * doc/xml/commands.xml: typo corrected
+ * tclconfig/ltmain.sh: new script from recently released libtools
+ * configure.ac: new macro AC_CONFIG_MACRO_DIR to include macros in m4
2011-10-12 Massimo Manghi <mx...@apache.org>
- * debian/*: actually removed from trunk (yesterday it was removed from branches/2.0)
+ * debian/*: actually removed from trunk (yesterday it was removed from branches/2.0)
2011-10-11 Massimo Manghi <mx...@apache.org>
- * debian/*: removed from trunk and moved into parent directory. Maintaining
- scripts and configuration for Debianizing a package in the same package
- repository is deprecated and error prone.
+ * debian/*: removed from trunk and moved into parent directory. Maintaining
+ scripts and configuration for Debianizing a package in the same package
+ repository is deprecated and error prone.
2011-10-09 Massimo Manghi <mx...@apache.org>
- * debian/*: preparing to move the debian stuff away from
- development branches of Rivet. I'm committing the latest
- changes done in the process of releasing the Debian package
- for 2.0.4
+ * debian/*: preparing to move the debian stuff away from
+ development branches of Rivet. I'm committing the latest
+ changes done in the process of releasing the Debian package
+ for 2.0.4
2011-09-26 Massimo Manghi <mx...@apache.org>
- * m4/ax_compare_version.m4: add macro for version comparison from the GNU macro archive
+ * m4/ax_compare_version.m4: add macro for version comparison from the GNU macro archive
2011-09-23 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c,src/apache-2/TclWebapache.c: merging changes
- made to fix bugs and requests to command 'makeurl', 'load_env' and 'load_headers'
+ * src/apache-2/rivetCore.c,src/apache-2/TclWebapache.c: merging changes
+ made to fix bugs and requests to command 'makeurl', 'load_env' and 'load_headers'
2011-09-07 Massimo Manghi <mx...@apache.org>
- * doc/xml/commands.xml: Add existing undocumented commands
- - import_keyvalue_pairs
- - lempty
- - lmatch
- - lassign (consider to remove, as it overlaps for name and features
- with identical Tcl core command)
- - read_file
- - wrap
- - wrapline
- Changed 'makeurl' documentation to account for new features recently committed
+ * doc/xml/commands.xml: Add existing undocumented commands
+ - import_keyvalue_pairs
+ - lempty
+ - lmatch
+ - lassign (consider to remove, as it overlaps for name and features
+ with identical Tcl core command)
+ - read_file
+ - wrap
+ - wrapline
+ Changed 'makeurl' documentation to account for new features recently committed
2011-09-06 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: Add Id svn keyword.
- * src/apache-2/TclWebapache.c: Command load_env and load_headers now resolve
- the array name parameter following the default method (removed
- TCL_NAMESPACE_ONLY flag that prevented creation of an array in a
- proc's scope). Still default values for the arguments create such arrays
- in the ::request namespace
- * src/apache-2/rivetCode.c: preprocess macros ENV_ARRAY_NAME and HEADERS_ARRAY_NAME
- modified to explicitly put in ::request namespace the default arrays.
- Procedure Rivet_MakeURL chages so that command 'makeurl' now accepts
- relative paths and prepends them with the value of the SCRIPT_NAME environment
- variable. When run without arguments 'makeurl' returns the value in the
- SCRIPT_NAME env variable.
-
+ * src/apache-2/mod_rivet.c: Add Id svn keyword.
+ * src/apache-2/TclWebapache.c: Command load_env and load_headers now resolve
+ the array name parameter following the default method (removed
+ TCL_NAMESPACE_ONLY flag that prevented creation of an array in a
+ proc's scope). Still default values for the arguments create such arrays
+ in the ::request namespace
+ * src/apache-2/rivetCode.c: preprocess macros ENV_ARRAY_NAME and HEADERS_ARRAY_NAME
+ modified to explicitly put in ::request namespace the default arrays.
+ Procedure Rivet_MakeURL chages so that command 'makeurl' now accepts
+ relative paths and prepends them with the value of the SCRIPT_NAME environment
+ variable. When run without arguments 'makeurl' returns the value in the
+ SCRIPT_NAME env variable.
+
2011-06-03 Massimo Manghi <mx...@apache.org>
- * tclconfig/ltmain.sh: new version shipped with libtool
+ * tclconfig/ltmain.sh: new version shipped with libtool
2011-06-01 Massimo Manghi <mx...@apache.org>
- * tclconfig/libtool.m4: autoconf 2.68 has a new IF..ELSE.. statement in m4 macros and
- libtool.m4 needs to get along it. New version copied into tclconfig.
+ * tclconfig/libtool.m4: autoconf 2.68 has a new IF..ELSE.. statement in m4 macros and
+ libtool.m4 needs to get along it. New version copied into tclconfig.
2011-05-09 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: fixed misleading error message displayed when rivet_abort_script fails
+ * src/apache-2/mod_rivet.c: fixed misleading error message displayed when rivet_abort_script fails
2011-05-05 Massimo Manghi <mx...@apache.org>
- * configure.ac: APACHE_VERSION returns an error message for--with-apache-version=1.
- * src/apache-1/: removed from trunk
+ * configure.ac: APACHE_VERSION returns an error message for--with-apache-version=1.
+ * src/apache-1/: removed from trunk
2011-04-14 Massimo Manghi <mx...@apache.org>
- * src/Makefile.am,src/apache-2/Makefile.am: Add target install-data-hook with command line for
- removing unneeded .la files from target directories
- * configure.ac: doc/convert_examples.tcl is generated from template: added to AC_CONFIG_FILES
- * debian/changelog,debian/control: changed to reflect improvement in the script for Debian
+ * src/Makefile.am,src/apache-2/Makefile.am: Add target install-data-hook with command line for
+ removing unneeded .la files from target directories
+ * configure.ac: doc/convert_examples.tcl is generated from template: added to AC_CONFIG_FILES
+ * debian/changelog,debian/control: changed to reflect improvement in the script for Debian
2011-06-07 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl: because of bug #3216070 of Tcl we cannot preload rivetlib, so it doesn't make
- sense to import the rivet namespace, because we cannot have all the command set loaded in and
- an import has to be done for them in the application scripts
- * rivet/rivet-tcl/incr0.tcl: Tcl8.5 provides identical functionalities, so this command is
- now aliased in the interpreter by the native incr command.
- * rivet/rivet-tcl/tclIndex: recreated
+ * rivet/init.tcl: because of bug #3216070 of Tcl we cannot preload rivetlib, so it doesn't make
+ sense to import the rivet namespace, because we cannot have all the command set loaded in and
+ an import has to be done for them in the application scripts
+ * rivet/rivet-tcl/incr0.tcl: Tcl8.5 provides identical functionalities, so this command is
+ now aliased in the interpreter by the native incr command.
+ * rivet/rivet-tcl/tclIndex: recreated
2011-04-06 Massimo Manghi <mx...@apache.org>
- * configure.ac: Added doc/convert_examples.tcl to files created from its .in template
+ * configure.ac: Added doc/convert_examples.tcl to files created from its .in template
2011-04-03 Massimo Manghi <mx...@apache.org>
- * doc/convert_examples.tcl.in,doc/convert_examples.tcl: Added script to convert code examples
- from their native form to a sgml escaped form.
- * doc/Makefile.am: Target 'examples' added
- * doc/xml/install.xml: Expanded --with-apxs explanation.
- * doc/README: expanded with instructions for adding new examples to the docs.
+ * doc/convert_examples.tcl.in,doc/convert_examples.tcl: Added script to convert code examples
+ from their native form to a sgml escaped form.
+ * doc/Makefile.am: Target 'examples' added
+ * doc/xml/install.xml: Expanded --with-apxs explanation.
+ * doc/README: expanded with instructions for adding new examples to the docs.
2011-04-01 Massimo Manghi <mx...@apache.org>
- * doc/: new directory doc/examples-sgml. This is the directory where examples ready for inclusion
- in the manual must stay. The directory doc/examples is now meant to keep examples suitable for
- actual test and exectution
- * doc/convert_examples.tcl: New procedure that check for changes in doc/examples and, if needed,
- creates/recreates the corrisponding file in doc/examples-sgml escaping characters
+ * doc/: new directory doc/examples-sgml. This is the directory where examples ready for inclusion
+ in the manual must stay. The directory doc/examples is now meant to keep examples suitable for
+ actual test and exectution
+ * doc/convert_examples.tcl: New procedure that check for changes in doc/examples and, if needed,
+ creates/recreates the corrisponding file in doc/examples-sgml escaping characters
2011-03-03 Massimo Manghi <mx...@apache.org>
- * rivet/rivet-tcl/*.tcl: all the commands in here moved into ::rivet namespace. File tclIndex
- recreated
- * doc/xml/directives.xml,doc/xml/commands.tcl: Documentation changed to reflect the new scoping of
- the command set. Commands in rivet-tcl/ not yet documented have been briefly explained with some
- examples.
- * src/apache-2/mod_rivet.[c|h],src/apache-2/rivetCore.c: changes in trunk merged into the
- rivet-namespace branch
+ * rivet/rivet-tcl/*.tcl: all the commands in here moved into ::rivet namespace. File tclIndex
+ recreated
+ * doc/xml/directives.xml,doc/xml/commands.tcl: Documentation changed to reflect the new scoping of
+ the command set. Commands in rivet-tcl/ not yet documented have been briefly explained with some
+ examples.
+ * src/apache-2/mod_rivet.[c|h],src/apache-2/rivetCore.c: changes in trunk merged into the
+ rivet-namespace branch
2011-03-01 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCode.c: 'abort_code' command is now created through the RIVET_CMD_OBJ macro
+ * src/apache-2/rivetCode.c: 'abort_code' command is now created through the RIVET_CMD_OBJ macro
2011-02-18 Massimo Manghi <mx...@apache.org>
- * src/rivet.h,src/apache-2/rivetCore.c,src/rivetPkgInit.c: Core commands namespace is now '::rivet' and
- the package provided by the core module is "::rivet". Also package RivetLib was renamed as 'rivetlib'.
+ * src/rivet.h,src/apache-2/rivetCore.c,src/rivetPkgInit.c: Core commands namespace is now '::rivet' and
+ the package provided by the core module is "::rivet". Also package RivetLib was renamed as 'rivetlib'.
2011-02-14 Karl Lehenbauer <ka...@apache.org>
- * src/apache-2/mod_rivet.c: Only create root interpreter once, not twice.
- In Rivet_CopyConfig cache_size and cache_free were getting copied twice.
- Only once now.
- * src/apache-2/rivetCore.c: Remove unused command var from Rivet_Upload.
- Remove unneeded loglevel var from Rivet_LogErrorCmd.
+ * src/apache-2/mod_rivet.c: Only create root interpreter once, not twice.
+ In Rivet_CopyConfig cache_size and cache_free were getting copied twice.
+ Only once now.
+ * src/apache-2/rivetCore.c: Remove unused command var from Rivet_Upload.
+ Remove unneeded loglevel var from Rivet_LogErrorCmd.
2011-02-14 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.[h|c],src/apache-2/rivetCore.c: Removed loading of RivetLib by default. Getting
- RivetLib into the module keeps Apache to segfault in other calls. In order to gain access to commands
- provided by RivetLib (formerly called Rivet) a 'package require RivetLib' must be in a Rivet script or
- in one of the initialization script (e.g. ServerInitScript ChildInitScript or GlobalInitScript). Notice:
- RivetLib exports the commands to the '::Rivet' namespace.
- * src/rivetCrypt.c, src/rivetWWW.c, src/rivetList.c: they now export their commands to the '::Rivet'
+ * src/apache-2/mod_rivet.[h|c],src/apache-2/rivetCore.c: Removed loading of RivetLib by default. Getting
+ RivetLib into the module keeps Apache to segfault in other calls. In order to gain access to commands
+ provided by RivetLib (formerly called Rivet) a 'package require RivetLib' must be in a Rivet script or
+ in one of the initialization script (e.g. ServerInitScript ChildInitScript or GlobalInitScript). Notice:
+ RivetLib exports the commands to the '::Rivet' namespace.
+ * src/rivetCrypt.c, src/rivetWWW.c, src/rivetList.c: they now export their commands to the '::Rivet'
2011-02-11 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.[c|h]: new conf scripts rivet_abort_script and rivet_force_script. rivet_abort_script
- is run when an abort_page command is called in the page content generation
- * src/apache-2/rivetCode.c: add new command abort_code that returns the code passed to abort_page
+ * src/apache-2/mod_rivet.[c|h]: new conf scripts rivet_abort_script and rivet_force_script. rivet_abort_script
+ is run when an abort_page command is called in the page content generation
+ * src/apache-2/rivetCode.c: add new command abort_code that returns the code passed to abort_page
2011-02-08 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: call to Rivet_InitWWW to include into Rivet's core the commands provided in
- src/rivetWWW.c
- * src/apache-2/mod_rivet.c: the inclusion into the module of RivetLib through Tcl_PkgRequire proved
- to cause segfaults in Rivet_ServerConf. The commands in rivetWWW.c are temporarily loaded by rivetCore.c
- * src/apache-2/Makefile.am: build of mod_rivet.so includes also code from src/libWWW.o
+ * src/apache-2/rivetCore.c: call to Rivet_InitWWW to include into Rivet's core the commands provided in
+ src/rivetWWW.c
+ * src/apache-2/mod_rivet.c: the inclusion into the module of RivetLib through Tcl_PkgRequire proved
+ to cause segfaults in Rivet_ServerConf. The commands in rivetWWW.c are temporarily loaded by rivetCore.c
+ * src/apache-2/Makefile.am: build of mod_rivet.so includes also code from src/libWWW.o
2011-02-07 Massimo Manghi <mx...@apache.org>
- * branches/rivet-namespace: new branch to experiment with the Rivet namespace and Rivet package
- * src/rivetPkgInit.c: Provides RivetLib package now when loaded by mod_rivet. Commands are now
- in the ::Rivet namespace
- * src/rivet.h: new macro RIVET_OBJ_CMD creates a command in the ::Rivet namespace
- and puts the command object on the namespace export list
- * src/apache-2/mod_rivet.h: the globals structure now holds a pointer to the Tcl_Namespace object
- representing ::Rivet namespace
- * src/apache-2/rivetCore.c: commands are now created with the RIVET_OBJ_CMD macro
- * rivet/init.tcl: provides package RivetTcl 2.1. This makes possible to consistently peek the
- init.tcl associated to the module. Command 'incr0' is now aliased by Tcl standard 'incr'
- * rivet/apache-2/mod_rivet.c: Rivet_PerInterpInit loads package RivetTcl 2.1 and package RivetLib 1.2.
- the latter ships the commands in rivetWWW.c rivetCrypt.c and rivetList.c
- * rivet/rivet-tcl/tclIndex: Command 'incr0' removed (see init.tcl)
+ * branches/rivet-namespace: new branch to experiment with the Rivet namespace and Rivet package
+ * src/rivetPkgInit.c: Provides RivetLib package now when loaded by mod_rivet. Commands are now
+ in the ::Rivet namespace
+ * src/rivet.h: new macro RIVET_OBJ_CMD creates a command in the ::Rivet namespace
+ and puts the command object on the namespace export list
+ * src/apache-2/mod_rivet.h: the globals structure now holds a pointer to the Tcl_Namespace object
+ representing ::Rivet namespace
+ * src/apache-2/rivetCore.c: commands are now created with the RIVET_OBJ_CMD macro
+ * rivet/init.tcl: provides package RivetTcl 2.1. This makes possible to consistently peek the
+ init.tcl associated to the module. Command 'incr0' is now aliased by Tcl standard 'incr'
+ * rivet/apache-2/mod_rivet.c: Rivet_PerInterpInit loads package RivetTcl 2.1 and package RivetLib 1.2.
+ the latter ships the commands in rivetWWW.c rivetCrypt.c and rivetList.c
+ * rivet/rivet-tcl/tclIndex: Command 'incr0' removed (see init.tcl)
2011-01-31 Massimo Manghi <mx...@apache.org>
- * configure.ac: default value for directive SeparateVirtualInterps changed to 'yes'.
- * VERSION: version number set as 2.1.0r1 ('r' is for 'revision')
- * doc/xml/directives.xml: New directive ServerInitScript is documented.
+ * configure.ac: default value for directive SeparateVirtualInterps changed to 'yes'.
+ * VERSION: version number set as 2.1.0r1 ('r' is for 'revision')
+ * doc/xml/directives.xml: New directive ServerInitScript is documented.
2011-01-23 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.[c|h]: Created new ServerInitScript configuration directive: it assigns
- rivet_server_init_script with a script run in Rivet_InitHandler after configuration has been built and
- before server children are forked. A master interpreter is created in Rivet_InitHandler. Children
- interpreters should hopefully be pure clones of this interpreter created by 'fork'
+ * src/apache-2/mod_rivet.[c|h]: Created new ServerInitScript configuration directive: it assigns
+ rivet_server_init_script with a script run in Rivet_InitHandler after configuration has been built and
+ before server children are forked. A master interpreter is created in Rivet_InitHandler. Children
+ interpreters should hopefully be pure clones of this interpreter created by 'fork'
2011-01-09 Massimo Manghi <mx...@apache.org>
- * configure.ac: fixed AC_DEFINE_UNQUOTED macro call for definition of proprocessor symbol RIVET_MAX_POST,
- an integer valued symbol which was put in quotation marks. File indentation was fixed and tabs replaced with spaces
+ * configure.ac: fixed AC_DEFINE_UNQUOTED macro call for definition of proprocessor symbol RIVET_MAX_POST,
+ an integer valued symbol which was put in quotation marks. File indentation was fixed and tabs replaced with spaces
2010-12-03 Massimo Manghi <mx...@apache.org>
- * configure.ac: new macros to set default values of configuration parameters.
- * src/apache-2/mod_rivet.c,mod_rivet.h: Default values are set in rivet_config.h through autotools. The Tcl
- Rivet environment is now loaded from mod_rivet by calling Tcl_PackageRequire("RivetTcl","1.1"); after auto_path
- is properly set. Configuration scripts are now stored in Tcl_Obj objects
- * doc/xml/install.xml: Add documentation for new 'configure' switch.
- * rivet/init.tcl: the path to RIVETLIB_DESTDIR is added to auto_path in mod_rivet.
+ * configure.ac: new macros to set default values of configuration parameters.
+ * src/apache-2/mod_rivet.c,mod_rivet.h: Default values are set in rivet_config.h through autotools. The Tcl
+ Rivet environment is now loaded from mod_rivet by calling Tcl_PackageRequire("RivetTcl","1.1"); after auto_path
+ is properly set. Configuration scripts are now stored in Tcl_Obj objects
+ * doc/xml/install.xml: Add documentation for new 'configure' switch.
+ * rivet/init.tcl: the path to RIVETLIB_DESTDIR is added to auto_path in mod_rivet.
2010-12-02 Massimo Manghi <mx...@apache.org>
- * debian/libapache2-mod-rivet.*,debian/changelog: removed redundant lines from postist script (Debian package)
- * rivet/rivet-tcl/cookie.tcl: add command "cookie unset"
- * contrib/form.tcl,contrib/README: add a form.tcl based on TclOO. New README explanatory file
- * doc/xml/commands.xml: new command "cookie unset" explained
-
+ * debian/libapache2-mod-rivet.*,debian/changelog: removed redundant lines from postist script (Debian package)
+ * rivet/rivet-tcl/cookie.tcl: add command "cookie unset"
+ * contrib/form.tcl,contrib/README: add a form.tcl based on TclOO. New README explanatory file
+ * doc/xml/commands.xml: new command "cookie unset" explained
+
2010-10-27 Massimo Manghi <mx...@apache.org>
- * branches/2_0: changes done in branches 2_0 reintegrated into trunk. This implied the following changes in trunk
- * debian/[clean,docs,*.substvars,dirs,files,install]: not needed, hence removed from repository
- * debian/[changelog,copyright,rules]: files changed to produce a clean package out of the source tree
- * VERSION,configure.ac: version number bumped up to 2.0.2
- * doc/rivet-chunk.xsl: obsolete and misplaced copyright statement removed
+ * branches/2_0: changes done in branches 2_0 reintegrated into trunk. This implied the following changes in trunk
+ * debian/[clean,docs,*.substvars,dirs,files,install]: not needed, hence removed from repository
+ * debian/[changelog,copyright,rules]: files changed to produce a clean package out of the source tree
+ * VERSION,configure.ac: version number bumped up to 2.0.2
+ * doc/rivet-chunk.xsl: obsolete and misplaced copyright statement removed
2010-10-20 Massimo Manghi <mx...@apache.org>
- * debian/[clean,install,docs,dirs]: removed because not needed or redundant
- * debian/copyright: completed to include also the Tcl license. Added copyright notes for stuff in win/
+ * debian/[clean,install,docs,dirs]: removed because not needed or redundant
+ * debian/copyright: completed to include also the Tcl license. Added copyright notes for stuff in win/
2010-10-19 Massimo Manghi <mx...@apache.org>
- * debian/control,debian/Makefile.am: Minor adjustments to debian/control to fulfill Debian policy
- * debian/libapache2-mod-rivet-doc.docs: the 'contrib' directory is installed now in this package.
- * src/apache-2/rivetCore.c: In Rivet_ApacheTable the variable table is initialized to NULL to silence a
- compilation warning
- * doc/Makefile.am: the 'distclean' target must remove the Makefile
- * Makefile.am: rivet_config.h removal added to 'distclean-local'
+ * debian/control,debian/Makefile.am: Minor adjustments to debian/control to fulfill Debian policy
+ * debian/libapache2-mod-rivet-doc.docs: the 'contrib' directory is installed now in this package.
+ * src/apache-2/rivetCore.c: In Rivet_ApacheTable the variable table is initialized to NULL to silence a
+ compilation warning
+ * doc/Makefile.am: the 'distclean' target must remove the Makefile
+ * Makefile.am: rivet_config.h removal added to 'distclean-local'
2010-10-18 Massimo Manghi <mx...@apache.org>
- * rivet/packages/tclrivet/parse.tcl: add svn:executable property as suggested by the debian consistency scripts
- * debian/*: more changes to remove unnecessary files from the binary packages of Debian
+ * rivet/packages/tclrivet/parse.tcl: add svn:executable property as suggested by the debian consistency scripts
+ * debian/*: more changes to remove unnecessary files from the binary packages of Debian
2010-10-14 Massimo Manghi <mx...@apache.org>
- * debian/: more adjustments in the way of getting a working setup for Debian. Some information was moved to make
- it 'package specific'. More tweaking on debian/control and /debian/changelog
+ * debian/: more adjustments in the way of getting a working setup for Debian. Some information was moved to make
+ it 'package specific'. More tweaking on debian/control and /debian/changelog
2010-10-13 Massimo Manghi <mx...@apache.org>
- * src/buildscripts: trying to keep the source tree as tidy as possible. src/buildscripts/* are removed because they were\
- then initial and later abandoned Rivet build scripts
- * branches/2_0/src/buildscripts: removed also from the branch development
- * branches/2_0/debian/*: merging the debian scripts largely rewritten in trunk. Added control files to
- build 2 packages for debian (binary module and docs)
+ * src/buildscripts: trying to keep the source tree as tidy as possible. src/buildscripts/* are removed because they were\
+ then initial and later abandoned Rivet build scripts
+ * branches/2_0/src/buildscripts: removed also from the branch development
+ * branches/2_0/debian/*: merging the debian scripts largely rewritten in trunk. Added control files to
+ build 2 packages for debian (binary module and docs)
2010-10-11 Massimo Manghi <mx...@apache.org>
- * tclconfig/config.sub,tclconfig/config.guess: Debian package build system signalled that these 2 files were too old
- and suggested to update them with newer versions shipped by automake-1.11
- * debian/*: various stuff was changed trying to shape scripts to make debian packages as uneventful as possible
- * doc/Makefile.am: The 'clean' target in doc/Makefile was renamed as 'distclean'. HTML files are deleted only when
- a deep cleaning is required.
+ * tclconfig/config.sub,tclconfig/config.guess: Debian package build system signalled that these 2 files were too old
+ and suggested to update them with newer versions shipped by automake-1.11
+ * debian/*: various stuff was changed trying to shape scripts to make debian packages as uneventful as possible
+ * doc/Makefile.am: The 'clean' target in doc/Makefile was renamed as 'distclean'. HTML files are deleted only when
+ a deep cleaning is required.
2010-10-07 Massimo Manghi <mx...@apache.org>
- * debian/*: various changes that fix some consistency faults in the debian packages
+ * debian/*: various changes that fix some consistency faults in the debian packages
2010-10-06 Massimo Manghi <mx...@apache.org>
- * debian/*: most files in this directory have been modified to comply with the latest version of debian packaging
- system. Some files were deleted because superseded by others which have been added to produce 2 separate
- packages: one for the module and the Tcl library, the other for the html manual.
+ * debian/*: most files in this directory have been modified to comply with the latest version of debian packaging
+ system. Some files were deleted because superseded by others which have been added to produce 2 separate
+ packages: one for the module and the Tcl library, the other for the html manual.
2010-09-20 Massimo Manghi <mx...@apache.org>
- * debian/*: changing some info in files needed by the debian
+ * debian/*: changing some info in files needed by the debian
2010-09-18 Massimo Manghi <mx...@apache.org>
- * debian/*: files modified and added in the process to build a debian package
- * doc/Makefile.am: comments added. Better target handling
+ * debian/*: files modified and added in the process to build a debian package
+ * doc/Makefile.am: comments added. Better target handling
2010-09-15 Massimo Manghi <mx...@apache.org>
- * debian/README.Debian, debian/rivet.load: add files needed to build a Debian package
- * debian/rules, debian/changelog, debian/control: experimental versions of files needed by .deb packages
+ * debian/README.Debian, debian/rivet.load: add files needed to build a Debian package
+ * debian/rules, debian/changelog, debian/control: experimental versions of files needed by .deb packages
2010-09-14 Massimo Manghi <mx...@apache.org>
- * doc/html/*: directory removed from repository
- * doc/Makefile.am: New targets for creating the doc/html/ directory and copying new or modified graphic files from
- doc/images to doc/html/images
+ * doc/html/*: directory removed from repository
+ * doc/Makefile.am: New targets for creating the doc/html/ directory and copying new or modified graphic files from
+ doc/images to doc/html/images
2010-08-30 Massimo Manghi <mx...@apache.org>
- * doc/images: Graphics displayed in the manual is copied in this directory. This is a first step in the transition
- to a manual generation procedure that should achieve a cleaner repository structure
+ * doc/images: Graphics displayed in the manual is copied in this directory. This is a first step in the transition
+ to a manual generation procedure that should achieve a cleaner repository structure
2010-08-26 Massimo Manghi <mx...@apache.org>
- * configure.ac: removed AC_DEFINE(BUILD_rivet....) as the tcl.m4 providing TEA 3.9
- makes redundant this definition. Argument to TEA_INIT changed accordingly
- * tclconfig/tcl.m4: overwritten by the new tcl.m4 and made a couple of adjustments that make it autoreconf/autoheader
- friendly.
+ * configure.ac: removed AC_DEFINE(BUILD_rivet....) as the tcl.m4 providing TEA 3.9
+ makes redundant this definition. Argument to TEA_INIT changed accordingly
+ * tclconfig/tcl.m4: overwritten by the new tcl.m4 and made a couple of adjustments that make it autoreconf/autoheader
+ friendly.
2010-07-20 Massimo Manghi <mx...@apache.org>
- * doc/examples/rivet_web_service.tcl,doc/html/*.html: Improved example of Ajax servlet.
- Manual changed accordingly.
+ * doc/examples/rivet_web_service.tcl,doc/html/*.html: Improved example of Ajax servlet.
+ Manual changed accordingly.
2010-07-18 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: static void ap_chdir_file renamed as static int Rivet_chdir_file. Rivet_chdir_file
- returns the value returned by chdir. This value is checked and in case of error the request
- aborts with an HTTP_INTERNAL_ERROR and a message is printed in the log file.
- * VERSION,configure.ac: version number changes as 2.0.1 (temporarily)
-
+ * src/apache-2/mod_rivet.c: static void ap_chdir_file renamed as static int Rivet_chdir_file. Rivet_chdir_file
+ returns the value returned by chdir. This value is checked and in case of error the request
+ aborts with an HTTP_INTERNAL_ERROR and a message is printed in the log file.
+ * VERSION,configure.ac: version number changes as 2.0.1 (temporarily)
+
2010-07-13 Massimo Manghi <mx...@apache.org>
- * doc/rivet.xml,doc/html/*.html: Latest minor changes before releasing
- * VERSION,configure.ac: Release number changed as 2.0.1
+ * doc/rivet.xml,doc/html/*.html: Latest minor changes before releasing
+ * VERSION,configure.ac: Release number changed as 2.0.1
2010-07-12 Massimo Manghi <mx...@apache.org>
- * branches/2_0: Merge of trunk changes into the 2_0 branch.
+ * branches/2_0: Merge of trunk changes into the 2_0 branch.
2010-07-12 Massimo Manghi <mx...@apache.org>
- * rivet/packages/calendar/calendar.tcl: new comments added. Fixed misspelled -errorinfo option
- in a return statement.
- * rivet/packages/session/session-create.sql: columns 'key' and 'package' are renamed as 'key_" and
- 'package_'.
- * rivet/packages/dio/dio_Postgresql.tcl: fixed typo in variable name
- * doc/xml/calendar.xml: More correction made on calendar.xml
- * doc/html/*.html: The whole manual has been rebuilt with the latest changes
+ * rivet/packages/calendar/calendar.tcl: new comments added. Fixed misspelled -errorinfo option
+ in a return statement.
+ * rivet/packages/session/session-create.sql: columns 'key' and 'package' are renamed as 'key_" and
+ 'package_'.
+ * rivet/packages/dio/dio_Postgresql.tcl: fixed typo in variable name
+ * doc/xml/calendar.xml: More correction made on calendar.xml
+ * doc/html/*.html: The whole manual has been rebuilt with the latest changes
2010-07-07 Massimo Manghi <mx...@apache.org>
- * INSTALL: improved installation instructions before merging trunk into branches/2_0
+ * INSTALL: improved installation instructions before merging trunk into branches/2_0
2010-07-03 Massimo Manghi <mx...@apache.org>
- * rivet/package/calendar/calendar.tcl: Add check on tcl version. If Tcl8.4 is being used
- we also need 'dict' backport as Calendar uses a dictionary to store some internal
- data.
- * doc/xml/calendar.xml: Wrong header corrected. Added explicit note about the requirements
- of the package
+ * rivet/package/calendar/calendar.tcl: Add check on tcl version. If Tcl8.4 is being used
+ we also need 'dict' backport as Calendar uses a dictionary to store some internal
+ data.
+ * doc/xml/calendar.xml: Wrong header corrected. Added explicit note about the requirements
+ of the package
2010-07-03 Massimo Manghi <mx...@apache.org>
- * rivet/packages/calendar/calendar.tcl: Fixed indentation in weekdays row
- * doc/html/: Manual pages regenerated to include latest changes in section about package Calendar
+ * rivet/packages/calendar/calendar.tcl: Fixed indentation in weekdays row
+ * doc/html/: Manual pages regenerated to include latest changes in section about package Calendar
2010-07-02 Massimo Manghi <mx...@apache.org>
- * rivet/packages/calendar/calendar.tcl: Add experimental package Calendar
+ * rivet/packages/calendar/calendar.tcl: Add experimental package Calendar
2010-07-02 Massimo Manghi <mx...@apache.org>
- * doc/html/calendar.html, doc/html/xml_calendar.html: Add html manual pages for Calendar
- * doc/xml/calendar.xml: more changes to calendar.xml
+ * doc/html/calendar.html, doc/html/xml_calendar.html: Add html manual pages for Calendar
+ * doc/xml/calendar.xml: more changes to calendar.xml
2010-07-02 Massimo Manghi <mx...@apache.org>
- * doc/xml/calendar.xml: Add manual page for package Calendar (package still to be
- added to repository)
- * doc/xml/form.xml: Page for package 'form' written with a more structured
- docbook organization that allows finer styling of a manual page.
- * doc/rivet.xsl: Add xsl configurations for elements refsect1,refsect2 and
- refsect3
- * configure.ac: Add message when building for Apache 1.x
+ * doc/xml/calendar.xml: Add manual page for package Calendar (package still to be
+ added to repository)
+ * doc/xml/form.xml: Page for package 'form' written with a more structured
+ docbook organization that allows finer styling of a manual page.
+ * doc/rivet.xsl: Add xsl configurations for elements refsect1,refsect2 and
+ refsect3
+ * configure.ac: Add message when building for Apache 1.x
2010-07-01 Massimo Manghi <mx...@apache.org>
- * doc/xml/Makefile.am: removed target 'html/rivet.html" from 'docs' depends. The no-chunks version
- of the manual can be build running 'make docs-nochunk'
+ * doc/xml/Makefile.am: removed target 'html/rivet.html" from 'docs' depends. The no-chunks version
+ of the manual can be build running 'make docs-nochunk'
2010-06-30 Massimo Manghi <mx...@apache.org>
- * doc/xml/form.xml: Add 'checkbox' subcommand documentation
- * doc/html/*.html: Updated manual pages
+ * doc/xml/form.xml: Add 'checkbox' subcommand documentation
+ * doc/html/*.html: Updated manual pages
2010-06-30 Massimo Manghi <mx...@apache.org>
- * rivet/packages/form/form.tcl: fixed various methods in package form: 'field' method must
- treat checkboxes and radiobuttons alike, so that labels are printed next to the button.
- 'radiobuttons' specialized method should not propagate the '-labels' switch to the attributes
- of the tag.
- * doc/rivet.xml: add new documentation in file doc/xml/form.xml
- * doc/xml/form.xml: add to repository
- * doc/html/form.html,doc/html/form_package.html: add to repository
- * doc/html/*.html: new manual pages including the form package
+ * rivet/packages/form/form.tcl: fixed various methods in package form: 'field' method must
+ treat checkboxes and radiobuttons alike, so that labels are printed next to the button.
+ 'radiobuttons' specialized method should not propagate the '-labels' switch to the attributes
+ of the tag.
+ * doc/rivet.xml: add new documentation in file doc/xml/form.xml
+ * doc/xml/form.xml: add to repository
+ * doc/html/form.html,doc/html/form_package.html: add to repository
+ * doc/html/*.html: new manual pages including the form package
2010-06-22 Massimo Manghi <mx...@apache.org>
- * Makefile.am: Rivet install target deletes every pkgIndex.tcl file that might have been
- left around in the Rivet directory tree, before calling pkg_mkIndex.tcl to regenerate
- the library index file in the root directory.
- * rivet/packages/tclrivet/parse.tcl,rivet/packages/commserver/server.tcl: add existence test on
- argv variable that wept during the installation process. If not set exits silently (variable is
- required for a sensible use of the procedures)
- * rivet/packages/tclrivet/tclrivet.tcl: wrong path to librivetparser.[so|dll] corrected
-
+ * Makefile.am: Rivet install target deletes every pkgIndex.tcl file that might have been
+ left around in the Rivet directory tree, before calling pkg_mkIndex.tcl to regenerate
+ the library index file in the root directory.
+ * rivet/packages/tclrivet/parse.tcl,rivet/packages/commserver/server.tcl: add existence test on
+ argv variable that wept during the installation process. If not set exits silently (variable is
+ required for a sensible use of the procedures)
+ * rivet/packages/tclrivet/tclrivet.tcl: wrong path to librivetparser.[so|dll] corrected
+
2010-06-19 Massimo Manghi <mx...@apache.org>
- * src/apache-2/mod_rivet.c: filled SERVER_CONF variable in the 'server' array with value generated
- by the build system of the directory holding the conf files.
- This fulfills a TODO comment in the code. The array server is undocumented and is not clear if it was
- added for the benefit of the programmer or for debugging of the module.
- * src/apache-2/mod_rivet.h: structure definitions beautified and aligned.
+ * src/apache-2/mod_rivet.c: filled SERVER_CONF variable in the 'server' array with value generated
+ by the build system of the directory holding the conf files.
+ This fulfills a TODO comment in the code. The array server is undocumented and is not clear if it was
+ added for the benefit of the programmer or for debugging of the module.
+ * src/apache-2/mod_rivet.h: structure definitions beautified and aligned.
2010-05-14 Massimo Manghi <mx...@apache.org>
- * BUGS,INSTALL,Changelog: small improvements in the documentation
+ * BUGS,INSTALL,Changelog: small improvements in the documentation
2010-05-14 Massimo Manghi <mx...@apache.org>
- * tclconfig/install-sh: the install-sh script is replaced with the same script shipped with automake-1.11
+ * tclconfig/install-sh: the install-sh script is replaced with the same script shipped with automake-1.11
2010-05-13 Massimo Manghi <mx...@apache.org>
- * src/apache-1/TclWebapache.c: call to ap_send_http_headers centralized in TclWeb_SendHeaders
- * src/apache-2/TclWebapache.c: bugfix for string assigned to the content_type field that has to
+ * src/apache-1/TclWebapache.c: call to ap_send_http_headers centralized in TclWeb_SendHeaders
+ * src/apache-2/TclWebapache.c: bugfix for string assigned to the content_type field that has to
be duplicated to preserve from memory deallocation by Tcl, includes to modules from apache APR
library added, call to ap_send_http_headers centralized in TclWeb_SendHeaders
2010-04-29 Massimo Manghi <mx...@apache.org>
- * src/apache-2/apache_multipart_buffer.c: Add include <apr_string.h> to silence a compilation
- warning.
- * src/apache-2/apache_multipart_buffer.h: set svn property to enable $Id: keyword expansion
- * doc/xml/session.xml: Commented line about a 'CookieDomain' command of Session that appears to
- be non coded yet. To be added to the TODO file.
+ * src/apache-2/apache_multipart_buffer.c: Add include <apr_string.h> to silence a compilation
+ warning.
+ * src/apache-2/apache_multipart_buffer.h: set svn property to enable $Id: keyword expansion
+ * doc/xml/session.xml: Commented line about a 'CookieDomain' command of Session that appears to
+ be non coded yet. To be added to the TODO file.
2010-04-29 Massimo Manghi <mx...@apache.org>
- * configure.ac,VERSION: Pre-branching operations: AC_INIT now uses 2.0.0 as version number
- to be used across the build system. Also the file VERSION has been updated to reflect the
- release number.
+ * configure.ac,VERSION: Pre-branching operations: AC_INIT now uses 2.0.0 as version number
+ to be used across the build system. Also the file VERSION has been updated to reflect the
+ release number.
2010-04-27 Massimo Manghi <mx...@apache.org>
- * src/apache-1/TclWebapache.c,src/apache-1/rivetCore.c,src/apache-1/mod_rivet.c,
- src/apache-1/apache_request.c,src/apache-1/apache_multipart_buffer.c: changes and
- additions made for apache 2 added to the code for apache 1.x
+ * src/apache-1/TclWebapache.c,src/apache-1/rivetCore.c,src/apache-1/mod_rivet.c,
+ src/apache-1/apache_request.c,src/apache-1/apache_multipart_buffer.c: changes and
+ additions made for apache 2 added to the code for apache 1.x
2010-04-22 Massimo Manghi <mx...@apache.org>
- * rivet/init.tcl: add to auto_path the directory where init.tcl is located, as this
- is also the directory for package Rivet
+ * rivet/init.tcl: add to auto_path the directory where init.tcl is located, as this
+ is also the directory for package Rivet
2010-04-19 Massimo Manghi <mx...@apache.org>
- * tests/upload.[rvt|test]: fix upload message sent to server. The end boundary
+ * tests/upload.[rvt|test]: fix upload message sent to server. The end boundary
went undetected and Rivet added it to the uploaded file. Thus the problem
affected only the test, not the module. Added delimiter to the returned
message to allow easy spotting of an empty string.
2009-12-08 Karl Lehenbauer <ka...@apache.org>
- * rivet/packages/form/form.tcl, form.txt: Add new form methods for HTML 5
- form elements "color", "date", "datetime", "datetime_local", "email",
- "file", "image", "month", "number", "range", "search", "tel", "time",
- "url", "week"
+ * rivet/packages/form/form.tcl, form.txt: Add new form methods for HTML 5
+ form elements "color", "date", "datetime", "datetime_local", "email",
+ "file", "image", "month", "number", "range", "search", "tel", "time",
+ "url", "week"
2009-11-03 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCore.c: in function Rivet_Upload the list of subcommands
- had 2 entries for 'tempname" leading Tcl_GetIndexfromObject to mismatch the entry for
- the 'names' subcommand with its numerical counterpart.
- This caused the child process to segfault when processing a 'upload names' command.
+ * src/apache-2/rivetCore.c: in function Rivet_Upload the list of subcommands
+ had 2 entries for 'tempname" leading Tcl_GetIndexfromObject to mismatch the entry for
+ the 'names' subcommand with its numerical counterpart.
+ This caused the child process to segfault when processing a 'upload names' command.
2009-11-02 Massimo Manghi <mx...@apache.org>
- * tests/apachetest/apachetest.tcl: apachetest::getallincludes failed to
- properly handle glob style file patterns.
+ * tests/apachetest/apachetest.tcl: apachetest::getallincludes failed to
+ properly handle glob style file patterns.
2009-09-17 Karl Lehenbauer <ka...@apache.org>
- * rivet/packages/form/form.tcl, form.txt: Add a new form method, "button",
- that's just like "submit" except pressing enter doesn't cause it to be
- invoked. Add quick doc, form.txt, on the forms package.
+ * rivet/packages/form/form.tcl, form.txt: Add a new form method, "button",
+ that's just like "submit" except pressing enter doesn't cause it to be
+ invoked. Add quick doc, form.txt, on the forms package.
- Terminate <option> with </option> in form selectors.
+ Terminate <option> with </option> in form selectors.
2009-09-15 Karl Lehenbauer <ka...@apache.org>
- * rivet/packages/form/form.tcl: If the array containing default values
- for the form is passed in when the form is created
- (for instance: form myform -defaults response -method post),
- make sure form classes public variable "defaults" is set to
- that array name.
+ * rivet/packages/form/form.tcl: If the array containing default values
+ for the form is passed in when the form is created
+ (for instance: form myform -defaults response -method post),
+ make sure form classes public variable "defaults" is set to
+ that array name.
2009-09-03 Karl Lehenbauer <ka...@apache.org>
- * src/apache-2/rivetCore.c: Add new command, apache_log_error, which
- allows consistent logging to the Apache error log file.
+ * src/apache-2/rivetCore.c: Add new command, apache_log_error, which
+ allows consistent logging to the Apache error log file.
2009-06-24 Karl Lehenbauer <ka...@apache.org>
- * acinclude.m4: Include m4/ax_prefix_config_h.m4 to define the
- AX_PREFIX_CONFIG_H macro.
+ * acinclude.m4: Include m4/ax_prefix_config_h.m4 to define the
+ AX_PREFIX_CONFIG_H macro.
- * tclconfig/libtool.m4, tclconfig/config.guess, tclconfig/config.sub,
- tclconfig/ltmain.sh: Freshened these files with the latest versions
- from libtool.
+ * tclconfig/libtool.m4, tclconfig/config.guess, tclconfig/config.sub,
+ tclconfig/ltmain.sh: Freshened these files with the latest versions
+ from libtool.
- * configure.ac, tclconfig/tcl.m4, tclconfig/ChangeLog,
- tclconfig/README.txt, tclconfig/install-sh: Updated to Tcl Extension
- Architecture (TEA) 3.7.
+ * configure.ac, tclconfig/tcl.m4, tclconfig/ChangeLog,
+ tclconfig/README.txt, tclconfig/install-sh: Updated to Tcl Extension
+ Architecture (TEA) 3.7.
2009-05-05 Karl Lehenbauer <ka...@apache.org>
- * src/apache-2/mod_rivet.c: When Rivet is shutting down and per-vhost
- separate virtual interpreters were in use, the shutdown code deleted
- the master interpreter and all of the slave interpreters using
- Tcl_DepeteInterp(). This was an error as it should only delete the
- mater interpreter, as deleting the master interpreter causes its
- slaves to be deleted. It now does this. (Had it checked using
- Tcl_InterpDeleted to see if the interpreter was already marked as
- deleted, it probably would have been OK.)
+ * src/apache-2/mod_rivet.c: When Rivet is shutting down and per-vhost
+ separate virtual interpreters were in use, the shutdown code deleted
+ the master interpreter and all of the slave interpreters using
+ Tcl_DepeteInterp(). This was an error as it should only delete the
+ mater interpreter, as deleting the master interpreter causes its
+ slaves to be deleted. It now does this. (Had it checked using
+ Tcl_InterpDeleted to see if the interpreter was already marked as
+ deleted, it probably would have been OK.)
- * src/rivetChannel.c - update Tcl channel handler to channel version 4.
+ * src/rivetChannel.c - update Tcl channel handler to channel version 4.
2009-05-05 Karl Lehenbauer <ka...@apache.org>
- * Add new Rivet Tcl command,apache_table, which can query, get and set
- values in the Apache "notes", "headers_in", "headers_out",
- "err_headers_out" and "subprocess_env" tables.
+ * Add new Rivet Tcl command,apache_table, which can query, get and set
+ values in the Apache "notes", "headers_in", "headers_out",
+ "err_headers_out" and "subprocess_env" tables.
- * Add new "upload" option "tempname" that'll return the name of the
- temporary file containing the upload.
+ * Add new "upload" option "tempname" that'll return the name of the
+ temporary file containing the upload.
- * When instantiating separate virtual interpreters, postpend an interpreter
- count to the self-created slave interpreter name, to keep
- Tcl_CreateSlave from failing if two or more virtual hosts have the same
- ServerName and don't have a port defined in the ServerName directive.
+ * When instantiating separate virtual interpreters, postpend an interpreter
+ count to the self-created slave interpreter name, to keep
+ Tcl_CreateSlave from failing if two or more virtual hosts have the same
+ ServerName and don't have a port defined in the ServerName directive.
- * Detect and report failure of Tcl_CreateSlave rather than assuming it
- succeeded and dereferencing a null pointer when it didn't. Also added
- asserts to detect null interpreter pointer.
+ * Detect and report failure of Tcl_CreateSlave rather than assuming it
+ succeeded and dereferencing a null pointer when it didn't. Also added
+ asserts to detect null interpreter pointer.
- * Slightly improved error messages when a child init or exit function
- fails.
+ * Slightly improved error messages when a child init or exit function
+ fails.
2009-05-01 Karl Lehenbauer <ka...@apache.org>
- * Rename global request rec pointer from globalrr to
- rivet_panic_request_rec, add rivet_panic_pool and
- rivet_panic_server_rec, grabbing those values from Rivet initialization
- rather than request handling so that they are initialized enough that
- Rivet_Panic can use them. (Previously Rivet_Panic or Tcl_Panic at
- initialization time caused a null-pointer-dereference segmentation
- violation because no request was being served.
+ * Rename global request rec pointer from globalrr to
+ rivet_panic_request_rec, add rivet_panic_pool and
+ rivet_panic_server_rec, grabbing those values from Rivet initialization
+ rather than request handling so that they are initialized enough that
+ Rivet_Panic can use them. (Previously Rivet_Panic or Tcl_Panic at
+ initialization time caused a null-pointer-dereference segmentation
+ violation because no request was being served.
- In Rivet_Panic, avoid emitting the unparsed URI unless a request is
- being processed.
+ In Rivet_Panic, avoid emitting the unparsed URI unless a request is
+ being processed.
2009-04-27 Karl Lehenbauer <ka...@apache.org>
- * src/apache-2/mod_rivet.c: In Rivet_SendContent, when checking to see
- if the file doesn't exist, check r->finfo.filetype rather than
- r->finfo.protection. (The prior check failed to detect that the
- Rivet source file did not exist, causing zero length webpages to
- be sent rather than 404's.)
+ * src/apache-2/mod_rivet.c: In Rivet_SendContent, when checking to see
+ if the file doesn't exist, check r->finfo.filetype rather than
+ r->finfo.protection. (The prior check failed to detect that the
+ Rivet source file did not exist, causing zero length webpages to
+ be sent rather than 404's.)
2009-01-16 Massimo Manghi <mx...@apache.org>
- * Makefile.am: Add DESTLIB variable handling as suggested
- by kikusz@gmail.com and accordingly with Automake directives
- for local install rules.
+ * Makefile.am: Add DESTLIB variable handling as suggested
+ by kikusz@gmail.com and accordingly with Automake directives
+ for local install rules.
2008-12-21 Massimo Manghi <mx...@apache.org>
- * src/apache-2/rivetCode.c: add handling for subcommand
- 'tempname'
+ * src/apache-2/rivetCode.c: add handling for subcommand
+ 'tempname'
2008-12-15 Massimo Manghi <mx...@apache.org>
- * src/apache-2/TclWebapache.c: fixed test on configuaration
- flag 'upload_files_to_var'
+ * src/apache-2/TclWebapache.c: fixed test on configuaration
+ flag 'upload_files_to_var'
2008-12-11 Massimo Manghi <mx...@apache.org>
-
- * src/apache-2/mod_rivet.c: fixed call to apr_strcat in function
- Rivet_ExecuteAndCheck (the corresponding call in the apache-1 code
- has been checked and appears to be correct).
-
- * doc/xml/internals.xml: Removed broken external link pointing
- to a no more existing gdb tutorial.
+
+ * src/apache-2/mod_rivet.c: fixed call to apr_strcat in function
+ Rivet_ExecuteAndCheck (the corresponding call in the apache-1 code
+ has been checked and appears to be correct).
+
+ * doc/xml/internals.xml: Removed broken external link pointing
+ to a no more existing gdb tutorial.
2008-12-03 Massimo Manghi <mx...@apache.org>
- * doc/rivet.xml: document timestamp is generated with the
- EXSLT datetime() function controlled through the <?dbtimestamp ...?>
- element. The timestamp now reflects the actual time when the xsl
- processor is run, instead of time when the svn commit is carried out.
+ * doc/rivet.xml: document timestamp is generated with the
+ EXSLT datetime() function controlled through the <?dbtimestamp ...?>
+ element. The timestamp now reflects the actual time when the xsl
+ processor is run, instead of time when the svn commit is carried out.
- * doc/rivet.xsl: customization added to make a list of examples
- appear at the end of the table of contents.
+ * doc/rivet.xsl: customization added to make a list of examples
+ appear at the end of the table of contents.
- * doc/html/*.html: manual pages rebuilt and committed to repository
+ * doc/html/*.html: manual pages rebuilt and committed to repository
2008-11-21 Massimo Manghi <mx...@apache.org>
- * doc/rivet.xml: file broken up into chunks containing the toplevel
- sections of the manual. For every file an xml entity was created.
+ * doc/rivet.xml: file broken up into chunks containing the toplevel
+ sections of the manual. For every file an xml entity was created.
- * doc/xml/*.xml: added xml files containing every toplevel section of
- the manual.
+ * doc/xml/*.xml: added xml files containing every toplevel section of
+ the manual.
- * doc/Makefile.am: added dependency from xml/*.xml for html pages
- generation
+ * doc/Makefile.am: added dependency from xml/*.xml for html pages
+ generation
2008-11-17 Karl Lehenbauer <ka...@apache.org>
- * src/apache-2/TclWebapache.c: Make TclWeb_UploadChannel open the
- uploaded file and make the file handle available through standard Tcl
- mechanisms, removing OS depdendencies.
+ * src/apache-2/TclWebapache.c: Make TclWeb_UploadChannel open the
+ uploaded file and make the file handle available through standard Tcl
+ mechanisms, removing OS depdendencies.
- Make TclWeb_UploadData access the uploaded file through standard
- Tcl mechanisms, making the uploaded data available and also removing
- OS dependencies.
+ Make TclWeb_UploadData access the uploaded file through standard
+ Tcl mechanisms, making the uploaded data available and also removing
+ OS dependencies.
- Add TclWeb_UploadTempname to get the name of the temp file the
- uploaded file was saved to.
+ Add TclWeb_UploadTempname to get the name of the temp file the
+ uploaded file was saved to.
- Include apr_strings.h to remove compiler warning of implicit
- definitions of apr_pstrdup and apr_psprintf as well as multiple
- warnings about casts to pointer from integer of different size.
+ Include apr_strings.h to remove compiler warning of implicit
+ definitions of apr_pstrdup and apr_psprintf as well as multiple
+ warnings about casts to pointer from integer of different size.
- Force rsc->upload_files_to_var to be set, temporarily, pending figuring
- out why the configuration directive to set that is not working.
+ Force rsc->upload_files_to_var to be set, temporarily, pending figuring
+ out why the configuration directive to set that is not working.
- * src/apache-2/rivetCore.c: Check return from Tcl_GetIndexFromObj call
- in "upload" command processing (Rivet_Upload command). Return an error
- when the subcommand (channel, save, data, exists, size, type, filename,
- tempname, or names) is invalid.
+ * src/apache-2/rivetCore.c: Check return from Tcl_GetIndexFromObj call
+ in "upload" command processing (Rivet_Upload command). Return an error
+ when the subcommand (channel, save, data, exists, size, type, filename,
+ tempname, or names) is invalid.
- Add "tempname" option to "upload" command. "upload tempname" will
- return the name of the temporary file a file uploaded via a
- POST command was saved to.
+ Add "tempname" option to "upload" command. "upload tempname" will
+ return the name of the temporary file a file uploaded via a
+ POST command was saved to.
- * src/apache-2/mod_rivet.c: Change "char *" arguments to
- Rivet_ServerConf, Rivet_DirConf and Rivet_UserConf to be
- "const char *" to bring them in line with what Apache expects,
- fixing compiler warnings warnings about "assignment discards qualifiers
- from pointer target type".
+ * src/apache-2/mod_rivet.c: Change "char *" arguments to
+ Rivet_ServerConf, Rivet_DirConf and Rivet_UserConf to be
+ "const char *" to bring them in line with what Apache expects,
+ fixing compiler warnings warnings about "assignment discards qualifiers
+ from pointer target type".
- Use a "void *" argument where expected in calls to AP_INIT_TAKE2
- for Rivet_DirConf and Rivet_UserConf and do an assigment to the
- Rivet-desired types of rivet_server_conf to eliminate
- "initialization from incompatible pointer type" compiler warnings.
+ Use a "void *" argument where expected in calls to AP_INIT_TAKE2
+ for Rivet_DirConf and Rivet_UserConf and do an assigment to the
+ Rivet-desired types of rivet_server_conf to eliminate
+ "initialization from incompatible pointer type" compiler warnings.
- Make Rivet_SetScript's script and string arguments be const char *
- instead of char *.
+ Make Rivet_SetScript's script and string arguments be const char *
+ instead of char *.
- * src/apache-2/apache_request.c: Change "char *error[1024]"
- to "char error[1024]" to fix "incompatible pointer type" error
- in the call to apr_strerror.
+ * src/apache-2/apache_request.c: Change "char *error[1024]"
+ to "char error[1024]" to fix "incompatible pointer type" error
+ in the call to apr_strerror.
- * src/apache-2/apache_request.h - make temp_dir be a const char *
- instead of a char *.
+ * src/apache-2/apache_request.h - make temp_dir be a const char *
+ instead of a char *.
- * src/apache-2/apache_multipart_buffer.c: Add include of apr_strings.h
- to remove compiler warning of implicit definitions of apr_pstrcat and
- warnings about casts to pointer from integer of different size (which
- occurred on 64-bit machines, anyway.)
+ * src/apache-2/apache_multipart_buffer.c: Add include of apr_strings.h
+ to remove compiler warning of implicit definitions of apr_pstrcat and
+ warnings about casts to pointer from integer of different size (which
+ occurred on 64-bit machines, anyway.)
- * doc/rivet.xml: added the "tempname" option to "upload".
+ * doc/rivet.xml: added the "tempname" option to "upload".
2008-11-13 Massimo Manghi <mx...@apache.org>
@@ -3146,7 +3150,7 @@
* src/apache-2/apache_multipart_buffer.c, src/apache-2/rivetCore.c,
src/apache-2/TclWebapache.c,src/rivetChannel.c,src/rivetCrypt.c:
- Inclusion of config.h changed to reflect renaming of config.h.
+ Inclusion of config.h changed to reflect renaming of config.h.
* configure.ac: new AX_PREFIX_CONFIG_H added to 'configure'
generation. Added switch --enable-display-version for having
@@ -3493,7 +3497,7 @@
<va...@gmail.com> improving the configure setup.
2006-07-03 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/dio/dio_Postgresql.tcl: when handling a PostgreSQL
+ * rivet/packages/dio/dio_Postgresql.tcl: when handling a PostgreSQL
result, if numrows is zero, see if cmdTuples
(Pg_result $resultHandle -cmdTuples) contains anything, and if it
does, put that in of numrows, hiding a PostgreSQL interface
@@ -3627,9 +3631,9 @@
* rivet/rivet-tcl: README, cookie.tcl, debug.tcl, html.tcl,
import_keyvalue_pairs.tcl, import_switch_args.tcl, incr0.tcl,
- lassign.tcl, lempty.tcl, lmatch.tcl, load_cookies.tcl,
- load_response.tcl, parray.tcl, random.tcl, read_file.tcl,
- rivet_command_document.tcl, wrap.tcl: Updated code comments
+ lassign.tcl, lempty.tcl, lmatch.tcl, load_cookies.tcl,
+ load_response.tcl, parray.tcl, random.tcl, read_file.tcl,
+ rivet_command_document.tcl, wrap.tcl: Updated code comments
and added subversion "Id" tags where they weren't present.
2005-09-23 David N. Welton <da...@dedasys.com>
@@ -3773,7 +3777,7 @@
2005-01-08 Karl Lehenbauer <ka...@sc.com>
* rivet/packages/dio/diodisplay.tcl: Accept arguments to the
- showform_prolog method that are passed through to the form's
+ showform_prolog method that are passed through to the form's
start method. This allows things like naming the form and
accessing the fields from javascript by name.
@@ -3815,7 +3819,7 @@
* Makefile.am, configure.ac: Added the doc/ directory.
2004-12-07 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/dio/dio.tcl: "DIO delete" method now return the
+ * rivet/packages/dio/dio.tcl: "DIO delete" method now return the
number of rows affected.
2004-12-03 Karl Lehenbauer <ka...@sc.com>
@@ -3886,9 +3890,9 @@
2004-12-01 Karl Lehenbauer <ka...@sc.com>
- * Update autoconf build to TEA 3.1
+ * Update autoconf build to TEA 3.1
- * configure.am: Automatically locate apxs in the PATH if it hasn't
+ * configure.am: Automatically locate apxs in the PATH if it hasn't
been overridden by --with-apxs. Likewise automatically locate
tclsh if it hasn't been overridden by --with-tclsh.
@@ -3896,12 +3900,12 @@
2004-11-17 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/dio/dio.tcl: Fixed comments incorrectly placed
+ * rivet/packages/dio/dio.tcl: Fixed comments incorrectly placed
outside of a switch body.
2004-11-11 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/dio/dio.tcl: Added "insert" method that
+ * rivet/packages/dio/dio.tcl: Added "insert" method that
doesn't try to see if it's there already all the other
stuff that "store" does.
@@ -3909,13 +3913,13 @@
2004-11-05 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/session/session-class.tcl: Quote backslashes when
+ * rivet/packages/session/session-class.tcl: Quote backslashes when
storing so they won't be stripped by the database. Needs to
be tested for MySQL and SQLlite.
2004-11-04 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/dio/*.tcl: Documented the code for
+ * rivet/packages/dio/*.tcl: Documented the code for
DIO and DIOdisplay.
2004-11-04 David N. Welton <da...@dedasys.com>
@@ -3930,12 +3934,12 @@
2004-10-29 Karl Lehenbauer <ka...@sc.com>
- * rivet/packages/dio/dio_Mysql.tcl: The "DIO handle" method, which
+ * rivet/packages/dio/dio_Mysql.tcl: The "DIO handle" method, which
returns the underlying database's connection handle, now forces
the database connection to be made, if it hasn't already been
made, just like DIO exec.
- * rivet/packages/dio/dio_Postgresql.tcl: (same)
+ * rivet/packages/dio/dio_Postgresql.tcl: (same)
2004-09-29 David N. Welton <da...@dedasys.com>
diff --git a/VERSION b/VERSION
index be94e6f..b347b11 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-3.2.2
+3.2.3
diff --git a/doc/rivet.xml b/doc/rivet.xml
index e0d8ab9..23d9b1a 100644
--- a/doc/rivet.xml
+++ b/doc/rivet.xml
@@ -36,7 +36,7 @@
<!ENTITY lazybridge.xml SYSTEM "xml/lazybridge.xml" >
<!ENTITY formbroker.xml SYSTEM "xml/formbroker.xml" >
<!ENTITY version "3.2" >
- <!ENTITY fullversion "3.2.2" >
+ <!ENTITY fullversion "3.2.3" >
<!ENTITY version2-series "2.0,2.1,2.2,2.3,2.4" >
<!ENTITY version2-generic "2.x" >
<!ENTITY version3-generic "3.x" >
diff --git a/src/TclWeb.h b/src/TclWeb.h
index 17c66fe..a1284c8 100644
--- a/src/TclWeb.h
+++ b/src/TclWeb.h
@@ -185,7 +185,7 @@ int TclWeb_UploadSave(char *varname, Tcl_Obj *filename, TclWebRequest *req);
* TclWeb_UploadData --
*
* Returns the uploaded data to the Tcl script level.
- *
+ *
* If the config parameter upload_files_to_var is not set the procedure
* returs an error
*
diff --git a/src/librivet/rivetCrypt.c b/src/librivet/rivetCrypt.c
index 7c9474c..78e2918 100644
--- a/src/librivet/rivetCrypt.c
+++ b/src/librivet/rivetCrypt.c
@@ -184,7 +184,7 @@ Rivet_InitCrypt( Tcl_Interp *interp)
RIVET_EXPORT_CMD(interp,rivet_ns,"encrypt");
RIVET_EXPORT_CMD(interp,rivet_ns,"decrypt");
- RIVET_EXPORT_CMD(interp,rivet_ns,"crypt");
+ RIVET_EXPORT_CMD(interp,rivet_ns,"crypt");
}
#endif
return TCL_OK;
diff --git a/src/librivet/rivetList.c b/src/librivet/rivetList.c
index 5884756..3aabd2b 100644
--- a/src/librivet/rivetList.c
+++ b/src/librivet/rivetList.c
@@ -277,7 +277,7 @@ Rivet_CommaSplitObjCmd (notUsed, interp, objc, objv)
c = *next;
/* if we've got a quote at this point, it is at the start
- * of a field, scan to the closing quote, make that a field,
+ * of a field, scan to the closing quote, make that a field,
* and update */
if (c == '"') {
@@ -290,7 +290,7 @@ Rivet_CommaSplitObjCmd (notUsed, interp, objc, objv)
if (c == '\0') goto format_error;
/*
- * If we get a double quote, first see if it's a pair of double
+ * If we get a double quote, first see if it's a pair of double
* quotes, i.e. a quoted quote, and handle that.
*/
if (c == '"') {
@@ -309,7 +309,7 @@ Rivet_CommaSplitObjCmd (notUsed, interp, objc, objv)
next++;
continue;
}
- /* It's a solo double-quote, not a pair of double-quotes,
+ /* It's a solo double-quote, not a pair of double-quotes,
* so terminate the element
* at the current quote (the closing quote).
*/
@@ -322,7 +322,7 @@ Rivet_CommaSplitObjCmd (notUsed, interp, objc, objv)
++next;
c = *next;
- /*
+ /*
* if we get end-of-line here, it's fine... and we're done
*/
@@ -336,7 +336,7 @@ Rivet_CommaSplitObjCmd (notUsed, interp, objc, objv)
format_error:
Tcl_ResetResult (interp);
Tcl_AppendResult (interp,
- "format error in string: \"",
+ "format error in string: \"",
first, "\"", (char *) NULL);
return TCL_ERROR;
}
@@ -362,7 +362,7 @@ Rivet_CommaSplitObjCmd (notUsed, interp, objc, objv)
c = *next;
/* If we reach end of the string, append the last element
- * and return to our caller.
+ * and return to our caller.
*/
if (c == '\0') {
@@ -427,9 +427,9 @@ Rivet_CommaJoinObjCmd (notUsed, interp, objc, objv)
resultPtr = Tcl_GetObjResult (interp);
- if (Tcl_ListObjGetElements (interp,
- objv[1],
- &listObjc,
+ if (Tcl_ListObjGetElements (interp,
+ objv[1],
+ &listObjc,
&listObjv) != TCL_OK) {
return TCL_ERROR;
}
@@ -547,7 +547,7 @@ TCL_CMD_HEADER( Rivet_LassignArrayObjCmd )
extern Tcl_Namespace* Rivet_GetNamespace( Tcl_Interp* interp);
#endif
-int
+int
Rivet_InitList( Tcl_Interp *interp)
{
RIVET_OBJ_CMD("lremove",Rivet_LremoveObjCmd,NULL);
diff --git a/src/librivet/rivetPkgInit.c b/src/librivet/rivetPkgInit.c
index 17fd31e..a996cfc 100644
--- a/src/librivet/rivetPkgInit.c
+++ b/src/librivet/rivetPkgInit.c
@@ -40,7 +40,7 @@
* pointer is stored in the interpreter's associated data (pointing to a
* rivet_interp_globals structure) if the interpreter is passed by mod_rivet.
* Otherwise a new ::rivet namespace is created and its Tcl_Namespace
- * pointer is returned
+ * pointer is returned
*
* Parameters:
*
@@ -55,13 +55,13 @@
#if RIVET_NAMESPACE_EXPORT == 1
-Tcl_Namespace*
+Tcl_Namespace*
Rivet_GetNamespace( Tcl_Interp* interp)
{
Tcl_Namespace *rivet_ns;
rivet_ns = Tcl_FindNamespace(interp,RIVET_NS,NULL,TCL_GLOBAL_ONLY);
- if (rivet_ns == NULL)
+ if (rivet_ns == NULL)
{
rivet_ns = Tcl_CreateNamespace (interp,RIVET_NS,NULL,
(Tcl_NamespaceDeleteProc *)NULL);
@@ -88,10 +88,10 @@ Rivetlib_Init( Tcl_Interp *interp )
{
#ifdef USE_TCL_STUBS
- if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) {
+ if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) {
#else
- if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL) {
-#endif
+ if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL) {
+#endif
return TCL_ERROR;
}
@@ -120,10 +120,10 @@ Rivetlib_SafeInit( Tcl_Interp *interp )
{
#ifdef USE_TCL_STUBS
- if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) {
+ if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) {
#else
- if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL) {
-#endif
+ if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL) {
+#endif
return TCL_ERROR;
}
diff --git a/src/librivet/rivetWWW.c b/src/librivet/rivetWWW.c
index 6f71e92..672c1b8 100644
--- a/src/librivet/rivetWWW.c
+++ b/src/librivet/rivetWWW.c
@@ -364,7 +364,7 @@ TCL_CMD_HEADER( Rivet_EscapeShellCommandCmd )
extern Tcl_Namespace* Rivet_GetNamespace( Tcl_Interp* interp);
#endif
-int
+int
Rivet_InitWWW( Tcl_Interp *interp)
{
RIVET_OBJ_CMD ("unescape_string",Rivet_UnescapeStringCmd,NULL);
diff --git a/src/mod_rivet_ng/TclWebapache.c b/src/mod_rivet_ng/TclWebapache.c
index 6b46e54..ea95973 100644
--- a/src/mod_rivet_ng/TclWebapache.c
+++ b/src/mod_rivet_ng/TclWebapache.c
@@ -65,7 +65,7 @@ extern mod_rivet_globals* module_globals;
if (source == VAR_SRC_QUERYSTRING) { j = nargs; } \
else if (source == VAR_SRC_POST) { i = nargs; }
-/*
+/*
* -- TclWeb_NewRequestObject
*
*
@@ -98,7 +98,7 @@ TclWeb_NewRequestObject (apr_pool_t *p)
* TclWebRequest* req: a pointer to a TclWebRequest object to be intialized
* Tcl_Interp* interp: current Tcl_Interp object serving the request
* void* arg: generic pointer. Current implementation passes the
- * request_rec object pointer
+ * request_rec object pointer
*
*/
@@ -126,11 +126,11 @@ TclWeb_InitRequest(rivet_thread_private* private, Tcl_Interp *interp)
if (((private->ctype==RIVET_TEMPLATE) && (content_type_len > strlen(RIVET_TEMPLATE_CTYPE))) || \
((private->ctype==RIVET_TCLFILE) && (content_type_len > strlen(RIVET_TCLFILE_CTYPE)))) {
-
+
char* charset;
/* we parse the content type: we are after a 'charset' parameter definition */
-
+
charset = strstr(r->content_type,"charset");
if (charset != NULL) {
charset = apr_pstrdup(r->pool,charset);
@@ -149,7 +149,7 @@ INLINE int
TclWeb_SendHeaders(TclWebRequest *req)
{
//TODO: fix ap_send_http_header
-
+
ap_send_http_header(req->req);
return TCL_OK;
@@ -167,7 +167,7 @@ TclWeb_StopSending(TclWebRequest *req)
int
TclWeb_SetHeaderType(char *header, TclWebRequest *req)
{
-
+
if (req->headers_set)
return TCL_ERROR;
@@ -193,12 +193,12 @@ TclWeb_PrintHeaders(TclWebRequest *req)
{
TclWeb_SetHeaderType(DEFAULT_HEADER_TYPE, req);
}
-
+
/*
* seems that ap_send_http_header is redefined to ; in Apache2.2
* ap_send_http_header(req->req);
*/
-
+
TclWeb_SendHeaders(req);
req->headers_printed = 1;
@@ -245,11 +245,11 @@ TclWeb_HeaderSet(char *header, char *val, TclWebRequest *req)
* headers
* - it returns nothing since it's a wrapper around an APR call
* that doesn't return anything
- *
- * -- TclWeb_OutputHeaderGet: reads from the output headers and
+ *
+ * -- TclWeb_OutputHeaderGet: reads from the output headers and
* returns the value associated to a key. If the key is not
* existing it returns NULL
- *
+ *
*/
INLINE void
@@ -461,11 +461,11 @@ TclWeb_VarNumber(Tcl_Obj *result, int source, TclWebRequest *req)
/* Environment variables. Include variables handling */
-/* These 2 array must be aligned and a one-to-one correspondence preserved
+/* These 2 array must be aligned and a one-to-one correspondence preserved
* The enum include_vars_idx *must* be terminated by 'invalid_env_var'
- * Adding a new env variable requires
+ * Adding a new env variable requires
* + the name of the variable be listed in include_env_vars
- * + a new value in the enumerator include_vars_idx must be added in the
+ * + a new value in the enumerator include_vars_idx must be added in the
* corresponding position
* + the switch construct in function TclWeb_SelectEnvIncludeVar must
* be expanded to handle the new case identified by the new enumerator value
@@ -483,11 +483,11 @@ enum include_vars_idx {
invalid_env_var
};
-/* -- TclWeb_SelectEnvIncludeVar
+/* -- TclWeb_SelectEnvIncludeVar
*
* Depending on the value idx of the enumerator a method is selected
* to return a string of a specific environment variable methods
- * Adding new environment variables need new cases of the switch
+ * Adding new environment variables need new cases of the switch
* construct to be added, provided the data can be obtained from
* the rivet_thread_private structure
*
@@ -501,7 +501,7 @@ enum include_vars_idx {
* A character string pointer to the value of the environment variable or
* NULL if the enumerator value idx was invalid or resolving the environment
* variable was impossible
- *
+ *
*/
static char*
@@ -509,12 +509,12 @@ TclWeb_SelectEnvIncludeVar (rivet_thread_private* private,int idx)
{
switch (idx)
{
- case date_local:
+ case date_local:
{
apr_pool_t* pool = private->req->req->pool;
apr_time_t date = private->req->req->request_time;
- return ap_ht_time(pool,date,DEFAULT_TIME_FORMAT,0);
+ return ap_ht_time(pool,date,DEFAULT_TIME_FORMAT,0);
}
case date_gmt:
{
@@ -592,13 +592,13 @@ TclWeb_SelectEnvIncludeVar (rivet_thread_private* private,int idx)
/*
* -- TclWeb_InitEnvVars
- *
+ *
* Load the CGI and environment variables into the request_rec environment structure
- * Variables belong to 3 cathegories
+ * Variables belong to 3 cathegories
*
* + common variables (ap_add_common_vars)
* + CGI variables (ad_cgi_vars)
- * + a miscellaneous set of variables
+ * + a miscellaneous set of variables
* listed in the array include_env_vars
*
* Each cathegory is controlled by flags in order to reduce the overhead of getting them
@@ -633,7 +633,7 @@ TclWeb_InitEnvVars (rivet_thread_private* private)
if (!ENV_VARS_LOADED(req->environment_set))
{
- apr_table_t *table;
+ apr_table_t *table;
int idx;
table = req->req->subprocess_env;
@@ -656,7 +656,7 @@ TclWeb_InitEnvVars (rivet_thread_private* private)
* a character string pointer to the environment variable value or
* NULL if the environment variable name in invalid or the variable
* could not be resolved
- *
+ *
*/
static char*
@@ -709,7 +709,7 @@ TclWeb_GetEnvVars(Tcl_Obj *envvar,rivet_thread_private* private)
* Default behavior (creation in the ::request namespace)
* is now more consistently constrained by fully qualifying
* the default array names (see rivetCore.c). This should fix
- * Bug #48963
+ * Bug #48963
*/
Tcl_ObjSetVar2(req->interp, envvar, key, val, 0);
@@ -837,7 +837,7 @@ int TclWeb_UploadChannel(char *varname, TclWebRequest *req)
result = Tcl_NewObj();
Tcl_SetStringObj(result, Tcl_GetChannelName(chan), -1);
Tcl_SetObjResult(req->interp, result);
-
+
return TCL_OK;
}
}
@@ -888,14 +888,14 @@ int TclWeb_UploadData(char *varname, TclWebRequest *req)
if (rsc->upload_files_to_var)
{
Tcl_Channel chan;
-
+
chan = Tcl_OpenFileChannel (req->interp, req->upload->tempname, "r", 0);
if (chan == NULL) {
char* tcl_error_msg;
int error_number = Tcl_GetErrno();
Tcl_AddErrorInfo(req->interp,"Error opening channel to uploaded data");
- tcl_error_msg = apr_psprintf(req->req->pool,"Error setting channel option '%s': %s",
+ tcl_error_msg = apr_psprintf(req->req->pool,"Error setting channel option '%s': %s",
Tcl_ErrnoId(), Tcl_ErrnoMsg(error_number));
Tcl_AddErrorInfo(req->interp,tcl_error_msg);
return TCL_ERROR;
@@ -904,7 +904,7 @@ int TclWeb_UploadData(char *varname, TclWebRequest *req)
char* tcl_error_msg;
int error_number = Tcl_GetErrno();
- tcl_error_msg = apr_psprintf(req->req->pool,"Error setting channel option '%s': %s",
+ tcl_error_msg = apr_psprintf(req->req->pool,"Error setting channel option '%s': %s",
Tcl_ErrnoId(), Tcl_ErrnoMsg(error_number));
Tcl_AddErrorInfo(req->interp,tcl_error_msg);
return TCL_ERROR;
@@ -913,7 +913,7 @@ int TclWeb_UploadData(char *varname, TclWebRequest *req)
char* tcl_error_msg;
int error_number = Tcl_GetErrno();
- tcl_error_msg = apr_psprintf(req->req->pool,"Error setting channel option '%s': %s",
+ tcl_error_msg = apr_psprintf(req->req->pool,"Error setting channel option '%s': %s",
Tcl_ErrnoId(), Tcl_ErrnoMsg(error_number));
Tcl_AddErrorInfo(req->interp,tcl_error_msg);
return TCL_ERROR;
@@ -925,14 +925,14 @@ int TclWeb_UploadData(char *varname, TclWebRequest *req)
if (Tcl_Close(req->interp, chan) == TCL_ERROR) {
return TCL_ERROR;
}
-
+
Tcl_SetObjResult(req->interp, result);
} else {
Tcl_AppendResult(req->interp,
"RivetServerConf UploadFilesToVar is not set", NULL);
return TCL_ERROR;
}
-
+
return TCL_OK;
}
diff --git a/src/mod_rivet_ng/apache_config.c b/src/mod_rivet_ng/apache_config.c
index e7bc550..11d873f 100644
--- a/src/mod_rivet_ng/apache_config.c
+++ b/src/mod_rivet_ng/apache_config.c
@@ -53,17 +53,17 @@ extern mod_rivet_globals* module_globals;
* - string_value: a string to be assigned to the Tcl_Obj
*
* Results:
- *
+ *
* - Pointer to a Tcl_Obj containing the parameter value.
*
*/
#if 0
-static Tcl_Obj*
+static Tcl_Obj*
Rivet_AssignStringToConf (Tcl_Obj** objPnt, const char* string_value)
{
Tcl_Obj *objarg = NULL;
-
+
if (*objPnt == NULL)
{
objarg = Tcl_NewStringObj(string_value,-1);
@@ -82,7 +82,7 @@ static char*
Rivet_AppendStringToConf (char* p,const char* string,apr_pool_t *pool)
{
- if (p == NULL) {
+ if (p == NULL) {
p = apr_pstrdup(pool,string);
} else {
p = apr_pstrcat(pool,p,"\n",string,NULL);
@@ -102,7 +102,7 @@ Rivet_AppendStringToConf (char* p,const char* string,apr_pool_t *pool)
*
* Results:
*
- * Returns a Tcl_Obj* pointing to the string representation of
+ * Returns a Tcl_Obj* pointing to the string representation of
* the current value for the directive.
*
*/
@@ -136,14 +136,14 @@ Rivet_SetScript (apr_pool_t *pool, rivet_server_conf *rsc, const char *script, c
} else {
return NULL;
}
-
+
*c = Rivet_AppendStringToConf(*c,string,pool);
return *c;
}
-/*
+/*
* -- Rivet_GetConf
*
* Rivet_GetConf fetches the confguration from the server record
@@ -156,8 +156,8 @@ Rivet_SetScript (apr_pool_t *pool, rivet_server_conf *rsc, const char *script, c
*
* Results:
*
- * - rivet_server_conf* rsc: the server merged configuration
- *
+ * - rivet_server_conf* rsc: the server merged configuration
+ *
* Side Effects:
*
* None.
@@ -171,7 +171,7 @@ Rivet_GetConf(request_rec *r)
void *dconf = r->per_dir_config;
rivet_server_conf *newconfig = NULL;
rivet_server_conf *rdc;
-
+
FILEDEBUGINFO;
/* If there is no per dir config, just return the server config */
@@ -179,13 +179,13 @@ Rivet_GetConf(request_rec *r)
return rsc;
}
- /* things might become tedious when there are scripts set
+ /* things might become tedious when there are scripts set
in a <Directory ...>...</Directory> stanza. Especially
since we are calling this function at every single request.
- We compute the new configuration merging the per-dir conf
+ We compute the new configuration merging the per-dir conf
with the server configuration and then we return it. */
- rdc = RIVET_SERVER_CONF ( dconf );
+ rdc = RIVET_SERVER_CONF ( dconf );
newconfig = RIVET_NEW_CONF ( r->pool );
Rivet_CopyConfig( rsc, newconfig );
@@ -243,12 +243,12 @@ Rivet_CopyConfig(rivet_server_conf *oldrsc, rivet_server_conf *newrsc)
/*
* -- Rivet_MergeDirConfigVars
- *
+ *
* Merging of base configuration with per directory configuration
* is done checking each field in the configuration record. If
* a more specific (per directory) conf variable is defined then
- * it supersedes the base record variable
- *
+ * it supersedes the base record variable
+ *
* Arguments:
*
* - apr_pool_t* t: pointer to an APR memory pool
@@ -258,8 +258,8 @@ Rivet_CopyConfig(rivet_server_conf *oldrsc, rivet_server_conf *newrsc)
* - rivet_server_conf* add:
*
* Results:
- *
- * configuration record are merge in place
+ *
+ * configuration record are merge in place
*
* Side Effects:
*
@@ -305,11 +305,11 @@ Rivet_MergeDirConfigVars(apr_pool_t *p, rivet_server_conf *new,
* -- Rivet_CreateDirConfig
*
* Apache HTTP server framework calls this function to
- * have a pointer to newly initialized directory specific
- * configuration record.
+ * have a pointer to newly initialized directory specific
+ * configuration record.
*
* Arguments:
- *
+ *
* - apr_pool_t*: pointer to an APR memory pool
* - char*: string pointer to the directory name
*
@@ -341,11 +341,11 @@ Rivet_CreateDirConfig(apr_pool_t *p, char *dir)
* Arguments:
*
* - apr_pool_t* p: pointer to an APR memory pool
- * - void* basev, addv: pointers to configuration records to be
+ * - void* basev, addv: pointers to configuration records to be
* merged
- *
+ *
* Results:
- *
+ *
* - void*: pointer to the resulting configuration
*/
@@ -495,9 +495,9 @@ Rivet_CreateConfig(apr_pool_t *p, server_rec *s )
*/
const char *
-Rivet_UserConf( cmd_parms *cmd,
- void *vrdc,
- const char *var,
+Rivet_UserConf( cmd_parms *cmd,
+ void *vrdc,
+ const char *var,
const char *val )
{
rivet_server_conf *rdc = (rivet_server_conf *)vrdc;
@@ -517,14 +517,14 @@ Rivet_UserConf( cmd_parms *cmd,
rdc->user_scripts_status |= (USER_SCRIPTS_UPDATED | USER_SCRIPTS_CONF);
- if (STREQU(var,"BeforeScript") ||
- STREQU(var,"AfterScript") ||
+ if (STREQU(var,"BeforeScript") ||
+ STREQU(var,"AfterScript") ||
STREQU(var,"AbortScript") ||
STREQU(var,"AfterEveryScript") ||
STREQU(var,"UploadDirectory") ||
STREQU(var,"ErrorScript"))
{
- apr_table_set( rdc->rivet_user_vars, var,
+ apr_table_set( rdc->rivet_user_vars, var,
Rivet_SetScript( cmd->pool, rdc, var, val));
}
else if (STREQU(var,"Debug") ||
@@ -536,7 +536,7 @@ Rivet_UserConf( cmd_parms *cmd,
}
else
{
- return apr_pstrcat(cmd->pool, "Rivet configuration error: '",var,
+ return apr_pstrcat(cmd->pool, "Rivet configuration error: '",var,
"' not valid for RivetUserConf", NULL);
}
@@ -569,14 +569,14 @@ Rivet_DirConf(cmd_parms *cmd,void *vrdc,const char *var,const char *val)
return "Rivet Error: RivetDirConf requires two arguments";
}
- if(STREQU(var, "UploadDirectory"))
+ if(STREQU(var, "UploadDirectory"))
{
rdc->upload_dir = val;
- }
- else
+ }
+ else
{
- if (STREQU(var,"BeforeScript") ||
- STREQU(var,"AfterScript") ||
+ if (STREQU(var,"BeforeScript") ||
+ STREQU(var,"AfterScript") ||
STREQU(var,"AbortScript") ||
STREQU(var,"AfterEveryScript") ||
STREQU(var,"ErrorScript"))
@@ -585,7 +585,7 @@ Rivet_DirConf(cmd_parms *cmd,void *vrdc,const char *var,const char *val)
}
else
{
- return apr_pstrcat(cmd->pool, "Rivet configuration error: '",var,
+ return apr_pstrcat(cmd->pool, "Rivet configuration error: '",var,
"' not valid in <Directory> sections", NULL);
}
}
diff --git a/src/mod_rivet_ng/mod_rivet.c b/src/mod_rivet_ng/mod_rivet.c
index 89408c1..7b583ba 100644
--- a/src/mod_rivet_ng/mod_rivet.c
+++ b/src/mod_rivet_ng/mod_rivet.c
@@ -75,18 +75,18 @@ DLLEXPORT mod_rivet_globals* module_globals = NULL;
/*
* -- Rivet_SeekMPMBridge
*
- * MPM name determination. The function returns a filename to
+ * MPM name determination. The function returns a filename to
* an MPM bridge module. The module name is determined in 4 steps
*
* - The environment variable RIVET_MPM_BRIDGE is checked. If the
* variable exists its value is returned as the path to the bridge module
* If the module doesn't exist the server exits with an error
* - The global configuration is checked. If module_globals->mpm_bridge is
- * not NULL its value is taken as the bridge name as given by means of
- * the server configuration directive RivetMpmBridge.
+ * not NULL its value is taken as the bridge name as given by means of
+ * the server configuration directive RivetMpmBridge.
* The value is interpolated with the macro RIVET_MPM_BRIDGE_COMPOSE
* to compose the full path (e.g. 'lazy' -> RIVET_DIR'/mpm/rivet_lazy_mpm.so')
- * to the bridge module.
+ * to the bridge module.
* - If the interpolated file name doesn't exist the mpm_bridge string is
* checked as a full path to the MPM bridge. If not existing the server exits
* - An heuristics criterion based on the MPM module features returned by
@@ -102,16 +102,16 @@ Rivet_SeekMPMBridge (apr_pool_t* pool)
apr_status_t apr_ret;
apr_finfo_t finfo;
- /* With the env variable RIVET_MPM_BRIDGE we have the chance to tell mod_rivet
+ /* With the env variable RIVET_MPM_BRIDGE we have the chance to tell mod_rivet
what bridge custom implementation we want be loaded */
if (apr_env_get (&mpm_bridge_path,"RIVET_MPM_BRIDGE",pool) == APR_SUCCESS)
{
if ((apr_ret = apr_stat(&finfo,mpm_bridge_path,APR_FINFO_MIN,pool)) != APR_SUCCESS)
{
- ap_log_perror(APLOG_MARK,APLOG_ERR,apr_ret,pool,
- MODNAME ": MPM bridge %s not found", module_globals->mpm_bridge);
- exit(1);
+ ap_log_perror(APLOG_MARK,APLOG_ERR,apr_ret,pool,
+ MODNAME ": MPM bridge %s not found", module_globals->mpm_bridge);
+ exit(1);
}
return mpm_bridge_path;
}
@@ -135,8 +135,8 @@ Rivet_SeekMPMBridge (apr_pool_t* pool)
{
ap_log_perror(APLOG_MARK,APLOG_ERR,apr_ret,pool,
MODNAME ": MPM bridge %s (%s) not found",module_globals->mpm_bridge,
- proposed_bridge);
- exit(1);
+ proposed_bridge);
+ exit(1);
}
} else {
@@ -183,16 +183,16 @@ Rivet_SeekMPMBridge (apr_pool_t* pool)
*
*/
-static mod_rivet_globals*
+static mod_rivet_globals*
Rivet_CreateModuleGlobals (apr_pool_t* pool)
{
mod_rivet_globals* mod_rivet_g;
-
+
mod_rivet_g = apr_pcalloc(pool,sizeof(mod_rivet_globals));
mod_rivet_g->single_thread_exit = SINGLE_THREAD_EXIT_UNDEF;
mod_rivet_g->separate_virtual_interps = RIVET_SEPARATE_VIRTUAL_INTERPS;
mod_rivet_g->separate_channels = RIVET_SEPARATE_CHANNELS;
- if (apr_pool_create(&mod_rivet_g->pool, NULL) != APR_SUCCESS)
+ if (apr_pool_create(&mod_rivet_g->pool, NULL) != APR_SUCCESS)
{
ap_log_perror(APLOG_MARK,APLOG_ERR,APR_EGENERAL,pool,
MODNAME ": could not initialize rivet module global pool");
@@ -205,7 +205,7 @@ Rivet_CreateModuleGlobals (apr_pool_t* pool)
&mod_rivet_g->default_handler,
&mod_rivet_g->default_handler_size) > 0)
{
- ap_log_perror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, pool,
+ ap_log_perror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, pool,
MODNAME ": could not read rivet default handler");
exit(1);
}
@@ -216,7 +216,7 @@ Rivet_CreateModuleGlobals (apr_pool_t* pool)
/*
* -- Rivet_Exit_Handler
*
- *
+ *
*
*/
@@ -227,7 +227,7 @@ int Rivet_Exit_Handler(int code)
return TCL_OK; /* Better not ever reach this! */
}
-/*
+/*
* -- Rivet_RunServerInit
*
* Prepare the execution of any Rivet server initialization script
@@ -248,23 +248,23 @@ Rivet_RunServerInit (apr_pool_t *pPool, apr_pool_t *pLog, apr_pool_t *pTemp, ser
module_globals->server_interp = Rivet_NewVHostInterp(pPool,0); /* root interpreter */
/* We initialize the interpreter and we won't register a channel with it because
- * we couldn't send data to the stdout anyway
+ * we couldn't send data to the stdout anyway
*/
Rivet_PerInterpInit(module_globals->server_interp,NULL,s,pPool);
/* This code conditionally compiled when we are building for the
- * Windows family of OS. The winnt MPM runs the post_config
+ * Windows family of OS. The winnt MPM runs the post_config
* hooks after it has spawned a child process but we don't want
* to run the Tcl server initialization script again. We
* detect we are in a child process by checking
- * the environment variable AP_PARENT_PID
+ * the environment variable AP_PARENT_PID
* (https://wiki.apache.org/httpd/ModuleLife)
*/
#ifdef WIN32
- /* if the environment variable AP_PARENT_PID is set
+ /* if the environment variable AP_PARENT_PID is set
* we know we are in a child process of the winnt MPM
*/
@@ -294,13 +294,13 @@ Rivet_RunServerInit (apr_pool_t *pPool, apr_pool_t *pLog, apr_pool_t *pTemp, ser
if (Tcl_EvalObjEx(interp, server_init, 0) != TCL_OK)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, s,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, s,
MODNAME ": Error running ServerInitScript '%s': %s",
module_globals->rivet_server_init_script,
Tcl_GetVar(interp, "errorInfo", 0));
} else {
ap_log_error(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, s,
- MODNAME ": ServerInitScript '%s' successful",
+ MODNAME ": ServerInitScript '%s' successful",
module_globals->rivet_server_init_script);
}
@@ -335,7 +335,7 @@ Rivet_ServerInit (apr_pool_t *pPool, apr_pool_t *pLog, apr_pool_t *pTemp, server
#endif
/* This function runs as post_config_hook
- * and as such it's run twice by design.
+ * and as such it's run twice by design.
* This is the recommended way to avoid a double load of
* external modules.
*/
@@ -382,10 +382,10 @@ Rivet_ServerInit (apr_pool_t *pPool, apr_pool_t *pLog, apr_pool_t *pTemp, server
{
char errorbuf[ERRORBUF_SZ];
- ap_log_error (APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
- MODNAME ": Error loading symbol bridge_jump_table: %s",
+ ap_log_error (APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
+ MODNAME ": Error loading symbol bridge_jump_table: %s",
apr_dso_error(dso_handle,errorbuf,ERRORBUF_SZ));
- exit(1);
+ exit(1);
}
/* we require only request_processor and thread_interp to be defined */
@@ -402,8 +402,8 @@ Rivet_ServerInit (apr_pool_t *pPool, apr_pool_t *pLog, apr_pool_t *pTemp, server
/* If we can't load the mpm handler module we give up and exit */
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
- MODNAME " Error loading MPM manager: %s",
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
+ MODNAME " Error loading MPM manager: %s",
apr_dso_error(dso_handle,errorbuf,ERRORBUF_SZ));
exit(1);
}
@@ -437,12 +437,12 @@ static void Rivet_ChildInit (apr_pool_t *pChild, server_rec *server)
ap_assert (apr_threadkey_private_create (&rivet_thread_key, NULL, pChild) == APR_SUCCESS);
- /* This code is run once per child process. The forking
- * of a child process doesn't preserve the thread where the Tcl
- * notifier runs. The Notifier should have been restarted by one the
+ /* This code is run once per child process. The forking
+ * of a child process doesn't preserve the thread where the Tcl
+ * notifier runs. The Notifier should have been restarted by one the
* pthread_atfork callbacks (setup in Tcl >= 8.5.14 and Tcl >= 8.6.1). In
* case pthread_atfork is not supported we unconditionally call Tcl_InitNotifier
- * hoping for the best (Bug #55153)
+ * hoping for the best (Bug #55153)
*/
#if !defined(HAVE_PTHREAD_ATFORK)
@@ -468,8 +468,8 @@ static void Rivet_ChildInit (apr_pool_t *pChild, server_rec *server)
apr_thread_mutex_create(&module_globals->pool_mutex, APR_THREAD_MUTEX_UNNESTED, pChild);
/* Once we have established a pool with the same lifetime of the child process we
- * process all the configured server records assigning an integer as unique key
- * to each of them
+ * process all the configured server records assigning an integer as unique key
+ * to each of them
*/
root_server_conf = RIVET_SERVER_CONF(server->module_config);
@@ -502,9 +502,9 @@ static void Rivet_ChildInit (apr_pool_t *pChild, server_rec *server)
}
-static int Rivet_Handler (request_rec *r)
+static int Rivet_Handler (request_rec *r)
{
- rivet_req_ctype ctype = Rivet_CheckType(r);
+ rivet_req_ctype ctype = Rivet_CheckType(r);
if (ctype == CTYPE_NOT_HANDLED) {
return DECLINED;
}
@@ -523,7 +523,7 @@ static int Rivet_InitGlobals (apr_pool_t *pPool, apr_pool_t *pLog, apr_pool_t *p
/*
* -- rivet_register_hooks: mod_rivet basic setup.
*
- *
+ *
*/
static void rivet_register_hooks(apr_pool_t *p)
@@ -549,9 +549,9 @@ const command_rec rivet_cmds[] =
/* Dispatch list for API hooks */
-module AP_MODULE_DECLARE_DATA rivet_module =
+module AP_MODULE_DECLARE_DATA rivet_module =
{
- STANDARD20_MODULE_STUFF,
+ STANDARD20_MODULE_STUFF,
Rivet_CreateDirConfig, /* create per-dir config structures */
Rivet_MergeDirConfig, /* merge per-dir config structures */
Rivet_CreateConfig, /* create per-server config structures */
diff --git a/src/mod_rivet_ng/mod_rivet.h b/src/mod_rivet_ng/mod_rivet.h
index 11f0e80..68fa9f7 100644
--- a/src/mod_rivet_ng/mod_rivet.h
+++ b/src/mod_rivet_ng/mod_rivet.h
@@ -59,7 +59,7 @@
/* Configuration options */
-/*
+/*
If you do not have a threaded Tcl, you can define this to 0. This
has the effect of running Tcl Init code in the main parent init
handler, instead of in child init handlers.
@@ -192,14 +192,14 @@ typedef struct _mpm_bridge_table {
typedef struct mpm_bridge_status mpm_bridge_status;
typedef struct _mod_rivet_globals {
- apr_pool_t* pool;
+ apr_pool_t* pool;
char* rivet_mpm_bridge; /* name of the MPM bridge */
server_rec* server; /* default host server_rec obj */
int vhosts_count; /* Number of configured virtual host including *
* the root server thus it's supposed to be >= 1 */
char* default_handler; /* Default request handler code */
int default_handler_size; /* Size of the default_handler buffer */
- rivet_thread_interp*
+ rivet_thread_interp*
server_interp; /* server and prefork MPM interpreter */
apr_thread_mutex_t* pool_mutex; /* threads commmon pool mutex */
rivet_bridge_table* bridge_jump_table; /* Jump table to bridge specific procedures */
@@ -297,17 +297,17 @@ Tcl_Obj* Rivet_CurrentServerRec (Tcl_Interp* interp, server_rec* s);
/* Configuration defaults */
-#define SINGLE_THREAD_EXIT_UNDEF -1 /* pre config undefined value for single
+#define SINGLE_THREAD_EXIT_UNDEF -1 /* pre config undefined value for single
thread exit flag in the module globals
structure */
#define TCL_MAX_CHANNEL_BUFFER_SIZE (1024*1024)
#define MODNAME "mod_rivet"
-/*
- * RIVET_CONF_SELECT:
+/*
+ * RIVET_CONF_SELECT:
*
- * This macro avoids unnecessary verbosity of repetitive code in functions
+ * This macro avoids unnecessary verbosity of repetitive code in functions
* overlaying and merging configuration records
*/
diff --git a/src/mod_rivet_ng/mod_rivet_cache.c b/src/mod_rivet_ng/mod_rivet_cache.c
index ba8054b..e3f95b9 100644
--- a/src/mod_rivet_ng/mod_rivet_cache.c
+++ b/src/mod_rivet_ng/mod_rivet_cache.c
@@ -51,12 +51,12 @@ int RivetCache_DefaultSize (void)
}
/*
- * -- RivetCache_Create
+ * -- RivetCache_Create
*
* Creates a per interpreter script cach
*
* Arguments:
- * apr_pool_t *p - APR memory pool pointer,
+ * apr_pool_t *p - APR memory pool pointer,
* rivet_thread_interp* interp_obj - interpreter object
*
*
@@ -69,9 +69,9 @@ int RivetCache_DefaultSize (void)
void RivetCache_Create (apr_pool_t *p, rivet_thread_interp* interp_obj)
{
- interp_obj->objCacheList =
+ interp_obj->objCacheList =
apr_pcalloc(p,(signed)((interp_obj->cache_size)*sizeof(char *)));
- interp_obj->objCache =
+ interp_obj->objCache =
apr_pcalloc(p,sizeof(Tcl_HashTable));
Tcl_InitHashTable(interp_obj->objCache,TCL_STRING_KEYS);
@@ -116,25 +116,25 @@ void RivetCache_Cleanup (rivet_thread_private* private,rivet_thread_interp* rive
ct++;
}
apr_pool_destroy(rivet_interp->pool);
-
+
/* let's recreate the cache list */
if (apr_pool_create(&rivet_interp->pool, private->pool) != APR_SUCCESS)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
MODNAME ": could not recreate cache private pool. Cache disabled");
rivet_interp->cache_free = rivet_interp->cache_size = 0;
}
else
{
- rivet_interp->objCacheList = apr_pcalloc (rivet_interp->pool,
+ rivet_interp->objCacheList = apr_pcalloc (rivet_interp->pool,
(signed)(rivet_interp->cache_size*sizeof(char *)));
rivet_interp->cache_free = rivet_interp->cache_size;
}
-
+
}
-/*
+/*
* -- Rivet_MakeCacheKey
*
* Arguments:
@@ -148,7 +148,7 @@ void RivetCache_Cleanup (rivet_thread_private* private,rivet_thread_interp* rive
char* RivetCache_MakeKey (apr_pool_t* pool,
char* filename,
- time_t ctime,
+ time_t ctime,
time_t mtime,
unsigned int user_conf,
int toplevel)
@@ -225,7 +225,7 @@ Tcl_Obj* RivetCache_FetchScript (Tcl_HashEntry* entry)
return (Tcl_Obj *)Tcl_GetHashValue(entry);
}
-/* -- RivetCache_StoreScript
+/* -- RivetCache_StoreScript
*
*/
@@ -237,14 +237,14 @@ int RivetCache_StoreScript(rivet_thread_interp* rivet_interp, Tcl_HashEntry* ent
char* hashKey = (char *) Tcl_GetHashKey (rivet_interp->objCache,entry);
/* Tcl_SetHashValue is a macro that simply stuffs the value pointer in an array
- * We need to incr the reference count of outbuf because we want it to outlive
+ * We need to incr the reference count of outbuf because we want it to outlive
* this function and be kept as long as the cache is preserved
*/
Tcl_IncrRefCount (script);
Tcl_SetHashValue (entry,(ClientData)script);
- rivet_interp->objCacheList[--rivet_interp->cache_free] =
+ rivet_interp->objCacheList[--rivet_interp->cache_free] =
(char*) apr_pcalloc (rivet_interp->pool,(strlen(hashKey)+1)*sizeof(char));
strcpy(rivet_interp->objCacheList[rivet_interp->cache_free], hashKey);
diff --git a/src/mod_rivet_ng/mod_rivet_cache.h b/src/mod_rivet_ng/mod_rivet_cache.h
index 868b7a8..02ae752 100644
--- a/src/mod_rivet_ng/mod_rivet_cache.h
+++ b/src/mod_rivet_ng/mod_rivet_cache.h
@@ -25,7 +25,7 @@ EXTERN int RivetCache_DefaultSize (void);
EXTERN void RivetCache_Create (apr_pool_t *p, rivet_thread_interp* interp_obj);
EXTERN void RivetCache_Cleanup (rivet_thread_private* private,rivet_thread_interp* rivet_interp);
EXTERN char* RivetCache_MakeKey (apr_pool_t* pool, char* filename,
- time_t ctime,
+ time_t ctime,
time_t mtime,
unsigned int user_conf,
int toplevel);
diff --git a/src/mod_rivet_ng/mod_rivet_common.c b/src/mod_rivet_ng/mod_rivet_common.c
index 29acd86..56908d9 100644
--- a/src/mod_rivet_ng/mod_rivet_common.c
+++ b/src/mod_rivet_ng/mod_rivet_common.c
@@ -1,5 +1,5 @@
-/* -- mod_rivet_common.c - functions likely to be shared among different
- * components of mod_rivet.c
+/* -- mod_rivet_common.c - functions likely to be shared among different
+ * components of mod_rivet.c
*/
/*
@@ -59,7 +59,7 @@ extern module rivet_module;
/*
* -- Rivet_ReadFile
- *
+ *
*/
int
@@ -77,7 +77,7 @@ Rivet_ReadFile (apr_pool_t* pool,char* filename,
{
return 1;
}
-
+
if (apr_file_open(&apr_fp,filename,APR_FOPEN_READ,
APR_FPROT_OS_DEFAULT,
pool) != APR_SUCCESS)
@@ -87,14 +87,14 @@ Rivet_ReadFile (apr_pool_t* pool,char* filename,
buffer_size = file_info->size;
*buffer = (char*) apr_palloc(pool,buffer_size);
-
+
if (apr_file_read(apr_fp,*buffer,&buffer_size) != APR_SUCCESS)
{
return 2;
}
apr_file_close(apr_fp);
-
+
*nbytes = (int)buffer_size;
return 0;
}
@@ -107,13 +107,13 @@ Rivet_ReadFile (apr_pool_t* pool,char* filename,
*
* Results:
* pointer to a Tcl_Interp structure
- *
+ *
* Side Effects:
*
*-----------------------------------------------------------------------------
*/
-static Tcl_Interp*
+static Tcl_Interp*
Rivet_CreateTclInterp (apr_pool_t* pool)
{
Tcl_Interp* interp;
@@ -165,21 +165,21 @@ running_scripts* Rivet_RunningScripts ( apr_pool_t* pool,
ap_assert(Rivet_ReadFile(pool,rivet_conf->request_handler,
&request_handler,&handler_size) == 0);
- scripts->request_processing =
+ scripts->request_processing =
Tcl_NewStringObj(request_handler,handler_size);
} else {
- scripts->request_processing =
+ scripts->request_processing =
Tcl_NewStringObj(module_globals->default_handler,
module_globals->default_handler_size);
- }
+ }
Tcl_IncrRefCount(scripts->request_processing);
return scripts;
}
/*
- * -- Rivet_ReleaseRunningScripts
+ * -- Rivet_ReleaseRunningScripts
*
*/
@@ -231,7 +231,7 @@ void Rivet_ReleasePerDirScripts(rivet_thread_interp* rivet_interp)
*---------------------------------------------------------------------
*/
void Rivet_PerInterpInit(rivet_thread_interp* interp_obj,
- rivet_thread_private* private,
+ rivet_thread_private* private,
server_rec *s,
apr_pool_t *p)
{
@@ -247,10 +247,10 @@ void Rivet_PerInterpInit(rivet_thread_interp* interp_obj,
globals = ckalloc(sizeof(rivet_interp_globals));
Tcl_SetAssocData (interp,"rivet",NULL,globals);
-
+
/*
* the ::rivet namespace is the only information still stored
- * in the interpreter global data
+ * in the interpreter global data
*/
/* Rivet commands namespace is created */
@@ -273,7 +273,7 @@ void Rivet_PerInterpInit(rivet_thread_interp* interp_obj,
if (Tcl_ListObjReplace(interp,auto_path,0,0,1,&rivet_tcl) == TCL_ERROR)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, s,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, s,
MODNAME ": error setting auto_path: %s",
Tcl_GetStringFromObj(auto_path,NULL));
} else {
@@ -284,9 +284,9 @@ void Rivet_PerInterpInit(rivet_thread_interp* interp_obj,
/* If the thread has private data we stuff the server conf
* pointer in the 'running_conf' field.
- * Commands running ouside a request processing must figure out
- * themselves how get a pointer to the configuration from the
- * context (e.g. ::rivet::inspect)
+ * Commands running ouside a request processing must figure out
+ * themselves how get a pointer to the configuration from the
+ * context (e.g. ::rivet::inspect)
*/
if (private != NULL) private->running_conf = RIVET_SERVER_CONF (s->module_config);
@@ -322,10 +322,10 @@ void Rivet_PerInterpInit(rivet_thread_interp* interp_obj,
/* -- Rivet_NewVHostInterp
*
* Returns a new rivet_thread_interp object with a new Tcl interpreter
- * configuration scripts and cache. The pool passed to Rivet_NewVHostInterp
+ * configuration scripts and cache. The pool passed to Rivet_NewVHostInterp
*
- * Arguments:
- * apr_pool_t* pool: a memory pool, it must be the private pool of a
+ * Arguments:
+ * apr_pool_t* pool: a memory pool, it must be the private pool of a
* rivet_thread_private object (thread private)
*
* Returned value:
@@ -339,13 +339,13 @@ rivet_thread_interp* Rivet_NewVHostInterp(apr_pool_t *pool,int default_cache_siz
/* This calls needs the root server_rec just for logging purposes */
- interp_obj->interp = Rivet_CreateTclInterp(pool);
+ interp_obj->interp = Rivet_CreateTclInterp(pool);
/* we now create memory from the cache pool as subpool of the thread private pool */
-
+
if (apr_pool_create(&interp_obj->pool, pool) != APR_SUCCESS)
{
- ap_log_perror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, pool,
+ ap_log_perror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, pool,
MODNAME ": could not initialize cache private pool");
return NULL;
}
@@ -354,7 +354,7 @@ rivet_thread_interp* Rivet_NewVHostInterp(apr_pool_t *pool,int default_cache_siz
* for compatibility with mod_rivet current version, but these values must become
* integers not pointers
*/
-
+
if (default_cache_size < 0) {
interp_obj->cache_size = RivetCache_DefaultSize();
} else if (default_cache_size > 0) {
@@ -366,12 +366,12 @@ rivet_thread_interp* Rivet_NewVHostInterp(apr_pool_t *pool,int default_cache_siz
// Initialize cache structures
if (interp_obj->cache_size) {
- RivetCache_Create(pool,interp_obj);
+ RivetCache_Create(pool,interp_obj);
}
interp_obj->flags = 0;
interp_obj->scripts = (running_scripts *) apr_pcalloc(pool,sizeof(running_scripts));
- interp_obj->per_dir_scripts = apr_hash_make(pool);
+ interp_obj->per_dir_scripts = apr_hash_make(pool);
return interp_obj;
}
@@ -411,7 +411,7 @@ Rivet_CreateRivetChannel(apr_pool_t* pPool, apr_threadkey_t* rivet_thread_key)
Tcl_SetStdChannel (*(outchannel), TCL_STDOUT);
- /* Set the output buffer size to the largest allowed value, so that we
+ /* Set the output buffer size to the largest allowed value, so that we
* won't send any result packets to the browser unless the Rivet
* programmer does a "flush stdout" or the page is completed.
*/
@@ -439,30 +439,30 @@ Rivet_CreateRivetChannel(apr_pool_t* pPool, apr_threadkey_t* rivet_thread_key)
*
* Side Effects:
*
- * channel debug counter decremented (TODO)
+ * channel debug counter decremented (TODO)
*
*-----------------------------------------------------------------------------
*/
-void
+void
Rivet_ReleaseRivetChannel (Tcl_Interp* interp, Tcl_Channel* channel)
{
- Tcl_UnregisterChannel(interp,*channel);
+ Tcl_UnregisterChannel(interp,*channel);
}
/*-----------------------------------------------------------------------------
*
- * -- Rivet_CreatePrivateData
+ * -- Rivet_CreatePrivateData
*
* Creates a thread private data object
*
* Arguments:
- *
+ *
* - apr_threadkey_t* rivet_thread_key
*
* Returned value:
- *
+ *
* - rivet_thread_private* private data object
*
*-----------------------------------------------------------------------------
@@ -478,9 +478,9 @@ rivet_thread_private* Rivet_CreatePrivateData (void)
private = apr_pcalloc (module_globals->pool,sizeof(*private));
apr_thread_mutex_unlock(module_globals->pool_mutex);
- if (apr_pool_create (&private->pool, NULL) != APR_SUCCESS)
+ if (apr_pool_create (&private->pool, NULL) != APR_SUCCESS)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
MODNAME ": could not create thread private pool");
return NULL;
}
@@ -497,7 +497,7 @@ rivet_thread_private* Rivet_CreatePrivateData (void)
}
/*
- * -- Rivet_ExecutionThreadInit
+ * -- Rivet_ExecutionThreadInit
*
* We keep here the basic initilization each execution thread should undergo
*
@@ -529,12 +529,12 @@ rivet_thread_private* Rivet_ExecutionThreadInit (void)
*
* Returned value:
*
- * - initialized rivet_thread_private* data record
- *
+ * - initialized rivet_thread_private* data record
+ *
*-----------------------------------------------------------------------------
*/
-rivet_thread_private*
+rivet_thread_private*
Rivet_SetupTclPanicProc (void)
{
rivet_thread_private* private;
@@ -578,13 +578,13 @@ void Rivet_Panic TCL_VARARGS_DEF(CONST char *, arg1)
buf = (char *) apr_pvsprintf(private->rivet_panic_pool, format, argList);
if (private->rivet_panic_request_rec != NULL) {
- ap_log_error(APLOG_MARK, APLOG_CRIT, APR_EGENERAL,
+ ap_log_error(APLOG_MARK, APLOG_CRIT, APR_EGENERAL,
private->rivet_panic_server_rec,
- MODNAME ": Critical error in request: %s",
+ MODNAME ": Critical error in request: %s",
private->rivet_panic_request_rec->unparsed_uri);
}
- ap_log_error(APLOG_MARK, APLOG_CRIT, APR_EGENERAL,
+ ap_log_error(APLOG_MARK, APLOG_CRIT, APR_EGENERAL,
private->rivet_panic_server_rec, "%s", buf);
abort();
@@ -595,9 +595,9 @@ void Rivet_Panic TCL_VARARGS_DEF(CONST char *, arg1)
*
* This function is meant to release memory and resorces
* owned by a thread.
- * The handler in general is not guaranteed to be called
- * within the same thread that created the resources to
- + release. As such it's useless to release any Tcl
+ * The handler in general is not guaranteed to be called
+ * within the same thread that created the resources to
+ + release. As such it's useless to release any Tcl
* related resorces (e.g. a Tcl_Interp* object) as
* any threaded build of Tcl uses its own thread private
* data. We leave the function as a placeholder
@@ -644,8 +644,8 @@ void Rivet_CleanupRequest( request_rec *r )
* RIVET_INIT - Rivet's init.tcl file
* RIVET_VERSION - Rivet version (only when RIVET_DISPLAY_VERSION is 1)
* MPM_THREADED - It should contain the string 'unsupported' for a prefork MPM
- * MPM_FORKED - String describing the forking model of the MPM
- * RIVET_MPM_BRIDGE - Filename of the running MPM bridge
+ * MPM_FORKED - String describing the forking model of the MPM
+ * RIVET_MPM_BRIDGE - Filename of the running MPM bridge
*
*/
@@ -703,7 +703,7 @@ void Rivet_InitServerVariables( Tcl_Interp *interp, apr_pool_t *pool )
if (ap_mpm_query(AP_MPMQ_IS_THREADED,&ap_mpm_result) == APR_SUCCESS)
{
- switch (ap_mpm_result)
+ switch (ap_mpm_result)
{
case AP_MPMQ_STATIC:
obj = Tcl_NewStringObj("static", -1);
@@ -711,7 +711,7 @@ void Rivet_InitServerVariables( Tcl_Interp *interp, apr_pool_t *pool )
case AP_MPMQ_NOT_SUPPORTED:
obj = Tcl_NewStringObj("unsupported", -1);
break;
- default:
+ default:
obj = Tcl_NewStringObj("undefined", -1);
break;
}
@@ -722,7 +722,7 @@ void Rivet_InitServerVariables( Tcl_Interp *interp, apr_pool_t *pool )
if (ap_mpm_query(AP_MPMQ_IS_FORKED,&ap_mpm_result) == APR_SUCCESS)
{
- switch (ap_mpm_result)
+ switch (ap_mpm_result)
{
case AP_MPMQ_STATIC:
obj = Tcl_NewStringObj("static", -1);
@@ -730,7 +730,7 @@ void Rivet_InitServerVariables( Tcl_Interp *interp, apr_pool_t *pool )
case AP_MPMQ_DYNAMIC:
obj = Tcl_NewStringObj("dynamic", -1);
break;
- default:
+ default:
obj = Tcl_NewStringObj("undefined", -1);
break;
}
@@ -747,7 +747,7 @@ void Rivet_InitServerVariables( Tcl_Interp *interp, apr_pool_t *pool )
obj,
TCL_GLOBAL_ONLY);
Tcl_DecrRefCount(obj);
-
+
obj = Tcl_NewStringObj(RIVET_CONFIGURE_CMD,-1);
Tcl_IncrRefCount(obj);
Tcl_SetVar2Ex(interp,
@@ -761,21 +761,21 @@ void Rivet_InitServerVariables( Tcl_Interp *interp, apr_pool_t *pool )
/*
* -- Rivet_chdir_file (const char* filename)
- *
+ *
* Determines the directory name from the filename argument
* and sets it as current working directory
*
* Argument:
- *
+ *
* const char* filename: file name to be used for determining
* the current directory (URI style path)
* the directory name is everything comes
* before the last '/' (slash) character
*
- * This snippet of code came from the mod_ruby project,
+ * This snippet of code came from the mod_ruby project,
* which is under a BSD license.
*/
-
+
int Rivet_chdir_file (const char *file)
{
const char *x;
@@ -798,7 +798,7 @@ int Rivet_chdir_file (const char *file)
chdir_retval = chdir(chdir_buf);
#endif
}
-
+
return chdir_retval;
}
diff --git a/src/mod_rivet_ng/mod_rivet_common.h b/src/mod_rivet_ng/mod_rivet_common.h
index 2e147f2..e252632 100644
--- a/src/mod_rivet_ng/mod_rivet_common.h
+++ b/src/mod_rivet_ng/mod_rivet_common.h
@@ -1,4 +1,4 @@
-/* -- mod_rivet_common.h Declariations for common utility functions */
+/* -- mod_rivet_common.h Declariations for common utility functions */
/*
Licensed to the Apache Software Foundation (ASF) under one
diff --git a/src/mod_rivet_ng/mod_rivet_generator.c b/src/mod_rivet_ng/mod_rivet_generator.c
index 0be2a00..9025c90 100644
--- a/src/mod_rivet_ng/mod_rivet_generator.c
+++ b/src/mod_rivet_ng/mod_rivet_generator.c
@@ -43,7 +43,7 @@ extern apr_threadkey_t* rivet_thread_key;
extern module rivet_module;
-/*
+/*
* -- Rivet_CheckType (request_rec *r)
*
* Utility function internally used to determine which type
@@ -52,7 +52,7 @@ extern module rivet_module;
* the test returns an integer (RIVET_TEMPLATE) for rvt templates
* or RIVET_TCLFILE for Tcl scripts
*
- * Argument:
+ * Argument:
*
* request_rec*: pointer to the current request record
*
@@ -78,14 +78,14 @@ Rivet_CheckType (request_rec *req)
ctype = RIVET_TCLFILE;
}
}
- return ctype;
+ return ctype;
}
/*
* -- Rivet_ReleaseScript
*
*
- *
+ *
*
*
*/
@@ -122,8 +122,8 @@ Rivet_SendContent(rivet_thread_private *private)
/* Set the global request req to know what we are dealing with in
* case we have to call the PanicProc. */
- /* TODO: we can't place a pointer to the request rec here, if Tcl_Panic
- gets called in general it won't have this pointer which has to be
+ /* TODO: we can't place a pointer to the request rec here, if Tcl_Panic
+ gets called in general it won't have this pointer which has to be
thread private */
private->rivet_panic_request_rec = private->r;
@@ -148,19 +148,19 @@ Rivet_SendContent(rivet_thread_private *private)
{
rivet_server_conf* rdc = NULL;
- rdc = RIVET_SERVER_CONF(private->r->per_dir_config);
+ rdc = RIVET_SERVER_CONF(private->r->per_dir_config);
if ((rdc != NULL) && (rdc->path))
{
/* Let's check if a scripts object is already stored in the per-dir hash table */
- private->running =
+ private->running =
(running_scripts *) apr_hash_get (interp_obj->per_dir_scripts,rdc->path,strlen(rdc->path));
if (private->running == NULL)
{
rivet_server_conf* newconfig = NULL;
- running_scripts* scripts =
+ running_scripts* scripts =
(running_scripts *) apr_pcalloc (private->pool,sizeof(running_scripts));
newconfig = RIVET_NEW_CONF(private->r->pool);
@@ -211,9 +211,9 @@ Rivet_SendContent(rivet_thread_private *private)
private->r->allowed |= (1 << M_POST);
private->r->allowed |= (1 << M_PUT);
private->r->allowed |= (1 << M_DELETE);
- if (private->r->method_number != M_GET &&
- private->r->method_number != M_POST &&
- private->r->method_number != M_PUT &&
+ if (private->r->method_number != M_GET &&
+ private->r->method_number != M_POST &&
+ private->r->method_number != M_PUT &&
private->r->method_number != M_DELETE) {
retval = DECLINED;
@@ -225,7 +225,7 @@ Rivet_SendContent(rivet_thread_private *private)
{
request_rec* r = private->r;
- ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR, APR_EGENERAL,
+ ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR, APR_EGENERAL,
private->r->server,
MODNAME ": File does not exist: %s",
(r->path_info ? (char*)apr_pstrcat(r->pool, r->filename, r->path_info, NULL) : r->filename));
@@ -238,7 +238,7 @@ Rivet_SendContent(rivet_thread_private *private)
goto sendcleanup;
}
- /*
+ /*
* This one is the big catch when it comes to moving towards
* Apache 2.0, or one of them, at least.
*/
@@ -250,8 +250,8 @@ Rivet_SendContent(rivet_thread_private *private)
/* something went wrong doing chdir into r->filename, we are not specific
* at this. We simply emit an internal server error and print a log message
*/
- ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR, APR_EGENERAL, r->server,
- MODNAME ": Error accessing %s, could not chdir into directory",
+ ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR, APR_EGENERAL, r->server,
+ MODNAME ": Error accessing %s, could not chdir into directory",
r->filename);
retval = HTTP_INTERNAL_SERVER_ERROR;
@@ -287,7 +287,7 @@ Rivet_SendContent(rivet_thread_private *private)
doing caching on the modification time of the .htaccess files
that concern us. FIXME */
- if (USER_CONF_UPDATED(private->running_conf) && (interp_obj->cache_size != 0) &&
+ if (USER_CONF_UPDATED(private->running_conf) && (interp_obj->cache_size != 0) &&
(interp_obj->cache_free < interp_obj->cache_size))
{
RivetCache_Cleanup(private,interp_obj);
@@ -295,15 +295,15 @@ Rivet_SendContent(rivet_thread_private *private)
/* Rivet's master request script execution and exception handling */
- if (Tcl_EvalObjEx(interp, private->running->request_processing,0) == TCL_ERROR)
+ if (Tcl_EvalObjEx(interp, private->running->request_processing,0) == TCL_ERROR)
{
/* we don't report errors coming from abort_page execution */
- if (!private->page_aborting)
+ if (!private->page_aborting)
{
request_rec* r = private->r;
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, r->server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, r->server,
MODNAME ": Error parsing exec file '%s': %s",
r->filename, Tcl_GetVar(interp, "errorInfo", 0));
}
@@ -336,10 +336,10 @@ sendcleanup:
* has been evaluated the exit condition is checked and the bridge
* exit handler is called upon.
*/
-
+
if (private->thread_exit)
{
- ap_log_rerror(APLOG_MARK,APLOG_DEBUG,APR_SUCCESS,private->r,
+ ap_log_rerror(APLOG_MARK,APLOG_DEBUG,APR_SUCCESS,private->r,
"process terminating with code %d",private->exit_status);
RIVET_MPM_BRIDGE_CALL(exit_handler,private);
diff --git a/src/mod_rivet_ng/rivetChannel.c b/src/mod_rivet_ng/rivetChannel.c
index d6ec90f..8b55236 100644
--- a/src/mod_rivet_ng/rivetChannel.c
+++ b/src/mod_rivet_ng/rivetChannel.c
@@ -53,7 +53,7 @@ outputproc(ClientData instancedata, CONST84 char *buf, int toWrite, int *errorCo
{
apr_threadkey_t* rivet_thread_key = (apr_threadkey_t*) instancedata;
rivet_thread_private* private;
-
+
apr_threadkey_private_get ((void **)&private,rivet_thread_key);
TclWeb_PrintHeaders(private->req);
diff --git a/src/mod_rivet_ng/rivetCore.c b/src/mod_rivet_ng/rivetCore.c
index eb1ef3d..147dfc8 100644
--- a/src/mod_rivet_ng/rivetCore.c
+++ b/src/mod_rivet_ng/rivetCore.c
@@ -77,7 +77,7 @@ extern apr_threadkey_t* rivet_thread_key;
/*
* -- Rivet_NoRequestRec
*
- * Adds standard error information to the interpreter. This procedure makes
+ * Adds standard error information to the interpreter. This procedure makes
* sense only when called by C functions implementing Tcl commands that
* are meaningful only if a valid requiest_rec object is defined. These
* procedures must return TCL_ERROR right away after Rivet_NoRequestRecord
@@ -157,9 +157,9 @@ TCL_CMD_HEADER( Rivet_MakeURL )
if (script_name_l > 0)
{
- // script name may have the form a directory path (and mod_rewrite
+ // script name may have the form a directory path (and mod_rewrite
// could have mapped it to a .tcl or .rvt script)
-
+
if (script_name[script_name_l-1] == '/')
{
url_target_name = apr_pstrcat(private->req->req->pool,script_name,url_target_name,NULL);
@@ -176,7 +176,7 @@ TCL_CMD_HEADER( Rivet_MakeURL )
}
}
- result = Tcl_NewObj();
+ result = Tcl_NewObj();
TclWeb_MakeURL(result, url_target_name, private->req);
Tcl_SetObjResult(interp, result);
@@ -247,7 +247,7 @@ TCL_CMD_HEADER( Rivet_Parse )
if (Rivet_Parser(outbuf, script) == 0)
{
Tcl_AppendToObj(outbuf, "\"\n", 2);
- }
+ }
Tcl_AppendToObj(outbuf,"\n",-1);
@@ -257,7 +257,7 @@ TCL_CMD_HEADER( Rivet_Parse )
return res;
//return Rivet_ParseExecString(private, objv[2]);
- } else {
+ } else {
Tcl_WrongNumArgs( interp, 1, objv, "?-virtual? filename | -string template_string" );
return TCL_ERROR;
@@ -283,7 +283,7 @@ TCL_CMD_HEADER( Rivet_Parse )
/* */
- cache_key =
+ cache_key =
RivetCache_MakeKey( private->pool,filename,
finfo_b.ctime,finfo_b.mtime,
IS_USER_CONF(private->running_conf),0);
@@ -325,10 +325,10 @@ TCL_CMD_HEADER( Rivet_Parse )
result = Tcl_EvalObjEx(interp,script,0);
Tcl_DecrRefCount(script);
return result;
-
+
} else {
script = RivetCache_FetchScript(entry);
- return Tcl_EvalObjEx(interp,script,0);
+ return Tcl_EvalObjEx(interp,script,0);
}
}
@@ -486,7 +486,7 @@ TCL_CMD_HEADER( Rivet_Headers )
return TCL_ERROR;
}
- header_value = TclWeb_OutputHeaderGet(Tcl_GetString(objv[2]),private->req);
+ header_value = TclWeb_OutputHeaderGet(Tcl_GetString(objv[2]),private->req);
Tcl_SetObjResult(interp,Tcl_NewStringObj(header_value ? header_value : "",-1));
}
@@ -655,7 +655,7 @@ TCL_CMD_HEADER ( Rivet_LoadHeaders )
TCL_CMD_HEADER ( Rivet_Var )
{
rivet_thread_private* private;
- const char* cmd;
+ const char* cmd;
char* command;
Tcl_Obj* result = NULL;
int source;
@@ -677,7 +677,7 @@ TCL_CMD_HEADER ( Rivet_Var )
/* determine if var_qs, var_post or var was called */
/* first of all we have to skip the namespace string at the beginning of the command:
- *
+ *
* This fragment of code is taken from tcl 8.6.6 (tclNamesp.c) and it's part of the
* function implementing Tcl "namespace tail", as such it should be authoritative
* regarding the stripping of the namespace from a FQ command name
@@ -686,7 +686,7 @@ TCL_CMD_HEADER ( Rivet_Var )
for (p = cmd; *p != '\0'; p++) {
/* empty body */
}
-
+
while (--p > cmd) {
if ((*p == ':') && (*(p-1) == ':')) {
p++; /* Just after the last "::" */
@@ -808,9 +808,9 @@ TCL_CMD_HEADER ( Rivet_Var )
return TCL_ERROR;
}
- for (; !done ; Tcl_DictObjNext(&search, &key, &value, &done))
+ for (; !done ; Tcl_DictObjNext(&search, &key, &value, &done))
{
- if (Tcl_DictObjGet(interp,result,key,&valuePtr) == TCL_OK)
+ if (Tcl_DictObjGet(interp,result,key,&valuePtr) == TCL_OK)
{
if (valuePtr == NULL)
{
@@ -1209,7 +1209,7 @@ TCL_CMD_HEADER( Rivet_Upload )
Tcl_SetIntObj(result,upload_prepared);
Tcl_SetObjResult(interp, result);
return TCL_OK;
-
+
}
if (tcl_status != TCL_OK)
@@ -1358,7 +1358,7 @@ TCL_CMD_HEADER( Rivet_AbortPageCmd )
if (objc == 2)
{
char* cmd_arg = Tcl_GetStringFromObj(objv[1],NULL);
-
+
if (strcmp(cmd_arg,"-aborting") == 0)
{
Tcl_SetObjResult (interp,Tcl_NewBooleanObj(private->page_aborting));
@@ -1370,12 +1370,12 @@ TCL_CMD_HEADER( Rivet_AbortPageCmd )
Tcl_SetObjResult (interp,Tcl_NewBooleanObj(private->thread_exit));
return TCL_OK;
}
-
- /*
+
+ /*
* we assume abort_code to be null, as abort_page shouldn't run twice while
- * processing the same request
+ * processing the same request
*/
-
+
if (private->abort_code == NULL)
{
private->abort_code = objv[1];
@@ -1383,7 +1383,7 @@ TCL_CMD_HEADER( Rivet_AbortPageCmd )
}
}
- /*
+ /*
* If page_aborting is true then this is the second call to abort_page
* processing the same request: we ignore it and return a normal
* completion code
@@ -1396,7 +1396,7 @@ TCL_CMD_HEADER( Rivet_AbortPageCmd )
/* this is the first (and supposedly unique) abort_page call during this request */
- /* we eleveta the page_aborting flag to the actual flag controlling the page abort execution.
+ /* we eleveta the page_aborting flag to the actual flag controlling the page abort execution.
* We still return the RIVET and ABORTPAGE_CODE, but internally
* its page_aborting that will drive the code execution after abort_page
*/
@@ -1410,9 +1410,9 @@ TCL_CMD_HEADER( Rivet_AbortPageCmd )
/*
*-----------------------------------------------------------------------------
- * Rivet_AbortCodeCmd --
+ * Rivet_AbortCodeCmd --
*
- * Returns the abort code stored internally by passing a user defined parameter
+ * Returns the abort code stored internally by passing a user defined parameter
* to the command 'abort_page'.
*
*
@@ -1421,7 +1421,7 @@ TCL_CMD_HEADER( Rivet_AbortPageCmd )
TCL_CMD_HEADER( Rivet_AbortCodeCmd )
{
rivet_thread_private* private;
-
+
THREAD_PRIVATE_DATA(private)
if (private->abort_code != NULL)
@@ -1454,7 +1454,7 @@ TCL_CMD_HEADER( Rivet_EnvCmd )
char* key;
char* val;
rivet_thread_private* private;
-
+
THREAD_PRIVATE_DATA(private)
CHECK_REQUEST_REC(private,"::rivet::env")
@@ -1480,14 +1480,14 @@ TCL_CMD_HEADER( Rivet_EnvCmd )
* as 'worker') the procedure should cause a thread to exit, not the
* whole process with all its threads. In this case the procedure
* returns an TCL_ERROR code that has to be handled in mod_rivet so that
- * the error is ignored and the request procedure interrupted.
- * For a non threaded MPM (such as 'prefork') the single child process
- * exits thus reproducing an ordinary 'exit' command.
+ * the error is ignored and the request procedure interrupted.
+ * For a non threaded MPM (such as 'prefork') the single child process
+ * exits thus reproducing an ordinary 'exit' command.
*
* Result:
*
- * TCL_ERROR
- *
+ * TCL_ERROR
+ *
* Side Effects:
*
* - non threaded MPMs: the child process exits for good
@@ -1519,13 +1519,13 @@ TCL_CMD_HEADER( Rivet_ExitCmd )
private->page_aborting = 1;
private->abort_code = Tcl_NewDictObj();
- /* The private->abort_code ref count is decremented before
+ /* The private->abort_code ref count is decremented before
* request processing terminates */
Tcl_IncrRefCount(private->abort_code);
/*
- * mod_rivet traps call to exit and offers a chance to handle them
+ * mod_rivet traps call to exit and offers a chance to handle them
* in the way we handle ::rivet::abort_page calls
*/
@@ -1590,7 +1590,7 @@ TCL_CMD_HEADER( Rivet_VirtualFilenameCmd )
*
* Rivet_Inspect --
*
- * Rivet configuration introspection. Command '::rivet::inspect'
+ * Rivet configuration introspection. Command '::rivet::inspect'
* returns a dictionary of configuration data:
*
* Results:
@@ -1602,7 +1602,7 @@ TCL_CMD_HEADER( Rivet_VirtualFilenameCmd )
TCL_CMD_HEADER( Rivet_InspectCmd )
{
rivet_thread_private* private;
- rivet_server_conf* rsc;
+ rivet_server_conf* rsc;
int status = TCL_OK;
THREAD_PRIVATE_DATA(private)
@@ -1612,7 +1612,7 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
Tcl_Obj* dictObj;
CHECK_REQUEST_REC(private,"::rivet::inspect")
- rsc = Rivet_GetConf(private->r);
+ rsc = Rivet_GetConf(private->r);
dictObj = Rivet_BuildConfDictionary(interp,rsc);
if (dictObj != NULL) {
Tcl_IncrRefCount(dictObj);
@@ -1646,7 +1646,7 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
cmd = Tcl_NewStringObj("info script",-1);
- Tcl_IncrRefCount(cmd);
+ Tcl_IncrRefCount(cmd);
status = Tcl_EvalObjEx(interp,cmd,TCL_EVAL_DIRECT);
Tcl_DecrRefCount(cmd);
@@ -1654,12 +1654,12 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
else if (STRNEQU(cmd_arg,"-all"))
{
Tcl_Obj* dictObj;
-
+
CHECK_REQUEST_REC(private,"::rivet::inspect -all")
- rsc = Rivet_GetConf(private->r);
+ rsc = Rivet_GetConf(private->r);
dictObj = Rivet_CurrentConfDict(interp,rsc);
Tcl_IncrRefCount(dictObj);
- Tcl_SetObjResult(interp,dictObj);
+ Tcl_SetObjResult(interp,dictObj);
Tcl_DecrRefCount(dictObj);
}
@@ -1673,7 +1673,7 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
} else {
if (private->r == NULL) {
- srec = module_globals->server;
+ srec = module_globals->server;
} else {
srec = private->r->server;
}
@@ -1684,14 +1684,14 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
dictObj = Rivet_CurrentServerRec(interp,srec);
Tcl_IncrRefCount(dictObj);
- Tcl_SetObjResult(interp,dictObj);
+ Tcl_SetObjResult(interp,dictObj);
Tcl_DecrRefCount(dictObj);
}
else if (STRNEQU(cmd_arg,"exit"))
{
Tcl_Obj* exit_flag;
-
+
CHECK_REQUEST_REC(private,"::rivet::inspect")
/* thread exit status flag */
exit_flag = Tcl_NewIntObj(private->thread_exit);
@@ -1712,7 +1712,7 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
if (private->r == NULL) {
rsc = private->running_conf;
} else {
- rsc = Rivet_GetConf(private->r);
+ rsc = Rivet_GetConf(private->r);
}
}
@@ -1739,7 +1739,7 @@ TCL_CMD_HEADER( Rivet_InspectCmd )
Tcl_DecrRefCount(par_name);
}
- else
+ else
{
Tcl_WrongNumArgs( interp, 1, objv, "?server | dir | user? ?parameter name?" );
status = TCL_ERROR;
@@ -1868,7 +1868,7 @@ TCL_CMD_HEADER( Rivet_LogErrorCmd )
* Calls the panic routine.
*
* Results:
- * Always returns TCL_OK.
+ * Always returns TCL_OK.
*
* Side effects:
* May exit application.
@@ -1924,7 +1924,7 @@ TCL_CMD_HEADER( Rivet_UrlScript )
Tcl_HashEntry* entry = NULL;
Tcl_Obj* script = NULL;
int result;
- unsigned int user_conf;
+ unsigned int user_conf;
time_t ctime;
time_t mtime;
@@ -1942,7 +1942,7 @@ TCL_CMD_HEADER( Rivet_UrlScript )
if (entry == NULL)
{
Tcl_Interp* interp;
-
+
interp = rivet_interp->interp;
script = Tcl_NewObj();
@@ -1974,11 +1974,11 @@ TCL_CMD_HEADER( Rivet_UrlScript )
Tcl_HashEntry* entry;
entry = RivetCache_CreateEntry (rivet_interp,cache_key,&isNew);
-
+
/* Sanity check: we are here for this reason */
ap_assert(isNew == 1);
-
+
/* we proceed storing the script in the cache */
RivetCache_StoreScript(rivet_interp,entry,script);
@@ -2009,7 +2009,7 @@ TCL_CMD_HEADER( Rivet_UrlScript )
* With a threaded bridge (worker and lazy) command [pid] on Unix systems return
* the same process id when called from all threads running within that process.
* For any debugging reason this command returns a unique thread identification
- * that can, for instance, be matched with the thread id (tid) information
+ * that can, for instance, be matched with the thread id (tid) information
* in the error log file.
*
* Arguments:
@@ -2066,7 +2066,7 @@ TCL_CMD_HEADER( Rivet_GetThreadId )
Tcl_AddObjErrorInfo(interp,"Wrong argument: it must be -decimal | -hex", -1);
return TCL_ERROR;
}
- }
+ }
else if (objc > 2)
{
Tcl_WrongNumArgs(interp,1,objv,"-decimal | -hex" );
@@ -2093,7 +2093,7 @@ TCL_CMD_HEADER( Rivet_GetThreadId )
* documented within the 'Rivet Internals' section of the manual
*
* Results:
- *
+ *
* a Tcl list of the keys in the interpreter cache
*
* Side Effects:
@@ -2114,12 +2114,12 @@ TCL_CMD_HEADER( Rivet_CacheContent )
rivet_interp = RIVET_PEEK_INTERP(private,private->running_conf);
interp = rivet_interp->interp;
-
+
entry_list = Tcl_NewObj();
Tcl_IncrRefCount(entry_list);
ep = rivet_interp->cache_size - 1;
-
+
while ((ep >= 0) && (rivet_interp->objCacheList[ep]))
{
int tcl_status;
@@ -2158,7 +2158,7 @@ TCL_CMD_HEADER( Rivet_CacheContent )
DLLEXPORT int
Rivet_InitCore(Tcl_Interp *interp,rivet_thread_private* private)
{
- rivet_server_conf* server_conf;
+ rivet_server_conf* server_conf;
RIVET_OBJ_CMD ("makeurl",Rivet_MakeURL,private);
RIVET_OBJ_CMD ("headers",Rivet_Headers,private);
@@ -2182,7 +2182,7 @@ Rivet_InitCore(Tcl_Interp *interp,rivet_thread_private* private)
RIVET_OBJ_CMD ("exit",Rivet_ExitCmd,private);
RIVET_OBJ_CMD ("url_script",Rivet_UrlScript,private);
RIVET_OBJ_CMD ("thread_id",Rivet_GetThreadId,private);
-
+
#ifdef RIVET_DEBUG_BUILD
/* code compiled conditionally for debugging */
RIVET_OBJ_CMD ("cache_content",Rivet_CacheContent,private);
diff --git a/src/mod_rivet_ng/rivetInspect.c b/src/mod_rivet_ng/rivetInspect.c
index 148dee8..767a84b 100644
--- a/src/mod_rivet_ng/rivetInspect.c
+++ b/src/mod_rivet_ng/rivetInspect.c
@@ -52,9 +52,9 @@ static const char* loglevel_defs[] =
/* These arrays must be kept aligned. confDirectives must be NULL terminated */
-static const char* confDirectives[] =
-{
- "ServerInitScript",
+static const char* confDirectives[] =
+{
+ "ServerInitScript",
"GlobalInitScript",
"ChildInitScript",
"ChildExitScript",
@@ -73,7 +73,7 @@ static const char* confDirectives[] =
"RequestHandler",
"ExportRivetNS",
"ImportRivetNS",
- NULL
+ NULL
};
enum confIndices {
@@ -96,18 +96,18 @@ enum confIndices {
request_handler,
export_rivet_ns,
import_rivet_ns,
- conf_index_terminator
+ conf_index_terminator
};
extern mod_rivet_globals* module_globals;
-/*
+/*
* -- Rivet_ReadConfParameter
*
- * This procedure reads a single field named par_name from
+ * This procedure reads a single field named par_name from
* rivet_server_conf structure and returns a Tcl_Obj pointer
* containing the field value. See confDirectives for a list
- * of possible names. If the procedure is queried for a non
+ * of possible names. If the procedure is queried for a non
* existing field a NULL is returned.
*
* Arguments:
@@ -131,7 +131,7 @@ Rivet_ReadConfParameter ( Tcl_Interp* interp,
Tcl_Obj* par_name)
{
int parameter_i;
- Tcl_Obj* int_value = NULL;
+ Tcl_Obj* int_value = NULL;
char* string_value = NULL;
if (Tcl_GetIndexFromObj(interp, par_name, confDirectives,
@@ -180,7 +180,7 @@ Rivet_ReadConfParameter ( Tcl_Interp* interp,
/* otherwise if string_value is defined we return it as Tcl_Obj*/
return Tcl_NewStringObj(string_value,-1);
- }
+ }
else
{
/* there is no other possible case: int_value must be returned */
@@ -190,11 +190,11 @@ Rivet_ReadConfParameter ( Tcl_Interp* interp,
}
-/*
- * Rivet_ReadConfTable:
- *
+/*
+ * Rivet_ReadConfTable:
+ *
* This procedure builds a key-value list from an apr table
- * It's called by Rivet_BuildConfDictionary to read theRivet
+ * It's called by Rivet_BuildConfDictionary to read theRivet
* configuration tables but it can work for every apr table
*
* Arguments:
@@ -204,7 +204,7 @@ Rivet_ReadConfParameter ( Tcl_Interp* interp,
*
*/
-static Tcl_Obj*
+static Tcl_Obj*
Rivet_ReadConfTable (Tcl_Interp* interp,
apr_table_t* table)
{
@@ -231,7 +231,7 @@ Rivet_ReadConfTable (Tcl_Interp* interp,
tcl_status = Tcl_ListObjAppendElement (interp,keyval_list,key);
if (tcl_status == TCL_ERROR)
- {
+ {
Tcl_DecrRefCount(keyval_list);
Tcl_DecrRefCount(key);
Tcl_DecrRefCount(val);
@@ -257,9 +257,9 @@ Rivet_ReadConfTable (Tcl_Interp* interp,
/*
* -- Rivet_BuildConfDictionary
- *
+ *
* Parameters set in the configuration files are collected in three
- * APR tables by Rivet_ServerConf,Rivet_DirConf and Rivet_UserConf.
+ * APR tables by Rivet_ServerConf,Rivet_DirConf and Rivet_UserConf.
*
* Arguments:
*
@@ -270,7 +270,7 @@ Rivet_ReadConfTable (Tcl_Interp* interp,
* Returned value:
*
* - Tcl dictionary storing the dir/user/server configuration. The
- * dictionary refCount is incremented
+ * dictionary refCount is incremented
*
*/
@@ -283,7 +283,7 @@ Tcl_Obj* Rivet_BuildConfDictionary ( Tcl_Interp* interp,
int it;
Tcl_Obj* conf_dict = Tcl_NewObj();
- static const char* section_names[] =
+ static const char* section_names[] =
{
"dir",
"user",
@@ -313,7 +313,7 @@ Tcl_Obj* Rivet_BuildConfDictionary ( Tcl_Interp* interp,
Tcl_Obj** objArrayPnt;
int objArrayCnt;
Tcl_Obj* val;
-
+
Tcl_IncrRefCount(keyval_list);
key_list[0] = Tcl_NewStringObj(section_names[it],-1);
@@ -347,7 +347,7 @@ Tcl_Obj* Rivet_BuildConfDictionary ( Tcl_Interp* interp,
/*
- * Rivet_CurrentConfDict
+ * Rivet_CurrentConfDict
*
* This function is called by Rivet_InspectCmd which implements command
* '::rivet::inspect -all'. The function returns a dictionary where every
@@ -363,14 +363,14 @@ Tcl_Obj* Rivet_BuildConfDictionary ( Tcl_Interp* interp,
*
* - a Tcl_Obj* pointer to a dictionary. The function is guaranteed to
* return a Tcl_Obj pointer
- *
+ *
*/
Tcl_Obj* Rivet_CurrentConfDict ( Tcl_Interp* interp,
rivet_server_conf* rivet_conf)
{
Tcl_Obj* dictObj = Tcl_NewObj();
- Tcl_Obj* par_name;
+ Tcl_Obj* par_name;
const char** p;
for (p = confDirectives; (*p) != NULL; p++)
@@ -396,19 +396,19 @@ Tcl_Obj* Rivet_CurrentConfDict ( Tcl_Interp* interp,
/*
* -- Rivet_CurrentServerRec
*
- * ::rivet::inspect provides also some basic access to
+ * ::rivet::inspect provides also some basic access to
* fields of the server_rec object.
*
- *
+ *
*/
-Tcl_Obj*
+Tcl_Obj*
Rivet_CurrentServerRec (Tcl_Interp* interp, server_rec* s )
{
- Tcl_Obj* dictObj;
+ Tcl_Obj* dictObj;
Tcl_Obj* field_name;
Tcl_Obj* field_value;
-
+
dictObj = Tcl_NewObj();
field_value = Tcl_NewStringObj(s->server_hostname,-1);
diff --git a/src/mod_rivet_ng/rivet_lazy_mpm.c b/src/mod_rivet_ng/rivet_lazy_mpm.c
index 7fbf136..9ac53d7 100644
--- a/src/mod_rivet_ng/rivet_lazy_mpm.c
+++ b/src/mod_rivet_ng/rivet_lazy_mpm.c
@@ -98,10 +98,10 @@ enum {
static void Lazy_RunConfScript (rivet_thread_private* private,lazy_tcl_worker* w,int init)
{
- Tcl_Obj* tcl_conf_script;
+ Tcl_Obj* tcl_conf_script;
Tcl_Interp* interp = private->ext->interp->interp;
void* function = NULL;
-
+
switch (init)
{
case child_global: function = w->conf->rivet_global_init_script;
@@ -116,16 +116,16 @@ static void Lazy_RunConfScript (rivet_thread_private* private,lazy_tcl_worker* w
tcl_conf_script = Tcl_NewStringObj(function,-1);
Tcl_IncrRefCount(tcl_conf_script);
- if (Tcl_EvalObjEx(interp,tcl_conf_script, 0) != TCL_OK)
+ if (Tcl_EvalObjEx(interp,tcl_conf_script, 0) != TCL_OK)
{
char* errmsg = "rivet_lazy_mpm.so: Error in configuration script: %s";
server_rec* root_server = module_globals->server;
ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL,root_server,
errmsg, function);
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL,root_server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL,root_server,
"errorCode: %s", Tcl_GetVar(interp, "errorCode", 0));
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL,root_server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL,root_server,
"errorInfo: %s", Tcl_GetVar(interp, "errorInfo", 0));
}
@@ -136,16 +136,16 @@ static void Lazy_RunConfScript (rivet_thread_private* private,lazy_tcl_worker* w
/*
* -- request_processor
*
- * The lazy bridge worker thread. This thread prepares its control data and
+ * The lazy bridge worker thread. This thread prepares its control data and
* will serve requests addressed to a given virtual host. Virtual host server
- * data are stored in the lazy_tcl_worker structure stored in the generic
+ * data are stored in the lazy_tcl_worker structure stored in the generic
* pointer argument 'data'
- *
+ *
*/
static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
{
- lazy_tcl_worker* w = (lazy_tcl_worker*) data;
+ lazy_tcl_worker* w = (lazy_tcl_worker*) data;
rivet_thread_private* private;
int idx;
rivet_server_conf* rsc;
@@ -159,7 +159,7 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
private = Rivet_ExecutionThreadInit();
/* A bridge creates and stores in private->ext its own thread private
- * data. The lazy bridge is no exception. We just need a flag controlling
+ * data. The lazy bridge is no exception. We just need a flag controlling
* the execution and an intepreter control structure */
private->ext = apr_pcalloc(private->pool,sizeof(mpm_bridge_specific));
@@ -168,7 +168,7 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
RIVET_POKE_INTERP(private,rsc,Rivet_NewVHostInterp(private->pool,rsc->default_cache_size));
private->ext->interp->channel = private->channel;
- /* The worker thread can respond to a single request at a time therefore
+ /* The worker thread can respond to a single request at a time therefore
must handle and register its own Rivet channel */
Tcl_RegisterChannel(private->ext->interp->interp,*private->channel);
@@ -176,14 +176,14 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
/* From the rivet_server_conf structure we determine what scripts we
* are using to serve requests */
- private->ext->interp->scripts =
+ private->ext->interp->scripts =
Rivet_RunningScripts (private->pool,private->ext->interp->scripts,rsc);
/* This is the standard Tcl interpreter initialization */
Rivet_PerInterpInit(private->ext->interp,private,w->server,private->pool);
-
- /* The child initialization is fired. Beware of the terminologic
+
+ /* The child initialization is fired. Beware of the terminologic
* trap: we inherited from fork capable systems the term 'child'
* meaning 'child process'. In this case the child init actually
* is a worker thread initialization, because in a threaded module
@@ -194,22 +194,22 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
idx = w->conf->idx;
- /* After the thread has run the configuration script we
+ /* After the thread has run the configuration script we
increment the threads counter */
apr_thread_mutex_lock(module_globals->mpm->vhosts[idx].mutex);
(module_globals->mpm->vhosts[idx].threads_count)++;
apr_thread_mutex_unlock(module_globals->mpm->vhosts[idx].mutex);
- /* The thread is now set up to serve request within the the
+ /* The thread is now set up to serve request within the the
* do...while loop controlled by private->keep_going */
apr_thread_mutex_lock(w->mutex);
- do
+ do
{
while ((w->status != init) && (w->status != thread_exit)) {
apr_thread_cond_wait(w->condition,w->mutex);
- }
+ }
if (w->status == thread_exit) {
private->ext->keep_going = false;
continue;
@@ -231,17 +231,17 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
apr_thread_cond_signal(w->condition);
while (w->status == done) {
apr_thread_cond_wait(w->condition,w->mutex);
- }
-
+ }
+
/* rescheduling itself in the array of idle threads */
-
+
apr_thread_mutex_lock(module_globals->mpm->vhosts[idx].mutex);
*(lazy_tcl_worker **) apr_array_push(module_globals->mpm->vhosts[idx].array) = w;
apr_thread_mutex_unlock(module_globals->mpm->vhosts[idx].mutex);
} while (private->ext->keep_going);
apr_thread_mutex_unlock(w->mutex);
-
+
Lazy_RunConfScript(private,w,child_exit);
ap_log_error(APLOG_MARK,APLOG_DEBUG,APR_SUCCESS,w->server,"processor thread orderly exit");
@@ -272,7 +272,7 @@ static lazy_tcl_worker* create_worker (apr_pool_t* pool,server_rec* server)
w->status = idle;
w->server = server;
ap_assert(apr_thread_mutex_create(&w->mutex,APR_THREAD_MUTEX_UNNESTED,pool) == APR_SUCCESS);
- ap_assert(apr_thread_cond_create(&w->condition, pool) == APR_SUCCESS);
+ ap_assert(apr_thread_cond_create(&w->condition, pool) == APR_SUCCESS);
apr_thread_create(&w->thread_id, NULL, request_processor, w, module_globals->pool);
return w;
@@ -280,7 +280,7 @@ static lazy_tcl_worker* create_worker (apr_pool_t* pool,server_rec* server)
/*
* -- LazyBridge_ChildInit
- *
+ *
* child process initialization. This function prepares the process
* data structures for virtual hosts and threads management
*
@@ -294,14 +294,14 @@ void LazyBridge_ChildInit (apr_pool_t* pool, server_rec* server)
module_globals->mpm = apr_pcalloc(pool,sizeof(mpm_bridge_status));
- /* This mutex is only used to consistently carry out these
+ /* This mutex is only used to consistently carry out these
* two tasks
*
- * - set the exit status of a child process (hopefully will be
- * unnecessary when Tcl is able again of calling
- * Tcl_DeleteInterp safely)
+ * - set the exit status of a child process (hopefully will be
+ * unnecessary when Tcl is able again of calling
+ * Tcl_DeleteInterp safely)
* - control the server_shutdown flag. Actually this is
- * not entirely needed because once set this flag
+ * not entirely needed because once set this flag
* is never reset to 0
*
*/
@@ -313,7 +313,7 @@ void LazyBridge_ChildInit (apr_pool_t* pool, server_rec* server)
/* the mpm->vhosts array is created with as many entries as the number of
* configured virtual hosts */
- module_globals->mpm->vhosts =
+ module_globals->mpm->vhosts =
(vhost *) apr_pcalloc(pool,module_globals->vhosts_count*sizeof(vhost));
ap_assert(module_globals->mpm->vhosts != NULL);
@@ -321,7 +321,7 @@ void LazyBridge_ChildInit (apr_pool_t* pool, server_rec* server)
* Each virtual host descriptor has its own mutex controlling
* the queue of available threads
*/
-
+
for (s = root_server; s != NULL; s = s->next)
{
int idx;
@@ -342,7 +342,7 @@ void LazyBridge_ChildInit (apr_pool_t* pool, server_rec* server)
/* -- LazyBridge_Request
*
- * The lazy bridge HTTP request function. This function
+ * The lazy bridge HTTP request function. This function
* stores the request_rec pointer into the lazy_tcl_worker
* structure which is used to communicate with a worker thread.
* Then the array of idle threads is checked and if empty
@@ -361,11 +361,11 @@ int LazyBridge_Request (request_rec* r,rivet_req_ctype ctype)
array = module_globals->mpm->vhosts[conf->idx].array;
apr_thread_mutex_lock(mutex);
- /* This request may have come while the child process was
- * shutting down. We cannot run the risk that incoming requests
- * may hang the child process by keeping its threads busy,
- * so we simply return an HTTP_INTERNAL_SERVER_ERROR.
- * This is hideous and explains why the 'exit' commands must
+ /* This request may have come while the child process was
+ * shutting down. We cannot run the risk that incoming requests
+ * may hang the child process by keeping its threads busy,
+ * so we simply return an HTTP_INTERNAL_SERVER_ERROR.
+ * This is hideous and explains why the 'exit' commands must
* be avoided at any costs when programming with mod_rivet
*/
@@ -381,7 +381,7 @@ int LazyBridge_Request (request_rec* r,rivet_req_ctype ctype)
if (apr_is_empty_array(array))
{
w = create_worker(module_globals->pool,r->server);
- //(module_globals->mpm->vhosts[conf->idx].threads_count)++;
+ //(module_globals->mpm->vhosts[conf->idx].threads_count)++;
}
else
{
@@ -390,7 +390,7 @@ int LazyBridge_Request (request_rec* r,rivet_req_ctype ctype)
apr_thread_mutex_unlock(mutex);
- /* Locking the thread descriptor structure mutex */
+ /* Locking the thread descriptor structure mutex */
apr_thread_mutex_lock(w->mutex);
w->r = r;
@@ -403,7 +403,7 @@ int LazyBridge_Request (request_rec* r,rivet_req_ctype ctype)
while (w->status != done) {
apr_thread_cond_wait(w->condition,w->mutex);
- }
+ }
ap_sts = w->ap_sts;
w->status = idle;
@@ -439,7 +439,7 @@ apr_status_t LazyBridge_Finalize (void* data)
int idx;
server_rec* server = (server_rec*) data;
rivet_server_conf* conf = RIVET_SERVER_CONF(server->module_config);
-
+
module_globals->mpm->server_shutdown = 1;
for (idx = 0; idx < module_globals->vhosts_count; idx++)
{
@@ -459,23 +459,23 @@ apr_status_t LazyBridge_Finalize (void* data)
apr_thread_mutex_unlock(mutex);
try = 0;
- while ((try++ < 3) && (count > 0))
+ while ((try++ < 3) && (count > 0))
{
ap_log_error(APLOG_MARK,APLOG_DEBUG,APR_SUCCESS,server,"waiting for %d thread to exit",count);
- if ((conf->idx == idx) && (count == 1)) { break; }
+ if ((conf->idx == idx) && (count == 1)) { break; }
- while (!apr_is_empty_array(array))
+ while (!apr_is_empty_array(array))
{
lazy_tcl_worker* w;
- w = *(lazy_tcl_worker**) apr_array_pop(array);
+ w = *(lazy_tcl_worker**) apr_array_pop(array);
apr_thread_mutex_lock(w->mutex);
w->r = NULL;
w->status = thread_exit;
apr_thread_cond_signal(w->condition);
apr_thread_mutex_unlock(w->mutex);
}
-
+
apr_thread_mutex_lock(mutex);
count = module_globals->mpm->vhosts[idx].threads_count;
apr_thread_mutex_unlock(mutex);
@@ -498,7 +498,7 @@ apr_status_t LazyBridge_Finalize (void* data)
int LazyBridge_ExitHandler(rivet_thread_private* private)
{
- /* This is not strictly necessary, because this command will
+ /* This is not strictly necessary, because this command will
* eventually terminate the whole processes */
/* This will force the current thread to exit */
@@ -507,12 +507,12 @@ int LazyBridge_ExitHandler(rivet_thread_private* private)
if (!module_globals->single_thread_exit)
{
- /* We now tell the supervisor to terminate the Tcl worker
+ /* We now tell the supervisor to terminate the Tcl worker
* thread pool so that we can safely shutdown the process
* by calling exit() */
-
+
LazyBridge_Finalize(private->r->server);
- }
+ }
return TCL_OK;
}
@@ -522,7 +522,7 @@ int LazyBridge_ExitHandler(rivet_thread_private* private)
*
* Bridge server wide inizialization:
*
- * We set the default value of the flag single_thread_exit
+ * We set the default value of the flag single_thread_exit
* stored in the module globals
*
*/
diff --git a/src/mod_rivet_ng/rivet_prefork_mpm.c b/src/mod_rivet_ng/rivet_prefork_mpm.c
index be41c31..ca3ba2e 100644
--- a/src/mod_rivet_ng/rivet_prefork_mpm.c
+++ b/src/mod_rivet_ng/rivet_prefork_mpm.c
@@ -66,7 +66,7 @@ void PreforkBridge_ChildInit (apr_pool_t* pool, server_rec* server)
ap_assert (apr_threadkey_private_create (&rivet_thread_key, NULL, pool) == APR_SUCCESS);
- /*
+ /*
* This is the only execution thread in this process so we create
* the Tcl thread private data here. In a fork capable OS
* private data should have been created by the httpd parent process
@@ -74,9 +74,9 @@ void PreforkBridge_ChildInit (apr_pool_t* pool, server_rec* server)
private = Rivet_ExecutionThreadInit();
private->ext = apr_pcalloc(private->pool,sizeof(mpm_bridge_specific));
- private->ext->interps =
+ private->ext->interps =
apr_pcalloc(private->pool,module_globals->vhosts_count*sizeof(rivet_thread_interp));
-
+
/* we now establish the full rivet core command set for the root interpreter */
@@ -94,7 +94,7 @@ void PreforkBridge_ChildInit (apr_pool_t* pool, server_rec* server)
module_globals->server_interp->cache_size,
module_globals->server_interp->cache_free);
- RivetCache_Create(module_globals->pool,module_globals->server_interp);
+ RivetCache_Create(module_globals->pool,module_globals->server_interp);
#ifdef RIVET_NAMESPACE_IMPORT
{
@@ -102,7 +102,7 @@ void PreforkBridge_ChildInit (apr_pool_t* pool, server_rec* server)
Tcl_Eval (module_globals->server_interp->interp,tcl_import_cmd);
}
-#endif
+#endif
/*
* We proceed creating the vhost interpreters database
@@ -167,14 +167,14 @@ rivet_thread_interp* MPM_MasterInterp(server_rec* server)
* of the process, math engine status included. This fact implies
* the random number generator has the same seed and every
* child process for which SeparateVirtualInterps would generate
- * the same random number sequence. We therefore reseed the RNG
+ * the same random number sequence. We therefore reseed the RNG
* calling a Tcl script fragment
*/
tcl_status = Tcl_Eval(module_globals->server_interp->interp,"expr {srand([clock clicks] + [pid])}");
if (tcl_status != TCL_OK)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
MODNAME ": Tcl interpreter random number generation reseeding failed");
}
return module_globals->server_interp;
@@ -183,14 +183,14 @@ rivet_thread_interp* MPM_MasterInterp(server_rec* server)
/*
* -- PreforkBridge_ExitHandler
*
- * Just calling Tcl_Exit
+ * Just calling Tcl_Exit
*
* Arguments:
* int code
*
* Side Effects:
*
- * the thread running the Tcl script will exit
+ * the thread running the Tcl script will exit
*/
int PreforkBridge_ExitHandler(rivet_thread_private* private)
@@ -198,7 +198,7 @@ int PreforkBridge_ExitHandler(rivet_thread_private* private)
Tcl_Exit(private->exit_status);
/* actually we'll never get here but we return
- * the Tcl return code anyway to silence the
+ * the Tcl return code anyway to silence the
* compilation warning
*/
return TCL_OK;
@@ -210,7 +210,7 @@ rivet_thread_interp* PreforkBridge_Interp (rivet_thread_private* private,
{
if (interp != NULL) { private->ext->interps[conf->idx] = interp; }
- return private->ext->interps[conf->idx];
+ return private->ext->interps[conf->idx];
}
/*
@@ -235,7 +235,7 @@ int PreforkBridge_ServerInit (apr_pool_t* pPool,apr_pool_t* pLog,apr_pool_t* pTe
* in that context. We create the cache now */
if (module_globals->server_interp->cache_size) {
- RivetCache_Create(pPool,module_globals->server_interp);
+ RivetCache_Create(pPool,module_globals->server_interp);
}
return OK;
}
diff --git a/src/mod_rivet_ng/rivet_worker_mpm.c b/src/mod_rivet_ng/rivet_worker_mpm.c
index ef041ab..4b7bb51 100644
--- a/src/mod_rivet_ng/rivet_worker_mpm.c
+++ b/src/mod_rivet_ng/rivet_worker_mpm.c
@@ -80,12 +80,12 @@ typedef struct mpm_bridge_status {
} mpm_bridge_status;
-/*
+/*
* data structure to work as communication
- * between Tcl worker thread and HTTP request handler
- */
+ * between Tcl worker thread and HTTP request handler
+ */
-typedef struct _handler_private
+typedef struct _handler_private
{
apr_thread_cond_t* cond;
apr_thread_mutex_t* mutex;
@@ -105,21 +105,21 @@ enum
child_exit
};
-/*
+/*
* -- WorkerBridge_Shutdown
*
* Child process shutdown: no more requests are served and we
- * pop from the queue all the threads sitting for work to do.
+ * pop from the queue all the threads sitting for work to do.
* In case some Tcl worker threads are still running and don't
* get back to the queue we wait for 1 sec max before returning
- * anyway
+ * anyway
*
* Arguments:
*
* none
*
* Returned value:
- *
+ *
* none
*
* Side effects:
@@ -144,7 +144,7 @@ void WorkerBridge_Shutdown (void)
module_globals->mpm->server_shutdown = 1;
- /* We wake up the supervisor who is now supposed to stop
+ /* We wake up the supervisor who is now supposed to stop
* all the Tcl worker threads
*/
@@ -162,7 +162,7 @@ void WorkerBridge_Shutdown (void)
* see the signal yet
*/
- if (rv == APR_EAGAIN)
+ if (rv == APR_EAGAIN)
{
waits--;
apr_sleep(200000);
@@ -195,7 +195,7 @@ void WorkerBridge_Shutdown (void)
module_globals->mpm->server_shutdown = 1;
- /* We wake up the supervisor who is now supposed to stop
+ /* We wake up the supervisor who is now supposed to stop
* all the Tcl worker threads
*/
@@ -213,7 +213,7 @@ void WorkerBridge_Shutdown (void)
* see the signal
*/
- if (rv == APR_EAGAIN)
+ if (rv == APR_EAGAIN)
{
waits--;
apr_sleep(200000);
@@ -248,13 +248,13 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
private = Rivet_ExecutionThreadInit();
private->ext = apr_pcalloc(private->pool,sizeof(mpm_bridge_specific));
private->ext->keep_going = 1;
- private->ext->interps =
+ private->ext->interps =
apr_pcalloc(private->pool,module_globals->vhosts_count*sizeof(rivet_thread_interp));
-
+
/* So far nothing differs much with what we did for the prefork bridge */
- /* At this stage we have to set up the private interpreters of configured
+ /* At this stage we have to set up the private interpreters of configured
* virtual hosts (if any). We assume the server_rec stored in the module
* globals can be used to retrieve the reference to the root interpreter
* configuration and to the rivet global script
@@ -273,7 +273,7 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
thread_obj = apr_pcalloc(private->pool,sizeof(handler_private));
ap_assert(apr_thread_cond_create(&(thread_obj->cond), private->pool) == APR_SUCCESS);
- ap_assert(apr_thread_mutex_create(&(thread_obj->mutex),APR_THREAD_MUTEX_UNNESTED,private->pool)
+ ap_assert(apr_thread_mutex_create(&(thread_obj->mutex),APR_THREAD_MUTEX_UNNESTED,private->pool)
== APR_SUCCESS);
thread_obj->status = idle;
@@ -293,7 +293,7 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
{
private->ext->keep_going = 0;
continue;
- }
+ }
while (thread_obj->status != init)
{
@@ -311,7 +311,7 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
thread_obj->status = request_processing;
/* we proceed with the request processing */
-
+
apr_atomic_inc32(module_globals->mpm->running_threads_count);
/* these assignements are crucial for both calling Rivet_SendContent and
@@ -339,7 +339,7 @@ static void* APR_THREAD_FUNC request_processor (apr_thread_t *thd, void *data)
ap_log_error(APLOG_MARK,APLOG_DEBUG,0,module_globals->server,"processor thread orderly exit");
/* We reestablish the single thread and interpreter cleanup */
-
+
Rivet_ProcessorCleanup(private);
apr_thread_mutex_lock(module_globals->mpm->job_mutex);
@@ -371,16 +371,16 @@ static void start_thread_pool (int nthreads)
{
apr_status_t rv;
apr_thread_t* slot;
-
+
rv = create_worker_thread(&slot);
module_globals->mpm->workers[i] = (void *) slot;
- if (rv != APR_SUCCESS)
+ if (rv != APR_SUCCESS)
{
char errorbuf[RIVET_MSG_BUFFER_SIZE];
apr_strerror(rv, errorbuf,RIVET_MSG_BUFFER_SIZE);
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
"Error starting request_processor thread (%d) rv=%d:%s\n",i,rv,errorbuf);
exit(1);
@@ -416,10 +416,10 @@ static void supervisor_housekeeping (void)
/* -- threaded_bridge_supervisor
- *
+ *
* This function runs within a single thread and to the
* start and stop of Tcl worker thread pool. It could be extended also
- * to provide some basic monitoring data.
+ * to provide some basic monitoring data.
*
* As we don't delete Tcl interpreters anymore because it can lead
* to seg faults or delays the supervisor threads doesn't restart
@@ -447,7 +447,7 @@ static void* APR_THREAD_FUNC threaded_bridge_supervisor (apr_thread_t *thd, void
do
{
apr_thread_t* p;
-
+
apr_thread_mutex_lock(mpm->job_mutex);
while (apr_is_empty_array(mpm->exiting) && !mpm->server_shutdown)
{
@@ -458,7 +458,7 @@ static void* APR_THREAD_FUNC threaded_bridge_supervisor (apr_thread_t *thd, void
{
int i;
p = *(apr_thread_t **)apr_array_pop(mpm->exiting);
-
+
for (i = 0; (i < module_globals->mpm->max_threads) && !mpm->server_shutdown; i++)
{
if (p == mpm->workers[i])
@@ -472,7 +472,7 @@ static void* APR_THREAD_FUNC threaded_bridge_supervisor (apr_thread_t *thd, void
/* terminated thread restart */
rv = create_worker_thread (&((apr_thread_t **)mpm->workers)[i]);
- if (rv != APR_SUCCESS)
+ if (rv != APR_SUCCESS)
{
char errorbuf[RIVET_MSG_BUFFER_SIZE];
@@ -481,16 +481,16 @@ static void* APR_THREAD_FUNC threaded_bridge_supervisor (apr_thread_t *thd, void
*/
apr_strerror(rv,errorbuf,RIVET_MSG_BUFFER_SIZE);
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, s,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, s,
"Error starting request_processor thread (%d) rv=%d:%s",i,rv,errorbuf);
exit(1);
}
-
+
break;
}
- }
- }
+ }
+ }
apr_thread_mutex_unlock(mpm->job_mutex);
} while (!mpm->server_shutdown);
@@ -505,18 +505,18 @@ static void* APR_THREAD_FUNC threaded_bridge_supervisor (apr_thread_t *thd, void
* -- WorkerBridge_ChildInit
*
* Child initialization function called by the web server framework.
- * For this bridge tasks are
+ * For this bridge tasks are
*
* + mpm_bridge_status object allocation and initialization
* + content generation callback private key creation
* + supervisor thread creation
- *
+ *
*/
void WorkerBridge_ChildInit (apr_pool_t* pool, server_rec* server)
{
apr_status_t rv;
-
+
apr_atomic_init(pool);
#ifdef RIVET_SERIALIZE_HTTP_REQUESTS
@@ -566,14 +566,14 @@ void WorkerBridge_ChildInit (apr_pool_t* pool, server_rec* server)
if (apr_queue_create(&module_globals->mpm->queue, MOD_RIVET_QUEUE_SIZE, module_globals->pool) != APR_SUCCESS)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, server,
MODNAME ": could not initialize mod_rivet request queue");
exit(1);
}
/* In order to set up some workload balancing let's
* query apache some configuration parameters of
- * the worker MPM
+ * the worker MPM
*/
if (ap_mpm_query(AP_MPMQ_MAX_THREADS,&module_globals->mpm->max_threads) != APR_SUCCESS)
@@ -593,14 +593,14 @@ void WorkerBridge_ChildInit (apr_pool_t* pool, server_rec* server)
module_globals->mpm->workers = apr_pcalloc(pool,module_globals->mpm->max_threads * sizeof(void *));
- rv = apr_thread_create( &module_globals->mpm->supervisor, NULL,
+ rv = apr_thread_create( &module_globals->mpm->supervisor, NULL,
threaded_bridge_supervisor, server, module_globals->pool);
if (rv != APR_SUCCESS) {
char errorbuf[RIVET_MSG_BUFFER_SIZE];
apr_strerror(rv, errorbuf,RIVET_MSG_BUFFER_SIZE);
- ap_log_error(APLOG_MARK, APLOG_ERR, rv, server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, rv, server,
MODNAME "Error starting supervisor thread rv=%d:%s\n",rv,errorbuf);
exit(1);
}
@@ -617,7 +617,7 @@ void WorkerBridge_ChildInit (apr_pool_t* pool, server_rec* server)
*
* void* client_data: a generic pointer cast to a handler_private object pointer
*
- */
+ */
apr_status_t Worker_RequestPrivateCleanup (void *client_data)
{
@@ -638,10 +638,10 @@ apr_status_t Worker_RequestPrivateCleanup (void *client_data)
* -- WorkerBridge_Request
*
* Content generation callback. Actually this function is not
- * generating directly content but instead builds a handler_private
- * structure, which is a descriptor of the request to be placed on a
- * global thread safe queue (module_globals->mpm->queue). In this structure
- * are also a condition variable and associated mutex. Through this
+ * generating directly content but instead builds a handler_private
+ * structure, which is a descriptor of the request to be placed on a
+ * global thread safe queue (module_globals->mpm->queue). In this structure
+ * are also a condition variable and associated mutex. Through this
* condition variable a worker thread running a Tcl interpreter will tell
* the framework thread the request has been served letting it return to the
* HTTP server framework
@@ -662,10 +662,10 @@ int WorkerBridge_Request (request_rec* r,rivet_req_ctype ctype)
apr_status_t rv;
handler_private* request_obj;
int http_code;
-
+
if (module_globals->mpm->server_shutdown == 1) {
- ap_log_rerror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, r,
+ ap_log_rerror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, r,
MODNAME ": http request aborted during child process shutdown");
return HTTP_INTERNAL_SERVER_ERROR;
@@ -685,7 +685,7 @@ int WorkerBridge_Request (request_rec* r,rivet_req_ctype ctype)
return HTTP_INTERNAL_SERVER_ERROR;
}
-
+
request_obj = (handler_private *) v;
apr_thread_mutex_lock(request_obj->mutex);
@@ -704,14 +704,14 @@ int WorkerBridge_Request (request_rec* r,rivet_req_ctype ctype)
http_code = request_obj->code;
request_obj->status = idle;
-
+
apr_thread_cond_signal(request_obj->cond);
apr_thread_mutex_unlock(request_obj->mutex);
return http_code;
}
-/*
+/*
* -- WorkerBridge_Finalize
*
*
@@ -749,7 +749,7 @@ apr_status_t WorkerBridge_Finalize (void* data)
rivet_thread_interp* MPM_MasterInterp(server_rec* s)
{
rivet_thread_private* private;
- rivet_thread_interp* interp_obj;
+ rivet_thread_interp* interp_obj;
rivet_server_conf* rsc = RIVET_SERVER_CONF(s->module_config);
RIVET_PRIVATE_DATA_NOT_NULL(rivet_thread_key,private)
@@ -762,7 +762,7 @@ rivet_thread_interp* MPM_MasterInterp(server_rec* s)
/*
* -- WorkerBridge_ExitHandler
- *
+ *
* Signals a thread to exit by setting the loop control flag to 0
* and by returning a Tcl error with error code THREAD_EXIT_CODE
*
@@ -771,12 +771,12 @@ rivet_thread_interp* MPM_MasterInterp(server_rec* s)
*
* Side Effects:
*
- * the thread running the Tcl script will exit
+ * the thread running the Tcl script will exit
*/
int WorkerBridge_ExitHandler(rivet_thread_private* private)
{
- /* This is not strictly necessary, because this command will
+ /* This is not strictly necessary, because this command will
* eventually terminate the whole processes */
/* This will force the current thread to exit */
@@ -795,9 +795,9 @@ int WorkerBridge_ExitHandler(rivet_thread_private* private)
* and is sequence the whole process to shutdown by calling exit() */
WorkerBridge_Finalize(private->r->server);
-
+
exit(private->exit_status);
- }
+ }
/*
* If single thread exit is enabled we continue and let the
@@ -811,12 +811,12 @@ int WorkerBridge_ExitHandler(rivet_thread_private* private)
#if 0
int WorkerBridge_ExitHandler(rivet_thread_private* private)
{
- /* This is not strictly necessary, because this command will
+ /* This is not strictly necessary, because this command will
* eventually terminate the whole processes
*/
/* By setting this flag to 0 we let the thread exit when the
- * request processing has completed
+ * request processing has completed
*/
private->ext->keep_going = 0;
@@ -825,10 +825,10 @@ int WorkerBridge_ExitHandler(rivet_thread_private* private)
module_globals->mpm->exit_command_status = private->exit_status;
/* In case single_thread_exit we return preparing this thread to exit */
-
- if (!private->running_conf->single_thread_exit)
+
+ if (!private->running_conf->single_thread_exit)
{
- /* We now tell the supervisor to terminate the Tcl worker
+ /* We now tell the supervisor to terminate the Tcl worker
* thread pool to exit and is sequence the whole process to
* shutdown by calling exit()
*/
@@ -836,7 +836,7 @@ int WorkerBridge_ExitHandler(rivet_thread_private* private)
WorkerBridge_Finalize (private->r->server);
}
-
+
return TCL_OK;
}
#endif
@@ -846,7 +846,7 @@ rivet_thread_interp* WorkerBridge_Interp (rivet_thread_private* private,
{
if (interp != NULL) { private->ext->interps[conf->idx] = interp; }
- return private->ext->interps[conf->idx];
+ return private->ext->interps[conf->idx];
}
/*
@@ -854,7 +854,7 @@ rivet_thread_interp* WorkerBridge_Interp (rivet_thread_private* private,
*
* Bridge server wide inizialization:
*
- * We set the default value of the flag single_thread_exit
+ * We set the default value of the flag single_thread_exit
* stored in the module globals
*
*/
diff --git a/src/mod_rivet_ng/worker_prefork_common.c b/src/mod_rivet_ng/worker_prefork_common.c
index 1e2b94f..a08f993 100644
--- a/src/mod_rivet_ng/worker_prefork_common.c
+++ b/src/mod_rivet_ng/worker_prefork_common.c
@@ -47,7 +47,7 @@ extern rivet_thread_interp* MPM_MasterInterp(server_rec* s);
*
*/
-static rivet_thread_interp*
+static rivet_thread_interp*
Rivet_DuplicateVHostInterp(apr_pool_t* pool, rivet_thread_interp* source_obj)
{
rivet_thread_interp* interp_obj = apr_pcalloc(pool,sizeof(rivet_thread_interp));
@@ -60,17 +60,17 @@ Rivet_DuplicateVHostInterp(apr_pool_t* pool, rivet_thread_interp* source_obj)
/* An intepreter must have its own cache */
if (interp_obj->cache_size) {
- RivetCache_Create(pool,interp_obj);
+ RivetCache_Create(pool,interp_obj);
}
interp_obj->pool = source_obj->pool;
interp_obj->scripts = (running_scripts *) apr_pcalloc(pool,sizeof(running_scripts));
- interp_obj->per_dir_scripts = apr_hash_make(pool);
+ interp_obj->per_dir_scripts = apr_hash_make(pool);
interp_obj->flags = source_obj->flags;
return interp_obj;
}
-/* -- Rivet_VirtualHostsInterps
+/* -- Rivet_VirtualHostsInterps
*
* The server_rec chain is walked through and server configurations is read to
* set up the thread private configuration and interpreters database
@@ -82,11 +82,11 @@ Rivet_DuplicateVHostInterp(apr_pool_t* pool, rivet_thread_interp* source_obj)
* Returned value:
*
* a new rivet_thread_private object
- *
+ *
* Side effects:
*
* GlobalInitScript and ChildInitScript are run at this stage
- *
+ *
*/
rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
@@ -94,7 +94,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
server_rec* s;
server_rec* root_server = module_globals->server;
rivet_server_conf* root_server_conf;
- rivet_server_conf* myrsc;
+ rivet_server_conf* myrsc;
rivet_thread_interp* root_interp;
void* parentfunction; /* this is topmost initialization script */
void* function;
@@ -102,10 +102,10 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
root_server_conf = RIVET_SERVER_CONF (root_server->module_config);
root_interp = MPM_MasterInterp(module_globals->server);
- /* we must assume the module was able to create the root interprter */
+ /* we must assume the module was able to create the root interprter */
ap_assert (root_interp != NULL);
-
+
/* The inherited interpreter has an empty cache since evalutating a server_init_script
* does not require parsing templates that need to be stored in it. We need to
* create it
@@ -117,11 +117,11 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
root_interp->cache_size = RivetCache_DefaultSize();
}
- RivetCache_Create(root_interp->pool,root_interp);
+ RivetCache_Create(root_interp->pool,root_interp);
/* Using the root interpreter we evaluate the global initialization script, if any */
- if (root_server_conf->rivet_global_init_script != NULL)
+ if (root_server_conf->rivet_global_init_script != NULL)
{
Tcl_Obj* global_tcl_script;
@@ -129,12 +129,12 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
Tcl_IncrRefCount(global_tcl_script);
if (Tcl_EvalObjEx(root_interp->interp, global_tcl_script, 0) != TCL_OK)
{
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, module_globals->server,
MODNAME ": Error running GlobalInitScript '%s': %s",
root_server_conf->rivet_global_init_script,
Tcl_GetVar(root_interp->interp, "errorInfo", 0));
} else {
- ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, module_globals->server,
+ ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, module_globals->server,
MODNAME ": GlobalInitScript '%s' successful",
root_server_conf->rivet_global_init_script);
}
@@ -154,7 +154,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
/* by default we assign the root_interpreter as
* interpreter of the virtual host. In case of separate
* virtual interpreters we create new ones for each
- * virtual host
+ * virtual host
*/
rivet_interp = root_interp;
@@ -163,7 +163,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
{
Tcl_RegisterChannel(rivet_interp->interp,*rivet_interp->channel);
}
- else
+ else
{
if (module_globals->separate_virtual_interps)
{
@@ -189,7 +189,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
rivet_interp->scripts = Rivet_RunningScripts (private->pool,rivet_interp->scripts,myrsc);
//private->ext->interps[myrsc->idx] = rivet_interp;
-
+
RIVET_POKE_INTERP(private,myrsc,rivet_interp);
/* Basic Rivet packages and libraries are loaded here */
@@ -215,7 +215,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
/* when configured a child init script gets evaluated */
function = myrsc->rivet_child_init_script;
- if (function &&
+ if (function &&
(s == root_server || module_globals->separate_virtual_interps || function != parentfunction))
{
char* errmsg = MODNAME ": Error in Child init script: %s";
@@ -225,7 +225,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
Tcl_IncrRefCount(tcl_child_init);
Tcl_Preserve (interp);
- /* There is a lot of passing pointers around among various structures.
+ /* There is a lot of passing pointers around among various structures.
* We should understand if this is all that necessary.
* Here we assign the server_rec pointer to the interpreter which
* is wrong, because without separate interpreters it doens't make
@@ -235,17 +235,17 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
/* before we run a script we have to store the pointer to the
* running configuration in the thread private data. The design has
* to improve and running a script must have everything sanely
- * prepared TODO
- */
+ * prepared TODO
+ */
private->running_conf = myrsc;
if (Tcl_EvalObjEx(interp,tcl_child_init, 0) != TCL_OK) {
ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, root_server,
errmsg, function);
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, root_server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, root_server,
"errorCode: %s", Tcl_GetVar(interp, "errorCode", 0));
- ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, root_server,
+ ap_log_error(APLOG_MARK, APLOG_ERR, APR_EGENERAL, root_server,
"errorInfo: %s", Tcl_GetVar(interp, "errorInfo", 0));
}
Tcl_Release (interp);
@@ -259,7 +259,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
/*
* -- Rivet_ProcessorCleanup
*
- * Thread private data cleanup. This function was meant to be
+ * Thread private data cleanup. This function was meant to be
* called by the worker and prefork MPM bridges to release resources
* owned by thread private data and pointed in the array of rivet_thread_interp
* objects. It has to be called just before an agent, either thread or
@@ -268,7 +268,7 @@ rivet_thread_private* Rivet_VirtualHostsInterps (rivet_thread_private* private)
*
* Arguments:
*
- * data: pointer to a rivet_thread_private data structure.
+ * data: pointer to a rivet_thread_private data structure.
*
* Returned value:
*
@@ -286,11 +286,11 @@ void Rivet_ProcessorCleanup (void *data)
int i;
rivet_thread_private* private = (rivet_thread_private *) data;
- ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, module_globals->server,
- "Thread exiting after %d requests served (%d vhosts)",
+ ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, module_globals->server,
+ "Thread exiting after %d requests served (%d vhosts)",
private->req_cnt,module_globals->vhosts_count);
- /* We are about to delete the interpreters and release the thread channel.
+ /* We are about to delete the interpreters and release the thread channel.
* Rivet channel is set as stdout channel of Tcl and as such is treated
* by Tcl_UnregisterChannel is a special way. When its refCount reaches 1
* the channel is released immediately by forcing the refCount to 0
@@ -302,7 +302,7 @@ void Rivet_ProcessorCleanup (void *data)
Tcl_SetStdChannel(NULL,TCL_STDOUT);
/* there must be always a root interpreter in the slot 0 of private->interps,
- * so we always need to run this cycle at least once
+ * so we always need to run this cycle at least once
*/
i = 0;
@@ -311,7 +311,7 @@ void Rivet_ProcessorCleanup (void *data)
RivetCache_Cleanup(private,private->ext->interps[i]);
- if ((i > 0) && module_globals->separate_channels)
+ if ((i > 0) && module_globals->separate_channels)
Rivet_ReleaseRivetChannel(private->ext->interps[i]->interp,private->channel);
Tcl_DeleteInterp(private->ext->interps[i]->interp);
@@ -325,7 +325,7 @@ void Rivet_ProcessorCleanup (void *data)
Rivet_ReleasePerDirScripts(private->ext->interps[i]);
/* if separate_virtual_interps == 0 we are running the same interpreter
- * instance for each vhost, thus we can jump out of this loop after
+ * instance for each vhost, thus we can jump out of this loop after
* the first cycle as the only real intepreter object we have is stored
* in private->ext->interps[0]
*/
diff --git a/src/mod_rivet_ng/worker_prefork_common.h b/src/mod_rivet_ng/worker_prefork_common.h
index 70c1d6a..6d3b4b7 100644
--- a/src/mod_rivet_ng/worker_prefork_common.h
+++ b/src/mod_rivet_ng/worker_prefork_common.h
@@ -24,7 +24,7 @@
#ifndef __worker_prefork_common_h__
#define __worker_prefork_common_h__
-/* Thread specific data common to the worker and prefork bridges
+/* Thread specific data common to the worker and prefork bridges
* Actually the prefork bridge won't use the keep_going flag, but
* they share the same interpreters array
*/
diff --git a/src/parser/parserPkgInit.c b/src/parser/parserPkgInit.c
index 205c617..1b2f554 100644
--- a/src/parser/parserPkgInit.c
+++ b/src/parser/parserPkgInit.c
@@ -1,5 +1,5 @@
/*
- * parserPkgInit.c - This code provides a wrapper around rivetParser.c,
+ * parserPkgInit.c - This code provides a wrapper around rivetParser.c,
* in order to expose it to Tcl scripts not running in Rivet.
*/
@@ -141,7 +141,7 @@ Rivetparser_Init( Tcl_Interp *interp )
#else
if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL)
#endif
- {
+ {
return TCL_ERROR;
}
@@ -165,9 +165,9 @@ Rivetparser_SafeInit( Tcl_Interp *interp )
*/
#ifdef USE_TCL_STUBS
- if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL)
+ if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL)
#else
- if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL)
+ if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 0) == NULL)
#endif
{
return TCL_ERROR;
diff --git a/src/parser/rivetParser.c b/src/parser/rivetParser.c
index fe978a3..e05941b 100644
--- a/src/parser/rivetParser.c
+++ b/src/parser/rivetParser.c
@@ -87,9 +87,9 @@ Rivet_GetTclFile(char *filename, Tcl_Obj *outbuf, Tcl_Interp *interp)
#if RIVET_CORE == mod_rivet_ng
/*
*-----------------------------------------------------------------------------
- * Rivet_GetRivetFileNG --
+ * Rivet_GetRivetFileNG --
*
- * The mod_rivet_ng core doesn't assume the parsed script to be
+ * The mod_rivet_ng core doesn't assume the parsed script to be
* enclosed in the ::request namespace. The whole ::request lifecycle is
* devolved to the Rivet::request_handling procedure
*
@@ -104,7 +104,7 @@ Rivet_GetRivetFile(char *filename, Tcl_Obj *outbuf, Tcl_Interp *interp)
Tcl_Channel rivetfile;
/*
- * we call Tcl to read this file but the caveat exposed in
+ * we call Tcl to read this file but the caveat exposed in
* in Rivet_GetRivetFile still holds true (TODO)
*/
diff --git a/src/parser/rivetParser.h b/src/parser/rivetParser.h
index 9b8ae59..f782bb7 100644
--- a/src/parser/rivetParser.h
+++ b/src/parser/rivetParser.h
@@ -28,7 +28,7 @@
#if RIVET_CORE == mod_rivet_ng
EXTERN int Rivet_GetRivetFile (char *filename, Tcl_Obj *outbuf, Tcl_Interp *interp);
#else
-EXTERN int Rivet_GetRivetFile (char *filename, int toplevel,
+EXTERN int Rivet_GetRivetFile (char *filename, int toplevel,
Tcl_Obj *outbuf, Tcl_Interp *interp);
#endif
diff --git a/src/request/apache_multipart_buffer.c b/src/request/apache_multipart_buffer.c
index 14a3ac9..9819fc2 100644
--- a/src/request/apache_multipart_buffer.c
+++ b/src/request/apache_multipart_buffer.c
@@ -88,7 +88,7 @@ int fill_buffer(multipart_buffer *self)
/* read the required number of bytes */
if(bytes_to_read > 0) {
char *buf = self->buffer + self->bytes_in_buffer;
-
+
actual_read = ap_get_client_block(self->r, buf, bytes_to_read);
/* update the buffer length */
@@ -225,8 +225,8 @@ apr_table_t *multipart_buffer_headers(multipart_buffer *self)
if(value) {
*value = 0;
- do {
- value++;
+ do {
+ value++;
} while (apr_isspace(*value));
#ifdef DEBUG
diff --git a/src/request/apache_multipart_buffer.h b/src/request/apache_multipart_buffer.h
index 6aa8662..8f8b29c 100644
--- a/src/request/apache_multipart_buffer.h
+++ b/src/request/apache_multipart_buffer.h
@@ -30,7 +30,7 @@
#ifdef __cplusplus
extern "C" {
-#endif
+#endif
typedef struct _multipart_buffer {
/* request info */
@@ -52,7 +52,7 @@ typedef struct _multipart_buffer {
multipart_buffer* multipart_buffer_new(char* boundary,apr_off_t length,request_rec* r);
// /*table*/apr_table_t *multipart_buffer_headers(multipart_buffer *self);
size_t multipart_buffer_read(multipart_buffer* self,char* buf,size_t bytes);
-char* multipart_buffer_read_body(multipart_buffer *self);
+char* multipart_buffer_read_body(multipart_buffer *self);
apr_table_t* multipart_buffer_headers(multipart_buffer *self);
int multipart_buffer_eof(multipart_buffer *self);
diff --git a/src/request/apache_request.c b/src/request/apache_request.c
index 7f7b4fb..0db8ec5 100644
--- a/src/request/apache_request.c
+++ b/src/request/apache_request.c
@@ -409,7 +409,7 @@ int ApacheRequest___parse(ApacheRequest *req)
req->nargs = ((apr_array_header_t *)req->parms)->nelts;
}
- if ((r->method_number == M_POST) && ct && strncaseEQ(ct, MULTIPART_ENCTYPE, MULTIPART_ENCTYPE_LENGTH))
+ if ((r->method_number == M_POST) && ct && strncaseEQ(ct, MULTIPART_ENCTYPE, MULTIPART_ENCTYPE_LENGTH))
{
//
//ap_log_rerror(REQ_INFO, "content-type: `%s'", ct);
@@ -436,7 +436,7 @@ int ApacheRequest_parse_urlencoded(ApacheRequest *req)
/*
const char *type;
type = apr_table_get(r->headers_in, "Content-Type");
-
+
if (!strncaseEQ(type, DEFAULT_ENCTYPE, DEFAULT_ENCTYPE_LENGTH) &&
!strncaseEQ(type, TEXT_XML_ENCTYPE, TEXT_XML_ENCTYPE_LENGTH)) {
return DECLINED;
@@ -482,14 +482,14 @@ apr_file_t *ApacheRequest_tmpfile(ApacheRequest *req, ApacheUpload *upload)
request_rec *r = req->r;
apr_file_t *fp = NULL;
char *name = NULL;
- char *file = NULL ;
+ char *file = NULL ;
const char *tempdir;
apr_status_t rv;
tempdir = req->temp_dir;
/* file = (char *)apr_palloc(r->pool,sizeof(apr_time_t)); */
file = apr_psprintf(r->pool,"%u.XXXXXX", (unsigned int)r->request_time);
- rv = apr_temp_dir_get(&tempdir,r->pool);
+ rv = apr_temp_dir_get(&tempdir,r->pool);
if (rv != APR_SUCCESS) {
ap_log_perror(APLOG_MARK, APLOG_ERR, rv, r->pool, "No temp dir!");
return NULL;
@@ -500,7 +500,7 @@ apr_file_t *ApacheRequest_tmpfile(ApacheRequest *req, ApacheUpload *upload)
ap_log_perror(APLOG_MARK, APLOG_ERR, rv, r->pool, "File path error!");
return NULL;
}
-
+
rv = apr_file_mktemp(&fp,name,0,r->pool);
if (rv != APR_SUCCESS) {
char* errorBuffer = (char*) apr_palloc(r->pool,256);
@@ -628,10 +628,10 @@ ApacheRequest_parse_multipart(ApacheRequest *req,const char* ct)
/* mozilla empty-file (missing CRLF) hack */
fill_buffer(mbuff);
- if( strEQN(mbuff->buf_begin, mbuff->boundary,
+ if( strEQN(mbuff->buf_begin, mbuff->boundary,
strlen(mbuff->boundary)) ) {
r->remaining -= 2;
- continue;
+ continue;
}
while ((blen = multipart_buffer_read(mbuff, buff, sizeof(buff)))) {
@@ -639,7 +639,7 @@ ApacheRequest_parse_multipart(ApacheRequest *req,const char* ct)
status = apr_file_write(upload->fp,buff,&bytes_to_write);
if (status != 0) {
- apr_strerror(status,error,1024);
+ apr_strerror(status,error,1024);
return HTTP_INTERNAL_SERVER_ERROR;
}
upload->size += blen;
diff --git a/src/request/apache_request.h b/src/request/apache_request.h
index af84334..0e05b95 100644
--- a/src/request/apache_request.h
+++ b/src/request/apache_request.h
@@ -82,7 +82,7 @@ extern Sfio_t* _stdopen _ARG_((int, const char*)); /*1999*/
#ifdef __cplusplus
extern "C" {
-#endif
+#endif
ApacheRequest* ApacheRequest_new(apr_pool_t *);
ApacheRequest* ApacheRequest_init(ApacheRequest* req, request_rec *r);
@@ -97,7 +97,7 @@ apr_array_header_t *ApacheRequest_params(ApacheRequest *req, const char *key);
char *ApacheRequest_params_as_string(ApacheRequest *req, const char *key);
int ApacheRequest___parse(ApacheRequest *req);
#define ApacheRequest_parse(req) \
- ((req)->status = (req)->parsed ? (req)->status : ApacheRequest___parse(req))
+ ((req)->status = (req)->parsed ? (req)->status : ApacheRequest___parse(req))
apr_table_t *ApacheRequest_query_params(ApacheRequest *req, apr_pool_t *p);
apr_table_t *ApacheRequest_post_params(ApacheRequest *req, apr_pool_t *p);
apr_table_t *ApacheRequest_query_params(ApacheRequest *req, apr_pool_t *p);
diff --git a/src/rivet.h b/src/rivet.h
index f8975de..4b59c04 100644
--- a/src/rivet.h
+++ b/src/rivet.h
@@ -45,7 +45,7 @@ typedef int rivet_req_ctype;
#define RIVET_PRIVATE_DATA(thread_key,private_p) \
ap_assert (apr_threadkey_private_get ((void **)&private_p,thread_key) == APR_SUCCESS);
-
+
#define RIVET_PRIVATE_DATA_NOT_NULL(thread_key,private_p) \
RIVET_PRIVATE_DATA(thread_key,private_p) \
ap_assert (private_p != NULL);
@@ -67,12 +67,12 @@ Tcl_CreateObjCommand( interp, /* Tcl interpreter */\
(Tcl_CmdDeleteProc *)NULL /* Tcl Delete Prov */)
/* RIVET_OBJ_CMD creates a command in the RIVET_NS namespace. Commands
- * are exported from the RIVET_NS (::rivet) namespace in the init.tcl
+ * are exported from the RIVET_NS (::rivet) namespace in the init.tcl
* script accordingly to configuration switches passed to ./configure
* (see configure.ac)
*/
- /* We now pass the thread private data to the
+ /* We now pass the thread private data to the
* Tcl command's ClientData
*/
@@ -81,16 +81,16 @@ Tcl_CreateObjCommand( interp, /* Tcl interpreter */\
RIVET_NS "::" name, /* Function name in Tcl */\
func, /* C function name */\
private_p, /* Client Data */\
- (Tcl_CmdDeleteProc *)NULL /* Tcl Delete Prov */);
+ (Tcl_CmdDeleteProc *)NULL /* Tcl Delete Prov */);
#define RIVET_EXPORT_CMD(interp,ns,cmdname) Tcl_Export(interp,ns,cmdname,0);
-/*
+/*
* Pointer in r is checked and in case Rivet_NoRequestRec is
* called returning TCL_ERROR. This macro is used (and often
* is the first code like) in commands that must ascertain
- * the request_rec object pointer in globals is valid
+ * the request_rec object pointer in globals is valid
* (when a request processing ends it's set to NULL)
*/
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org