[GitHub] vdiravka edited a comment on issue #1605: DRILL-6956: Maintain a single entry for Drill Version in the pom file

[GitBox <gi...@apache.org>]

vdiravka edited a comment on issue #1605: DRILL-6956: Maintain a single entry for Drill Version in the pom file
URL: https://github.com/apache/drill/pull/1605#issuecomment-453071735
 
 
   @kkhatua This is a good change, but there are two concerns with it:
   
   - according to [maven doc](https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup) this feature works starting from 3.5.0-beta-1 Maven version. It means that we push all devs to update their Maven to 3.5.0 version. Currently Drill can be built with [Maven 3.3.3 version](https://github.com/apache/drill/blob/master/docs/dev/Environment.md#how-to-build-and-run-apache-drill). Do we really want it? Possibly it can be discussed on mailing list.
   - Did you verify `mvn release:prepare` [maven phase](https://github.com/parthchandra/drill/wiki/Drill-Release-Process#manual-release-process)? Did it update version entry only in a single place?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services