You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:46 UTC

Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
-------

Refactored verify-reviews.py to use commons.py and argparse


Diffs
-----

  support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 


Diff: https://reviews.apache.org/r/67505/diff/1/


Testing
-------


Thanks,

Dragos Schebesch

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204492
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67502, 67503, 67504, 67505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204673
-----------------------------------------------------------



Regarding the commit: the Testing Done part should be filled.


support/python3/verify-reviews.py
Line 36 (original), 36 (patched)
<https://reviews.apache.org/r/67505/#comment287286>

    Unused to the comment marker added before `@atexit.register` line 138.



support/python3/verify-reviews.py
Lines 56 (patched)
<https://reviews.apache.org/r/67505/#comment287282>

    Missing docstring.



support/python3/verify-reviews.py
Lines 75 (patched)
<https://reviews.apache.org/r/67505/#comment287281>

    Wrong indentation.



support/python3/verify-reviews.py
Line 138 (original), 122 (patched)
<https://reviews.apache.org/r/67505/#comment287283>

    Line too long.



support/python3/verify-reviews.py
Line 255 (original), 240 (patched)
<https://reviews.apache.org/r/67505/#comment287285>

    Missing docstring.



support/python3/verify-reviews.py
Lines 259 (patched)
<https://reviews.apache.org/r/67505/#comment287284>

    Line too long.


- Armand Grillet


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204485
-----------------------------------------------------------



PASS: Mesos patch 67505 was successfully built and tested.

Reviews applied: `['67502', '67503', '67504', '67505']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67505

- Mesos Reviewbot Windows


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204874
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67502, 67503, 67504, 67505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review207665
-----------------------------------------------------------



PASS: Mesos patch 67505 was successfully built and tested.

Reviews applied: `['67502', '67503', '67504', '67505']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2203/mesos-review-67505

- Mesos Reviewbot Windows


On Aug. 7, 2018, 10:37 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/5/
> 
> 
> Testing
> -------
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206954
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67502', '67503', '67504', '67505']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2115/mesos-review-67505

Relevant logs:

- [libprocess-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2115/mesos-review-67505/logs/libprocess-tests-cmake.log):

```
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj" (default target) (11) ->
         cmake -E tar : warning : skipping symbolic link "grpc-1.10.0/test/core/http/python_wrapper.sh" -> "../../../tools/distrib/python_wrapper.sh". [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56): warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35): warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56): warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56): warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35): warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56): warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         server_posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         rpc_method.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         create_channel_posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         server_posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         rpc_method.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
         create_channel_posix.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj] [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (3) ->
       (ClCompile target) -> 
         d:\dcos\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp(879): error C3493: 'messageCount' cannot be implicitly captured because no default capture mode has been specified [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]

    31 Warning(s)
    1 Error(s)

Time Elapsed 00:07:34.71
```

- Mesos Reviewbot Windows


On Aug. 7, 2018, 5:37 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 5:37 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/5/
> 
> 
> Testing
> -------
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review207251
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Aug. 7, 2018, 10:37 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/5/
> 
> 
> Testing
> -------
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206953
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67502, 67503, 67504, 67505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 7, 2018, 5:37 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 5:37 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/5/
> 
> 
> Testing
> -------
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
-----------------------------------------------------------

(Updated Aug. 7, 2018, 5:37 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
-------

Refactored verify-reviews.py to use commons.py and argparse.


Diffs (updated)
-----

  support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 


Diff: https://reviews.apache.org/r/67505/diff/5/

Changes: https://reviews.apache.org/r/67505/diff/4-5/


Testing
-------

Sample run on this review request:
```
./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt

07-18-18_11:09:22 - Running support/python3/verify-reviews.py
0 review requests need verification
```


Thanks,

Dragos Schebesch

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206196
-----------------------------------------------------------



PASS: Mesos patch 67505 was successfully built and tested.

Reviews applied: `['67502', '67503', '67504', '67505']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1952/mesos-review-67505

- Mesos Reviewbot Windows


On July 18, 2018, 8:36 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 8:36 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/4/
> 
> 
> Testing
> -------
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206909
-----------------------------------------------------------


Fix it, then Ship it!





support/python3/verify-reviews.py
Lines 75 (patched)
<https://reviews.apache.org/r/67505/#comment290035>

    Pylint tells me that this needs 3 more spaces before `default_query`. The overall style of this call is quite heavy but I don't see how to make things clearer.



support/python3/verify-reviews.py
Line 138 (original), 122 (patched)
<https://reviews.apache.org/r/67505/#comment290036>

    A third argument seems to be misssing to call `apply_reviews(review_request, reviews, handler)`.



support/python3/verify-reviews.py
Lines 291 (patched)
<https://reviews.apache.org/r/67505/#comment290037>

    A second argument seems to be misssing to call `verify_review(review_request, handler)`.


- Armand Grillet


On July 18, 2018, 8:36 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 8:36 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/4/
> 
> 
> Testing
> -------
> 
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
> 
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
-----------------------------------------------------------

(Updated July 18, 2018, 8:36 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Changes
-------

Fixed misuse of handler class


Repository: mesos


Description
-------

Refactored verify-reviews.py to use commons.py and argparse.


Diffs (updated)
-----

  support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 


Diff: https://reviews.apache.org/r/67505/diff/4/

Changes: https://reviews.apache.org/r/67505/diff/3-4/


Testing (updated)
-------

Sample run on this review request:
```
./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt

07-18-18_11:09:22 - Running support/python3/verify-reviews.py
0 review requests need verification
```


Thanks,

Dragos Schebesch

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review205991
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67502, 67503, 67504, 67505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 11, 2018, 11:54 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated July 11, 2018, 11:54 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/3/
> 
> 
> Testing
> -------
> 
> Tests have been done later in the chain.
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review205967
-----------------------------------------------------------



PASS: Mesos patch 67505 was successfully built and tested.

Reviews applied: `['67502', '67503', '67504', '67505']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1901/mesos-review-67505

- Mesos Reviewbot Windows


On July 11, 2018, 4:54 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated July 11, 2018, 4:54 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse.
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/3/
> 
> 
> Testing
> -------
> 
> Tests have been done later in the chain.
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
-----------------------------------------------------------

(Updated July 11, 2018, 11:54 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Summary (updated)
-----------------

Refactored verify-reviews.py to use commons.py and argparse.


Repository: mesos


Description (updated)
-------

Refactored verify-reviews.py to use commons.py and argparse.


Diffs (updated)
-----

  support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 


Diff: https://reviews.apache.org/r/67505/diff/3/

Changes: https://reviews.apache.org/r/67505/diff/2-3/


Testing (updated)
-------

Tests have been done later in the chain.


Thanks,

Dragos Schebesch

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review205907
-----------------------------------------------------------



The commit message should be edited to finish with a period and the Testing Done part needz to be filled so that we know what tests have been done to check that this chain works.


support/python3/verify-reviews.py
Line 36 (original), 36 (patched)
<https://reviews.apache.org/r/67505/#comment288830>

    Unused import.



support/python3/verify-reviews.py
Lines 52 (patched)
<https://reviews.apache.org/r/67505/#comment288824>

    A comment to say where is this from would be useful.



support/python3/verify-reviews.py
Lines 56 (patched)
<https://reviews.apache.org/r/67505/#comment288818>

    Missing period.



support/python3/verify-reviews.py
Lines 64 (patched)
<https://reviews.apache.org/r/67505/#comment288820>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Lines 73 (patched)
<https://reviews.apache.org/r/67505/#comment288821>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Lines 75 (patched)
<https://reviews.apache.org/r/67505/#comment288819>

    The spacing is wrong.



support/python3/verify-reviews.py
Lines 81 (patched)
<https://reviews.apache.org/r/67505/#comment288822>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Lines 84 (patched)
<https://reviews.apache.org/r/67505/#comment288823>

    Put the final space at the beginning of the next line instead.



support/python3/verify-reviews.py
Line 137 (original), 121 (patched)
<https://reviews.apache.org/r/67505/#comment288831>

    Remove trailing space.



support/python3/verify-reviews.py
Line 138 (original), 122 (patched)
<https://reviews.apache.org/r/67505/#comment288829>

    s/`ReviewBoardHandler`/`ReviewBoardHandler()`.



support/python3/verify-reviews.py
Line 254 (original), 240 (patched)
<https://reviews.apache.org/r/67505/#comment288828>

    We need a docstring for this function.



support/python3/verify-reviews.py
Line 256 (original), 242 (patched)
<https://reviews.apache.org/r/67505/#comment288826>

    s/`There are %s review requests that need verification`/`%s review requests need verification`.



support/python3/verify-reviews.py
Lines 284 (patched)
<https://reviews.apache.org/r/67505/#comment288825>

    Put the final space at the beginning of the next line instead.


- Armand Grillet


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review204816
-----------------------------------------------------------



PASS: Mesos patch 67505 was successfully built and tested.

Reviews applied: `['67502', '67503', '67504', '67505']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67505

- Mesos Reviewbot Windows


On June 14, 2018, 4:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 4:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored verify-reviews.py to use commons.py and argparse
> 
> 
> Diffs
> -----
> 
>   support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 
> 
> 
> Diff: https://reviews.apache.org/r/67505/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/
-----------------------------------------------------------

(Updated June 14, 2018, 11:13 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
-------

Refactored verify-reviews.py to use commons.py and argparse


Diffs (updated)
-----

  support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855 


Diff: https://reviews.apache.org/r/67505/diff/2/

Changes: https://reviews.apache.org/r/67505/diff/1-2/


Testing
-------


Thanks,

Dragos Schebesch