You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lresende <gi...@git.apache.org> on 2016/03/06 01:41:24 UTC
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
GitHub user lresende opened a pull request:
https://github.com/apache/spark/pull/11542
[SPARK-13703][BUILD] Remove obsolete scala-2.10 source files
## What changes were proposed in this pull request?
Remove obsolete scala-2.10 source files
## How was this patch tested?
unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lresende/spark scala-2.11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11542
----
commit c3829c7289d1b92b7d59c1b6bf52ea0bc9aab200
Author: Luciano Resende <lr...@apache.org>
Date: 2016-03-06T00:39:50Z
[SPARK-13703][BUILD] Remove obsolete scala-2.10 source files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203179609
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203180605
**[Test build #54482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54482/consoleFull)** for PR 11542 at commit [`d726f9a`](https://github.com/apache/spark/commit/d726f9a52f510d49a4ee7737d898277878cf081e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203178769
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54481/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203436651
Yeah there isn't a 'here is the decision' message from a decider. Some in favor and no veto is the end state. Java 7 seems pretty unanimous even so I think we can take that as decided. (Or else someone please make clear their objection.)
Rereading the thread I still see more people than that in favor of dropping 2.10 and I see no veto or strong negative from Michael. Sure that deserves clarity. This PR is OK as a WIP though; you seemed to be asserting there was a decision not to make this change and don't see that happened. The opposite looks more likely actually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203376206
@markhamstra the PMC doesn't decide these things. In extreme cases it could be put to a vote. Code changes all work on lazy consensus by default.
I actually saw no direct opposition to dropping Java 7 support or 2.10. In both cases a few people brought up the counterargument for discussion. I'm on the PMC and support both for example . I walked away with a very different impression.
The output of that thread seemed clearly that 7 support goes, with many informal +1 and no objection. I think we should have a follow on thread for 2.10 for separate clarity about any clear objections.
But this kind of PR is OK as a WIP. It can even be a data point showing the resulting change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203228945
One small correction: I believe Mridul was in favor of dropping Scala 2.10 support, so the expressed opinions of PMC members were mixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-192864762
Aren't these still required for Scala 2.10 support?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203206216
@markhamstra The discussion seems to be getting consensus, so it's not that I am jumping the gun and creating something completely new, but reopening something that seems to be aligned with the direction the community is going (mainly because it was done already). Anyway, what constitute a decision ? Does the community needs to have a vote for these types of decision ? If you feel strongly about closing this, please let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203183327
@markhamstra I had done this is the past, and with the current discussion of droping jdk 7 and scala 2.10 i think this might be useful now. Any concerns reopening this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203228466
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54482/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203228465
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-192769369
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203178767
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
Github user lresende closed the pull request at:
https://github.com/apache/spark/pull/11542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203178766
**[Test build #54481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54481/consoleFull)** for PR 11542 at commit [`c3829c7`](https://github.com/apache/spark/commit/c3829c7289d1b92b7d59c1b6bf52ea0bc9aab200).
* This patch **fails R style tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203181027
Why has this been re-opened?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203224103
There was no consensus reached in that discussion thread. Reynold opened the thread to get a sense of how the Spark community feels about dropping Java 7 for Java 8 in Spark 2.0. While those of us on the PMC seek to respect the opinions of others in the Spark community, ultimately the overall direction of the project is in our hands, regardless of any replies to such a comment thread. If you look at the posts of PMC members in that thread, you will find no strong commitment to definitely dropping Java 7. More to the point of this PR, the only PMC replies to that thread on the issue of dropping Scala 2.10 leaned toward not dropping 2.10.
Regardless, my basic point remains: There has not yet been any decision by the PMC to either drop Java 7 or Scala 2.10 support in Spark 2.0; re-opening this PR is not appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203554149
I would veto removing 2.10 support at this time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203227472
Thanks.
Before the 2.0.0 release we will need to make final decisions on both Java 7 and Scala 2.10. It's not really difficult to remove support for either of those, so it's my opinion that delaying making the decisions is a reasonable approach for now. Maybe later we can resurrect this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
Github user lresende closed the pull request at:
https://github.com/apache/spark/pull/11542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-192963213
@lresende It is not the case. In Spark 2.0, the default build will now use Scala 2.11, but we will still be supporting Scala 2.10.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203178073
**[Test build #54481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54481/consoleFull)** for PR 11542 at commit [`c3829c7`](https://github.com/apache/spark/commit/c3829c7289d1b92b7d59c1b6bf52ea0bc9aab200).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203228341
**[Test build #54482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54482/consoleFull)** for PR 11542 at commit [`d726f9a`](https://github.com/apache/spark/commit/d726f9a52f510d49a4ee7737d898277878cf081e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
GitHub user lresende reopened a pull request:
https://github.com/apache/spark/pull/11542
[SPARK-13703][BUILD] Remove obsolete scala-2.10 source files
## What changes were proposed in this pull request?
Remove obsolete scala-2.10 source files
## How was this patch tested?
unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lresende/spark scala-2.11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11542
----
commit c3829c7289d1b92b7d59c1b6bf52ea0bc9aab200
Author: Luciano Resende <lr...@apache.org>
Date: 2016-03-06T00:39:50Z
[SPARK-13703][BUILD] Remove obsolete scala-2.10 source files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203433869
@srowen I see the decisions whether to drop Java 7 or Scala 2.10 as more than just code changes. I'll agree that there was no objection to dropping Java 7, but there was also no definitive "this is what we are going to do." On Scala 2.10, if we include you as in favor of dropping support, then we have you and Mridul in favor, myself skeptical, and Michael Armbrust opposed. In short, I don't see any basis for claiming that a decision has been made to drop 2.10 support or to change from your opinion 24 days ago that this PR should be closed.
We do need to make these decisions before 2.0.0, but I still don't think that we need to decide right now. A separate discussion on 2.10 would be a good thing, and it may well take a vote to adequately resolve the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-192938438
@srowen I was under the impression we were not supporting 2.10 anymore, if this is not the case I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203184032
Re-opening is not appropriate at this time. There has been discussion on the dev list about dropping Java 7. That is a separate issue from whether Scala 2.10 support is discontinued. For both of these, discussion on the dev list does not constitute a decision by the Spark PMC. Until there is such a decision, both Java 7 and Scala 2.10 support remain part of the Spark 2.0 release plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-203444519
While I don't see the "I think that it is premature to drop support for 2.10.x." from @marmbrus as particularly ambiguous, I also don't think that a definite decision not to drop 2.10 was made in Reynold's Java 7 thread. Neither do I think a decision was made to drop 2.10, and I don't know what the outcome would be if it were put to a vote. In short, I see the 2.10 issue as a no-decision (with several in the community in favor of dropping 2.10 support) and no reason to re-open this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13703][BUILD] Remove obsolete scala-2.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11542#issuecomment-192969388
Yeah, no support has been dropped. You can close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org