You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/06/25 02:02:39 UTC

[GitHub] johnyangk edited a comment on issue #51: [NEMO-102] Stage Partitioning by PhysicalPlanGenerator

johnyangk edited a comment on issue #51: [NEMO-102] Stage Partitioning by PhysicalPlanGenerator
URL: https://github.com/apache/incubator-nemo/pull/51#issuecomment-399810051
 
 
   @seojangho 
   
   Overall, looks good to me. I just have one request: can you group the CreateViewTransform vertices with the children vertices connected with an O2O edge in the same stage? #38 did that, and it appears that this PR undoes it. 
   
   For example, Stage-12 should be in the same stage as Stage-4 in this DAG. It'd be also nice if you can add a test for this case.
   
   http://cmscluster.snu.ac.kr:50080/nemo-dag-out/6e7cbad076a44f199f0e0c6105327c73.svg

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services