[jira] [Commented] (HIVE-10128) BytesBytesMultiHashMap does not allow concurrent read-only access

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389617#comment-14389617 ] 

Hive QA commented on HIVE-10128:
--------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12708481/HIVE-10128.03.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8691 tests executed
*Failed tests:*
{noformat}
TestDummy - did not produce a TEST-*.xml file
TestMinimrCliDriver-smb_mapjoin_8.q - did not produce a TEST-*.xml file
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3225/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3225/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3225/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12708481 - PreCommit-HIVE-TRUNK-Build

> BytesBytesMultiHashMap does not allow concurrent read-only access
> -----------------------------------------------------------------
>
>                 Key: HIVE-10128
>                 URL: https://issues.apache.org/jira/browse/HIVE-10128
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Sergey Shelukhin
>             Fix For: llap
>
>         Attachments: HIVE-10128.01.patch, HIVE-10128.02.patch, HIVE-10128.03.patch, HIVE-10128.patch, hashmap-after.png, hashmap-sync-source.png, hashmap-sync.png
>
>
> The multi-threaded performance takes a serious hit when LLAP shares hashtables between the probe threads running in parallel. 
> !hashmap-sync.png!
> This is an explicit synchronized block inside ReusableRowContainer which triggers this particular pattern.
> !hashmap-sync-source.png!
> Looking deeper into the code, the synchronization seems to be caused due to the fact that WriteBuffers.setReadPoint modifies the otherwise read-only hashtable.
> To generate this sort of result, run LLAP at a WARN log-level, to avoid all the log synchronization that otherwise affects the thread sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)