You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/21 14:39:10 UTC
[GitHub] [superset] simchaNielsen opened a new pull request #12662: feat(cross-filters): add cross filters
simchaNielsen opened a new pull request #12662:
URL: https://github.com/apache/superset/pull/12662
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add cross filter functionality that gives option to charts to filter other charts
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
https://user-images.githubusercontent.com/56388545/105365631-1f9f6b80-5c07-11eb-8563-cb9bebafaa87.mov
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-767517823
> I wonder in terms of actual UX, is a separate `filter_select` viz type actually what we want?
>
> I remember when we [talked about cross-filtering before](https://github.com/apache/superset/pull/9593#discussion_r411927471), the expectation was that clicking on elements in a chart itself will update the filters (be it a table chart cell, or the legend in a line chart). Each chart will have a `cross_filter` config value and will emit filter events accordingly.
>
> Is this still the ultimate goal?
I feel the ultimate goal is to support cross filtering in all charts where it makes sense. But opt-in of course; clicking an item on a chart should only cause cross filtering if explicitly enabled. The following obvious charts come to mind:
- table chart: filter only selected rows
- pivot table: filter only selected rows/columns/cells
- pie chart: filter only selected slices
- bar chart: filter only selected bars
- timeseries chart: filter only selected time range (x-axis) or selected series.
etc. Even in the presence of more advanced charts with cross-filtering functionality, the simple select filter used in native filters may very well be something that end users want to place on the dashboard like a chart, especially when there will be lots of selects on a dashboard. To reduce confusion, it would be a good idea to keep these native filter charts separate from regular charts in the chart type selector, e.g. in a separate tab ("charts" vs "native filters").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (cadcb2d) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `0.33%`.
> The diff coverage is `71.68%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 66.46% -0.34%
==========================================
Files 1015 1021 +6
Lines 49676 49981 +305
Branches 4847 4899 +52
==========================================
+ Hits 33183 33221 +38
- Misses 16371 16631 +260
- Partials 122 129 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.52% <31.11%> (-0.53%)` | :arrow_down: |
| javascript | `60.89% <69.91%> (+0.13%)` | :arrow_up: |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `77.02% <0.00%> (-1.06%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (+6.86%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `90.90% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `60.16% <64.15%> (+2.27%)` | :arrow_up: |
| ... and [54 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563775241
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@agatapst `DASHBOARD_NATIVE_FILTERS` feature flag filter out native filter charts from the view that responsible for creation of charts, because if they will be created as charts they will not can filter other charts, but with new feature of cross-filter functionality they will can to do it, so no need any more filter out them from this view. Because of that `FeatureFlag.DASHBOARD_CROSS_FILTERS` just cancel `DASHBOARD_NATIVE_FILTERS` flag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (cadcb2d) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `0.24%`.
> The diff coverage is `71.68%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 66.55% -0.25%
==========================================
Files 1015 1021 +6
Lines 49676 49981 +305
Branches 4847 4899 +52
==========================================
+ Hits 33183 33264 +81
- Misses 16371 16592 +221
- Partials 122 125 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.89% <31.11%> (-0.16%)` | :arrow_down: |
| javascript | `60.89% <69.91%> (+0.13%)` | :arrow_up: |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `77.02% <0.00%> (-1.06%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (+6.86%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `90.90% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `60.16% <64.15%> (+2.27%)` | :arrow_up: |
| ... and [49 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12662:
URL: https://github.com/apache/superset/pull/12662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.28% -3.52%
==========================================
Files 1015 487 -528
Lines 49676 30029 -19647
Branches 4847 0 -4847
==========================================
- Hits 33183 19005 -14178
+ Misses 16371 11024 -5347
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.28% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.47%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...e4ec409](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (cadcb2d) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `4.32%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 62.46% -4.33%
==========================================
Files 1015 1021 +6
Lines 49676 49962 +286
Branches 4847 4899 +52
==========================================
- Hits 33183 31211 -1972
- Misses 16371 18551 +2180
- Partials 122 200 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.89% <69.91%> (+0.13%)` | :arrow_up: |
| python | `63.50% <ø> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `39.18% <0.00%> (-38.90%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (+6.71%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `90.90% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `71.92% <50.00%> (-20.80%)` | :arrow_down: |
| ... and [231 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r575042391
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/utils.ts
##########
@@ -93,14 +101,31 @@ export function mergeExtraFormData(
};
}
+export function isCrossFilter(vizType: string) {
+ // @ts-ignore need export from superset-ui `ItemWithValue`
+ return getChartMetadataRegistry().items[vizType]?.value.behaviors?.includes(
+ Behavior.CROSS_FILTER,
+ );
+}
+
export function getExtraFormData(
nativeFilters: NativeFiltersState,
+ charts: Charts,
): ExtraFormData {
let extraFormData: ExtraFormData = {};
Object.keys(nativeFilters.filters).forEach(key => {
const filterState = nativeFilters.filtersState[key] || {};
const { extraFormData: newExtra = {} } = filterState;
extraFormData = mergeExtraFormData(extraFormData, newExtra);
});
+ if (isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS)) {
+ Object.entries(charts).forEach(([key, chart]) => {
+ if (isCrossFilter(chart?.formData?.viz_type)) {
+ const filterState = nativeFilters.filtersState[key] || {};
+ const { extraFormData: newExtra = {} } = filterState;
+ extraFormData = mergeExtraFormData(extraFormData, newExtra);
+ }
+ });
+ }
Review comment:
General comment: it doesn't really matter now, but especially once we start using overrides as opposed to appends, the order in which these get applied will matter. If possible, we should probably think about some way of visually understanding which chart/filter has taken precedent/been overridden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-767517823
> I wonder in terms of actual UX, is a separate `filter_select` viz type actually what we want?
>
> I remember when we [talked about cross-filtering before](https://github.com/apache/superset/pull/9593#discussion_r411927471), the expectation was that clicking on elements in a chart itself will update the filters (be it a table chart cell, or the legend in a line chart). Each chart will have a `cross_filter` config value and will emit filter events accordingly.
>
> Is this still the ultimate goal?
I feel the ultimate goal is to support cross filtering in all charts where it makes sense. But opt-in of course; clicking an item on a chart should only cause cross filtering if explicitly enabled. The following obvious charts come to mind:
- table chart: filter only selected rows
- pivot table: filter only selected rows/columns/cells
- pie chart: same: filter only selected slices
- bar chart: filter only selected bars
- timeseries chart: filter only selected time range (x-axis) or selected series.
etc. Even in the presence of more advanced charts with cross-filtering functionality, the simple select filter used in native filters may very well be something that end users want, especially when there will be lots of selects on a dashboard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] agatapst commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
agatapst commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563763849
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@simchaNielsen could you explain why we need this feature flag enabled here?
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@simchaNielsen could you explain why we need this feature flag enabled here (and below)?
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
Thanks, makes sense 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (6db310b) into [master](https://codecov.io/gh/apache/superset/commit/da63b4b0eaef621201999f3f33eeb7b7d1d7e88b?el=desc) (da63b4b) will **decrease** coverage by `2.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 65.97% 63.79% -2.19%
==========================================
Files 1022 488 -534
Lines 50050 30117 -19933
Branches 4915 0 -4915
==========================================
- Hits 33022 19214 -13808
+ Misses 16868 10903 -5965
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.79% <ø> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <0.00%> (-2.46%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [da63b4b...6db310b](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (65e5dfd) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.28% -3.52%
==========================================
Files 1015 486 -529
Lines 49676 29969 -19707
Branches 4847 0 -4847
==========================================
- Hits 33183 18966 -14217
+ Misses 16371 11003 -5368
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.28% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...65e5dfd](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r562199910
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/utils.ts
##########
@@ -196,13 +201,27 @@ export function mergeExtraFormData(
export function getExtraFormData(
nativeFilters: NativeFiltersState,
+ charts: Charts,
): ExtraFormData {
let extraFormData: ExtraFormData = {};
Object.keys(nativeFilters.filters).forEach(key => {
const filterState = nativeFilters.filtersState[key] || {};
const { extraFormData: newExtra = {} } = filterState;
extraFormData = mergeExtraFormData(extraFormData, newExtra);
});
+ if (isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS)) {
+ Object.entries(charts).forEach(([key, chart]) => {
+ const { isNativeFilter } = getChartMetadataRegistry().items[
+ chart?.formData?.viz_type
+ // @ts-ignore need export from superset-ui `ItemWithValue`
+ ].value;
Review comment:
Can this be moved to some kind of helper function? E.g.
```ts
function isNativeFilter(vizType: string) {
return getChartMetadataRegistry().items[vizType].isNativeFilter
}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/utils.ts
##########
@@ -33,6 +37,7 @@ import {
TreeItem,
} from './types';
import { DASHBOARD_ROOT_ID } from '../../util/constants';
+import { FeatureFlag, isFeatureEnabled } from '../../../featureFlags';
Review comment:
Nit: let's use absolute import path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (e4ec409) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.54% -3.26%
==========================================
Files 1015 488 -527
Lines 49676 30104 -19572
Branches 4847 0 -4847
==========================================
- Hits 33183 19130 -14053
+ Misses 16371 10974 -5397
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (ø)` | |
| [...set-frontend/src/explore/components/ControlRow.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUm93LmpzeA==) | | |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (65e5dfd) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.28% -3.52%
==========================================
Files 1015 486 -529
Lines 49676 29969 -19707
Branches 4847 0 -4847
==========================================
- Hits 33183 18966 -14217
+ Misses 16371 11003 -5368
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.28% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...65e5dfd](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (e4ec409) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.50% -3.29%
==========================================
Files 1015 488 -527
Lines 49676 30104 -19572
Branches 4847 0 -4847
==========================================
- Hits 33183 19119 -14064
+ Misses 16371 10985 -5386
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.50% <ø> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.85% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (6db310b) into [master](https://codecov.io/gh/apache/superset/commit/da63b4b0eaef621201999f3f33eeb7b7d1d7e88b?el=desc) (da63b4b) will **decrease** coverage by `2.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 65.97% 63.39% -2.59%
==========================================
Files 1022 488 -534
Lines 50050 30115 -19935
Branches 4915 0 -4915
==========================================
- Hits 33022 19090 -13932
+ Misses 16868 11025 -5843
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [540 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [da63b4b...6db310b](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (a5d9def) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.78%`.
> The diff coverage is `38.88%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
+ Coverage 53.06% 61.84% +8.78%
==========================================
Files 489 546 +57
Lines 17314 20167 +2853
Branches 4482 5277 +795
==========================================
+ Hits 9187 12472 +3285
+ Misses 8127 7481 -646
- Partials 0 214 +214
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.84% <38.88%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `39.18% <0.00%> (-37.53%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `93.10% <ø> (+1.10%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.65% <ø> (-2.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `73.87% <0.00%> (+7.56%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `70.27% <36.36%> (-29.73%)` | :arrow_down: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `84.21% <50.00%> (-6.70%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `88.88% <100.00%> (-11.12%)` | :arrow_down: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [463 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [8b2df52...a5d9def](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.64% -3.16%
==========================================
Files 1015 487 -528
Lines 49676 30044 -19632
Branches 4847 0 -4847
==========================================
- Hits 33183 19121 -14062
+ Misses 16371 10923 -5448
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.64% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (ø)` | |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | | |
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-767517823
> I wonder in terms of actual UX, is a separate `filter_select` viz type actually what we want?
>
> I remember when we [talked about cross-filtering before](https://github.com/apache/superset/pull/9593#discussion_r411927471), the expectation was that clicking on elements in a chart itself will update the filters (be it a table chart cell, or the legend in a line chart). Each chart will have a `cross_filter` config value and will emit filter events accordingly.
>
> Is this still the ultimate goal?
I feel the ultimate goal is to support cross filtering in all charts where it makes sense. But opt-in of course; clicking an item on a chart should only cause cross filtering if explicitly enabled. The following obvious charts come to mind:
- table chart: filter only selected rows
- pivot table: filter only selected rows/columns/cells
- pie chart: same: filter only selected slices
- bar chart: filter only selected bars
- timeseries chart: filter only selected time range (x-axis) or selected series.
etc. Even in the presence of more advanced charts with cross-filtering functionality, the simple select filter used in native filters may very well be something that end users want to place on the dashboard like a chart, especially when there will be lots of selects on a dashboard. To reduce confusion, it would be a good idea to keep these native filter charts separate from regular charts in the chart type selector, e.g. in a separate tab ("charts" vs "native filters").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (e4ec409) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.54% -3.26%
==========================================
Files 1015 488 -527
Lines 49676 30104 -19572
Branches 4847 0 -4847
==========================================
- Hits 33183 19130 -14053
+ Misses 16371 10974 -5397
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <0.00%> (ø)` | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] agatapst commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
agatapst commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563763849
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@simchaNielsen could you explain why we need this feature flag enabled here?
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@simchaNielsen could you explain why we need this feature flag enabled here (and below)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (cadcb2d) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `1.52%`.
> The diff coverage is `71.68%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 65.27% -1.53%
==========================================
Files 1015 1021 +6
Lines 49676 49980 +304
Branches 4847 4899 +52
==========================================
- Hits 33183 32624 -559
- Misses 16371 17202 +831
- Partials 122 154 +32
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `44.75% <18.88%> (-6.30%)` | :arrow_down: |
| javascript | `60.89% <69.91%> (+0.13%)` | :arrow_up: |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `74.32% <0.00%> (-3.76%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.89% <ø> (+6.86%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `90.90% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `60.16% <64.15%> (+2.27%)` | :arrow_up: |
| ... and [136 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (e4ec409) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `7.83%`.
> The diff coverage is `31.11%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 58.96% -7.84%
==========================================
Files 1015 964 -51
Lines 49676 47188 -2488
Branches 4847 4406 -441
==========================================
- Hits 33183 27824 -5359
- Misses 16371 19364 +2993
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <31.11%> (-0.16%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-2.41%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `89.47% <ø> (-1.44%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| ... and [413 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (6db310b) into [master](https://codecov.io/gh/apache/superset/commit/da63b4b0eaef621201999f3f33eeb7b7d1d7e88b?el=desc) (da63b4b) will **decrease** coverage by `2.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 65.97% 63.39% -2.59%
==========================================
Files 1022 488 -534
Lines 50050 30117 -19933
Branches 4915 0 -4915
==========================================
- Hits 33022 19092 -13930
+ Misses 16868 11025 -5843
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [539 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [da63b4b...6db310b](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-767042047
I wonder in terms of actual UX, is a separate `filter_select` viz type actually what we want?
I remember when we [talked about cross-filtering before](https://github.com/apache/superset/pull/9593#discussion_r411927471), the expectation was that clicking on elements in a chart itself will update the filters (be it a table chart cell, or the legend in a line chart). Each chart will have a `cross_filter` config value and will emit filter events accordingly.
Is this still the ultimate goal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] agatapst commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
agatapst commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563782130
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
Thanks, makes sense 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-767042047
I wonder in terms of actual UX, is a separate `filter_select` viz type actually what we want?
I remember when we [talked about cross-filtering before](https://github.com/apache/superset/pull/9593#discussion_r411927471), the expectation was that clicking on elements in a chart itself will update the filters (be it a table chart cell, or the legend in a line chart). Each chart will have a `cross_filter` config value and will emit filter events accordingly.
Is this still the ultimate goal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `7.77%`.
> The diff coverage is `31.11%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 59.02% -7.78%
==========================================
Files 1015 963 -52
Lines 49676 47126 -2550
Branches 4847 4404 -443
==========================================
- Hits 33183 27814 -5369
- Misses 16371 19312 +2941
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <31.11%> (-0.16%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.64% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-2.41%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `89.47% <ø> (-1.44%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| ... and [411 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.61% -3.19%
==========================================
Files 1015 487 -528
Lines 49676 30029 -19647
Branches 4847 0 -4847
==========================================
- Hits 33183 19103 -14080
+ Misses 16371 10926 -5445
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.61% <ø> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.85% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [529 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...e4ec409](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563775241
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@agatapst `FeatureFlag.DASHBOARD_NATIVE_FILTERS` feature flag filter out native filter charts from the view that responsible for creation of charts, because if they will be created as charts they will not can filter other charts, but with new feature of cross-filter functionality they will can to do it, so no need any more filter out them from this view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r562199910
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/utils.ts
##########
@@ -196,13 +201,27 @@ export function mergeExtraFormData(
export function getExtraFormData(
nativeFilters: NativeFiltersState,
+ charts: Charts,
): ExtraFormData {
let extraFormData: ExtraFormData = {};
Object.keys(nativeFilters.filters).forEach(key => {
const filterState = nativeFilters.filtersState[key] || {};
const { extraFormData: newExtra = {} } = filterState;
extraFormData = mergeExtraFormData(extraFormData, newExtra);
});
+ if (isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS)) {
+ Object.entries(charts).forEach(([key, chart]) => {
+ const { isNativeFilter } = getChartMetadataRegistry().items[
+ chart?.formData?.viz_type
+ // @ts-ignore need export from superset-ui `ItemWithValue`
+ ].value;
Review comment:
Can this be moved to some kind of helper function? E.g.
```ts
function isNativeFilter(vizType: string) {
return getChartMetadataRegistry().items[vizType].isNativeFilter
}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/utils.ts
##########
@@ -33,6 +37,7 @@ import {
TreeItem,
} from './types';
import { DASHBOARD_ROOT_ID } from '../../util/constants';
+import { FeatureFlag, isFeatureEnabled } from '../../../featureFlags';
Review comment:
Nit: let's use absolute import path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (cfc7254) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **decrease** coverage by `0.05%`.
> The diff coverage is `40.90%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 53.06% 53.00% -0.06%
==========================================
Files 489 489
Lines 17314 17327 +13
Branches 4482 4490 +8
==========================================
- Hits 9187 9185 -2
- Misses 8127 8142 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.00% <40.90%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `92.00% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [3e0681b...cfc7254](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.65% -3.15%
==========================================
Files 1015 487 -528
Lines 49676 30029 -19647
Branches 4847 0 -4847
==========================================
- Hits 33183 19114 -14069
+ Misses 16371 10915 -5456
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <ø> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <0.00%> (-0.02%)` | :arrow_down: |
| ... and [527 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `7.55%`.
> The diff coverage is `31.11%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 59.24% -7.56%
==========================================
Files 1015 963 -52
Lines 49676 47126 -2550
Branches 4847 4404 -443
==========================================
- Hits 33183 27921 -5262
- Misses 16371 19205 +2834
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.88% <31.11%> (-0.16%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.99% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-2.41%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `89.47% <ø> (-1.44%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| ... and [408 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen commented on a change in pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563775241
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@agatapst `FeatureFlag.DASHBOARD_NATIVE_FILTERS` feature flag filter out native filter charts from the view that responsible for creation of charts, because if they will be created as charts they will not can filter other charts, but with new feature of cross-filter functionality they will can to do it, so no need any more filter out them from this view.
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
const filterString = filter.toLowerCase();
const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
- .filter(type => !registry.get(type).isNativeFilter)
+ .filter(
+ type =>
+ isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||
Review comment:
@agatapst `DASHBOARD_NATIVE_FILTERS` feature flag filter out native filter charts from the view that responsible for creation of charts, because if they will be created as charts they will not can filter other charts, but with new feature of cross-filter functionality they will can to do it, so no need any more filter out them from this view. Because of that `FeatureFlag.DASHBOARD_CROSS_FILTERS` just cancel `DASHBOARD_NATIVE_FILTERS` flag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simchaNielsen commented on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-766306353
Fixed / Added description @ktmud @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (65e5dfd) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.27% -3.53%
==========================================
Files 1015 486 -529
Lines 49676 29984 -19692
Branches 4847 0 -4847
==========================================
- Hits 33183 18973 -14210
+ Misses 16371 11011 -5360
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.27% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...65e5dfd](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (5d5d9e1) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `5.85%`.
> The diff coverage is `31.11%`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 60.94% -5.86%
==========================================
Files 1015 855 -160
Lines 49676 41404 -8272
Branches 4847 2955 -1892
==========================================
- Hits 33183 25232 -7951
+ Misses 16371 16172 -199
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.79% <31.11%> (+2.74%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.64% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `72.97% <0.00%> (-5.11%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `90.90% <ø> (-9.10%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | `89.47% <ø> (-1.44%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| ... and [450 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...cadcb2d](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12662: feat(cross-filters): add cross filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-764827494
# [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=h1) Report
> Merging [#12662](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=desc) (65e5dfd) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12662 +/- ##
==========================================
- Coverage 66.79% 63.27% -3.53%
==========================================
Files 1015 486 -529
Lines 49676 29984 -19692
Branches 4847 0 -4847
==========================================
- Hits 33183 18973 -14210
+ Misses 16371 11011 -5360
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.27% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12662/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=footer). Last update [2463215...65e5dfd](https://codecov.io/gh/apache/superset/pull/12662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org