You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ddanielr (via GitHub)" <gi...@apache.org> on 2023/12/09 00:01:53 UTC
[PR] Fix disabled CompactionITs [accumulo]
ddanielr opened a new pull request, #4046:
URL: https://github.com/apache/accumulo/pull/4046
Fixes and enables ExternalCompactionMetricsIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix disabled CompactionITs [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4046:
URL: https://github.com/apache/accumulo/pull/4046#discussion_r1422636461
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java:
##########
@@ -163,7 +176,9 @@ public void testMetrics() throws Exception {
// Wait for all external compactions to complete
long count;
do {
- UtilWaitThread.sleep(100);
+ // TODO: Change this from waiting to verifying that all compactors are done running jobs,
Review Comment:
This seems like a good change, were you thinking of making the change in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix disabled CompactionITs [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4046:
URL: https://github.com/apache/accumulo/pull/4046#discussion_r1422987989
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java:
##########
@@ -52,21 +58,28 @@
import org.apache.hadoop.conf.Configuration;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
-@Disabled // ELASTICITY_TODO
public class ExternalCompactionMetricsIT extends SharedMiniClusterBase {
public static class ExternalCompactionMetricsITConfig
implements MiniClusterConfigurationCallback {
@Override
public void configureMiniCluster(MiniAccumuloConfigImpl cfg, Configuration coreSite) {
ExternalCompactionTestUtils.configureMiniCluster(cfg, coreSite);
- cfg.getClusterServerConfiguration().setNumDefaultCompactors(2);
+ cfg.getClusterServerConfiguration().setNumDefaultCompactors(0);
// use one tserver so that queue metrics are not spread across tservers
cfg.getClusterServerConfiguration().setNumDefaultTabletServers(1);
+ // Override the initial state from ExternalCompactionTestUtils to not create compactors
Review Comment:
Right, because MAC will read the properties and start the compactors for the defined resource groups. Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix disabled CompactionITs [accumulo]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #4046:
URL: https://github.com/apache/accumulo/pull/4046#discussion_r1424562276
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionMetricsIT.java:
##########
@@ -163,7 +176,9 @@ public void testMetrics() throws Exception {
// Wait for all external compactions to complete
long count;
do {
- UtilWaitThread.sleep(100);
+ // TODO: Change this from waiting to verifying that all compactors are done running jobs,
Review Comment:
No, I want to add that change in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix disabled CompactionITs [accumulo]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr merged PR #4046:
URL: https://github.com/apache/accumulo/pull/4046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org