You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (Created) (JIRA)" <ji...@apache.org> on 2012/03/18 07:35:03 UTC
[jira] [Created] (ZOOKEEPER-1426) add version command to the
zookeeper server
add version command to the zookeeper server
-------------------------------------------
Key: ZOOKEEPER-1426
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
Project: ZooKeeper
Issue Type: Improvement
Components: scripts, server
Reporter: Patrick Hunt
Add a version command to the zkServer.sh.
Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
We could do something similar, hook it into our current version information class (perhaps add main to that class).
Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426927#comment-13426927 ]
Hadoop QA commented on ZOOKEEPER-1426:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538829/ZOOKEEPER-1426-2.patch
against trunk revision 1368203.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//console
This message is automatically generated.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated ZOOKEEPER-1426:
-----------------------------------
Attachment: ZOOKEEPER-1426-3.patch
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426099#comment-13426099 ]
Jakob Homan commented on ZOOKEEPER-1426:
----------------------------------------
Is the ASF header required on generated files?
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430713#comment-13430713 ]
Jakob Homan commented on ZOOKEEPER-1426:
----------------------------------------
Hey Eli. Looks like the new patch picked up some changes from the changelog. Also, can you look into the [new findbugs warning|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html]? Thanks.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444465#comment-13444465 ]
Jakob Homan commented on ZOOKEEPER-1426:
----------------------------------------
+1 from me. Thanks for the update. [~phunt], does this look good to you?
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426768#comment-13426768 ]
Hadoop QA commented on ZOOKEEPER-1426:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538805/MAPREDUCE-4282-2.patch
against trunk revision 1368072.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 19 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1150//console
This message is automatically generated.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated ZOOKEEPER-1426:
-----------------------------------
Attachment: MAPREDUCE-4282-2.patch
Added test, fixed generated class name to include "Main" prefix, etc. passes 'ant compile-test'
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated ZOOKEEPER-1426:
-----------------------------------
Attachment: ZOOKEEPER-1426-1.patch
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Labels: newbie, patch
> Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426799#comment-13426799 ]
Eli Reisman commented on ZOOKEEPER-1426:
----------------------------------------
I saw this Hadoop QA notice, so I pulled fresh trunk and applied the patch. it worked fine. It is a git --no-prefix patch, and I used "patch -p0 ..." is that the problem? anyway I don't know what its talking about so I can't fix it yet. Still passes ant compile-test as well.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1426:
---------------------------------------
Assignee: Eli Reisman
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430788#comment-13430788 ]
Hadoop QA commented on ZOOKEEPER-1426:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12539752/ZOOKEEPER-1426-3.patch
against trunk revision 1368737.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//console
This message is automatically generated.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419391#comment-13419391 ]
Hadoop QA commented on ZOOKEEPER-1426:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537373/ZOOKEEPER-1426-1.patch
against trunk revision 1362660.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//console
This message is automatically generated.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Labels: newbie, patch
> Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426843#comment-13426843 ]
Eli Reisman commented on ZOOKEEPER-1426:
----------------------------------------
sorry wrong patch, will upload the right one now!
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1426:
-------------------------------------
Fix Version/s: 3.5.0
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Fix For: 3.5.0
>
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426733#comment-13426733 ]
Eli Reisman commented on ZOOKEEPER-1426:
----------------------------------------
If you mean the ASF license at the top in comments, its in there, gets generated also. Did you mean something else?
I will add a test today.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426809#comment-13426809 ]
Patrick Hunt commented on ZOOKEEPER-1426:
-----------------------------------------
for some reason you attached a MAPREDUCE patch? the patch QA bot pulls the most recent attachment to try as the patch (against trunk).
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426123#comment-13426123 ]
Patrick Hunt commented on ZOOKEEPER-1426:
-----------------------------------------
Good catch Jakob. It's good to add it whenever possible, esp for source files.
Eli please add the header as well.
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: ZOOKEEPER-1426-1.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1426) add version command to the
zookeeper server
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Reisman updated ZOOKEEPER-1426:
-----------------------------------
Attachment: ZOOKEEPER-1426-2.patch
lets see if I can click the mouse correctly this time...
> add version command to the zookeeper server
> -------------------------------------------
>
> Key: ZOOKEEPER-1426
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts, server
> Affects Versions: 3.3.5
> Reporter: Patrick Hunt
> Assignee: Eli Reisman
> Labels: newbie, patch
> Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch
>
>
> Add a version command to the zkServer.sh.
> Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo
> We could do something similar, hook it into our current version information class (perhaps add main to that class).
> Would also need to add a new "version" command to zkServer.sh that calls this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira