You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2016/07/01 16:49:11 UTC

[jira] [Updated] (FLINK-3753) KillerWatchDog should not use kill on toKill thread

     [ https://issues.apache.org/jira/browse/FLINK-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated FLINK-3753:
--------------------------
    Description: 
{code}
    // this is harsh, but this watchdog is a last resort
    if (toKill.isAlive()) {
      toKill.stop();
    }
{code}

stop() is deprecated.


See:
https://www.securecoding.cert.org/confluence/display/java/THI05-J.+Do+not+use+Thread.stop()+to+terminate+threads

  was:
{code}
    // this is harsh, but this watchdog is a last resort
    if (toKill.isAlive()) {
      toKill.stop();
    }
{code}

stop() is deprecated.

See:
https://www.securecoding.cert.org/confluence/display/java/THI05-J.+Do+not+use+Thread.stop()+to+terminate+threads


> KillerWatchDog should not use kill on toKill thread
> ---------------------------------------------------
>
>                 Key: FLINK-3753
>                 URL: https://issues.apache.org/jira/browse/FLINK-3753
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     // this is harsh, but this watchdog is a last resort
>     if (toKill.isAlive()) {
>       toKill.stop();
>     }
> {code}
> stop() is deprecated.
> See:
> https://www.securecoding.cert.org/confluence/display/java/THI05-J.+Do+not+use+Thread.stop()+to+terminate+threads



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)