You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/20 08:56:36 UTC

[GitHub] [spark] Ngone51 opened a new pull request #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Ngone51 opened a new pull request #28271:
URL: https://github.com/apache/spark/pull/28271


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   To support formatted explain for AQE.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   AQE does not support formatted explain yet. It's good to support it for better user experience, debugging, etc.
   
   Here's an example of formatted explain of AQE plan:
   
   ```
   == Physical Plan ==
          AdaptiveSparkPlan (14)
          +- * HashAggregate (13)
             +- CustomShuffleReader (12)
                +- ShuffleQueryStage (11)
                   +- Exchange (10)
                      +- * HashAggregate (9)
                         +- * Project (8)
                            +- * BroadcastHashJoin Inner BuildRight (7)
                               :- * Project (2)
                               :  +- * LocalTableScan (1)
                               +- BroadcastQueryStage (6)
                                  +- BroadcastExchange (5)
                                     +- * Project (4)
                                        +- * LocalTableScan (3)
   ```
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   No, this should be new feature along with AQE in Spark 3.0.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Added a query file: `explain-aqe.sql` and a unit test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617177756






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616412267






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617940576






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616578126


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121514/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-618105766


   Hi, All.
   This seems to break all Jenkins job in `branch-3.0`. Could you make a follow-up?
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-maven-hadoop-2.7-hive-2.3-jdk-11/278/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617741437


   **[Test build #121620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121620/testReport)** for PR 28271 at commit [`5893e40`](https://github.com/apache/spark/commit/5893e4004a0c14e3a00d0730e44779a1d71ebfe0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28271:
URL: https://github.com/apache/spark/pull/28271#discussion_r412872981



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala
##########
@@ -212,7 +228,7 @@ object ExplainUtils {
               case _ =>
             }
         })
-    }
+      }

Review comment:
       wrong indentation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616577399


   **[Test build #121514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121514/testReport)** for PR 28271 at commit [`4808054`](https://github.com/apache/spark/commit/4808054e839c27764a86107765b19d45246f7b7a).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-618121425


   Sure, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617939281


   **[Test build #121620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121620/testReport)** for PR 28271 at commit [`5893e40`](https://github.com/apache/spark/commit/5893e4004a0c14e3a00d0730e44779a1d71ebfe0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28271:
URL: https://github.com/apache/spark/pull/28271#discussion_r411319209



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -332,4 +335,57 @@ class ExplainSuite extends QueryTest with SharedSparkSession with DisableAdaptiv
   }
 }
 
+class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuite {
+  import testImplicits._
+
+  test("Explain formatted") {
+    val df1 = Seq((1, 2), (2, 3)).toDF("k", "v1")
+    val df2 = Seq((2, 3), (1, 1)).toDF("k", "v2")
+    val testDf = df1.join(df2, "k").groupBy("k").agg(count("v1"), sum("v1"), avg("v2"))
+    // trigger the final plan for AQE
+    testDf.collect()
+    // whitespace
+    val ws = " "
+    //   == Physical Plan ==
+    //   AdaptiveSparkPlan (14)

Review comment:
       > Was it just AdaptiveSparkPlan (14)?
   
   Yeah..have updated description, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617940576






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617372849


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617177037


   **[Test build #121585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121585/testReport)** for PR 28271 at commit [`4808054`](https://github.com/apache/spark/commit/4808054e839c27764a86107765b19d45246f7b7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617372849






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617372864


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121590/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616411708


   **[Test build #121514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121514/testReport)** for PR 28271 at commit [`4808054`](https://github.com/apache/spark/commit/4808054e839c27764a86107765b19d45246f7b7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617578240






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617298585


   **[Test build #121590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121590/testReport)** for PR 28271 at commit [`0c7ff4f`](https://github.com/apache/spark/commit/0c7ff4f3aa79db61d8ed6d2feb7706cbeb774cd1).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617742353






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617498892






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616412267






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617299356






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-618105766


   Hi, All.
   This seems to break all Jenkins job in `branch-3.0`. Could you make a follow-up?
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-maven-hadoop-2.7-hive-2.3-jdk-11/278/
   ```
    org.scalatest.exceptions.TestFailedException: explain-aqe.sql
   Expected "...ondition: None
        [  ]
   (9) AdaptiveSparkPl...", but got "...ondition: None
        []
   (9) AdaptiveSparkPl..." Result did not match for query #8
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617756433


   The last commit just changes indentation. Thanks, merging to master/3.0!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617286174


   **[Test build #121585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121585/testReport)** for PR 28271 at commit [`4808054`](https://github.com/apache/spark/commit/4808054e839c27764a86107765b19d45246f7b7a).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617500658


   **[Test build #121600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121600/testReport)** for PR 28271 at commit [`1228d2e`](https://github.com/apache/spark/commit/1228d2e439197eee986473f7c9af82e86d11a449).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617578240






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616578109






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617800841


   thanks all!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617578374


   cc @cloud-fan @maryannxue 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617500658


   **[Test build #121600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121600/testReport)** for PR 28271 at commit [`1228d2e`](https://github.com/apache/spark/commit/1228d2e439197eee986473f7c9af82e86d11a449).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28271:
URL: https://github.com/apache/spark/pull/28271#discussion_r411245351



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -332,4 +335,57 @@ class ExplainSuite extends QueryTest with SharedSparkSession with DisableAdaptiv
   }
 }
 
+class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuite {
+  import testImplicits._
+
+  test("Explain formatted") {
+    val df1 = Seq((1, 2), (2, 3)).toDF("k", "v1")
+    val df2 = Seq((2, 3), (1, 1)).toDF("k", "v2")
+    val testDf = df1.join(df2, "k").groupBy("k").agg(count("v1"), sum("v1"), avg("v2"))
+    // trigger the final plan for AQE
+    testDf.collect()
+    // whitespace
+    val ws = " "
+    //   == Physical Plan ==
+    //   AdaptiveSparkPlan (14)

Review comment:
       @Ngone51, it would be better if we show the before/after results in the PR description. What was it before out of curiosity? Was it just `AdaptiveSparkPlan (14)`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616578109


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617286689






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-616411708


   **[Test build #121514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121514/testReport)** for PR 28271 at commit [`4808054`](https://github.com/apache/spark/commit/4808054e839c27764a86107765b19d45246f7b7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617742353






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28271:
URL: https://github.com/apache/spark/pull/28271#discussion_r411319209



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -332,4 +335,57 @@ class ExplainSuite extends QueryTest with SharedSparkSession with DisableAdaptiv
   }
 }
 
+class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuite {
+  import testImplicits._
+
+  test("Explain formatted") {
+    val df1 = Seq((1, 2), (2, 3)).toDF("k", "v1")
+    val df2 = Seq((2, 3), (1, 1)).toDF("k", "v2")
+    val testDf = df1.join(df2, "k").groupBy("k").agg(count("v1"), sum("v1"), avg("v2"))
+    // trigger the final plan for AQE
+    testDf.collect()
+    // whitespace
+    val ws = " "
+    //   == Physical Plan ==
+    //   AdaptiveSparkPlan (14)

Review comment:
       Thanks, I'm updating the decription.

##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -332,4 +335,57 @@ class ExplainSuite extends QueryTest with SharedSparkSession with DisableAdaptiv
   }
 }
 
+class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuite {
+  import testImplicits._
+
+  test("Explain formatted") {
+    val df1 = Seq((1, 2), (2, 3)).toDF("k", "v1")
+    val df2 = Seq((2, 3), (1, 1)).toDF("k", "v2")
+    val testDf = df1.join(df2, "k").groupBy("k").agg(count("v1"), sum("v1"), avg("v2"))
+    // trigger the final plan for AQE
+    testDf.collect()
+    // whitespace
+    val ws = " "
+    //   == Physical Plan ==
+    //   AdaptiveSparkPlan (14)

Review comment:
       Thanks, I'm updating the description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617622814


   looks fine to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617286689


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617176302


   retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617298585


   **[Test build #121590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121590/testReport)** for PR 28271 at commit [`0c7ff4f`](https://github.com/apache/spark/commit/0c7ff4f3aa79db61d8ed6d2feb7706cbeb774cd1).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617498892






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617177037


   **[Test build #121585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121585/testReport)** for PR 28271 at commit [`4808054`](https://github.com/apache/spark/commit/4808054e839c27764a86107765b19d45246f7b7a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617741437


   **[Test build #121620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121620/testReport)** for PR 28271 at commit [`5893e40`](https://github.com/apache/spark/commit/5893e4004a0c14e3a00d0730e44779a1d71ebfe0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a change in pull request #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28271:
URL: https://github.com/apache/spark/pull/28271#discussion_r411319209



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -332,4 +335,57 @@ class ExplainSuite extends QueryTest with SharedSparkSession with DisableAdaptiv
   }
 }
 
+class ExplainSuiteAE extends ExplainSuiteHelper with EnableAdaptiveExecutionSuite {
+  import testImplicits._
+
+  test("Explain formatted") {
+    val df1 = Seq((1, 2), (2, 3)).toDF("k", "v1")
+    val df2 = Seq((2, 3), (1, 1)).toDF("k", "v2")
+    val testDf = df1.join(df2, "k").groupBy("k").agg(count("v1"), sum("v1"), avg("v2"))
+    // trigger the final plan for AQE
+    testDf.collect()
+    // whitespace
+    val ws = " "
+    //   == Physical Plan ==
+    //   AdaptiveSparkPlan (14)

Review comment:
       > Was it just AdaptiveSparkPlan (14)?
   Yeah..have updated description, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617177756






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617286702


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121585/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617299356






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617577525


   **[Test build #121600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121600/testReport)** for PR 28271 at commit [`1228d2e`](https://github.com/apache/spark/commit/1228d2e439197eee986473f7c9af82e86d11a449).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28271: [SPARK-31495][SQL] Support formatted explain for AQE

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28271:
URL: https://github.com/apache/spark/pull/28271#issuecomment-617372592


   **[Test build #121590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121590/testReport)** for PR 28271 at commit [`0c7ff4f`](https://github.com/apache/spark/commit/0c7ff4f3aa79db61d8ed6d2feb7706cbeb774cd1).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org