You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "silver-ymz (via GitHub)" <gi...@apache.org> on 2023/06/25 06:19:01 UTC
[GitHub] [incubator-opendal] silver-ymz opened a new pull request, #2527: feat(bindings/haskell): support list and scan
silver-ymz opened a new pull request, #2527:
URL: https://github.com/apache/incubator-opendal/pull/2527
Update:
- export `list` and `scan`
- add tests for `copy`, `rename`, `list`, `scan`
- fix error of trailling `\0` in `leak_str`
I imitate `DirStream` in `unix` library to design `Lister` API. However, it doesn't seem very native and useful. I havn't came up with other solutions about it yet. Maybe we can improve it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2527: feat(bindings/haskell): support list and scan
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2527:
URL: https://github.com/apache/incubator-opendal/pull/2527#issuecomment-1605900757
> we provide `next` and `all` operation for it.
Provide `all` on Lister is wrong since the Lister could be very large (more than 1M objects). It's by design that only has a `next` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] silver-ymz commented on pull request #2527: feat(bindings/haskell): support list and scan
Posted by "silver-ymz (via GitHub)" <gi...@apache.org>.
silver-ymz commented on PR #2527:
URL: https://github.com/apache/incubator-opendal/pull/2527#issuecomment-1605914296
I have removed `all` operation. Could you review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] silver-ymz commented on pull request #2527: feat(bindings/haskell): support list and scan
Posted by "silver-ymz (via GitHub)" <gi...@apache.org>.
silver-ymz commented on PR #2527:
URL: https://github.com/apache/incubator-opendal/pull/2527#issuecomment-1605898231
These are `unix` library API for `DirStream`.
```
openDirStream :: RawFilePath -> IO DirStream
readDirStream :: DirStream -> IO RawFilePath
```
It seems only to provide an `iterator` and `next` function.
These are the APIs I exported.
```
listOpRaw :: Operator -> String -> IO (Either OpenDALError Lister)
nextLister :: Lister -> IO (Either OpenDALError (Maybe String))
allLister :: Lister -> IO (Either OpenDALError [String])
```
`list` operation will return a `Lister` and we provide `next` and `all` operation for it.
The API I'm expecting is like `ListT` in `pipe` library. With it, users can use all standard library utilities like `map`, `filter`, etc. I may need to spend more time researching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2527: feat(bindings/haskell): support list and scan
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2527:
URL: https://github.com/apache/incubator-opendal/pull/2527#issuecomment-1605893058
> I imitate `DirStream` in `unix` library to design `Lister` API. However, it doesn't seem very native and useful. I havn't came up with other solutions about it yet. Maybe we can improve it in the future.
How will haskell handle silimiar works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2527: feat(bindings/haskell): support list and scan
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2527:
URL: https://github.com/apache/incubator-opendal/pull/2527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org