You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/06/24 23:39:31 UTC
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23085
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
IMPALA-14076: Improve readability of workload management query
This patch improve the readability of workload management's insert dml
query profiles by:
1. Add a newline between each entry in the VALUES clause.
2. Remove analyzed query from the PLAN column in both tables.
For second one, a new query option HIDE_ANALYZED_QUERY is added. If this
option is set to True, 'Analyzed query' will not be printed in Plan
section of runtime profile. This is helpful for long SQL such as
workload management's insert dml query.
Testing:
- Add explain test case for HIDE_ANALYZED_QUERY option.
- Manually run some queries in minicluster with enabled workload
management. Confirmed that both improvement happen in DML runtime
profile.
Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
---
M be/src/service/query-options.cc
M be/src/service/query-options.h
M be/src/service/workload-management-worker.cc
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-query/queries/QueryTest/explain-level2.test
M testdata/workloads/functional-query/queries/QueryTest/explain-level3.test
8 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/23085/1
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23085/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23085/1//COMMIT_MSG@15
PS1, Line 15: option is set to True, 'Analyzed query' will not be printed in Plan
> I'm not quite clear where the explain plan is generated during the INSERT s
Please check query profile after the change attached in JIRA (https://issues.apache.org/jira/secure/attachment/13077205/profile_eb4c870cd027ac3e_f2bf97d300000000.txt).
With this option, the long INSERT INTO VALUES is not repeated again in Plan section.
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Jul 2025 23:32:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jul 2025 03:51:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
IMPALA-14076: Improve readability of workload management query
This patch improve the readability of workload management's insert dml
query profiles by:
1. Add a newline between each entry in the VALUES clause.
2. Remove analyzed query from the PLAN column in both tables.
For second one, a new query option HIDE_ANALYZED_QUERY is added. If this
option is set to True, 'Analyzed query' will not be printed in Plan
section of runtime profile. This is helpful for long SQL such as
workload management's insert dml query.
Testing:
- Add explain test case for HIDE_ANALYZED_QUERY option.
- Manually run some queries in minicluster with enabled workload
management. Confirmed that both improvement happen in DML runtime
profile.
Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Reviewed-on: http://gerrit.cloudera.org:8080/23085
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/query-options.cc
M be/src/service/query-options.h
M be/src/service/workload-management-worker.cc
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-query/queries/QueryTest/explain-level2.test
M testdata/workloads/functional-query/queries/QueryTest/explain-level3.test
8 files changed, 33 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12178/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 21:16:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19589/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 00:06:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23085/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23085/1//COMMIT_MSG@15
PS1, Line 15: option is set to True, 'Analyzed query' will not be printed in Plan
> Please check query profile after the change attached in JIRA (https://issue
Ack
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 21:12:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 21:16:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Jun 2025 19:01:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14076: Improve readability of workload management query
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23085 )
Change subject: IMPALA-14076: Improve readability of workload management query
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23085/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23085/1//COMMIT_MSG@15
PS1, Line 15: option is set to True, 'Analyzed query' will not be printed in Plan
I'm not quite clear where the explain plan is generated during the INSERT statement that this change helps with.
--
To view, visit http://gerrit.cloudera.org:8080/23085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30576795dbc2af27a6879684f3757becfd8fc8d0
Gerrit-Change-Number: 23085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Jul 2025 23:25:31 +0000
Gerrit-HasComments: Yes