You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hughhhh (via GitHub)" <gi...@apache.org> on 2023/07/31 21:15:19 UTC
[GitHub] [superset] hughhhh opened a new pull request, #24849: fix: validation errors appearing after ssh tunnel switch
hughhhh opened a new pull request, #24849:
URL: https://github.com/apache/superset/pull/24849
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
fixed issues with onBlur validation callbacks when user clicks the ssh tunnel toggle. Main issue was errors were still appearing after the fact when the entire forms needs to be filled out to establish an ssh tunnel connection
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #24849: fix: validation errors appearing after ssh tunnel switch
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh merged PR #24849:
URL: https://github.com/apache/superset/pull/24849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24849: fix: validation errors appearing after ssh tunnel switch
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24849:
URL: https://github.com/apache/superset/pull/24849#issuecomment-1659264309
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24849](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (387c40a) into [master](https://app.codecov.io/gh/apache/superset/commit/5f103072b0f006862c61abc0ab336b6a388ec95a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5f10307) will **increase** coverage by `0.00%`.
> Report is 2 commits behind head on master.
> The diff coverage is `93.10%`.
> :exclamation: Current head 387c40a differs from pull request most recent head d2d3e22. Consider uploading reports for the commit d2d3e22 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24849 +/- ##
=======================================
Coverage 68.99% 69.00%
=======================================
Files 1904 1904
Lines 74081 74108 +27
Branches 8193 8193
=======================================
+ Hits 51115 51137 +22
- Misses 20845 20850 +5
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.82% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ses/DatabaseModal/DatabaseConnectionForm/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0vaW5kZXgudHN4) | `81.81% <ø> (ø)` | |
| [superset/advanced\_data\_type/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL2FwaS5weQ==) | `100.00% <ø> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `89.23% <ø> (ø)` | |
| [superset/annotation\_layers/annotations/schemas.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `100.00% <ø> (ø)` | |
| [superset/annotation\_layers/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `86.20% <ø> (ø)` | |
| [superset/annotation\_layers/schemas.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvc2NoZW1hcy5weQ==) | `100.00% <ø> (ø)` | |
| [superset/async\_events/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | `100.00% <ø> (ø)` | |
| [superset/available\_domains/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYXZhaWxhYmxlX2RvbWFpbnMvYXBpLnB5) | `100.00% <ø> (ø)` | |
| [superset/cachekeys/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2FjaGVrZXlzL2FwaS5weQ==) | `96.15% <ø> (ø)` | |
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `87.82% <ø> (ø)` | |
| ... and [43 more](https://app.codecov.io/gh/apache/superset/pull/24849?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24849/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org