You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by zi...@apache.org on 2022/05/30 12:46:41 UTC

[incubator-inlong] branch master updated: [INLONG-4438][Manager] Add warning log to remind register dataproxy cluster (#4440)

This is an automated email from the ASF dual-hosted git repository.

zirui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-inlong.git


The following commit(s) were added to refs/heads/master by this push:
     new 898ca8928 [INLONG-4438][Manager] Add warning log to remind register dataproxy cluster (#4440)
898ca8928 is described below

commit 898ca8928b68d95c532f8aee8726e2b32c0fbdbb
Author: dockerzhang <do...@tencent.com>
AuthorDate: Mon May 30 20:46:36 2022 +0800

    [INLONG-4438][Manager] Add warning log to remind register dataproxy cluster (#4440)
---
 .../service/core/impl/ThirdPartyClusterServiceImpl.java       | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/ThirdPartyClusterServiceImpl.java b/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/ThirdPartyClusterServiceImpl.java
index 19899bec6..ab5bdc9bc 100644
--- a/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/ThirdPartyClusterServiceImpl.java
+++ b/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/ThirdPartyClusterServiceImpl.java
@@ -278,17 +278,16 @@ public class ThirdPartyClusterServiceImpl implements ThirdPartyClusterService {
      */
     @Override
     public ThirdPartyClusterDTO getConfigV2(String clusterName) {
+        // TODO Optimize query conditions use dataProxyClusterId
+        ThirdPartyClusterDTO object = new ThirdPartyClusterDTO();
         ThirdPartyClusterEntity clusterEntity = thirdPartyClusterMapper.selectByName(clusterName);
         if (clusterEntity == null) {
-            throw new BusinessException("data proxy cluster not found by name=" + clusterName);
+            LOGGER.warn("DataProxy cluster not found by name = " + clusterName + ", please register it firstly.");
+            return object;
         }
-
-        // TODO Optimize query conditions use dataProxyClusterId
-        ThirdPartyClusterDTO object = new ThirdPartyClusterDTO();
         List<InlongGroupEntity> groupEntityList = groupMapper.selectAll(GroupStatus.CONFIG_SUCCESSFUL.getCode());
         if (CollectionUtils.isEmpty(groupEntityList)) {
-            String msg = "not found any inlong group with success status for proxy cluster name = " + clusterName;
-            LOGGER.warn(msg);
+            LOGGER.warn("not found any inlong group with success status for proxy cluster name = " + clusterName);
             return object;
         }