You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/20 03:36:58 UTC

[GitHub] [flink] wsry opened a new pull request #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.

wsry opened a new pull request #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.
URL: https://github.com/apache/flink/pull/10639
 
 
   ## What is the purpose of the change
   Currently, org.lz4:lz4-java library is used by runtime and table module for data compression to reduce disk and network IO. To avoid potential conflict, the library is shaded. However, shading changes the class name, which prevents JVM to find the more performant native implementation. To boost the performance, this commit removes the shade of org.lz4:lz4-java library. Note that this change can improve the probability of potential class conflict and to solve the problem, we can make it a plugin in the future.
   
   
   ## Brief change log
   
     - Shade of org.lz4:lz4-java library is removed.
   
   
   ## Verifying this change
   
     - The change can be verified by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**yes** / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW edited a comment on issue #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.

Posted by GitBox <gi...@apache.org>.
zhijiangW edited a comment on issue #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.
URL: https://github.com/apache/flink/pull/10639#issuecomment-567960585
 
 
   backport from #10636 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW removed a comment on issue #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.

Posted by GitBox <gi...@apache.org>.
zhijiangW removed a comment on issue #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.
URL: https://github.com/apache/flink/pull/10639#issuecomment-567960585
 
 
   backport from #10636 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW merged pull request #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.

Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.
URL: https://github.com/apache/flink/pull/10639
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on issue #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #10639: [FLINK-15311][runtime] Remove shade of org.lz4:lz4-java to make lz4 block compression use native implementation by default.
URL: https://github.com/apache/flink/pull/10639#issuecomment-567960585
 
 
   back port from #10636 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services