You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/06 16:55:53 UTC
[GitHub] [incubator-pinot] mayankshriv opened a new pull request #5342: Fix new broker to old server backward compatibility issue.
mayankshriv opened a new pull request #5342:
URL: https://github.com/apache/incubator-pinot/pull/5342
With PR #5259 and #5275, the broker starts to send aggregation function arguments
in a new field in the thrift class. While new server prefers new field and falls back
to old field, in case of new broker and old server the server is unable to find
values in the field.
This PR fixes this issue by adding both old and new field in the broker. We will need to
change back broker to stop setting the old field with a future release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #5342: Fix new broker to old server backward compatibility issue.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5342:
URL: https://github.com/apache/incubator-pinot/pull/5342#issuecomment-624791322
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=h1) Report
> Merging [#5342](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/52001be6e37f07a7359766021df9495f7112fae9&el=desc) will **increase** coverage by `9.40%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5342 +/- ##
==========================================
+ Coverage 56.88% 66.28% +9.40%
==========================================
Files 1073 1073
Lines 54722 54726 +4
Branches 8159 8159
==========================================
+ Hits 31126 36275 +5149
+ Misses 21149 15785 -5364
- Partials 2447 2666 +219
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `89.57% <100.00%> (+0.09%)` | :arrow_up: |
| [...inot/pql/parsers/pql2/ast/FunctionCallAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9GdW5jdGlvbkNhbGxBc3ROb2RlLmphdmE=) | `63.26% <100.00%> (+5.81%)` | :arrow_up: |
| [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `88.25% <0.00%> (+0.75%)` | :arrow_up: |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `70.63% <0.00%> (+0.85%)` | :arrow_up: |
| [...re/segment/index/metadata/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L21ldGFkYXRhL1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `79.52% <0.00%> (+0.95%)` | :arrow_up: |
| [...t/core/operator/CombineGroupByOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9yZGVyQnlPcGVyYXRvci5qYXZh) | `80.95% <0.00%> (+0.95%)` | :arrow_up: |
| [...rg/apache/pinot/core/operator/CombineOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lT3BlcmF0b3IuamF2YQ==) | `65.97% <0.00%> (+1.03%)` | :arrow_up: |
| [.../FixedByteSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5TaW5nbGVWYWx1ZVJlYWRlcldyaXRlci5qYXZh) | `98.94% <0.00%> (+1.05%)` | :arrow_up: |
| [...t/common/response/broker/BrokerResponseNative.java](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL0Jyb2tlclJlc3BvbnNlTmF0aXZlLmphdmE=) | `90.52% <0.00%> (+1.05%)` | :arrow_up: |
| ... and [320 more](https://codecov.io/gh/apache/incubator-pinot/pull/5342/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=footer). Last update [52001be...e6cdc5c](https://codecov.io/gh/apache/incubator-pinot/pull/5342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org