You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mark-bathori (via GitHub)" <gi...@apache.org> on 2023/04/04 14:47:00 UTC
[GitHub] [nifi] mark-bathori opened a new pull request, #7121: NIFI-11342: HDFS processors fail to get ClassloaderIsolationKey at startup
mark-bathori opened a new pull request, #7121:
URL: https://github.com/apache/nifi/pull/7121
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11342](https://issues.apache.org/jira/browse/NIFI-11342)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #7121: NIFI-11342: HDFS processors fail to get ClassloaderIsolationKey at startup
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #7121: NIFI-11342: HDFS processors fail to get ClassloaderIsolationKey at startup
URL: https://github.com/apache/nifi/pull/7121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #7121: NIFI-11342: HDFS processors fail to get ClassloaderIsolationKey at startup
Posted by "turcsanyip (via GitHub)" <gi...@apache.org>.
turcsanyip commented on code in PR #7121:
URL: https://github.com/apache/nifi/pull/7121#discussion_r1157608507
##########
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java:
##########
@@ -211,18 +211,22 @@ public String getClassloaderIsolationKey(final PropertyContext context) {
return explicitKerberosPrincipal;
}
- final KerberosCredentialsService credentialsService = context.getProperty(KERBEROS_CREDENTIALS_SERVICE).asControllerService(KerberosCredentialsService.class);
- if (credentialsService != null) {
- final String credentialsServicePrincipal = credentialsService.getPrincipal();
- if (credentialsServicePrincipal != null) {
- return credentialsServicePrincipal;
+ try {
+ final KerberosCredentialsService credentialsService = context.getProperty(KERBEROS_CREDENTIALS_SERVICE).asControllerService(KerberosCredentialsService.class);
+ if (credentialsService != null) {
+ final String credentialsServicePrincipal = credentialsService.getPrincipal();
+ if (credentialsServicePrincipal != null) {
+ return credentialsServicePrincipal;
+ }
}
- }
- final KerberosUserService kerberosUserService = context.getProperty(KERBEROS_USER_SERVICE).asControllerService(KerberosUserService.class);
- if (kerberosUserService != null) {
- final KerberosUser kerberosUser = kerberosUserService.createKerberosUser();
- return kerberosUser.getPrincipal();
+ final KerberosUserService kerberosUserService = context.getProperty(KERBEROS_USER_SERVICE).asControllerService(KerberosUserService.class);
+ if (kerberosUserService != null) {
+ final KerberosUser kerberosUser = kerberosUserService.createKerberosUser();
+ return kerberosUser.getPrincipal();
+ }
+ } catch (Exception e) {
Review Comment:
@mark-bathori Thanks for handling this "Controller Service's State is currently DISABLED" issue!
Instead of the generic `Exception`, only `ControllerServiceDisabledException` should be caught and handled but it is not visible here (and we definitely do not want to add `nifi-framework-core-api`). This exception is a child of `IllegalStateException` which could be used in the catch block to narrow the scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mark-bathori commented on a diff in pull request #7121: NIFI-11342: HDFS processors fail to get ClassloaderIsolationKey at startup
Posted by "mark-bathori (via GitHub)" <gi...@apache.org>.
mark-bathori commented on code in PR #7121:
URL: https://github.com/apache/nifi/pull/7121#discussion_r1158162517
##########
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java:
##########
@@ -211,18 +211,22 @@ public String getClassloaderIsolationKey(final PropertyContext context) {
return explicitKerberosPrincipal;
}
- final KerberosCredentialsService credentialsService = context.getProperty(KERBEROS_CREDENTIALS_SERVICE).asControllerService(KerberosCredentialsService.class);
- if (credentialsService != null) {
- final String credentialsServicePrincipal = credentialsService.getPrincipal();
- if (credentialsServicePrincipal != null) {
- return credentialsServicePrincipal;
+ try {
+ final KerberosCredentialsService credentialsService = context.getProperty(KERBEROS_CREDENTIALS_SERVICE).asControllerService(KerberosCredentialsService.class);
+ if (credentialsService != null) {
+ final String credentialsServicePrincipal = credentialsService.getPrincipal();
+ if (credentialsServicePrincipal != null) {
+ return credentialsServicePrincipal;
+ }
}
- }
- final KerberosUserService kerberosUserService = context.getProperty(KERBEROS_USER_SERVICE).asControllerService(KerberosUserService.class);
- if (kerberosUserService != null) {
- final KerberosUser kerberosUser = kerberosUserService.createKerberosUser();
- return kerberosUser.getPrincipal();
+ final KerberosUserService kerberosUserService = context.getProperty(KERBEROS_USER_SERVICE).asControllerService(KerberosUserService.class);
+ if (kerberosUserService != null) {
+ final KerberosUser kerberosUser = kerberosUserService.createKerberosUser();
+ return kerberosUser.getPrincipal();
+ }
+ } catch (Exception e) {
Review Comment:
Thanks @turcsanyip for the review. I originally wanted to use `ControllerServiceDisabledException` but faced with the same issue that it is not visible there, that's why I used `Exception` but using `IllegalStateException` is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org