You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "Madhan Neethiraj (JIRA)" <ji...@apache.org> on 2017/01/20 22:55:26 UTC

[jira] [Comment Edited] (ATLAS-1478) REST API endpoint to support adding a tag to multiple entities

    [ https://issues.apache.org/jira/browse/ATLAS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832551#comment-15832551 ] 

Madhan Neethiraj edited comment on ATLAS-1478 at 1/20/17 10:54 PM:
-------------------------------------------------------------------

Address review comment #3 above - by moving the Precondition.checkNotNull() to addTrait() method.

About throwing alternate exception (TraitNotFound instead of TypeNotFound), I see few places that handle TypeNotFound differently than other exceptions. Changing the exception might break these code; if this is critical, I would suggest we take this in a separate patch.


was (Author: madhan.neethiraj):
Address review comment.

> REST API endpoint to support adding a tag to multiple entities
> --------------------------------------------------------------
>
>                 Key: ATLAS-1478
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1478
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Vimal Sharma
>            Assignee: Vimal Sharma
>             Fix For: 0.8-incubating
>
>         Attachments: ATLAS-1478.patch, ATLAS-1478-v2.patch, ATLAS-1478-v3.patch, ATLAS-1478-v4.patch
>
>
> Currently, there is no REST endpoint to add a tag to multiple entities. Add a REST endpoint in V2 APIs to support adding a tag to multiple entities in a single call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)