You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/11/13 11:20:58 UTC
[GitHub] brooklyn-server pull request #893: BROOKLYN-461: coerce empty string to URI ...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/893
BROOKLYN-461: coerce empty string to URI as null
This fixes https://issues.apache.org/jira/browse/BROOKLYN-561
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-561
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/893.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #893
----
----
---
[GitHub] brooklyn-server issue #893: BROOKLYN-461: coerce empty string to URI as null
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/893
retest this please
Failure was `ElectPrimaryTest.testSelectionModeFailoverReelectWithPreference`:
```
java.lang.AssertionError: failed succeeds-eventually, 75 attempts, 30001ms elapsed: AssertionError: attribute=Sensor: primary (org.apache.brooklyn.api.entity.Entity); val=TestEntityImpl{id=rg0witaqno}
at org.apache.brooklyn.camp.brooklyn.test.policy.failover.ElectPrimaryTest.runSelectionModeTest(ElectPrimaryTest.java:334)
at org.apache.brooklyn.camp.brooklyn.test.policy.failover.ElectPrimaryTest.testSelectionModeFailoverReelectWithPreference(ElectPrimaryTest.java:292)
Caused by: java.lang.AssertionError: attribute=Sensor: primary (org.apache.brooklyn.api.entity.Entity); val=TestEntityImpl{id=rg0witaqno}
at org.apache.brooklyn.camp.brooklyn.test.policy.failover.ElectPrimaryTest.runSelectionModeTest(ElectPrimaryTest.java:334)
at org.apache.brooklyn.camp.brooklyn.test.policy.failover.ElectPrimaryTest.testSelectionModeFailoverReelectWithPreference(ElectPrimaryTest.java:292)
```
---
[GitHub] brooklyn-server issue #893: BROOKLYN-461: coerce empty string to URI as null
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/brooklyn-server/pull/893
SUCCESS
4932 tests run, 0 skipped, 0 failed.
--none--
---
[GitHub] brooklyn-server pull request #893: BROOKLYN-461: coerce empty string to URI ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/893
---
[GitHub] brooklyn-server issue #893: BROOKLYN-461: coerce empty string to URI as null
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/893
retest this please
---
[GitHub] brooklyn-server issue #893: BROOKLYN-461: coerce empty string to URI as null
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/brooklyn-server/pull/893
FAILURE
4260 tests run, 0 skipped, 1 failed.
--none--
---