You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/08 08:26:59 UTC
[GitHub] [phoenix] stoty opened a new pull request #1078: synchronize HTU creation/teardown
stoty opened a new pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-757107393
Although PR build#4 should finish sometime soon hopefully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r553889088
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Oh this is not even being used
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Looks like this is recent addition right? We could include `deletePriorMetaData()` too?
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Or maybe just synchronizing `deletePriorMetaData()` could be enough as it would cover `deletePriorTables()`, `nextTimestamp()` and `deletePriorSchemas()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r553896489
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Must have been copied from HBase, then lurked here for years...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-757111497
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 53s | master passed |
| +1 :green_heart: | compile | 1m 34s | master passed |
| +1 :green_heart: | checkstyle | 0m 35s | master passed |
| +1 :green_heart: | javadoc | 2m 7s | master passed |
| +0 :ok: | spotbugs | 3m 32s | phoenix-core in master has 956 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 56s | root in master has 1005 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 4s | the patch passed |
| +1 :green_heart: | compile | 1m 25s | the patch passed |
| +1 :green_heart: | javac | 1m 25s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 33s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 16s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 30s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 241m 39s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
| | | 301m 11s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.AlterIndexIT |
| | phoenix.end2end.index.IndexMetadataIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 5fbb6398d0a9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9c346ed |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/4/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/4/testReport/ |
| Max. process+thread count | 6282 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756899800
Last test also had a setup error, but it wasn't the timeout error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-762932711
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 3s | master passed |
| +0 | hbaserecompile | 22m 13s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 33s | master passed |
| +1 :green_heart: | checkstyle | 0m 37s | master passed |
| +1 :green_heart: | javadoc | 2m 13s | master passed |
| +0 :ok: | spotbugs | 4m 18s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 50s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 59s | the patch passed |
| +0 | hbaserecompile | 14m 44s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 30s | the patch passed |
| +1 :green_heart: | javac | 1m 30s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 36s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 7s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 47s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 48s | root in the patch failed. |
| -1 :x: | asflicense | 2m 52s | The patch generated 610 ASF License warnings. |
| | | 193m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 504a70eb0efa 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 50df995 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/10/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/10/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/10/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 8985 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/10/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-762814295
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 12s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 3s | master passed |
| +0 | hbaserecompile | 23m 16s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 35s | master passed |
| +1 :green_heart: | checkstyle | 0m 39s | master passed |
| +1 :green_heart: | javadoc | 2m 17s | master passed |
| +0 :ok: | spotbugs | 4m 37s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 55s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 55s | the patch passed |
| +0 | hbaserecompile | 30m 25s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 30s | the patch passed |
| +1 :green_heart: | javac | 1m 30s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 38s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 6s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 59s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 59s | root in the patch failed. |
| -1 :x: | asflicense | 0m 47s | The patch generated 610 ASF License warnings. |
| | | 206m 56s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/9/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 224325bcdd45 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 50df995 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/9/artifact/yetus-general-check/output/whitespace-eol.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/9/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/9/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/9/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 11006 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/9/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r554102532
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Or maybe just synchronizing `deletePriorMetaData()` could be enough as it would cover `deletePriorTables()`, `nextTimestamp()` and `deletePriorSchemas()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756728295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r553889088
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Oh this is not even being used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-762704449
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 45s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 19s | master passed |
| +0 | hbaserecompile | 25m 17s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 33s | master passed |
| +1 :green_heart: | checkstyle | 0m 39s | master passed |
| +1 :green_heart: | javadoc | 2m 19s | master passed |
| +0 :ok: | spotbugs | 4m 31s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 10s | the patch passed |
| +0 | hbaserecompile | 14m 40s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 34s | the patch passed |
| +1 :green_heart: | javac | 1m 34s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 38s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 12s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 54s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 127m 44s | root in the patch failed. |
| -1 :x: | asflicense | 1m 27s | The patch generated 610 ASF License warnings. |
| | | 198m 22s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.LocalImmutableNonTxIndexIT |
| | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 3a417243576d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 50df995 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/8/artifact/yetus-general-check/output/whitespace-eol.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/8/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/8/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/8/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 9509 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/8/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-764984704
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 39s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 5s | master passed |
| +0 | hbaserecompile | 23m 38s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 34s | master passed |
| +1 :green_heart: | checkstyle | 0m 39s | master passed |
| +1 :green_heart: | javadoc | 2m 10s | master passed |
| +0 :ok: | spotbugs | 4m 28s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 52s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 50s | the patch passed |
| +0 | hbaserecompile | 15m 37s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 28s | the patch passed |
| +1 :green_heart: | javac | 1m 28s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 38s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 9s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 458m 46s | root in the patch failed. |
| -1 :x: | asflicense | 1m 37s | The patch generated 610 ASF License warnings. |
| | | 529m 24s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.RTrimFunctionIT |
| | phoenix.end2end.index.MutableIndexSplitForwardScanIT |
| | phoenix.end2end.index.GlobalImmutableNonTxIndexIT |
| | phoenix.end2end.index.GlobalImmutableTxIndexIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 5cc9e9662ff6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 55f1362 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 11024 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r553896489
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Must have been copied from HBase, then lurked here for years...
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Looking at again, this still might have effect on Pherf.
It probably should be purged, but not today.
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Those are only used when running the tests on a real cluster, which feature is broken in many ways.
Almost no-one uses it, and it doesn't affect the maven test suite.
And by the pherf tests, which really should be fixed :)
It doesn't hurt to synchronize it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-757499801
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 7s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 57s | master passed |
| +1 :green_heart: | compile | 1m 20s | master passed |
| +1 :green_heart: | checkstyle | 0m 29s | master passed |
| +1 :green_heart: | javadoc | 1m 52s | master passed |
| +0 :ok: | spotbugs | 2m 58s | phoenix-core in master has 955 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 0s | root in master has 1004 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 37s | the patch passed |
| +1 :green_heart: | compile | 1m 18s | the patch passed |
| +1 :green_heart: | javac | 1m 18s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 57s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 20s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 188m 3s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
| | | 238m 11s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux dbcb8e6216cc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / fe0b3ca |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/7/artifact/yetus-general-check/output/whitespace-eol.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/7/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/7/testReport/ |
| Max. process+thread count | 6125 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/7/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756860302
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 10s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 59s | master passed |
| +1 :green_heart: | compile | 1m 21s | master passed |
| +1 :green_heart: | checkstyle | 0m 32s | master passed |
| +1 :green_heart: | javadoc | 1m 54s | master passed |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in master has 956 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 57s | root in master has 1005 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 26s | the patch passed |
| +1 :green_heart: | compile | 1m 19s | the patch passed |
| +1 :green_heart: | javac | 1m 19s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 53s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 203m 47s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
| | | 255m 40s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.MappingTableDataTypeIT |
| | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux b1b2733b5730 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / ca4f784 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/2/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/2/testReport/ |
| Max. process+thread count | 6093 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-757106976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756728295
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 42s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 16m 1s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 0m 26s | master passed |
| +1 :green_heart: | javadoc | 0m 46s | master passed |
| +0 :ok: | spotbugs | 3m 1s | phoenix-core in master has 956 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 40s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 25s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 5s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 194m 53s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 234m 56s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.tx.TransactionIT |
| | phoenix.tx.FlappingTransactionIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux d80696bf852d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / ca4f784 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/1/testReport/ |
| Max. process+thread count | 6190 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r554105323
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Looking at again, this still might have effect on Pherf.
It probably should be purged, but not today.
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Those are only used when running the tests on a real cluster, which feature is broken in many ways.
Almost no-one uses it, and it doesn't affect the maven test suite.
And by the pherf tests, which really should be fixed :)
It doesn't hurt to synchronize it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-757106976
FWIW, synchronizing all these methods could be subtask of PHOENIX-6288 and good to directly check for results in multibranch? In the meanwhile we can keep PHOENIX-6288 opened until we get 2-3 multibranch build results without init errors. WDYT @stoty ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-765395528
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 38s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 15m 8s | master passed |
| +0 | hbaserecompile | 27m 19s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 53s | master passed |
| +1 :green_heart: | checkstyle | 0m 43s | master passed |
| +1 :green_heart: | javadoc | 2m 34s | master passed |
| +0 :ok: | spotbugs | 5m 28s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 3s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 11m 38s | the patch passed |
| +0 | hbaserecompile | 20m 2s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 58s | the patch passed |
| +1 :green_heart: | javac | 1m 58s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 44s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 29s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 34s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 46s | root in the patch failed. |
| -1 :x: | asflicense | 0m 50s | The patch generated 610 ASF License warnings. |
| | | 211m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/14/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 8c355f4d5c19 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 11b37e6 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/14/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/14/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/14/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 9185 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/14/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-763732509
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 39s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 14m 20s | master passed |
| +0 | hbaserecompile | 27m 22s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 0s | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | master passed |
| +1 :green_heart: | javadoc | 2m 33s | master passed |
| +0 :ok: | spotbugs | 5m 32s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 37s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 11m 19s | the patch passed |
| +0 | hbaserecompile | 21m 14s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 59s | the patch passed |
| +1 :green_heart: | javac | 1m 59s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 48s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 43s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 56s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 448m 28s | root in the patch failed. |
| -1 :x: | asflicense | 1m 47s | The patch generated 610 ASF License warnings. |
| | | 532m 39s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/12/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 3b865305ba5c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 772ff2c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/12/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/12/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/12/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 13710 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/12/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r554100484
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Looks like this is recent addition right? We could include `deletePriorMetaData()` too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-757390628
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 50s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 10s | master passed |
| +1 :green_heart: | compile | 1m 22s | master passed |
| +1 :green_heart: | checkstyle | 0m 32s | master passed |
| +1 :green_heart: | javadoc | 1m 55s | master passed |
| +0 :ok: | spotbugs | 3m 2s | phoenix-core in master has 956 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 2s | root in master has 1005 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 49s | the patch passed |
| +1 :green_heart: | compile | 1m 24s | the patch passed |
| +1 :green_heart: | javac | 1m 24s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 32s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 0s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 30s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 192m 0s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
| | | 244m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 1b8095b2f4e0 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9c346ed |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/6/artifact/yetus-general-check/output/whitespace-eol.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/6/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/6/testReport/ |
| Max. process+thread count | 6130 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/6/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756920516
Set all stateful priected static methods to synchronized as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756920516
Set all stateful private static methods to synchronized as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1078: PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-764984704
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 39s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 5s | master passed |
| +0 | hbaserecompile | 23m 38s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 34s | master passed |
| +1 :green_heart: | checkstyle | 0m 39s | master passed |
| +1 :green_heart: | javadoc | 2m 10s | master passed |
| +0 :ok: | spotbugs | 4m 28s | root in master has 1004 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 52s | phoenix-core in master has 955 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 50s | the patch passed |
| +0 | hbaserecompile | 15m 37s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 28s | the patch passed |
| +1 :green_heart: | javac | 1m 28s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 38s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 9s | the patch passed |
| +1 :green_heart: | spotbugs | 8m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 458m 46s | root in the patch failed. |
| -1 :x: | asflicense | 1m 37s | The patch generated 610 ASF License warnings. |
| | | 529m 24s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.RTrimFunctionIT |
| | phoenix.end2end.index.MutableIndexSplitForwardScanIT |
| | phoenix.end2end.index.GlobalImmutableNonTxIndexIT |
| | phoenix.end2end.index.GlobalImmutableTxIndexIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1078 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml |
| uname | Linux 5cc9e9662ff6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 55f1362 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 11024 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1078/13/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1078: synchronize HTU creation/teardown
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#issuecomment-756920516
Set all stateful priected static methods to synchronized as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org