You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/25 15:14:16 UTC

[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #239: Remove Apache snapshot repository

mdedetrich opened a new pull request, #239:
URL: https://github.com/apache/incubator-pekko-connectors/pull/239

   We are not relying on snapshots anymore so we can remove the repository


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #239: Remove Apache snapshot repository

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #239:
URL: https://github.com/apache/incubator-pekko-connectors/pull/239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #239: Remove Apache snapshot repository

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #239:
URL: https://github.com/apache/incubator-pekko-connectors/pull/239#discussion_r1305833862


##########
build.sbt:
##########
@@ -351,6 +347,9 @@ lazy val docs = project
   .enablePlugins(PekkoParadoxPlugin, ParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin)
   .disablePlugins(MimaPlugin)
   .settings(
+    // TODO Remove when pekko-paradox-sbt has its first release

Review Comment:
   Still necessary for doc generation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #239: Remove Apache snapshot repository

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #239:
URL: https://github.com/apache/incubator-pekko-connectors/pull/239#discussion_r1306004161


##########
build.sbt:
##########
@@ -351,6 +347,9 @@ lazy val docs = project
   .enablePlugins(PekkoParadoxPlugin, ParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin)
   .disablePlugins(MimaPlugin)
   .settings(
+    // TODO Remove when pekko-paradox-sbt has its first release
+    resolvers += Resolver.ApacheMavenSnapshotsRepo,
+    updateOptions := updateOptions.value.withLatestSnapshots(false),

Review Comment:
   True is the default, false means that it will cache snapshots which for us is fine because the snapshot versions are hashed and immutable 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #239: Remove Apache snapshot repository

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #239:
URL: https://github.com/apache/incubator-pekko-connectors/pull/239#discussion_r1305807641


##########
build.sbt:
##########
@@ -351,6 +347,9 @@ lazy val docs = project
   .enablePlugins(PekkoParadoxPlugin, ParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin)
   .disablePlugins(MimaPlugin)
   .settings(
+    // TODO Remove when pekko-paradox-sbt has its first release
+    resolvers += Resolver.ApacheMavenSnapshotsRepo,
+    updateOptions := updateOptions.value.withLatestSnapshots(false),

Review Comment:
   Should it be true?



##########
build.sbt:
##########
@@ -351,6 +347,9 @@ lazy val docs = project
   .enablePlugins(PekkoParadoxPlugin, ParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin)
   .disablePlugins(MimaPlugin)
   .settings(
+    // TODO Remove when pekko-paradox-sbt has its first release
+    resolvers += Resolver.ApacheMavenSnapshotsRepo,
+    updateOptions := updateOptions.value.withLatestSnapshots(false),

Review Comment:
   Should it be true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org