You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by msjgriffiths <gi...@git.apache.org> on 2014/10/23 19:47:03 UTC

[GitHub] spark pull request: [SPARK-4065] Add check for IPython on Windows

GitHub user msjgriffiths opened a pull request:

    https://github.com/apache/spark/pull/2910

    [SPARK-4065] Add check for IPython on Windows

    This issue employs logic similar to the bash launcher (pyspark) to check
    if IPTYHON=1, and if so launch ipython with options in IPYTHON_OPTS.
    This fix assumes that ipython is available in the system Path, and can
    be invoked with a plain "ipython" command.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/msjgriffiths/spark pyspark-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2910
    
----
commit f076d3b0c4de62001be449c5ce22cae399bf6bde
Author: Michael Griffiths <ms...@gmail.com>
Date:   2014-10-23T17:45:13Z

    [SPARK-4065] Add check for IPython on Windows
    
    This issue employs logic similar to the bash launcher (pyspark) to check
    if IPTYHON=1, and if so launch ipython with options in IPYTHON_OPTS.
    This fix assumes that ipython is available in the system Path, and can
    be invoked with a plain "ipython" command.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4065] Add check for IPython on Windows

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/2910#issuecomment-60819184
  
    This LGTM. I guess we just never supported ipython on windows. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4065] Add check for IPython on Windows

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2910#issuecomment-60278572
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4065] Add check for IPython on Windows

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2910#discussion_r19323459
  
    --- Diff: bin/pyspark2.cmd ---
    @@ -33,7 +33,7 @@ for %%d in ("%FWDIR%assembly\target\scala-%SCALA_VERSION%\spark-assembly*hadoop*
     )
     if [%FOUND_JAR%] == [0] (
       echo Failed to find Spark assembly JAR.
    -  echo You need to build Spark before running this program.
    +  echo You need to build Spark with sbt\sbt assembly before running this program.
    --- End diff --
    
    Removing "with sbt\sbt assembly" is correct. see #2640.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4065] Add check for IPython on Windows

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/2910


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org