You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2014/10/28 00:22:08 UTC
Review Request 27252: Add --enable-debug and --enable-optimize flag
for controlling building debug and optimized verisons of libprocess
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27252/
-----------------------------------------------------------
Review request for mesos and Timothy St. Clair.
Bugs: mesos-1985 and mesos-898
https://issues.apache.org/jira/browse/mesos-1985
https://issues.apache.org/jira/browse/mesos-898
Repository: mesos-git
Description
-------
Reworks buiding mesos in a "debug" vs. a "release" configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity
None: '-O0 -g1'
--enable-optimize == '-O2'
--enable-debug == '-g'
--enable-optimize --enable-debug == '-O2 -g'
If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use).
Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion.
Diffs
-----
3rdparty/libprocess/configure.ac ee482fcc312199823040798ac3c279d03d92c19f
Diff: https://reviews.apache.org/r/27252/diff/
Testing
-------
Tested all four combinations of flags, making sure they set the right CXXFLAGS. Also specified
Thanks,
Cody Maloney
Re: Review Request 27252: Add --enable-debug and --enable-optimize
flag for
controlling building debug and optimized verisons of libprocess
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27252/#review58817
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy St. Clair
On Oct. 27, 2014, 11:22 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27252/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 11:22 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Bugs: mesos-1985 and mesos-898
> https://issues.apache.org/jira/browse/mesos-1985
> https://issues.apache.org/jira/browse/mesos-898
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Reworks buiding mesos in a "debug" vs. a "release" configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity
>
> None: '-O0 -g1'
> --enable-optimize == '-O2'
> --enable-debug == '-g'
> --enable-optimize --enable-debug == '-O2 -g'
>
> If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use).
>
> Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac ee482fcc312199823040798ac3c279d03d92c19f
>
> Diff: https://reviews.apache.org/r/27252/diff/
>
>
> Testing
> -------
>
> Tested all four combinations of flags, making sure they set the right CXXFLAGS. Also specified
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 27252: Add --enable-debug and --enable-optimize
flag for
controlling building debug and optimized verisons of libprocess
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27252/#review58836
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy St. Clair
On Oct. 27, 2014, 11:22 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27252/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 11:22 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Bugs: mesos-1985 and mesos-898
> https://issues.apache.org/jira/browse/mesos-1985
> https://issues.apache.org/jira/browse/mesos-898
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Reworks buiding mesos in a "debug" vs. a "release" configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity
>
> None: '-O0 -g1'
> --enable-optimize == '-O2'
> --enable-debug == '-g'
> --enable-optimize --enable-debug == '-O2 -g'
>
> If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use).
>
> Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac ee482fcc312199823040798ac3c279d03d92c19f
>
> Diff: https://reviews.apache.org/r/27252/diff/
>
>
> Testing
> -------
>
> Tested all four combinations of flags, making sure they set the right CXXFLAGS. Also specified
>
>
> Thanks,
>
> Cody Maloney
>
>