You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/03/23 13:34:02 UTC
[orc] branch master updated: ORC-772: Fix Spark benchmark jar creation (#667)

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/master by this push:
     new 8a593d2  ORC-772: Fix Spark benchmark jar creation (#667)
8a593d2 is described below

commit 8a593d214d9d1a25e4e6e971aa335d9cc443dae4
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Tue Mar 23 06:33:52 2021 -0700

    ORC-772: Fix Spark benchmark jar creation (#667)
    
    ### What changes were proposed in this pull request?
    
    This PR aims to fix Spark benchmark jar creation by using the default Maven shade plugin configurations explicitly. Otherwise, the parent pom's configuration is applied.
    
    ### Why are the changes needed?
    
    Since ORC-750, it builds incorrect uber jar.
    ```
    $ cd java/bench
    
    $ mvn clean package -pl spark --am
    
    $ ls -alh spark/target/*.jar
    -rw-rw-r-- 1 dongjoon dongjoon  62K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
    -rw-rw-r-- 1 dongjoon dongjoon 808K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT-nohive.jar
    ```
    
    ### How was this patch tested?
    
    Manually.
    ```
    $ cd java/bench
    
    $ mvn clean package -pl spark --am
    
    $ ls -alh spark/target/*.jar
    -rw-rw-r-- 1 dongjoon dongjoon 130M Mar 23 05:56 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
    -rw-rw-r-- 1 dongjoon dongjoon  62K Mar 23 05:55 spark/target/original-orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
    ```
---
 java/bench/spark/pom.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/java/bench/spark/pom.xml b/java/bench/spark/pom.xml
index e84630f..c26885c 100644
--- a/java/bench/spark/pom.xml
+++ b/java/bench/spark/pom.xml
@@ -174,6 +174,13 @@
             </goals>
             <configuration>
 	      <createDependencyReducedPom>false</createDependencyReducedPom>
+              <artifactSet>
+                <includes>
+                  <include>*:*</include>
+                </includes>
+              </artifactSet>
+              <shadedArtifactAttached>false</shadedArtifactAttached>
+              <shadedClassifierName>shaded</shadedClassifierName>
               <filters>
                 <filter>
                   <artifact>org.codehaus.janino:janino</artifact>