[GitHub] [lucene] rmuir commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

[GitBox <gi...@apache.org>]

rmuir commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-981367730


   > But since we are not changing the behavior of `AutomatonQuery` (it still determinizes up-front by default), I don't think we need to block pushing this (once we iterate on all feedback) on benchmark results?
   
   Can we at least run existing benchmarks to confirm it doesn't introduce regressions? Some of the code is performance sensitive and we are adding  abstractions here. damn java.
   
   I'm still confused about the API, as it adds lots of booleans/enums. Do we really need enums, or can a simple boolean suffice? Does AutomatonQuery really need such boolean, or should it just look at `Automaton.isDeterministic` to determine what to do? Depending on what performance shows, why even keep around a both `determinizeWorkLimit` and the booleans/enums? Instead of throwing an exception, why not fall back to NFA if you really want to run some crazy regexp? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org