You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/01 18:16:58 UTC

[GitHub] haojin2 commented on a change in pull request #11955: [MXNET-751] fix bce_loss flaky

haojin2 commented on a change in pull request #11955: [MXNET-751] fix bce_loss flaky
URL: https://github.com/apache/incubator-mxnet/pull/11955#discussion_r206981469
 
 

 ##########
 File path: tests/python/unittest/test_loss.py
 ##########
 @@ -81,8 +81,10 @@ def test_ce_loss():
             eval_metric=mx.metric.Loss(), optimizer='adam')
     assert mod.score(data_iter, eval_metric=mx.metric.Loss())[0][1] < 0.05
 
-
-@with_seed(1234)
+# @lanking520: getting rid of the fixed seed
+#               and add atol and rtol
 
 Review comment:
   nit: you should be able to fit this line together with the line above in a single line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services